- 03 Dec, 2019 40 commits
-
-
Thomas Anderson authored
This is a reland of abf93b0b Reason for reland: Should be fixed for realz (hopefully) now that [1] has landed. [1] https://chromium.googlesource.com/chromium/src.git/+/5cc50bc375d289623ed0c290c3429c70e32a88d9 Original change's description: > Revert "Revert PowerSaveBlockerLinux [2/4]" > > This reverts commit bbfce899. > > Reason for revert: Issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1937507/ lands > > Original change's description: > > Revert PowerSaveBlockerLinux [2/4] > > > > and the subsequent PowerSaveBlockerLinux [3/4] and PowerSaveBlockerLinux [4/4] patches > > > > This reverts commit 2fdeba1b. ("Rewrite PowerSaveBlockerLinux [2/4]") > > This reverts commit 38fdf074. ("Rewrite PowerSaveBlockerLinux [3/4]") > > This reverts commit 3bc463b4. ("Rewrite PowerSaveBlockerLinux [4/4]") > > > > The patch caused timeouts in WakeLockTest.ChangeType() and other tests in the services_unittests on > > Linux Tests (dbg). More details in crbug/1027852. > > > > TBR=thomasanderson@chromium.org > > > > Bug: 1013812,1027852 > > Change-Id: I7688c72f9d9d6c12ff3731f3abde6a05508cfbeb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932357 > > Commit-Queue: Tim Schumann <tschumann@chromium.org> > > Reviewed-by: Tim Schumann <tschumann@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718447} > > TBR=thomasanderson@chromium.org,tschumann@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1013812, 1027852 > Change-Id: I84a6681cc8ec347587d38f0f5f38ed628e624274 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937509 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720760} TBR=tschumann@chromium.org Bug: 1013812, 1027852 Change-Id: I4e18be4df7824a93769b8a13cc5455b8640e48c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949232Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#721205}
-
Brian Sheedy authored
Rolls the goldctl version to pick up recent changes, including the ability for goldctl to provide diffs for local testing. Also updates the GPU Gold code in order to provide the now-required --crs and --cis arguments when running on trybots. TBR=ynovikov@chromium.org Bug: 1030349 Change-Id: I3a3bd880a8c754441ff2f343ebb49eb610b5c7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949082Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721204}
-
Stephen Nusko authored
protozero event. This is the first full protozero typed event (!!). As part of this we need to add some dependencies on tracing to access the macros as well as protozero writing. This improves the output trace size when enabled because we no longer need to write out the JSON dictionary including field names. And decreasing tracing CPU overhead when this category is enabled by 8% (6%-10% at 95% CI) [1] This should also improve memory usage while tracing since we will not be emitting large dynamically allocated JSON dictionaries. [1] https://docs.google.com/spreadsheets/d/1dxtQ72hl_aRA4lWp45u0SsGysZ1YR155oE83pUd5Iso/edit?usp=sharing TBR=nuskos@google.com Change-Id: I0ac53b850cbce78d893ff26a204280bc8d627c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944357 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
enne <enne@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721203}
-
Connie Wan authored
Created TabGroupViews, which manages most of the tab group's visual calculations and updates. TabStrip still paints the views, but it no longer keeps low-level maps to each individual view. TabGroupUnderline can now use TabGroupViews for the bulk of its visual calculations. In the future, TabGroupHighlight will take a similar approach. Change-Id: I894dc03375cb29b42b80bd1273587a41131f1b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925336 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#721202}
-
Yann Dago authored
Bug: 1012920 Change-Id: Ifccd4d4eab21ba21d0e7984add2b26757e5cbec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929450Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#721201}
-
Takumi Fujimoto authored
This reverts commit 53550932. Reason for revert: This CL seems to have broken compile on the android_arm64-builder-perf bot: https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/135203 Original change's description: > [Payments] remove stubs for Clank dependencies > > This cl removes stubs from PaymentApp and PaymentInstrument classes as > well as payment_handler_host.mojom > > This should get landed after the dependnet Clank cl gets merged: > https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2255260 > > Bug: 984694 > Change-Id: I03972ab75d7c4f33b644ebf77a9ef2618ef07921 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946457 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721089} TBR=kenrb@chromium.org,rouslan@chromium.org,sahel@chromium.org Change-Id: Iff10dbae61e31d32312bf8a4ca947b00ed003fae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948919Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721200}
-
Devlin Cronin authored
Add a DCHECK that the Browser object the ExtensionViewHost is creating the view for is associated with the same profile as the ExtensionViewHost itself. Bug: None Change-Id: I2be3c2bcc5a3faaa309dd3250d5ecaac76b5ab9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940588Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721199}
-
kdillon authored
Bug: 966177, 1027606 Change-Id: I335d1df534ff7a7baafac89f6e0c8d034fc061d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947399Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#721198}
-
James Hawkins authored
This case is no longer possible in the multidevice world. R=hansberry@chromium.org Bug: none Test: none Change-Id: I070b46562d28517b373fa67a8267d5504ac2da7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936968 Commit-Queue: James Hawkins <jhawkins@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#721197}
-
Henrique Ferreiro authored
Bug: None Change-Id: I515c7508c09a857e9023fb1a93d080de97115f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948442Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#721196}
-
Maks Orlovich authored
Just because requested range start is < kMaxOffset doesn't mean the final result will be; consider for example this sequence: WriteSparseData("Key0", offset = 331530, size = 61184) = 61184 GetAvailableRange("Key0", 131076, 262143) = net::ERR_IO_PENDING (async) [Async IO (GetAvailableRange) = 60938] [1203/162431.032212:FATAL:disk_cache_fuzzer.cc(1000)] Check failed: *start_tmp <= kMaxEntrySize (331776 vs. 262144) this asks for the available interval in [131076, 393219), and returns [331776, 392714), which is reasonable given the earlier write of [331530, 392714), since the backend doesn't have to guarantee complete exactness on sparse writes. Bug: 1029779, 1026689, 1020882, 1028111 Change-Id: I23ea47a48c13828d343d6830974583a4bc355617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948047 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#721195}
-
Luke Zielinski authored
Logged bugs where issues were found, or there were discrepancies between local and/or wpt.fyi runs. If the test was failing everywhere, it just goes on the backlog. Bug: 937369 Change-Id: Ie5412f80b2e13006b77d666d6c59e6ba07007331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949060 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#721194}
-
Joe Mason authored
R=proberge Bug: 1030333 Change-Id: I66b9b3dc73980e8ed03ee37d89eb172b5330c913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948235 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#721193}
-
Xiaoqian Dai authored
Bug: 1027353, 997885 Change-Id: Ia72d214f3a96f55e15128bb4b4155df5ddfe250e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931544 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721192}
-
Peng Huang authored
This CL refactor DClayers related code, so it can be shared with other platforms. Bug: 1012401 Change-Id: I6550823081d538b6b1a4702fae941534af897508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940347 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#721191}
-
Nigel Tao authored
This undoes crrev.com/c/1898151 "Flip enable_skia_wuffs_gif gn arg default to true", as there have been reports (crbug.com/1023129, crbug.com/1023191) of ARM performance regressions, and fixing those is ongoing work. We might try flipping the default back to true after the upcoming M80 branch point. Also fix build of skia when enable_skia_wuffs_gif=false. The libgifcodec dependency isn't really new. It was spun out of the existing Skia git repository a couple of weeks ago: https://review.skia.org/255780 Fix to: https://crrev.com/c/1942595 Bug: 1014044 Bug: 1023129 Bug: 1023191 Change-Id: Icfd7e9b703cb1c7d25f891937d54a01f97711389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944286 Commit-Queue: Hal Canary <halcanary@google.com> Reviewed-by:Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721190}
-
Brian Ho authored
This CL introduces a NativePixmap-based SharedImageBacking for use by ChromeOS to support WebGPU. This only creates a skeleton for SharedImageBackingOzone in an effort to split up code reviews; the SharedImageBacking methods are neither implemented nor called. Bug: 1023997,996470 Change-Id: Id4e8ba3079df8af609f883b61ffe6e54975e075b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913081 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721189}
-
Fei Ling authored
"about:blank" should not be a translatable URL. Bug: 960369 Change-Id: Ife979fd641a793d8e4442309c436c6c0dd07c876 Fixed: 960369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946870Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Fei Ling <feiling@chromium.org> Cr-Commit-Position: refs/heads/master@{#721188}
-
Jesse Schettler authored
This reverts commit 0ec01b13. Reason for revert: Causing browser to crash. Original change's description: > printing: Check all color modes in IsColorModelSelected() > > Update IsColorModelSelected() to check for all color modes. > > Change-Id: I61b4922e1ddb6b9a3f906b9122b1ca4f29c8272e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901835 > Reviewed-by: Sean Kau <skau@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718884} TBR=thestig@chromium.org,skau@chromium.org,jschettler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id739f17f6a3e8c1bc232eb85d10c165b8a515a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948501Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#721187}
-
Mia Glaese authored
Bug: 1029691 Change-Id: I06d704ff991d5ee19ab733b50c893568309a5bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944283Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#721186}
-
Vi Nguyen authored
This CL allows for spatialRendering to be queried with MediaCapabilities.decodingInfo() for clear and EME. Changes required to blink and media were relatively small so they were combined into this CL. This CL does not add the ability to render spatial audio. This functionality is behind blink feature flag MediaCapabilitiesSpatialAudio. Note that if the flag is disabled, querying for spatialRendering will return supported because decodingInfo ignores extraneous parameters by design. For the media implementation, AudioType was because spatialRendering is strictly tied to the codec. Bug: 1020943 Change-Id: I01c9853b88f72ae8cb6291f9ca49e1d82cb220d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928077Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Vi Nguyen <ving@microsoft.com> Cr-Commit-Position: refs/heads/master@{#721185}
-
Joe Mason authored
Update comments to clarify how the child process log interacts with ScopedLogging. Use the new class to capture logs in cleaner_test.cc, secure_dll_loading_test.cc and proto_chrome_prompt_ipc_unittest.cc. R=proberge Bug: 1030333 Change-Id: I88f538ff360bb8ed9da6743dc5d6c4b263af992c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947986 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Collin Baker authored
Bug: 989131 Change-Id: Ie6816df088e9a3dcbc6a8dba884e9b7c72f02c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938194 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721183}
-
Etienne Pierre-doray authored
The comparison was too strict. In practise, there's only one PT_NOTE segment, so early exit doesn't affect behavior. For correctness, we should keep looking for other segment. Change-Id: I49fb7ab3c7361d4ed6ea1d6f3a0c56db24dc13cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948497 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#721182}
-
Jeremy Roman authored
Previously the shell redirection only redirected stdout, but the message was being printed to stderr. While here, use trap to ensure that the output file is removed even when bash exits abnormally. Change-Id: Icf9f9de24bf115713b61e860616a6457be8fa593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945925 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This callback can be called multiple times, so make it a RepeatingCallback. Also pass it by value for functions that take ownership per guidelines in //docs/callback.md. Bug: 1007763 Change-Id: Ib15dd0a20357ac58dbe691b3dea263ebf24b0163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948364Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#721180}
-
Saman Sami authored
Since each cache miss can result in one frame with no overlays, we would like to make sure it doesn't regress as we work towards fixing https://crbug.com/756454 Bug: 756454 Change-Id: Iae7cbaddf5974ece8e0078d9ea265752fa016fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941047 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#721179}
-
Yuke Liao authored
This reverts commit 5b3adc3c. Reason for revert: This turns out to be NOT helpful to debugging the issue. Original change's description: > [code coverage] Change log warning to info > > Will ssh to bot if still nothing printed. > > Bug: 1027818 > Change-Id: I98147da43689d2b4ea9db0ee8643312eac6fc72b > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935860 > Auto-Submit: Yun Liu <yliuyliu@google.com> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719180} TBR=liaoyuke@chromium.org,yliuyliu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027818 Change-Id: Ibc49a3f10e3847a1b269e2f501ba321ef943b9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948489Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721178}
-
Mike Reed authored
TBR= Change-Id: I4607f91a8efb87202d68311894f67bc69a8f8e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948487 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#721177}
-
Kramer Ge authored
unique_ptr has been moved and get() returns nullptr Change-Id: I26460d92140941ec8d6627e77f4401bc19641966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948739 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721176}
-
Kurt Horimoto authored
The filename should match the name of the class defined within. By naming these files infobar.[h/mm], we were interfering with XCode's indexing and making the "⌘ + shift + O" shortcut difficult to use. Bug: none Change-Id: Ibd976cae6e82c222e8380f3cd3eeec1c086f4735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949103Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721175}
-
Jian Cai authored
Add the flag so we can turn on pattern initialization from https://reviews.llvm.org/D54604 in the future. Bug: 966551 Change-Id: I631bd71f5e1da553ec7a9e480537adc8573d1047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835027 Commit-Queue: Jian Cai <jiancai@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#721174}
-
Ahmed Mehfooz authored
This will ensure the focus ring is visible with it's full thickness. Bug: 1015348 Change-Id: I8d618d3b39b7a4cb48e709eb541f70c10a71573f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947641Reviewed-by:
-
Daniel Hosseinian authored
constexpr variables must be initialized and computed at compile-time, unlike their const counterparts that can defer their initializations to run-time. This change allows for a slight run-time performance boost. Correct a typo by changing the static variable kSizeTrasholdUm to kSizeThresholdUm. The use of the variable is limited to printer_description.cc. Change-Id: I4e43df7666570fa37a15e8860a635badbac306e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937253 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Connie Wan authored
Created a TabGroupController interface that lets TabGroup notify the TabStrip (via TabStripModel) of changes to its contents and visuals. The TabGroupController interface splits out the event handling for tab groups -- I created a family of observer notifications that handle creation, modification, and deletion as separate events on tab groups. Next step (Part 3) would be to create a TabGroupViews class that would simplify the various maps being kept in TabStrip (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.h?rcl=74a75649aa028187ccde250a98c23d324d9f9728&l=636,639). I also still want to look into removing the TabStripController APIs like ListTabsInGroup, since I was able to remove some of the references in TabStrip by splitting out the event handling. Change-Id: I9334b0e66be3053fdfffd8b77a32b9e4f3ef83c6 Bug: 940677 Change-Id: I9334b0e66be3053fdfffd8b77a32b9e4f3ef83c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918715 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/22e4696f2435..84e94841f5ea Created with: gclient setdep -r src-internal@84e94841f5ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iec0733a8e65f138e5c6b6f7bf543d5f9ff986ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721170}
-
Shakti Sahu authored
When ephemeral tab is gone, we should destroy the WebContents. Earlier destroy was called when the sheet is hidden, which causes an issue if we go to tab switcher and come back to the same tab. This CL moves it to the onSheetContentChanged method, which is a better way of knowing if the sheet has been closed. Bug: 1029291 Change-Id: I1008355aa9ed4fc407f4d827ab3d0eecf2cc98b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949079Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721169}
-
Lei Zhang authored
The code that interacts with plugin code in these files are already guarded with BUILDFLAG(ENABLE_PLUGINS), but the headers are not. Fix lint errors about duplicate #includes along the way. Bug: 1027360 Change-Id: Ida542b2b6817cd7a81c3522f2652cb9c7be3935b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930103Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#721168}
-
Joon Ahn authored
Instead of hiding attach-error on fileSelect callback, hook onto the click event to clear out attach-error before fileselected callback is called. This will reannounce the alert as needed. BUG=chromium:1020047 TEST=ChromeVox on ChromeOS. Verify by choosing files over 3mb over and over. Change-Id: I2e41d61c1bc226573a4cc1a30f675b5a6693c486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936763Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#721167}
-
Roger Tawa authored
TBR=xiyuan@chromium.org Bug: 1030393 Change-Id: Ia1255af64bc57ef0bd5d9a43fc781c1a79cf07f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947460Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
-
