- 30 Oct, 2019 40 commits
-
-
Joey Arhar authored
The html spec does not seem to say anything against emitting change events for input elements which are detached from the DOM. It does say that immutable input elements should not have change events emitted for them, but I don't think that having it detached from the DOM means that it is immutable, especially since we can successfully change the .checked value while detached from the dom. Bug: 773680 Change-Id: Ie579ed1f3c34fc03f74554a5685f40c510805f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885093Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#710642}
-
Thomas Guilbert authored
This CL adds a new callback to VideoFrameCompositor. A client can now set a callback, to be notified whenever a new frame has been presented for composition. This will be used to ultimately fulfill callbacks registered through the new <video>.requestAnimationFrame API. Bug: 1012063 Change-Id: If7c9e4192db03b81a9040219bedec70e38241509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887743 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#710641}
-
Yoshisato Yanagisawa authored
Allow developers to select Xcode.app to be used for iOS development. Bug: 1015730, 619921 Change-Id: I395eda1da49971f4cbd2d22c0901caff604ff89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886553 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#710640}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88a74e59f04c..bb35bb4e5379 git log 88a74e59f04c..bb35bb4e5379 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 jmadill@chromium.org Vulkan: Implement simple case ANGLE_get_image. 2019-10-29 tobine@google.com Fix Renderbuffer support for unsized DS formats 2019-10-29 courtneygo@google.com Update docs for recent dEQP / VK-GL-CTS update 2019-10-29 courtneygo@google.com Print the testConfig in dEQP tests. Created with: gclient setdep -r src/third_party/angle@bb35bb4e5379 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:997351 Change-Id: I7fba7760d6d5f2b9a3623d1da56a4498d26d2f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888395Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710639}
-
Yoichi Osato authored
This CL fixes the crash if mojo creation in OnAddChannelResponse failed, then we call WebSocket::Reset(), which deletes WebSocketChannel but it tries to call instance methods after that. To fix that, this CL unifies WebSocket::WebSocketEventHandler ::OnAddChannelResponse and ::AddSendFlowControlQuota for quota initialize. Fixed: 1018432 Change-Id: I197a15c07e23b04284713e67fca2dfcd92f01e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883450Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#710638}
-
John Lee authored
Change-Id: Ie57da6d81d9ea386b47333483438b4356f02158b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889113 Auto-Submit: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710637}
-
khmel@chromium.org authored
This reads power energy counters available for Intel platform. Energy is reported as runtime power in tracing tool. BUG=b:143532713 b:143534199 TEST=Locally + unit test Change-Id: If07397e36582bc3be985806fa3cd9fe106b64eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888194 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710636}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/651618043819..54eda5713da0 git log 651618043819..54eda5713da0 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 tsepez@chromium.org Avoid duplicate string construction in CXFA_Textlayout 2019-10-29 thestig@chromium.org Properly handle seek failure in CFX_BmpDecompressor::ReadBmpHeader(). 2019-10-29 thestig@chromium.org Get rid of longjmp() usage in CFX_BmpDecompressor. 2019-10-29 tsepez@chromium.org Use span instead of raw pointer in CFDE_TextOut::ReloadLinePiece(). Created with: gclient setdep -r src/third_party/pdfium@54eda5713da0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:997588 Change-Id: I675fae4f2e95848681d80be2b2998a3adbccdbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889253Reviewed-by:
-
Moe Ahmadi authored
- Realbox input always gets focus after deleting a match. - Selects the first match in the list after deletion and fills the realbox input with its content if it is allowed to be the default match. Otherwise sets the input to the user typed value. Bug: 1018437 Change-Id: I02fd690a0c0acaa570f37604970c13391af14b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881991 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#710634}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/512f92b73181..1e4dbf3f6432 git log 512f92b73181..1e4dbf3f6432 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 erikchen@chromium.org Add more git tracing. 2019-10-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1e4dbf3f6432 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I039c2ad6ec0888b910e762dcaecbc859bf4d0fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888597Reviewed-by:
-
Adam Langley authored
Windows is commonly observed to take about 10 seconds to establish a GATT connection to caBLE devices. Some reports, however, are suggesting that even a 15 second timeout is insufficient. This change raises that timeout 20 seconds. It's unclear whether humans will actually wait around this long, at least this might make some caBLE actions _possible_. Change-Id: I99a9647cdab8ed7475ce13b1652731a5109c8d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884756 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#710632}
-
Jared Saul authored
Bug: 884817 Change-Id: Id2a27744c30ce2d7d3ecc683641069c6a91d2655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877617 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#710631}
-
Chris Lu authored
Creates InfobarTranslateTableViewController with basic setup for its navigation bar. Initializes it in InfobarTranslateCoordinator in addition to creating InfobarTranslateModalDelegate for the TableViewController to send signals back to the coordinator. Screenshot: https://drive.google.com/open?id=1W0UyJ6DQnQ4v3-8_gkhuWxd8SLZGnp1s Bug: 1014959 Change-Id: I5cc434e5330de9bbe3ccd8f8fb0537ea2db4bc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878910 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710630}
-
Daniel Clark authored
This change fixes an issue where a sandboxed iframe can be created such that it contains a sandboxed Document with an opaque origin that still shares a script context with the iframe's initial un-sandboxed about:blank Document. The scenario is set up in the following manner: 1) Create a new iframe dynamically, and set its src to a same-domain page that we are going to sandbox. 2) Insert the iframe into a Document, and synchronously grab a reference to its initial about:blank Document. 3) Synchronously set iframe.sandbox = "allow-scripts" (this is still before the same-domain page has loaded in the frame). 4) The iframe’s navigation to the same-domain page occurs, asynchronously. FrameLoader::ShouldReuseDefaultView is called to determine the mode in which to load the new page. FrameLoader::ShouldReuseDefaultView fails to check the iframe’s sandbox flags (it only looks at the CSP ones), so the navigation proceeds without resetting the type system of the iframe. The result is that the newly loaded page shares the type system of the initial about:blank Document. 5) Code in the sandboxed iframe is now free to make changes to its type system that can affect any usage of the about:blank Document since they share the same type system. This is a sandbox escape in that if the same-domain page that the iframe is navigated to contains user-generated code, it could run outside the iframe. It can also result in crashes if we poke things in the right way, since an object that should be considered cross-origin can bleed into the top-level page, with the result that access checks which are never expected to fail can now fail. This change fixes the issue by making FrameLoader::ShouldReuseDefaultView() check the iframe's sandbox flags via FrameLoader::EffectiveSandboxFlags(), in addition to the existing check for CSP sandbox flags. Bug: 1017441 Change-Id: Ide1b13e16b0e0428a243ff47b6e17ae25ad0ff0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881315Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710629}
-
Jinsuk Kim authored
There are situations where back button closes the current tab. Gesture navigation also need to do what back button does in this case. This CL shows close indicator "Close Tab", and does not open the navigation sheet. Bug: 1009059 Change-Id: Ife4f53bb41253646d18feb1cf5e2c50a04b1d2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885135Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710628}
-
Hongchan Choi authored
When the buffer is set to `null` while there is an active buffer within a reverb object, SetBuffer() function can prematurely nullify the `reverb_` and `shared_buffer_` while it is still being accessed by the rendering thread. This CL adds two locks (graph lock and process lock) when the buffer gets nullified to ensure the synchronization between two threads. Change-Id: I8f501b6a16b3c7e16db767e0b279a1a53d6eb290 Bug: 1019226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888103 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710627}
-
Dan Beam authored
* restore search magnifying glass (aka loupe) as default icon @ 20px * add 8px of bottom margin below last realbox result * add feature to experiment with Google (g) icon ("super g") R=mahmadi@chromium.org Bug: 1017495 Change-Id: I4db697dcf66d20ab2509ccbec35317f80919c10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884951 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710626}
-
Joonghun Park authored
For additional explanation, add an annotation about HTML body element's 8px default margin to core/layout/README.md with the corresponding spec link. Bug: None Change-Id: I9cfe9acf005f5725dab4b99f7e874c9cdcda37db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886139Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Joonghun Park <pjh0718@gmail.com> Cr-Commit-Position: refs/heads/master@{#710625}
-
Kai Ninomiya authored
We already had this workaround on Mali-T*, but it's needed on Mali-400 as well (and most likely Mali-300, if that even supports WebGL). Bug: 1018528 Change-Id: Iebcaa45a0cc7402399f7a1cb5e24b443b02078cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888954 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#710624}
-
Cici Ruan authored
Assign string value to AppWindowInfo#displayId. Bug: None. Test: tested the API and received the correct display id. Change-Id: I43b0142bf60326811f00e2d6661d23d6f92ab55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887876Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Cici Ruan <cuicuiruan@google.com> Auto-Submit: Cici Ruan <cuicuiruan@google.com> Cr-Commit-Position: refs/heads/master@{#710623}
-
Peter Kasting authored
Calling GetPreferredSize() on a label which hadn't otherwise computed a layout would return an empty size, which seems wrong. Calling GetHeightForWidth() (a const method) could change the results of GetPreferredSize(), a violation of logical constness. Bug: none Change-Id: I2729b9d83ffa94e368fb6553e9ead4b2646e01c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884360 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#710622}
-
Rune Lillesveen authored
We need to be able to walk the current flat tree ancestors without updating the distribution when marking the ancestor chain for style recalc. For Shadow DOM V1, we introduced a separate method for that since for V1 we update the slot assignment while traversing. For V0, we need to explicitly update distribution and DCHECK during traversal that we made sure it was up to date. Here we skip the DCHECK when FlatTreeStyleRecalc is enabled. We could have introduced some scoping mechanism that sets a flag from outside the traversal saying that we intentionally walk a dirty tree instead of always skipping the DCHECK for FlatTreeStyleRecalc. Since V0 is going away soon, I gathered we could skip the DCHECK. Multiple tests in the TEST lines below will trigger the DCHECK without this change and FlatTreeStyleRecalc enabled. TEST=fast/dom/shadow/ TEST=shadow-dom/ Bug: 972752 Change-Id: I8a850123b9b647a6575c3a2679e382d61c0ed8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875258Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/567c7481c849..9eeaad1a5bde Created with: gclient setdep -r src-internal@9eeaad1a5bde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:b/141127636,chromium:1018879,chromium:None Change-Id: Ie12e2cfd3deacd2971cb5dd809c7f885fc9d4bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888822Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710620}
-
Manas Verma authored
Tracking the time it takes to fetch the full PAN of a credit card once user successfully authenticates using WebAuthn. Bug: 949269 Change-Id: Ic50eba0bcc687c988f0f61ceb96399610bf752c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864627 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710619}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers and add an attribute to disable CFI-icall checking. Bug: 1018834 Change-Id: Ia79aa823ab42e89b7103b8b89e65cda0c24dbb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885010 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710618}
-
Xiaohan Wang authored
Current WebContentDecryptionModuleImpl and CdmSessionAdapter take a blink::WebContentDecryptionModuleResult during CDM creation. There are a few issues with this: 1. Bad encapsulation, e.g. CompleteWithSession() is exposed to these two classes. 2. Hard to test: There's no easy way to create one |result| for testing. See Bug. 3. Readability: Working with the result directly ends up with more code, e.g. kWebContentDecryptionModuleExceptionNotSupportedError. Bug: 1018832 Test: No functionality change Change-Id: I9b1ec2662873d9da6797133355b1a3261145feac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884277Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710617}
-
Jeremy Roman authored
Change-Id: I6ef8b0098a795dc550037306e7b972ea907b0fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884285Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710616}
-
nancy authored
The browser test AppListClientImplBrowserTest.UninstallApp is flaky, because AppService is mojom based, which is slow when loading icon, compared with sync Extensions. Update the test case to flush mojo call. BUG=1009248 Change-Id: I7e5702392ec9369991ffb357c5dcb402dd6cb0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885134Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
zhaoyangli authored
This is a reland of cf629e19 Added import of constants.h file in unified_consent_view_controller.h so that internal egtests can continue access the constants. After this CL lands, will change the egtest header in internal code base and remove the constants.h header import here. Original change's description: > Extract unified consent constants target. > > Preparing for SigninEarlGreyUI and SigninEarlGreyUtils EG2 migrations. > > Bug: 922813, 1015907 > Change-Id: I47e4678e40f1820b22938463c5a791c04a662f3c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884286 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710479} Bug: 922813, 1015907 Change-Id: I4584bfdda1a4854e17aac174ba1906b9e80adf09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888601 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#710614}
-
Ionel Popescu authored
https://chromium-review.googlesource.com/c/chromium/src/+/1838997 caused an issue where using up/down keys to highlight autofill suggestions were not read out using VoiceOver and NVDA. The issue was caused by only checking for menu and menuitem roles when the events are fixed. The fix is to extend the checks to include the new roles: listbox and listboxoption. Bug: 1017527 Change-Id: I67f346b7a8a024d1d84d250d8afc63edc125bda5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884763 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#710613}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca687f6e0c70..11a79e755c5e git log ca687f6e0c70..11a79e755c5e --date=short --no-merges --format='%ad %ae %s' 2019-10-29 primiano@google.com Trace Processor: Add RestoreInitialTables() method Created with: gclient setdep -r src/third_party/perfetto@11a79e755c5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:143074239 Change-Id: I8db9a9ff724bb2b9fa18557363a73e95a5d92c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888818Reviewed-by:
-
Karan Bhatia authored
This is a purely refactoring CL. We are adding support for regex rules to DNR. Currently RulesetMatcher is tasked with evaluating a single ruleset source (An extension can have upto two ruleset sources: static and dynamic). RulesetMatcher implements matching of filter list style rules supported by url_pattern_index. This CL does the following: - Introduce an interface called RulesetMatcherInterface. - Introduce ExtensionUrlPatternIndexMatcher: this will handle all filter list style rules within a ruleset. - Move most of the implementation from RulesetMatcher to ExtensionUrlPatternIndexMatcher. After this CL RulesetMatcher is just a wrapper over ExtensionUrlPatternIndexMatcher. - A subsequent CL will - Introduce RegexRulesMatcher which will handle all regex rules within a ruleset. It will also implement the RulesetMatcherInterface. - RulesetMatcher owns a ExtensionUrlPatternIndexMatcher currently. Subsequently it will also own a RegexRulesMatcher and combine the results from the two. BUG=974391 Doc=https://docs.google.com/document/d/1mRErUMII_gSSPaHmxyn31UOYWUaZLj0xOaezekxD2-Y/edit?usp=sharing (Internal) Change-Id: I580be59c8b19840622c2c673338c0f54087f5186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879565Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710611}
-
Jinsuk Kim authored
The public API returns the underlying application context of |mThemedApplicationContext| which you can also get with |ContextUtils.getApplicationContext| directly. This CL deletes the API and has the call sites use ContextUtils instead. Bug: 925242, 995903 Change-Id: Ie323a815225f67a3876a9a1559eaee8b3dd01687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884402Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710610}
-
Rob Schonberger authored
This is a major change that adds an implementation of NeuralStylusPalmDetectionFilter, along with a unittest for it. The changes outside of that new file are to support the new class added. Note that no actual implementation of a model is included, and this class is not instantiated or used in this change. Bug: 1009290 Change-Id: Icac32a1a113b0ff83e307bccb3a3d0fc948bcc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880414Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710609}
-
Alex Cooper authored
If the only features requested for an XRSession can be fully supported by a sensorless session, then just create the sensorless session rather than trying to get a fully device backed session. There were cases where the only requested features were "viewer", but the session was still being backed by the orientation_sensors device. This change introduces an enum that indicates whether sensor data, and therefore a runtime, is needed, optional, or not required. If sensor data is not required, then a sensorless session is created rather than querying for device support. This also refactors "CanRequestSensorlessInlineSession" to an enum, to better consolidate and support this expanded logic. Fixed: 1018794 Change-Id: I0b930a733ccab85275fcc965969a17313cb3cf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884827 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#710608}
-
Yuly Novikov authored
Pixel_Video_MP4_FourColors_Aspect_4x3 Pixel_Video_MP4_FourColors_Rot_180 Pixel_Video_MP4_FourColors_Rot_270 Pixel_Video_MP4_FourColors_Rot_90 Pixel_Video_MP4_Rounded_Corner TBR=kbr Bug: 1019462 Change-Id: I106e55d37671f92e256f10065b5f7fa081176b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888098Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#710607}
-
Hiroki Sato authored
Previously, a role of the root ARC++ accessibility nodes was changed from rootWebArea to genericContainer. (http://crrev/c/1469064) There was a remaining logic that checks role==rootWebArea. This CL fixes it. This CL also adds an unit test to check string properties, and moved a tooltip related test into here as it was previously in name computation test. Bug: None Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: Id945f7fdd3e48455593986b975a339a73c83c1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886554Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#710606}
-
Sadrul Habib Chowdhury authored
Instead of running the webgl/canvas animations for 5 seconds, run them a little longer: 10 seconds. The web-animation tests are also currently run for 10 seconds. So this change aligns these animations. There are ~35 canvas stories, and ~15 webgl stories. So overall, this would increase the runtime, if all tests were to run on the same bot, by ~4 minutes (= 50 * 5seconds). If the stories are sharded, then the increased runtime should not be very noticeable. BUG=894287 Change-Id: I62e341cfd3b605ab4090af2fc185fa1648324459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882760Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#710605}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b07147b04082..e1cda3916cee git log b07147b04082..e1cda3916cee --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sugoi@google.com vkGetPhysicalDeviceFeatures2 fix Created with: gclient setdep -r src/third_party/swiftshader@e1cda3916cee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I195d0d598b2adfd99cf4d0c9b61aaee486225a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888815Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c165bf48..87fb5cb2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8b2347a9b9844323bdcf3a2bb8982d205c4fa60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888553Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710603}
-
