GitLab

This is a reland of 61450bbc

Original change's description:
> Recreate DirectManipulationHelper when every LRWHH UpdateParent
>
> Compositor and window event target is associated with window's parent. We call
> LRWHH UpdateParent when window's parent update, includes window's parent
> actually update and window initialize. Recreate DirectManipulationHelper on
> every window's parent update helps keep DirectManipulationHelper lifecycle
> tracking simpler. We also make CompositorAnimationObserver owned by
> DirectManipulationHelper.
>
> With this changes, we start the DirectManipulation event polling when
> DirectManipulationHelper created and stop when it destroyed. The issue should be
> fix since event polling start no more depends on DM_POINTERHITTEST.
>
>
> This also includes 2 refactoring changes:
>
> 1. Move CompositorAnimationObserver into DirectManipulationHelper.
> 2. Call ZoomToRect to reset viewport of DirectManipulation when viewport is
>    actually transformed in RUNNING - READAY sequence.
>
> Bug: 914914
> Change-Id: I0a63f9a407e0231d631e64f2b22a9975471f2fd9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547049
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#649342}

TBR=sky@chromium.org

Bug: 914914
Change-Id: Ic0c8aa84d21fe7a88fd9d3552dbd5ffdb6adcc4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562582
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649682}

This reverts commit 9abefd14.

Reason for revert: This CL has been identified as causing a breakage when merging coverage data for instrumented browser_tests. This is currently blocking a P0

Original change's description:
> performance_browser_tests: Stabilize around AV-sync, run with AudioService.
>
> Ensures that the separate, sandboxed Audio Service process is being used
> when the tests are run. Also, prevents tests from failing due to recent
> breakage of AV-sync measurement methodology (fix is being researched).
>
> Bug: 940087
> Change-Id: I0d7189ba9ce0d03bc8401a636085b4cc0f779920
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555713
> Auto-Submit: Yuri Wiitala <miu@chromium.org>
> Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#648503}

TBR=miu@chromium.org,crouleau@chromium.org,rkc@chromium.org,sajjadm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 940087
Change-Id: I3655a0031f3fe1d12f4f4a23fa73cd4a5abefc1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562306
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649681}

This flag is no longer used.

Bug: None
Change-Id: I9f035a7b236a80f457f6f142749ed51310e123af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561633
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649680}

TBR: hiroh@chromium.org
Bug: 951428
Change-Id: I3859b3900576776b884b1a0de52f5f3df34d2d83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562610Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649679}

https://chromium.googlesource.com/catapult.git/+log/f8d4d2df5377..b60f2a72fcb3


git log f8d4d2df5377..b60f2a72fcb3 --date=short --no-merges --format='%ad %ae %s'
2019-04-10 benjhayden@chromium.org Add ConfigRequest and ConfigCacheRequest to spa
2019-04-10 benjhayden@chromium.org Add /api/config
2019-04-10 rmhasan@google.com [Typ] Make sure that the full test name is passed to _load_via_load_tests


Created with:
  gclient setdep -r src/third_party/catapult@b60f2a72fcb3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:865515,chromium:865515,chromium:698902
TBR=skyostil@chromium.org

Change-Id: Ie5972a6058ba1568ebcdd6ba8e07b0f9d076cc0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562491Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649678}

Set on an Array can throw exceptions if for instance
Object.defineProperty is called on Array.prototype, so use
CreateDataProperty instead.

Bug: v8:7283, v8:8834
Change-Id: I144951b5c9c1cb0801aa5394bf6f7df58f4a6d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561127
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649677}

Roll Material Roboto Font Loader to bc63eabbbd1e14cee0779b05827e08db2e413553

TBR=smut

Change-Id: I25bd4c5cce78b022a9d081283fa7a311e1ca8a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562514Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649676}

Clear information about profile policy requirements from known user
database when account type is changed. It will enforce establishing
the information again and fix problems resulting from incorrect
information being cached.

It fixes problem when policy is not fetched for account that changed
type to child when DMServerOAuthForChildUser is turned on.

Bug: 951238
Test: Manually changing account type and regular child user sign in
Change-Id: Iaab25af95d7f4dd818001aae1e2acab7cd0135e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558901Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649675}

Set up buildbucket for dawn-mac-x64-deps-rel trybot.

Bug: 950021
Bug: 948902
Change-Id: I0e64633e5f929821676e97039a8afb27644c858d
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562617Reviewed-by: smut <smut@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649674}

DragTab fails at about 25% in classic mode under FindIt flake
analysis. It seems that the mouse move to detach the tab sometimes
does not go through when the post event callback is invoked. Add
a WaitForNoPointerHoldLock before sending the mouse move to make
sure the event is handled before its post process callback.

Bug: 942599
Change-Id: Ieea45562b4c8ca7e1ee6bcd9f5cda2a938d1000f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562085Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649673}

https://pdfium.googlesource.com/pdfium.git/+log/44034bca7d3e..b9516868546e


git log 44034bca7d3e..b9516868546e --date=short --no-merges --format='%ad %ae %s'
2019-04-10 thestig@chromium.org Convert |CXFA_FFDocView::m_IndexChangedSubforms| to a deque.
2019-04-10 thestig@chromium.org Add a test to exercise FPDF_FFLDraw() with FPDF_REVERSE_BYTE_ORDER.
2019-04-10 tsepez@chromium.org Separate CXFA_FFWidget from CXFA_ContentLayoutItem.
2019-04-10 thestig@chromium.org Use early returns in CXFA_Node.
2019-04-10 thestig@chromium.org Give CXFA_FFDocView* params proper names in CXFA_Node.
2019-04-10 thestig@chromium.org Return Optional<float> from CXFA_Node::FindSplitPos().
2019-04-10 thestig@chromium.org Add CXFA_LayoutPageMgr::ShouldGetNextPageArea().
2019-04-10 thestig@chromium.org Add CXFA_LayoutPageMgr::HasCurrentViewRecord().
2019-04-10 thestig@chromium.org Prevent an out of bound access in CXFA_TextLayout::DoLayout().


Created with:
  gclient setdep -r src/third_party/pdfium@b9516868546e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:932900,chromium:925788
TBR=dsinclair@chromium.org

Change-Id: I368f5bf1b393923a8002ecab848b75b702eb16b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562493Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649672}

OneCopyRasterBufferProvider set SHARED_IMAGE_USAGE_RASTER |
SHARED_IMAGE_USAGE_DISPLAY, which technically met the criteria as coded
but was unsupported.

Change-Id: I21ab072c75044122b2ba1dd4f625ad0cac2a3d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562078
Commit-Queue: Jonathan Backer <backer@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649671}

Add build flags for async VR.
Add proguard configs for keeping VR compatible with base.

Bug: 947544
Change-Id: Ibbfc1eb9325d09e6ceb3e241bc82ef4ff0ad1f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552020Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@google.com>
Cr-Commit-Position: refs/heads/master@{#649670}

CastAudioOutputStream::CmaWrapper failed to set the correct value
on |channel_layout| in |audio_config|. The default value is considered
to be invalid and causes error when sent through Mojo pipe.

Bug: internal b/129642940
Test: None
Change-Id: Ie449ee966c4d79717a4951e18b1953f62a109929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562089Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649669}

This CL tracks certain important metrics for MimeHandlerView. The metrics are
mostly around postMessage API usage for embedded MimeHandlerView which would
determine the use cases for cross vs. same origin resources.

Expected Outcome:
  * Determine the popularity of the API; and in specific, the type of messages.
  * Determine the usage of the API for cross-origin resources. This would help
    decide the path forward for CORB vs. embedded PDF.
  * Frequency of postMessage to embedded PDF.

If the usages are small UKMs might help track down the users of the API and possibly deprecate the
postMessage API in favor of window.postMessage *after* MimeHandlerViewInCrossProcssFrame ships.

TBR=lazyboy@chromium.org

Bug: 659750, 929300
Change-Id: Id2d59a2891c7fe192bb4932eff761d49e64771d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558615
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649668}

This a precursor change that tracks mime type counts for all
resource types in frames. This will allow future changes to record
other mime types without adding separate counters to FrameData.

Bug: 951480
Change-Id: I700c8ce9f3065082a621ce8e69027fa8607105e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562291Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649667}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/280474c2a985..77b3499b8809


git log 280474c2a985..77b3499b8809 --date=short --no-merges --format='%ad %ae %s'
2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@77b3499b8809

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I5d43f8a410484cba53663171bea6ae243ff1316b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649666}

This CL had to be reverted because GPU bots were failing because the
results_merger.py script could not handle the test_name_prefix field
that was still getting populated in the JSON results. This CL will
add the metadata field along side the test_name_prefix field in the
Optional fields list in the results_merger.py script. It also removes
the checking of test_name_prefix in the gpu unit tests because the
test_name_prefix field will be removed from the top level of the
results in a future CL.

Bug: chromium:698902
Change-Id: I4867e60ca5a97d426d5fd1a4de08e26c14d326ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559492
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649665}

https://skia.googlesource.com/skia.git/+log/14003828df72..1208002548e8


git log 14003828df72..1208002548e8 --date=short --no-merges --format='%ad %ae %s'
2019-04-10 egdaniel@google.com Revert "Remove unnecessary flush in RenderYUVAToRGBA (take 2)"
2019-04-10 mtklein@google.com make to_vec template parameters explicit
2019-04-10 mtklein@google.com tweak SkVx to play nicely with others
2019-04-10 herb@google.com Add an index to SkGlyphPos
2019-04-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-10 brianosman@google.com Make SkShaper's GN setup more DLL friendly
2019-04-10 brianosman@google.com Make Skottie's GN setup more DLL friendly
2019-04-10 ethannicholas@google.com moved files generated from .fp files into generated/ directories
2019-04-10 herb@google.com Reland "Do not use sub-pixel positioning for source space"
2019-04-10 robertphillips@google.com Remove unnecessary flush in RenderYUVAToRGBA (take 2)


Created with:
  gclient setdep -r src/third_party/skia@1208002548e8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I30ca000d4eb2321a0ab82f9fbcdd5c4d6164b2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562066Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649664}

SyncerErrors with type NETWORK_CONNECTION_UNAVAILABLE should only be
created through the NetworkConnectionUnavailable() factory function, to
make sure that the expected net_error_code is always set.

Bug: 842096
Change-Id: Ibad86d6f0be6a36306db8b7e0e0d28404321f841
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560190
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649663}

Bug: 242119
Change-Id: Ia83d5b52366f12828c6623a0e601e7691b196b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559262
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649662}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7274e4b5..790137c1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0f1e9124f6d4dbee65ae0c9ecd9c0e459341b82f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562083Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649661}

Don't sign out the user when FirstSetupComplete flag is off when
UnifiedConsent is on.

Bug: 948681
Change-Id: I8da53595d1e89652e9e566d5402a2733aec21f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554672
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649660}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7682feb30b68..21a8eca7b39f


Created with:
  gclient setdep -r src-internal@21a8eca7b39f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=harrisjay@chromium.org,ellyjones@chromium.org,btolsch@chromium.org

Change-Id: I96006ce9507ad6d6040184a6a2230a1a4f45c64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562490Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#649659}

SparseArray#valueAt(int index) takes an int index param where the
previous assert was passing a key. Use SparseArray#get(int key)
instead.

BUG=950744

Change-Id: I4842a1718b09bdec00bce74117e1e9389a313bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562084Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649658}

This was preventing configs from finding new builders added that
had a different number of cores.

Bug: 822310
Change-Id: I59f452cb913a10cae8a54d8f0062f5fd2dc5cdff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562452Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649657}

Builder's name in job was incorrect, so it wasn't getting scheduled.

Bug: 948902
Change-Id: I8731c706a77514f2b4d5e6e592d93a777ce113ef
Tbr: martiniss@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562614Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649656}

Previously when ResetScreen was allocated it'd force set itself
as the active screen. This is the only screen that does this and
it does not play well with pre-allocating screen instances ahead of
time.

Bug: None
Change-Id: Ie70a0e64dd1f6891935fd0f6d39c99ab1d4999d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560437
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649655}

This CL adds a check to prevent handling media keys when the screen is
locked.

Bug: 951485
Change-Id: I1a2481894e20ceee1879d32066cf969a0b4263bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562370Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649654}

Add tint for NewTabButton(+) in top tool bar when tabgrid is enabled.

Bug: 946290
Change-Id: I4e1ad838789b63720465f818294f82042b2a6475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559209Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@google.com>
Cr-Commit-Position: refs/heads/master@{#649653}

Clean up various extension action-related manifest constants:
- Instead of prefixing with "PageAction", just say "Action".
- Rename kPageActionId to kFileBrowserHandlerId, since that's the only
  thing that uses it.
- Remove undefined constant kInvalidPageActionPopupHeight
- Combine kInvalidPageActionPopup and kInvalidPageActionPopupPath
- Remove unused constants kPageActionTypePermanent and
  kPageActionTypeTab

Bug: 893373
Change-Id: Ic22f6d6f0ba1399c1f2dbbaeea3eac62e954e32d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559767
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649652}

Bug: 677338
Change-Id: Ief7c222727c34edbec0a0112103b2902fb4f4848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561967Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649651}

This fixes a race in GaiaScreenHandler method for setting test user
credentials not to start AddUserFlow (and force GAIA reload) if the auth
extension load has started (in addition to when the gaia frame started
loading) - this was causing issues because the flow would clear up the
current sign-in partition, without stopping the current auth extension
load (and later attempt to authenticate would crash on current signin
storage partition session being empty).
NOTE: This is a wider issue that I plan to look more closely into, but
this change should unblock tests.

BUG=936041,891277

Change-Id: Ie1f76daf0278af59af8b85c4a0fd82b9b0223555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560534
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Auto-Submit: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649650}

Bug: 948675
Change-Id: I674f924ef3fb7bf4351cce0140f096c5a2707109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549195
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649649}

This CL introduces a new script that can be used to check and try to
fix various locale-related files in the Chromium source directory.

This is essentially a replacement for
build/android/check_android_grit_strings.py that will be extended
to support more features over-time, most of them not Android
specific.

This will be used to ease the addition of translations for new locales.

Example usage:

  # Print list of locales supported by Chrome.
  build/locale_tool.py list-locales

  # Print list of locales supported by Chrome, as JSON
  build/locale_tool.py list-locales --as-json

  # Check all .grd and BUILD.gn for locale-related issues
  build/locale_tool.py check-all --scan-dir .

  # Does the same and tries to fix bad files.
  build/locale_tool.py check-all --scan-dir . --fix-inplace

  # Only check and fix Android .xml outputs in .grd files:
  build/locale_tool.py check-grd-android-outputs \
    --scan-dir . --fix-inplace

  # Try to add android_webview .xtb outputs in .grd files
  # for new locales 'aa' and 'zz':
  build/locale_tool.py check-grd-translations \
    --scan-dir android_webview/ \
    --add-locales 'aa zz' \
    --fix-inplace

  # Perform internal consistency check between this script
  # and the content of build/config/localges.gni
  build/locale_tools.py check-locales

BUG=944606
R=agrieve@chromium.org, govind@chromium.org, jshin@chromium.org, estevenson@chromium.org

Change-Id: I3753bb528f6a56bec94cce8ec7b5b802f438857e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553425
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649648}

Also, check in results for from build 3363 to 4131. Data might be deleted and
lost forever at a future point. Such data is valuable to understand the issues
with IPG and potential solutions for reliable power measuring.

BUG=867155
TEST=manual
R=sunnyps@chromium.org

Change-Id: Iee41152a10993c72e13b3daff4c3d6e08ac5bee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558747
Auto-Submit: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649647}

With enabled pointer compression empty V8 instance reports memory usage
values less than 1 MB which makes the test fail for
Memory.Experimental.Renderer2.V8.* metrics.

Bug: v8:7703, chromium:949157
Change-Id: I285731326732157b592efc197c1fda1a5016c686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559141Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649646}

Follow-up to crrev.com/c/1560141

Bug: 861983
Change-Id: I8c8a51fc8b6c44b2e2e693e5746e2d370bacde53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562290
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649645}

This adds to mark the tracing of overview enter/exit animation to
ease the performance analysis.

Bug: 949227
Test: manually in chrome://tracing
Change-Id: Ia616dbbc8f825fd459e1253b2d60915a1f653250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560307
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649644}

As part of https://chromium-review.googlesource.com/c/chromium/src/+/1547051
InvalidateLayout() was changed to result in a Layout() at a later date. This
means there may be an additional Layout() called. AppsGridView cancels any
animations if Layout() is called. Currently, an async layout is being
triggered as part of preparing for the animation. Which means the reorder
animation is canceled. The fix is to explicitly force a layout (which makes
the pending layout do nothing) and further ignore the layout call.

BUG=949713
TEST=see steps in bug.

Change-Id: I9aa887e4e49b182a2912a6c599fa26618429e1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562372Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649643}