- 16 May, 2018 40 commits
-
-
Jan Wilken Doerrie authored
This change provides an implementation of Windows::Foundation's ITypedEventHandlder. It serves as a thin wrapper around a base::RepeatingCallback of the appropriate signature. Bug: 821766 Change-Id: Ib940ebc5a4d90e5304be2c08839efbc020011180 Reviewed-on: https://chromium-review.googlesource.com/1060054 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#559212}
-
Sahel Sharify authored
This cl adds tracing to answer the following questions to be able to further narrow down the root cause of crbug.com/797708 -When did the last call to SetCurrentlyScrollingNode happen? (other than on PushPropertyTrees after each commit) -Is animation tick needed? (due to an ongoing animation) -Whether the animation_host notifies the compositor about animation end or not? -When does the CurrentlyScrollingNode get cleared? Bug: 797708 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I70f2295905798e430ce080c26f6924617504491b Reviewed-on: https://chromium-review.googlesource.com/1060302 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559211}
-
rbpotter authored
Add a timeout to the select sections, so that the preview does not immediately begin generating and freeze the dropdown when the value is changed. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If217c25420815f56a7c37adde7e97f86bcc99fa3 Reviewed-on: https://chromium-review.googlesource.com/1056216 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#559210}
-
Sigurdur Asgeirsson authored
The old-style CPUUsage attributes are supported by transforming the batched cumulatives in the System CU. Bug: 755840 Change-Id: I3e5d3d66223070a90ad35a835a210db0bb257809 Reviewed-on: https://chromium-review.googlesource.com/1060127 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#559209}
-
Dominic Mazzoni authored
Bug: None Change-Id: Ic63e1619729b79dc5c6010fed3223895c72c5999 Reviewed-on: https://chromium-review.googlesource.com/679446 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#559208}
-
Ken Rockot authored
Changes the SharedMemoryRegion types in mojo_base mojom to use a handle<shared_buffer> as their internal representation. This simplifies the traits and makes these region types usable in Java and JS. Bug: 826213 Change-Id: Id515f61f34b85c655b70d45d53302e873547a83a Reviewed-on: https://chromium-review.googlesource.com/1059008 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/99a046acd2d1..67268cd0efa2 $ git log 99a046acd..67268cd0e --date=short --no-merges --format='%ad %ae %s' 2018-05-16 dsinclair Cleanup CPDF_ContentParser 2018-05-16 tsepez Use pdfium::span<> in CPDF_Encryptor 2018-05-16 dsinclair Remove CFX_BidiLine 2018-05-16 dsinclair Convert Formcalc ToJavascript to a pointer WideTextBuf Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62d1fbb948e1971ead399113ac157004ca96a473 Reviewed-on: https://chromium-review.googlesource.com/1062024Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559206}
-
Steve Kobes authored
Bug: 823365 Change-Id: I34bd09b180ed8c7403217d0931cf2e765dc951d8 Reviewed-on: https://chromium-review.googlesource.com/1062288Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#559205}
-
Xiaohui Chen authored
R=xiyuan Bug: None Change-Id: I9a0b6decf9e2eae5d58ef74e5f482854592f054e Reviewed-on: https://chromium-review.googlesource.com/1062022Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#559204}
-
Dominic Mazzoni authored
Bug: 841218 TBR=michaelpg@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaea99a1a18c1eea7d1480b68b4a1aa71448d09d1 Reviewed-on: https://chromium-review.googlesource.com/1050498 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#559203}
-
Jeffrey Kardatzke authored
Bug: 832508 Test: Verified key generation by concierge from Chrome call Change-Id: Ie031d59ab95da3f5394c9621413a5a48066619a5 Reviewed-on: https://chromium-review.googlesource.com/1053273Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#559202}
-
Devlin Cronin authored
Correct a bug where an extension would be improperly disabled for a privilege increase when it went from a more powerful permission to a less powerful one, if the permission messages were different. Previously, privilege escalation code would look check if there were any warning strings in the new set of permissions that were not in the old set. This failed, because a new warning (not contained in the previous set) might be less powerful. Instead, compare whether *adding* the new permissions to the already-granted permissions results in any new (or different) warnings. Consider it a permissions increase only if there is a difference. Conceptually, this is more accurate, since when an extension is updated, new permissions are added to the list of granted permissions (and any already-granted permissions are not revoked). Update the IsPrivilegeIncrease() arguments to make this slightly more clear by replacing "old_permissions" and "new_permissions" with "granted_permissions" and "requested_permissions", respectively. Add a regression test for the same. TBR=slan@chromium.org Bug: 841938 Change-Id: I41542c6813c1f4a2f0318609bd75b838eef00cb5 Reviewed-on: https://chromium-review.googlesource.com/1054607 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#559201}
-
wutao authored
Currently for non-Qwerty keyboard layout, Shortcut Viewer returns incorrect keys. This cl fixes the bug by creating a reverse mapping from dom_code to {dom_key, key_code}. Bug: 841670 Test: manually. Change-Id: Ib75bf84b34c0b03bf5501fab0586db8e750478bc Reviewed-on: https://chromium-review.googlesource.com/1058080 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559200}
-
Michael Spang authored
Bug: none Test: compile Change-Id: I6bc5009527bdf9efbfc5fe935aa86856ee491711 Reviewed-on: https://chromium-review.googlesource.com/1061396Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#559199}
-
Jao-ke Chin-Lee authored
BUG=793909,793906,793945,793946 Change-Id: Iac8f30fd03b8cd5d95dded09a932cc695983bf1f Reviewed-on: https://chromium-review.googlesource.com/1060635Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#559198}
-
Zinovy Nis authored
- Get rid of redundant .c_str() for std::string, - Get rid of redundant .get() for std::unique_ptr, - Get rid of redundant member initializations - Replace NULL -> nullptr. R=blundell@chromium.org, caitkp@chromium.org, jochen@chromium.org, sdefresne@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic043a0bf296132eadd1b8a6e349d3a5f903fbaec Reviewed-on: https://chromium-review.googlesource.com/1045965Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#559197}
-
Daniel Park authored
The delete button's size is always accounted for when laying out suggestion views Adds padding to the omnibox text when voice search is disabled for RTL See crbug link for photos. Bug: 833342 Change-Id: I2b35be70d4296abf7eae318d5dccea4d0201c91f Reviewed-on: https://chromium-review.googlesource.com/1054201Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#559196}
-
Albert Chaulk authored
Implementation is being ported in another CL https://chromium-review.googlesource.com/c/chromium/src/+/1015553 & followups Bug: b/78445519 Test: local build Change-Id: If215057180bcc762864b32b82433f74211f4c311 Reviewed-on: https://chromium-review.googlesource.com/1025373 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#559195}
-
Vaclav Brozek authored
This might be causing the crashes seen in the associated bug. In any case, it is a good idea to handle the failure, because the reasons why that FILE* can be null are beyond Chrome's control. Bug: 838639 Change-Id: I700266840c1447c0b999aa91a361bfba3ff2710b Reviewed-on: https://chromium-review.googlesource.com/1060057 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#559194}
-
Stephen McGruer authored
Code was found via Chromium coverage report and then some sleuthing to spot a method that was only called from a test. Bug: 252472 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7223c9210d336fbec89b923e903bd95a64865d40 Reviewed-on: https://chromium-review.googlesource.com/1060106 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#559193}
-
Simon authored
Landing this for eakuefner@ since he's OOO this week. This CL switches some smaller benchmarks to the histogram pipeline. Ie. thread_times, battor, tracing_with_*, etc. Bug: 744736 Change-Id: I5bafea53e9d8b82bb3d38559192ab54565b63f44 Reviewed-on: https://chromium-review.googlesource.com/1059937Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#559192}
-
Charlie Andrews authored
TBR=eyaich@chromium.org Bug: 842232 Change-Id: I01d6db483807f9e7840434f586e608b8d92a490a Reviewed-on: https://chromium-review.googlesource.com/1062285Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#559191}
-
Mustaq Ahmed authored
Bug: 843366 Change-Id: Ifa1d702a1357e4f508f708b5cf9783d0db90ad06 Reviewed-on: https://chromium-review.googlesource.com/1062009Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
-
Tommy Steimel authored
This CL removes the sizing-tiny breakpoint from the media controls, since there are no CSS differences between the sizing-small and sizing-tiny classes. This CL also avoids setting the sizing-* classes on audio controls (and video controls acting as audio controls) in order to avoid unwanted CSS changes for the audio controls. Bug: 839088 Change-Id: I3c9ba1119572d0b0f8bec6d8f6c261ff192c96f3 Reviewed-on: https://chromium-review.googlesource.com/1060281Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#559189}
-
https://chromium.googlesource.com/angle/angle.git/+log/80c32ccbbcc6..e943df226e2b $ git log 80c32ccbb..e943df226 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 geofflang Add more dEQP EGL expectations for Linux and Android. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I7a197d7aecefe6b74636da1804603ecfad5546d8 Reviewed-on: https://chromium-review.googlesource.com/1062005Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559188}
-
Conley Owens authored
This change removes all code related to the Physical Web. BUG=826540 Change-Id: Ifda5d80c5cebeedf2e2fdf48142e6dd6c1ef73b6 Reviewed-on: https://chromium-review.googlesource.com/1054335Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#559187}
-
Steve Kobes authored
Bug: 823365 Change-Id: Ied4f19b6a565e171e8cf8cd0e16189a8c7f29752 Reviewed-on: https://chromium-review.googlesource.com/1062011 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Daniel Bratell authored
The presubmit check warning for correct include guards would trigger for generated files in third_party/win_build_output. Since files in third_party is often not written with the Chromium style guide in mind that is over zealous so this patch stops checking their names (except for in blink). The presubmit code will still check the existence of a guard since lack of one can cause problems outside the module and there has been no reports of false warnings. This patch also removes the exceptions that used to be there for blink since blink has moved and been reformatted. Bug: 814776 Change-Id: Ic7f2bbba5b9bcafbb5bec15b79b04d5e81994b77 Reviewed-on: https://chromium-review.googlesource.com/1061698Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Fernando Serboncini authored
Those tests are all green on flakiness dashboard. It's time to give them a chance. TBR=junov Change-Id: I0dfaaa9eddb3aa63bae0d4b4c78f9f5ddfef9445 Reviewed-on: https://chromium-review.googlesource.com/1062081Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559184}
-
Tom Sepez authored
Plumbs through enough of the app.beep() callback path so that we can prove that JavaScript was executed in the PDF plugin. We do not actually produce any sound, since beeps are annoying. It is just a convenient pre-existing side-effect free hook to test. The path is almost built-out, and the size cost to complete it is small. Precursor to disabling JavaScript; we first need to have an end-to-end test that proves it runs in the PDF before introducing a test that shows it doesn't run when disabled. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e7338f0c44ad2c4fe72b8b06efd88bd8b37ebd0 Reviewed-on: https://chromium-review.googlesource.com/1058550Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#559183}
-
Khushal authored
1) Image shaders are currently first decoded at the raster scale, but then serialized at the original size. This is because all the decoding happens in ScopedRasterFlags, but eventually the serialization needs to happen in PaintOpWriter. For record shaders, we would overwrite the shader with the correct scale, that would eventually be used in raster. Clean up all of this to not use ScopedRasterFlags for any image decoding during serialization. The logic for getting the scales is pulled into common methods on PaintShader used by ScopedRasterFlags for in process raster, and PaintOpWriter for oop serialization. This also fixes #3. 2) When decoding an image using the ImageProvider, a component of the scale is already applied to the decoded image. This needs to be accounted for during raster, which is missed for oop-r. Fix this by adding this scale to DrawImage/DrawImageRect ops. Image shaders already take care of this on their local matrix. 3) Decoding of PaintRecord backed shaders also fixes the raster scale for them. But since this was being done in ScopedRasterFlags, we would only do them for cases where these records have images. In order to get the font analysis correct for oop-r, this needs to be done for records with text also. This change ensures that we always serialize scaled records for these shaders, ensuring that we use the same scale during font analysis and raster. R=enne@chromium.org Bug: 829622 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If567d192220450306b15b94993c86e610c7885cb Reviewed-on: https://chromium-review.googlesource.com/1053528 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#559182}
-
Charlie Andrews authored
Bug: 842232 Change-Id: I9de002edb847154f19194dc910492d9bc2fcbe74 Reviewed-on: https://chromium-review.googlesource.com/1062146 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL shapes the role of a KeyboardAccessoryData.Tab element: It is an element that provides a specific benefit to the Manual UI by... ... providing data that is used by the bar to render a tab (upcoming) ... providing the content for a separate tab in the bottom sheet. This means, that the bottom sheet provides space for tabs and manages the general visibility and active states of tabs. The exact content of a tab doesn't matter to the AccessorySheetComponent. That way, it should become fairly straight forward to implement a new tab that is rendered into bottom sheet and accessory. The first concrete instance of a bottom sheet will follow soon: a bottom sheet that contains password related actions and data. (It's important to not mix this specific data into the AccessorySheet component as other upcoming sheets are already planned, like one for payments and one for address data.) Bug: 811747 Change-Id: Id8bd8c389496246166d26a6c298056a142c36566 Reviewed-on: https://chromium-review.googlesource.com/1047285 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559180}
-
Ted Choc authored
BUG=843596 Change-Id: I4846edc879c2b913ba558cbfb7884836d398aabc Reviewed-on: https://chromium-review.googlesource.com/1062018Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#559179}
-
Dominic Mazzoni authored
Changes to these externs are mechanical and already enforced by a presubmit check, so it doesn't make sense to get owners review most of the time. We'll use our best judgement and loop in an owner if the change is nontrivial. NOTRY=true Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a4ab89ae7cf231cffcf313b631b3c878b693b31 Reviewed-on: https://chromium-review.googlesource.com/1062075 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559178}
-
Randy Rossi authored
Part of ongoing effort to enable ChromeVox in chromecast. This CL added a required message filter to handle I18nGetMessage. Bug: b/73383411 Test: None Change-Id: I5d704397ae789e4ca72c15e0240a079b2ddc43ac Reviewed-on: https://chromium-review.googlesource.com/1058082Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559177}
-
Robbie McElrath authored
This is needed in order to migrate the devicemotion layout tests over to using mock generic sensor services. The old devicemotion events are backed by 3 different generic sensor types, so the MockSensorProvider needs to be able to mock and allow tests to get references to multiple types of sensors at the same time in order for these tests to mock out everything they use. Bug: 802815 Change-Id: I254c37d67db0e9c6feb639080394305b41f6b7e6 Reviewed-on: https://chromium-review.googlesource.com/1060477Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#559176}
-
Evan Stade authored
Previously we used the deprecated NotificationUiService::CancelAll via BrowserCloseManager to do this. That used the MessageCenter singleton directly, which worked with in-process Ash but not oop Ash. By listening for profile shutdown in the NotificationPlatformBridge, we can accomplish the same thing and it works in oop Ash as well. This is a roundabout way of fixing the bug, which AFAICT is a race between the Profile object shutting down and Ash asynchronously (via mojo) notifying of a notification toast closing. I couldn't figure out how to trigger this race, hence no direct test. Bug: 842705 Change-Id: I5913bcb3077450433e26ba6cc7397e17211bc9a6 Reviewed-on: https://chromium-review.googlesource.com/1058491Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Steven Bennetts authored
Bug: 798569 Change-Id: I476672a73ba64ee28d399686d0ecfc4c26690936 Reviewed-on: https://chromium-review.googlesource.com/1060579Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#559174}
-
Matthew Jones authored
The preload functionality causes more problems than it solves. Content that wants to delay loading until the sheet is opened can do so using events provided by the BottomSheetObserver. This fixes a race condition in EoC that would cause the sheet to peek before being requested. Bug: 834923,843267 Change-Id: If5c35e22a502e42f6bc591784b4fb8343e713eff Reviewed-on: https://chromium-review.googlesource.com/1060353 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
