GitLab

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyColumnGap from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIColumnGap.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIColumnGap.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIColumnGap.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2609933004
Cr-Commit-Position: refs/heads/master@{#442812}

Move LocalDomWindow unusedPreloadsTimer to TaskRunnerTimer, which
associates it wuith the frame's timer task queue.

BUG=624694

Review-Url: https://codereview.chromium.org/2625953002
Cr-Commit-Position: refs/heads/master@{#442811}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyClip from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIClip.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIClip.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIClip.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2614783003
Cr-Commit-Position: refs/heads/master@{#442810}

We avoid timing dependence by rAF looping until the animation is in
progress.

BUG=248938

Review-Url: https://codereview.chromium.org/2621603002
Cr-Commit-Position: refs/heads/master@{#442809}

Made -webkit-rtl-ordering property independent. Also updated
independent-inheritance-fast-path.html to include webkitRtlOrdering.

Tested using independent-inheritance-fast-path.html.

BUG=628043

Review-Url: https://codereview.chromium.org/2626893002
Cr-Commit-Position: refs/heads/master@{#442808}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyCaretColor from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPICaretColor.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPICaretColor.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPICaretColor.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2618613002
Cr-Commit-Position: refs/heads/master@{#442807}

R=tsergeant@chromium.org
BUG=679973

Review-Url: https://codereview.chromium.org/2624873003
Cr-Commit-Position: refs/heads/master@{#442806}

The size of the Safe Browsing client class was getting to be too large
to be contained entirely within PermissionContextBase, so it has been
moved to its own header and implementation.

Test coverage is supplied in permission_context_base_unitttest.cc, but
there will be follow up unit tests for this class.

BUG=561867

Review-Url: https://codereview.chromium.org/2626853002
Cr-Commit-Position: refs/heads/master@{#442805}

Since we don't know know whether the drag image is going to have an
opaque backdrop, disable LCD text conservatively.

This was previously handled by SkPictureImageGenerator, internally, but
broke in http://crrev.com/2619573002.

BUG=679307
R=reed@google.com

Review-Url: https://codereview.chromium.org/2625803002
Cr-Commit-Position: refs/heads/master@{#442804}

This is a temporary fix to enforce linear filter for texture object
in OffscreenCanvasRenderingContext2D in commit(). An ideal solution, which is
not urgent for OffscreenCanvas launch, is to adapt the filter to respect
image-rendering CSS property, as indicated in crbug.com/645590.

BUG=676666
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2607373002
Cr-Commit-Position: refs/heads/master@{#442803}

BUG=679660

Review-Url: https://codereview.chromium.org/2624973002
Cr-Commit-Position: refs/heads/master@{#442802}

The majority of the data and logic in the Interpolation base class is only
required for the LegacyStyleInterpolation subclass, and is ignored or
overwritten for InvalidatableInterpolation. This patch moves this data and logic
down the hierarchy into LegacyStyleInterpolation.

As additional consequences:
- SampleInterpolation classes defined in tests inherit from
  LegacyStyleInterpolation instead of the Interpolation base class
- getCachedValueForTesting is made pure virtual, requiring a placeholder
  implementation to be added to InvalidatableInterpolation, although this is not
  called anywhere

BUG=678875

Review-Url: https://codereview.chromium.org/2619173002
Cr-Commit-Position: refs/heads/master@{#442801}

SubresourceIntegrity::CheckSubresourceIntegrity expects a non-null Document
which doesn't exist in workers. This CL replaces Document with
ExecutionContext.

BUG=678515
R=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2614813004
Cr-Commit-Position: refs/heads/master@{#442800}

A LayoutThemeDefault instance can be associated to a real
WebThemeEngine or a mock WebThemeEngine, which have different
metrics. We need to invalidate a cached value when a WebThemeEngine is
switched.

The bug affects only layout tests.

BUG=673754

Review-Url: https://codereview.chromium.org/2627773002
Cr-Commit-Position: refs/heads/master@{#442799}

This patch fixed a bug when devtools is scaled it causes some backend
errors to occur due to expecting an integer instead of float.

R=dgozman
BUG=679268

Review-Url: https://codereview.chromium.org/2622633006
Cr-Commit-Position: refs/heads/master@{#442798}

Review-Url: https://codereview.chromium.org/2623153002
Cr-Commit-Position: refs/heads/master@{#442797}

Reland2 [Mojo Video Capture] Replace method OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt()

PatchSet#1 is the state as previously reviewed, landed, and reverted.
PatchSet#2 is the fix for the caused issue.

Description of issue and fix:

The original CL caused crbug.com/678766.
Method OnIncomingCapturedBufferExt() unwrapped |memory_handle| and passed it
to |frame|. However, |frame| did not take ownership, resulting in
|memory_handle| never getting closed.
Since the memory handle inside |frame| is not being used downstream anyway,
the fix is to use a NULLHandle() instead of unwrapping and attaching ownership.

Description of original CL:

In interface media:VideoCaptureDevice::Client, replaced the method
OnIncomingCapturedVideoFrame() with OnIncomingCapturedBufferExt(). Compared to
method OnIncomingCaptureBuffer(), the VideoFrame parameter in
OnIncomingCapturedVideoFrame() was only used for passing along a bit of extra
information, namely a custom |visible_rect| as well as some
|additional_metadata|. The new method makes the intent clear and eliminates the
need for passing a media::VideoFrame that is partly redundant with the also
passed media::VideoCaptureDevice::Client::Buffer.

This CL breaks the video_capture_unittests, because current implementation of
the video_capture service wants to use VideoCaptureDeviceClient with buffers
that are backed by MojoSharedMemoryBufferTracker instances instead of the
"regular" shared memory buffers. With this CL, VideoCaptureDeviceClient is
dropping support for this. We are working towards making the video_capture
service work with the regular buffers. To keep CLs small, we defer changes
to the service to after refactorings of VideoCaptureController and
VideoCaptureManager are complete and deactive the video_capture_unittests
temporarily. This is acceptable for the time being, since they are not run on
the bots yet. The CL that re-enables them is currently labeled CL1.9.22 in the
design doc.

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL1.9.9

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*",
  video_capture_unittests,
  Apprtc loopback on Debug,
  Desktop Capture Example extension on Release

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Committed: https://crrev.com/fc2e2a6f6597cf6582673572bbf22268e445dac0
Cr-Original-Commit-Position: refs/heads/master@{#441391}
Review-Url: https://codereview.chromium.org/2621743002
Cr-Commit-Position: refs/heads/master@{#442796}

The arrow keys now actually select the newly highlighted picture.

BUG=668416
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623993002
Cr-Commit-Position: refs/heads/master@{#442795}

Call adjustedFocusedElementInTreeScope() only if the modified attribute can
affect focusability.

BUG=677446

Review-Url: https://codereview.chromium.org/2625903002
Cr-Commit-Position: refs/heads/master@{#442794}

Since fixing bug 676702 and 597053, we no longer need the string
BluetoothRemoteGATTCharacteristic::m_serviceInstanceId.

R=juncai

BUG=None

Review-Url: https://codereview.chromium.org/2624823002
Cr-Commit-Position: refs/heads/master@{#442793}

BUG=675686

Review-Url: https://codereview.chromium.org/2628463005
Cr-Commit-Position: refs/heads/master@{#442792}

This CL makes WebTaskRunner ThreadSafeRefCounted, and update all user to
use RefPtr<WebTaskRunner> instead of raw pointers or std::unique_ptr.
In public/platform, WebTaskRunner is passed as a raw pointer to avoid
using WTF there.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2550373005
Cr-Commit-Position: refs/heads/master@{#442791}

Instead of always logging the message ID, log a custom error string.
This is necessary for when the messages are converted to mojo messages,
where the messages do not have a corresponding ID.

BUG=643746

Review-Url: https://codereview.chromium.org/2624613003
Cr-Commit-Position: refs/heads/master@{#442790}

git log 71db2b55..682d73bd --date=short --no-merges --format='%ad %ae %s'
2016-12-27 gurchetansingh@chromium.org minigbm: cros_gralloc: don't fail BO_USE_SW_*_OFTEN | BO_USE_RENDERING allocation
2016-09-06 hoegsberg@chromium.org rockchip: Add support for AFBC buffers
2016-12-21 henryhsu@chromium.org minigbm: fix size_t type not found
2016-12-19 gurchetansingh@chromium.org minigbm: consolidate flags
2016-12-14 gurchetansingh@chromium.org minigbm: tegra: add blocklinear detiling logic
2016-12-16 dcastagna@chromium.org minigbm: Remove (c) from copyright notice.

BUG=chrome-os-partner:56407

Review-Url: https://codereview.chromium.org/2624863002
Cr-Commit-Position: refs/heads/master@{#442789}

android.util.Log does not take formatted string (the third argument is
a fixed overload taking a Throwable object), so currently the bare "%s"
is emit to the log. Let's drop it.

BUG=none

Review-Url: https://codereview.chromium.org/2620843003
Cr-Commit-Position: refs/heads/master@{#442788}

Cr-Commit-Position: refs/heads/master@{#442787}

Auto generated by //tools/perf/generate_perf_json.py.

TBR=eyaich@chromium.org

Review-Url: https://codereview.chromium.org/2624963002
Cr-Commit-Position: refs/heads/master@{#442786}

will enable https://skia-review.googlesource.com/c/6845/

BUG=

Review-Url: https://codereview.chromium.org/2623913002
Cr-Commit-Position: refs/heads/master@{#442785}

Add an enum histogram "InputMethod.ImeMenu.EmojiHandwritingVoiceButton"
to track the number of times users click emoji, handwriting or voice
button in opt-in IME menu.

The enum value represents:
1: Emoji
2: Handwriting
3: Voice

BUG=676798
TEST=None

Review-Url: https://codereview.chromium.org/2600173002
Cr-Commit-Position: refs/heads/master@{#442784}

BUG=657117
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2622033002
Cr-Commit-Position: refs/heads/master@{#442783}

Revert of Add LevelDB database names to tracing path for easier debugging (patchset #2 id:40001 of https://codereview.chromium.org/2399903004/ )

Reason for revert:
We identified the largest consumer of memory in leveldb_proto databases and fixed it crbug.com/662019.
It is not safe to add dumps with database names since new clients of leveldb_proto might not update the whitelist and we will miss the memory usage.

Original issue's description:
> Add LevelDB database names to tracing path for easier debugging
>
> The data from field trials show large databases, but not sure what are
> their names. So, adding names to the path.
>
> BUG=645126
>
> Committed: https://crrev.com/279f8d702e8b2fffda1b7f50b311c5202331e121
> Cr-Commit-Position: refs/heads/master@{#424055}

TBR=primiano@chromium.org,nyquist@chromium.org,mathp@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=645126

Review-Url: https://codereview.chromium.org/2601233002
Cr-Commit-Position: refs/heads/master@{#442782}

- when navigating, add host bindings to the pending frame rather than old frame;
- force renderer swap if front-end URL is invalid;
- move front-end URL validation to DevToolsUIBindingds

This also re-lands https://codereview.chromium.org/2607833002

BUG=662859,678035

Review-Url: https://codereview.chromium.org/2620153002
Cr-Commit-Position: refs/heads/master@{#442781}

crbug.com/676675
Out of memory crash caused by memory alloc inside vector::push_back().
Since vector grows its internal buffer following some kind of geometric
progression, it makes more sense to keep pointers inside the vector
instead of actual objects.  Therefore, change the
vector<ReferrerChainEntry> into vector<unique_ptr<ReferrerChainEntry>>.
This will help with the memory allocation inside push_back() function.

crbug.com/679252
Add additional check on the return of FindNavigationEvent() function to
make suer it is valid.

BUG=676675,679252

Review-Url: https://codereview.chromium.org/2624463003
Cr-Commit-Position: refs/heads/master@{#442780}

Currently it sets a custom close button which is different to the other
Harmony dialogs.

To keep items aligned, use the standard panel margins from
ui/views/layout_constants.h. (13px rather than 16px). This makes the
panel slightly more narrow.

BUG=640851, 674269

Review-Url: https://codereview.chromium.org/2581493002
Cr-Commit-Position: refs/heads/master@{#442779}

A previous patch failed to return the composited PaintLayer, which is what
GraphicsLayerUpdater expected.

BUG=679667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2624843002
Cr-Commit-Position: refs/heads/master@{#442778}

This CL makes the check for unregistering dump providers on right thread
stricter by checking even if tracing is not enabled. This is made
stricter only for new dump providers while the existing ones (except few
which are verified correct) are added to a blacklist which does not hit
this check. In next CLs this blacklist will be cleared not to cause
flakiness on the bots with lots of dump providers failing.

BUG=643438

Review-Url: https://codereview.chromium.org/2592233002
Cr-Commit-Position: refs/heads/master@{#442777}

This in preparation for using this method to grab other schemes that we need to now share across the browser and renderer for PlzNavigate. This change does:
-combines AddAdditionalSchemes/AddSecureSchemesAndOrigins/AddServiceWorkerSchemes
-standardizes on std::string

BUG=627502

Review-Url: https://codereview.chromium.org/2622693002
Cr-Commit-Position: refs/heads/master@{#442776}

Changed EUnicodeBidi to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EUnicodeBidi to be used by generated
fields in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2625553005
Cr-Commit-Position: refs/heads/master@{#442775}

BUG=None
Test=None, no visible change.

Review-Url: https://codereview.chromium.org/2619973002
Cr-Commit-Position: refs/heads/master@{#442774}

This test turns off caching for the reload request initiated via the DevTools network agent.
Without PlzNavigate, this goes through the normal resource load path, where in
RenderFrameImpl::decidePolicyForNavigation is invoked after which the cache policy is set in
the WebURLRequest to disabled correctly.

With PlzNavigate, the reload request is sent out to the browser via the BeginNavigate IPC
in RenderFrameImpl::decidePolicyForNavigation() and we indicate  to blink that the client
handled the request.

As a result the cache policy does not get set to disabled.

Fix is to add query the dev tools agent if caching is disabled. To achieve this following changes
were needed.
1. Add a virtual function cacheDisabled() to the WebDevToolsAgent class.
2. This function calls to the newly added cacheDisabled() function in the InspectorNetworkAgent class.
   which checks the state variable for the same.

BUG=673745

Review-Url: https://codereview.chromium.org/2611183007
Cr-Commit-Position: refs/heads/master@{#442773}