- 03 Nov, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604404061-6e4b1d6492901c864984b20d97dc0cd527cfcccf.profdata to chrome-mac-master-1604426269-8f05fba2f9491fbe2e5ad2e4e4fb4bee6873c7ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I36e2826001e69a56fcb6cc08266467e8f5effd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823696}
-
Matt Wolenetz authored
BUG=1143546,1145278 R=sky@chromium.org,bbudge@chromium.org Change-Id: I23be33444805035442f858e84a72d0f05465e964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518268Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#823695}
-
Jamie Madill authored
Skia Gold requires tests to run on CI before registering golden images in the dashboard. This fixes odd behaviour we were seeing where only one golden image was visible on the UI despite accepting many of them. This adds the ANGLE restricted trace tests to 8 bots: - Win10 FYI x64 Release (Intel UHD 630) - Win10 FYI x64 Release (Intel HD 630) - Win10 FYI x64 Exp Release (Intel HD 630) - Win10 FYI x64 Release (NVIDIA) - Win10 FYI x64 Exp Release (NVIDIA) - Linux FYI Release (NVIDIA) - Linux FYI Release (Intel UHD 630) - Linux FYI Release (Intel HD 630) Once we move to the chromium.angle waterfall we can remove these tests entirely from GPU.FYI. Bug: angleproject:5297 Change-Id: Ic36932cc7aa5dbb922565517a3f7a64f6e694ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517621Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#823694}
-
Joel Hockey authored
Make it clearer that it is the virtual path which is passed in, not the absolute path in the host. Change-Id: I2506387a06463c0a6635e3b0ecfb3a29455268b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515428Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823693}
-
Gabriel Charette authored
R=fdoray@chromium.org Change-Id: Ie210d0d4f63eecf35b53c0419393b4c6c3ca26a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504193Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#823692}
-
Caitlin Fischer authored
Bug: 1145159 Change-Id: Ie83ca14104ce98e1eb9655ce2ac3367e5a6905b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517381Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#823691}
-
Mark Schillaci authored
This CL updates the strings/content for aria-current nodes on Android. In the previous CL (https://crrev.com/c/2493660), we added a base string with a placeholder that was dynamically populated. This presents an issue with gendered languages and translations, as the "current" text would need to match the gender of the dynamically populated portion. To fix this, we instead make each string the full content, and removed the dynamic placeholder logic. AX-Relnotes: N/A Skip-Translation-Screenshots-Check: True Bug: 1093578 Change-Id: I11ef9ae570a632176bfe9819b852f584e8f0634d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511036Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#823690}
-
Michael Montvelishsky authored
Bug: 170082901 Change-Id: I84be6454a82eb394b67a26a1c2ac44ce9a01d7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518260 Auto-Submit: Michael Montvelishsky <mont@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#823689}
-
Egor Pasko authored
Reason: ntp.NewTabPageTest#testFocusFakebox failing on builder "Lollipop Tablet Tester". Tbr: twellington@chromium.org Bug: 1145195 Change-Id: I611995e08bfb2f540e0ee184f036b646d8d66b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517725Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823688}
-
Joel Hockey authored
Partial revert of crrev.com/c/2461372 where changes should have only applied to OS_LINUX and not OS_CHROMEOS. Bug: 1144979 Change-Id: I752783a181afa8c40e73e883b2906cfd5da1e7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515806Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823687}
-
Peter Wen authored
Error: util.build_utils.CalledProcessError: <exception str() failed> This is due string.decode turning stdout and stderr into unicode strings in python 2. Bug: None Change-Id: Id21da9a9126f31c851932a62a9fbf349a658ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511881Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823686}
-
Jamie Madill authored
This was most likely fixed along with several changes that went into fixing angle_end2end_tests on TSAN. Bug: chromium:1035461 Change-Id: I5de352a9f1d00226ccf5c00b220689082c475ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517643 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#823685}
-
dpapad authored
This reverts commit b70bf309. Reason for revert: Caused crbug.com/1145097 and crbug.com/1145103. The former is trivial to fix, while the latter requires changes to code that resides outside the Chromium repo. Original change's description: > NTP: Enable scrollbars to follow system's light/dark theme. > > Previously scrollbars always appeared light, even if a WebUI > page was otherwise respecting dark mode. The upcoming > FormControlsDarkMode feature allows webpages to specify whether > scrollbars should follow the system's theme, by specifying a new > <meta name="color-scheme"> tag. > > Launch Chrome with the following flags to experience dark scrollbars. > --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ > --force-dark-mode > > Bug: 1142291 > Change-Id: Iaaea8427a88bdf7cb53559e5fed35d8d59df5ef3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513686 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823279} TBR=dpapad@chromium.org,aee@chromium.org Change-Id: If6ec121d06e7ec1e38c3e814681379ddc0a0a7f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142291,1145097,1145103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518190Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823684}
-
manukh authored
Adds a OmniboxTriggeredFeatureService, accessible through AutocompleteProviderClient, that registers features as they're triggered which are copied to the metrics logs once an omnibox session ends. Change-Id: I311fc20b185dd58b1acc6174321e47a38f794c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437743 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#823683}
-
Alex Turner authored
Use of base::Bind and base::Callback is deprecated in favor of the more explicit Once/Repeating versions. Despite being marked as fixed, a few directories have a few remaining uses that were missed in the conversion. This cl fixes those stragglers in the components/* directories that have been marked as fixed. The presubmit is also enabled for these directories to avoid any future regressions. Bug: 1141533, 1007674, 1007677, 1007712, 1007717, 1007739, 1007747 Change-Id: I3bf96c5e820168a01f5859ad2a5e181bb28b22d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505579Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#823682}
-
Omar Morsi authored
This CL introduces ARC key permissions manager delegate which observes changes that affect ARC usage allowance of corporate keys residing on a specific token. If an ArcKpmDelegate observes a change in the state of ARC usage allowance, it notifies all observers. ArcKpmDelegates are utilized by key permissions managers to keep key permissions updated in chaps. Bug: 1113115, 1127284 Change-Id: Ib7636c83f313904c7d5a23f91baca6bf43907344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479706 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823681}
-
Ian Struiksma authored
These were FYI and trybots that were used to validate new win10 version. Removing buildbot and mb configurations for these bots. Bug: 1124829 Change-Id: I42f41dd233dc2d8e3de19c0de6dd35a8f68413f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517980Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#823680}
-
Alex Gough authored
This is a reland of df9e203b Original change's description: > Only pass executable sections to OnDllLoaded for patching > > On recent Windows insider builds GetModuleHandleExW loads sections for > inspection as non-executable images, rather than as files. This leads > to our hooks detecting the SEC_IMAGE attribute and potentially patching > functions (e.g. for user32.dll). > > This caused content_browsertests to fail as it pinned user32.dll in some > processes. With this change, the tests run again. > > See crbug.com/1143397 for a full discussion. > > Bug: 1143397 > Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823354} Bug: 1143397 Change-Id: Ibacc1ba6105665c32ea445a7f63178163585efbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515783 Auto-Submit: Alex Gough <ajgo@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#823679}
-
Matt Wolenetz authored
BUG=1145235 TBR=tedchoc@chromium.org Change-Id: I83885281502a8dc338504f378063bf50c4641a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517563 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#823678}
-
Gabriel Charette authored
And punt back expiry by 3 months. R=rdevlin.cronin@chromium.org Bug: 1130637 Change-Id: I469336c3383576fdf8bcdfd6b974142f72857bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510273Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#823677}
-
minch authored
Bug: 1145255 Change-Id: I20b9a1352209948897d8174786a58122c3f5a37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518322Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#823676}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb20-58.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Ibeefcf93e32138cdd178f2e9559c57f4e81797df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518103Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#823675}
-
Avi Drissman authored
Fixed: 1144809 Change-Id: Ic16a621c3b74e6259a0ac3d94f359869a30c4e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516019 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#823674}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/df4236e338ac..2e411e2f8478 2020-11-03 chrche@microsoft.com [Loc] Migrate coverage to Loc V2 2020-11-03 andoli@chromium.org Sets up infrastructure to migrate extensions of type 'view' 2020-11-03 aerotwist@chromium.org TypeScriptify LineLevelProfile.js 2020-11-03 mulherje@gmail.com Update template for text buttons to allow for mousedown event listener If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1134103,chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie856c0f4fe7eacc75c47e80cf049592819f2aebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823673}
-
Henrique Nakashima authored
The assert is for debugging as if native is not initialized this will crash anyway. Moving it from IncognitoTabModelImpl breaks its dependency on TabModelJniBridge. Bug: 1109013 Change-Id: I3cd06e4f2115b315bb1ba3e7699e925a9b30c4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511092Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#823672}
-
Mohamed Heikal authored
When image_editor DFM is not defined, pressing the edit button should do nothing rather than crash chrome. Bug: 1145044 Change-Id: Ideaf738bde7c626bee627648c517f4fe9f3a4910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517619Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823671}
-
Sigurdur Asgeirsson authored
Change-Id: I6fbf2bdfcba2445997dd55e102dac491b2f981d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517622 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#823670}
-
Michael Thiessen authored
This will be a 3-sided multi-part CL. In this change I move CriteriaHelper to base/, leaving a copy in content/ I will then migrate the downstream and upstream content/ imports to base/ imports. After downstream has rolled I'll remove the content/ copies. Bug: 1134178 Change-Id: I07c646a1cc9aebfcd2c2a7cd3e0446f0581f6e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518120Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823669}
-
Yuke Liao authored
This CL uses also_build_ash_chrome on CI builders to as to be consistent with the linux-lacros-rel CQ builder. Bug: 1129223 Change-Id: Id4fa70033a2702ed94590a943239492001a9a2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517145 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823668}
-
Michael Checo authored
Screenshot: http://shortn/_OHS9E7XPgF Bug: 1059779 Test: browser_tests --gtest_filter=ScanningAppBrowserTest.All Change-Id: Ida6b9bccfeb781d353ccb944713e4c95b1735387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506304 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#823667}
-
Clark DuVall authored
This should fix the crash seen with isolated splits. Isolated split class loaders are not able to load native libraries due to b/b/171269960, so the paths must be resolved manually. This will have a corresponding change in the internal repo. Bug: 1143321 Change-Id: I58f4e496417248ad38b388a4e45fafb3843226bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515439 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823666}
-
Mariam Ali authored
This CL fixes the regular guest NTP where it seems to be unreachable. Bug: 1144597 Change-Id: Ie1d5a8ca5f059e15b3c2526b01e67ad4f12aebee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512889Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Mariam Ali <alimariam@google.com> Cr-Commit-Position: refs/heads/master@{#823665}
-
Rakib M. Hasan authored
Bug: None Change-Id: I3e8c0bf667a028b256c2d200df33d4f8d68ff389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515022 Commit-Queue: Rakib Hasan <rmhasan@google.com> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#823664}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba40ae7e..adbea905 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieab7cde1cb844986feda89090d1e09a8b972c34f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517144Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823663}
-
Wei Li authored
Prior to this change, expand button inherits ToggleImageButton's default focus behavior which is ACCESSIBLE_ONLY. This button should be focusable by default as user can navigate/toggle the button using a keyboard. Bug: 1001103 Change-Id: Ic698f3865ddcb8cc66b962292831c3d5a73fc29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510729Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#823662}
-
Henrik Boström authored
Despite this test already being marked as [ Pass Crash ], when the test crashes on the bots, the Flake Portal registers the crash not as a crash but as a failure, see https://crbug.com/1094930#c25. For now, I'm marking this test as [ Pass Crash Failure ]. TBR=hta@chromium.org Bug: chromium:1094930 Change-Id: Ic6e1b54798ba53302ef1b7ac9dee4b06cba2a08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517462 Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#823661}
-
Tommy Nyquist authored
This reverts commit dbe0ea06. Reason for revert: New test fails on the following bots: https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20N%20%28dbg%29 Original change's description: > ContentCapture: re-stream onscreen content when the frame show again > > Previously ContentCaptureConsumer had no way to know the the frame > shows again because the visible content didn't change. > > This patch resets the task session when the frame was hidden, so > ContentCapture task will stream on-screen content because they > aren't streamed from the task point of view when the frame was > shown. > > Adds the test to coverage this scenario. > > Bug: 1137463 > Change-Id: I0065ce080101d2149622b0f9f6a3aa196c18d717 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511030 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Michael Bai <michaelbai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823251} TBR=michaelbai@chromium.org,wangxianzhu@chromium.org Change-Id: I219bd94c5dfc36b073590d6e604ce951aef3c966 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518401Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#823660}
-
Jamie Madill authored
This config is unsupported. Leave angle_unittests because they're used with Chrome separate from ANGLE. This removes angle_end2end and angle_perftests. Bug: angleproject:5298 Change-Id: Ia7ddca4de7e2989fd7e2d375dec7a9a3bf942f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517642Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#823659}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/655afebfcd13..5bdfcd8f3397 2020-11-03 sokcevic@google.com Add `main` when guessing origin remote If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143724 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Ib34347e387f75f7d63ba2b9d4cd0eee314f1711e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823658}
-
Rakib M. Hasan authored
These changes will add a tester for Android Marshmallow which will run Weblayer skew tests. It also renames the Android 10 builder. Bug: 1114563 Change-Id: I13b72e50cac7e322bfd8214fae4e08718d7667b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514675Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#823657}
-