- 14 Aug, 2019 40 commits
-
-
David Staessens authored
The new video_decode_accelerator_perf_tests collect various performance metrics while decoding a video. To give an idea of the relative amount of frames dropped the 'frame drop rate' is calculated, which is the ratio between frames dropped and frames not-dropped. This metric is unfortunately rather confusing to interpret (e.g. 50% of frames dropped is a frame drop rate of 1). The drop rate was initially used rather than drop percentage to keep in sync with the old video_decode_accelerator_unittest. This CL changes the 'frame drop rate' metric to the more readable 'frame drop percentage', which is also the metric collected by various other tests such as the Tast playback_perf_* tests. TEST=new vda performance tests on eve BUG=None Change-Id: I674e47b9d540df0348ee53f4cf71f5cc19fb5db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750534Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#686680}
-
Gyuyoung Kim authored
This CL replaces all remained uses of GetDataResourceAsASCIIString as well as the implementation of GetDataResourceAsASCIIString in data_resource_helper. Bug: 983396 Change-Id: Ic388ac0c72162ae6c081797d23245b5b1f3d41e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746213 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#686679}
-
Gyuyoung Kim authored
This CL converts implementations of nfc.mojom in the renderer process. Major changes are as below, - Change the argument of SetClient from NFCClient to pending_remote<NFCClient> in nfc.mojom - Change mojo::Binding with mojo::Receiver - Change NFCClientPtr with mojo::Remote<NFCClient> Bug: 955171 Change-Id: Ibfc900f35dc22736e8af3753705e55fadd5ac76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750517 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#686678}
-
David Staessens authored
When the video_decode_accelerator_(perf_)tests are build for ChromeOS the video test code expects at least the 'use_v4l2_codec' or 'use_vaapi' flag to be set. This CL ensures the build works if none of these flags are set. The test won't work, but the build will not be broken. BUG=993467 TEST=Built for ChromeOS without 'use_v4l2_codec' or 'use_vaapi' set Change-Id: Ic7b543907ed1b37bcac2b9f2bc3dc006109a8166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752268Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#686677}
-
Nate Fischer authored
We allow downgrades by default when installing APKs. We should apply the same setting for App Bundles. There's no good reason to not allow downgrades by default for local development, since it's just annoying when installation fails because a previous install had a higher version. Note: this does not allow downgrades on user builds, but "allow_downgrade" is otherwise harmless to pass (the install acts as if allow_downgrade was not specified). This is a follow-up to https://crrev.com/c/1383575. Bug: 915431 Test: manual Change-Id: I7392d9a4656f702266f5790bee9a7fec395190f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746642Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686676}
-
Rohit Rao authored
Disabling to unblock the CQ. BUG=993604 Change-Id: I6a129e8ae3d8b48b155bfec3ce3bff0ff7657f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753204 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#686675}
-
Antonio Gomes authored
... when posting tasks. A task posted runs once, so CrossThreadBindRepeating is not strictly correct. This is now possible, after [1]. [1] crrev.com/c/1750043 BUG=964922 R=jbroman@chromium.org Change-Id: Ic1937f017ec6cd5a532b99a1f270f2ce2a99b8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752078 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#686674}
-
Yutaka Hirano authored
Implement https://github.com/whatwg/xhr/issues/248. We haven't sorted the headers, so there is no compatibility issue. Bug: 993271, 651750 Change-Id: Ie69fb45a90795ea303324358312b16b7e6e227aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750476Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#686673}
-
Brandon Wylie authored
This color samples the edges of the dse logo and creates a background that the logo is then laid on top of. Bug: 993416 Change-Id: I64ccd7358165334914eff54563f71f141dd4d4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737331 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#686672}
-
Michael Giuffrida authored
Removes remaining KioskNext code and references. Bug: 977019 Change-Id: Ic1d554d9771996f87e85ee2d335cbf82da2ec19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750264 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#686671}
-
Bret Sepulveda authored
If the only tab in a group is added to another group in a way that causes that tab to move (e.g. there is an intervening ungrouped tab) then we will crash. This is caused by TabStripModel setting the new group on WebContentsData and then sending the kMoved notification before the kGroupChanged notification. TabStripLayoutHelper::MoveTab expects the group of the tab being moved is not empty according to the model. This patch fixes the bug by sending kGroupChanged immediately after setting the group on WebContentsData, so TabStrip will delete the old group immediately. Bug: 983961 Change-Id: Ib214a1b7a82f5958e48310477ba9c63d832e3095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753059 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#686670}
-
Ken Rockot authored
The removes Service Manager dependencies from the Mirroring Service and its singular client in Chrome. CastMirroringServiceHost now manages its own service process instead of using Service Manager. This service was also the only service asking to bind the viz.mojom.Gpu interface through a Connector to the browser (supported by common_browser_interfaces.cc), so that support code has been removed and CastMirroringServiceHost instead pushes a Gpu interface to the service, acquired directly from content::CreateGpuClient(). This should be functionally equivalent to what was done before but with fewer round- trips. Bug: 977637 Change-Id: I2ac8addac4a4e67c8ad35856ec70052530990dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743313 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686669}
-
Alan Cutter authored
This CL updates an old comment class name to the current name. Change-Id: I38ef92fab6a26ed1143b3a226d8cf008a2b4352c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751102 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#686668}
-
Sajjad Mirza authored
The coverage dump in TerminateCurrentProcessImmediately is currently blocking us from gathering coverage for sandboxed processes, because it corrupts the data from those processes. This is a temporary workaround, until we implement a proper solution for the data corruption. Bug: 993537 Change-Id: Idd4669f3d41b349247161e9611e52ca00a9e75ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752926 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#686667}
-
Hwanseung Lee authored
According to guide[1], it is acceptable to be also named like macro instead of constants. but it is old way. so change it to keep consistency with others. [1] https://google.github.io/styleguide/cppguide.html#Enumerator_Names Bug: 940736 Change-Id: I8c158f230cea7d68b358b8ff7bd0aeff6df78697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600387Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#686666}
-
Sunny Sachanandani authored
Without this the 2D canvas demo https://codepen.io/miguelao/full/ZjJNNw janks a lot since it enqueues too many presents which introduce implicit synchronization without the DXGI_PRESENT_ALLOW_TEARING flag. This moves the swap chain tearing feature detection to a central place, and makes shared image swap chain dependent on swap chain tearing. Bug: 939657, 939659 Change-Id: Ic8a423a4e2742056dcbb8d3d4af473180e246a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750199 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#686665}
-
Nico Weber authored
No intended behavior change. TBR=rdevlin Bug: 961769 Change-Id: I478dea8583b6cf8870812197f61a43207ef9e587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752626 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#686664}
-
John Budorick authored
Bug: 922145 Change-Id: I568cda76f19e1813b5f8cf8a46775c92b30c272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753183 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#686663}
-
Clifford Cheng authored
Change-Id: Idd4f601db27ee27306f3dd159fb5b4ef5a992c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743062Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#686662}
-
Lambros Lambrou authored
After http://crrev.com/3d3751dc8d7a7797939d05f99d5c051b185315be, the software encoders were being run on the main (network) thread instead of the dedicated encoder thread. The member WebrtcVideoScheduler::encode_task_runner_ and the WebrtcVideoEncoderProxy class were unused. This CL puts the software encoders back on the encoder thread. The hardware (H264) encoder is not affected, as that runs asynchronously already. Change-Id: I8346247dde0ee5bdc0f10578937b8c89a56d3d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752179 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#686661}
-
tby authored
This CL finishes the move from the AppSearchResultRanker to the RecurrenceRanker. A follow-up will delete the unused ASRR code. Bug: 989350 Change-Id: I4e5fc82dcc2ab5e33f33da3e9eb134a6f5226118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737361 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#686660}
-
Kunihiko Sakamoto authored
This reflects https://github.com/WICG/webpackage/pull/484. Bug: 969596 Change-Id: I3484b6e76f51a76e507667499dddc37024cc0af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750528Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b3b228c60d63..90c00916229f git log b3b228c60d63..90c00916229f --date=short --no-merges --format='%ad %ae %s' 2019-08-13 zoddicus@users.noreply.github.com Rolling 3 dependencies (#777) Created with: gclient setdep -r src/third_party/shaderc/src@90c00916229f The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I4d2826df39a62983b11d18beeb84cf26fb11ca4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686658}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6bb29da82994..979fa780ce2f git log 6bb29da82994..979fa780ce2f --date=short --no-merges --format='%ad %ae %s' 2019-08-13 ehmaldonado@chromium.org depot_tools: Make gclient_scm Python 3 compatible. 2019-08-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@979fa780ce2f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I2373657fba8cb586e78c4e389a90f128601cd6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753084Reviewed-by:
-
Wez authored
Transition to the fully-qualified names has rolled in the SDK, so remove the legacy accommodation. Bug: 988195 Change-Id: I41bf4c655526c6ef8fd8d41976c879c4f78ce4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746760 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#686656}
-
jonross authored
Changes for how gl syncs with Skia was landed: https://chromium-review.googlesource.com/c/chromium/src/+/1738441 This change updates the current SkiaRenderer expectation files to re-enable tests which are now working. TBR=cblume@chromium.org TEST=skia_renderer_gl_blink_web_tests, skia_renderer_vulkan_blink_web_tests vulkan_swiftshader_blink_web_tests Change-Id: I4701eacb107f3c3800c209411cb4036951721e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742986Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#686655}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/225110211231..b3eeb2a40354 git log 225110211231..b3eeb2a40354 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 geofflang@chromium.org Emulate RGB textures using BGRX IOSurfaces. Created with: gclient setdep -r src/third_party/angle@b3eeb2a40354 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I9ef657c87f313cd09d8d755a7e64df1492be8145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753053Reviewed-by:
-
Jacques Newman authored
Issue: Selection APIs can expose ignored nodes. AXSelections are built using AXPositions (which can be ignored). The selection is then serialized into AXTreeData. This is read and exposed directly without any additional logic regarding the ignored state of the node, allowing for ignored nodes to be exposed to ATs. Solution: Add GetUnignoredSelection API to the AXTree to 'fix' positions to be unignored before exposing them to ATs Added new APIs * AXTree::GetUnignoredSelection * AXPosition::AsUnignoredTextPosition * AXNode::GetDeepestFirstUnignoredChild * AXNode::GetDeepestLastUnignoredChild * AXNode::GetNextUnignoredSibling * AXNode::GetPreviousUnignoredSibling * AXNode::GetNextUnignoredInTreeOrder * AXNode::GetPreviousUnignoredInTreeOrder Added unit test in ax_tree_unittests Added Dumptests Bug: 982414, 985965 Change-Id: Ic889df8edd93140ae7e93dfff6a6def6993e79ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691559 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686653}
-
Sunny Sachanandani authored
Flush on the client side to ensure the PresentSwapChain() IPC message makes it to the service, and flush device context in the service to ensure that driver flushes its command queue. Without the former, the last frame presented to low-latency webgl canvas before a pause can be delayed until canvas updates again. On https://codepen.io/miguelao/full/WKZaqd this can be seen as a delayed stroke at the last position of pointerup after starting a new touch sequence. Bug: 939655 Change-Id: I464c77fe1d25e0af73708b89963b876ec1ae7a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747157 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9b1a4a9da1da370552ceab43906102b58574b737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753087Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d550b702ac53..283aa6a07c39 Created with: gclient setdep -r src-internal@283aa6a07c39 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I5e143aa0b05ab2bb8705fd7ffda7578e0a2ae615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753083Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686650}
-
Sergey Ulanov authored
Previously compositor supported YCbCr samplers only on Android and only for external Vulkan images. On Fuchsia sysmem APIs use Vulkan I420 formats to return decoded images and so YCbCr samplers have to be used to render them on the screen. In this CL: 1. Updated VulkanImplementation::CreateImageFromGpuMemoryHandle() to make it possible to return YCbCr info. 2. Added image_format in gpu::VulkanYCbCrInfo to remove the assumption YCbCr images are always external. 3. ExternalVkImageBacking now bundles returned YCbCr info in GrVkImageInfo when wrapping in GrBackendTexture. 4. SkiaOutputSurfaceImpl now passes image format when initializing GrVkYcbcrConversionInfo. 5. Updated VulkanDeviceQueue and VulkanImplementationScenic to enable YCbCr sampler extension on Fuchsia. Bug: 981022 Change-Id: I477ebf698d098bafefaadbf77dfa8d373f9ae076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730311 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#686649}
-
dalyk authored
The kDnsOverHttps feature now has two params: Fallback and Templates. The Fallback param allows the default SecureDnsMode used by the HostResolverManager to be set to AUTOMATIC (true) or SECURE (false). The Templates param allows multiple DoH templates separated by spaces to be used in either AUTOMATIC or SECURE mode. Invalid templates are dropped, and among valid templates, the configured HTTP method is GET if the template contains a "dns" variable, and is POST otherwise. This change provides the ability to experiment easily with multiple DoH templates in different SecureDnsModes. Example usage: --enable-features="DnsOverHttps<DoHTrial" \ --force-fieldtrials="DoHTrial/Group1" --force-fieldtrial-params=\ "DoHTrial.Group1:Fallback/true/Templates/https%3A%2F%2Fcloudflare-dns.com\ %2Fdns-query" Bug: 985589 Change-Id: I0b847becebf63b9a309c81b1eeb1b788df91cc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524304 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#686648}
-
Sujie Zhu authored
Previously when we introduce the enum NOT_OFFERED_USE_UNSUPPORTED_LOCAL_CARD, we forgot to add the label string for the enum value: https://chromium-review.googlesource.com/c/chromium/src/+/1700298 This is a fix for that. Bug: 954367 Change-Id: I3bba1d4ed4c1879339e8baa54d600a8d319242a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753050 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Auto-Submit: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#686647}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/35670f183a73..2fb628da46f1 git log 35670f183a73..2fb628da46f1 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 hob@chromium.org Remove GLFW dependency for non-GL tests 2019-08-13 enga@chromium.org Add dawn_platform::Platform for handling tracing events in Dawn Created with: gclient setdep -r src/third_party/dawn@2fb628da46f1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:993457,chromium:958013 Change-Id: Icaebab52c118104672ad837a026569a3a4824b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752907Reviewed-by:
-
nancy authored
BUG=992839 Change-Id: Ice35146fbe8c931bbfb81e885c9a24766619e27b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750515Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686645}
-
Alexey Baskakov authored
Plumb WebApp::launch_container_ from WebAppInstallFinalizer::FinalizeInstall. Implement persistence for launch_container_ and its enum. We don't want to change components/sync/protocol/web_app_specifics.proto for now: there will be many proto changes on our side. We will upstream them in one big CL to be approved by the sync team (i.e. we want to batch all the updates when our proto structure stabilized). Bug: 891172 Change-Id: Ia6780ddcfc4143cad3f4a74e92ac61c71b3886b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750475Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#686644}
-
Ian Kilpatrick authored
This passes border_padding of the flex-item into the size calculation calls, instead of border_scrollbar_padding. Additionally this removes two GetLayoutBox() calls (used to determine) the scrollbars from within NGFlexLayoutAlgorithm::Layout. Bug: 845235 Change-Id: Ifddca6db7e25b4c2d8851ffbcbce71b2740cd9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752549Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#686643}
-
Vikas Soni authored
1. StreamTextureHost's |channel_| could be null while StreamTextureHost is still alive because |channel_| can be set to null on a OnChannelError() call. 2. Add a new unit test to test and make sure StreamTextureHost can handle a null |channel_|. 3. An invalid mailbox needs to be checked by calling Mailbox::IsZero(). 4. Remove previously added CHECK's for debugging. Bug: 984309 Change-Id: I1fb42855877540f1ec0ddbcec4fe5713071727a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740168 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#686642}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/42424bf2eab6..f20959283711 git log 42424bf2eab6..f20959283711 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 thestig@chromium.org Remove some checks that are always/never true in CPWL_ListCtrl. 2019-08-13 thestig@chromium.org Reuse existing methods in CPWL_ListCtrl. 2019-08-13 thestig@chromium.org Clean up some CPDF_CMap code. Created with: gclient setdep -r src/third_party/pdfium@f20959283711 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I5b197c597f0d7265d794dac6bf4f61483f4b6766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753047Reviewed-by:
-
