- 15 Mar, 2018 40 commits
-
-
Helen Li authored
This test is flaky on Mac. This CL disables it temporarily. Bug: 821224 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I909087ed5102631fdca68b45d9a0c4b6810410fc Reviewed-on: https://chromium-review.googlesource.com/964614Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543459}
-
https://chromium.googlesource.com/catapult.git/+log/6c4a8ca2e9bc..1446cf3fe8a3 $ git log 6c4a8ca2e..1446cf3fe --date=short --no-merges --format='%ad %ae %s' 2018-03-12 tiborg [vr] Fix draw metrics in frameCycleDurationMetric 2018-03-13 perezju [Telemetry] Let Telemetry find the embedder APK for WebView Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I729e915f328d914579609e93cec723aa64c597a7 Reviewed-on: https://chromium-review.googlesource.com/963838 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543458}
-
Emily Hanley authored
Bug: 779634 Change-Id: Ifbc4d5736cef4ceda239b5a5efe31533a4a01e78 Reviewed-on: https://chromium-review.googlesource.com/963083Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#543457}
-
Dave Schuyler authored
This CL uses CanProcessEventsWithinSubtree to stop enter/exit events to text and image elements. Bug: 820892 Change-Id: Ice5adc61ba617db3119eea9a99d10255888aa840 Reviewed-on: https://chromium-review.googlesource.com/962665Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#543456}
-
Cathy Li authored
Bug: 812022 Change-Id: I8cb1c8e9566bf4fb92f67ef5b8c9e434467e647b Reviewed-on: https://chromium-review.googlesource.com/944620 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#543455}
-
wutao authored
This cl changes one string in Keyboard Shortcut Helper to make it more clear to the users. Bug: b/74186947 Test: manually tested. Change-Id: I4af4d7a99c9a279a775309e58584c06e63f7a136 Reviewed-on: https://chromium-review.googlesource.com/964586Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543454}
-
Owen Min authored
Browser test for crrev.com/027059d8. Bug: 820649 Change-Id: I8f9cd3a53b702ce67b62fd6986b469c426ad1f84 Reviewed-on: https://chromium-review.googlesource.com/961541Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543453}
-
Tarun Bansal authored
Add an explicit DCHECK in the data reduction proxy (DRP) to ensure that we do not check for explicit bypasses in the responses. Bug: 760294 Change-Id: Ifd683efc79d484388f2446757e9025068c1d6fb8 Reviewed-on: https://chromium-review.googlesource.com/963100Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543452}
-
Andrew Grieve authored
Allows for better inlining by ProGuard. TBR=agrieve # Simple rename Change-Id: If0b57507aeae938bdbe2adbd62e5d38c0d50ab4c Reviewed-on: https://chromium-review.googlesource.com/964383Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/0b0dcbc1cffa..41918387cc52 $ git log 0b0dcbc1c..41918387c --date=short --no-merges --format='%ad %ae %s' 2018-03-13 lucferron Vulkan: Additional texture formats support. RGB565, RGBA4444, RGBA5551 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I0e12575bd41525577314faf73fd7f5e6b6974db3 Reviewed-on: https://chromium-review.googlesource.com/964602Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543450}
-
John Abd-El-Malek authored
There are two fixes: -ensure that intercepted navigations have the correct StoragePartition: this was currently not true because ResourceDownloader::InterceptNavigationResponse was using empty site url. The fix is to pass the right one in from DownloadManagerImpl::InterceptNavigationOnChecksComplete. This is similar to the fix in r528794 but instead of for new downloads, it's for intercepted downloads. -pass the (now correct) StoragePartition to BeginDownloadInternal, instead of it creating it from the render frame ID, as that doesn't work with storage partitions for web views. Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I65caeaefbf489ab5a2c955d8a7a8d0efb562d281 Reviewed-on: https://chromium-review.googlesource.com/957983Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543449}
-
Anita Woodruff authored
- This test was frequently timing out the net_unittests on multiple platforms. TBR=juliatuttle@chromium.org Bug: 820950 Change-Id: I1e24c286824b678db290ad1116f463c314a045cd Reviewed-on: https://chromium-review.googlesource.com/964661Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#543448}
-
Fady Samuel authored
I stumbled upon the need for some cleanup in deadlines while investigating a surface sync bug. SurfaceDependencyDeadline::InheritFrom returned a bool that wasn't used anywhere anymore. This CL removes it. This CL also clarifies the InheritFrom contract. When deadline object A inherits from deadline object B, A gets B's deadline but does not get B's start time. This was already true but this CL adds direct test coverage of this. The other oddity is InheritFrom only supported deadline inheritance if the object already had a deadline set. This is how it's used by surface sync in practice but seems unnecessarily brittle. With a small change, the contract is fully specified and this special case is removed. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Icd6a078ef90298af578c7267ca38f5c0f3ab5d37 Reviewed-on: https://chromium-review.googlesource.com/964257 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#543447}
-
Miguel Casas authored
VaVDA passes a UMA callback of sorts to VaapiWrapper to mark error conditions (Media.VAVDA.DecoderFailure) but there's no baseline for the amount of times it succeeds: this CL adds it as Media.VAVDA.VaapiWrapperCreationSuccess. It also adds a Media.VaapiWrapper.VADisplayStateInitializeSuccess to track the success/fail of initialising the VADisplayState, which we suspect to fail at times in the field. It also adds a "Vaapi" prefix to some traces so that they can be visually related in chrome:tracing. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib841dca9626f2bed53a39b8bfd756d29c99b553e Reviewed-on: https://chromium-review.googlesource.com/962709Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#543446}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/703b4a85a21e..a325ad2db5de $ git log 703b4a85a..a325ad2db --date=short --no-merges --format='%ad %ae %s' 2018-03-14 misterg erging, cont 2018-03-13 misterg merging, merging 2018-03-13 misterg fixing, was removing too much 2018-03-13 misterg More merges, removing old dead code 2018-03-12 bauerb Allow macros inside of parametrized test names. 2018-03-12 misterg merges-port(1) 2018-03-07 misterg Merging, XML tests Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official Change-Id: I28944f5f6293d391c221dda2d67a8342de89062a Reviewed-on: https://chromium-review.googlesource.com/963706Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543445}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ied9c3836a042a7278ba5833fc05d3df47ab38877 Reviewed-on: https://chromium-review.googlesource.com/963834 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543444}
-
Robert Liao authored
The first kFocusPage config has been skipped since at least the initial public commit and appears to be an oversight. https://chromium.googlesource.com/chromium/src/+blame/09911bf300f1a419907a9412154760efd0b7abc3/chrome/browser/browser_focus_uitest.cc#186 BUG= Change-Id: If17bfc7594d57ea62e5508b8912abcd628d5a0bf Reviewed-on: https://chromium-review.googlesource.com/964608Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543443}
-
https://pdfium.googlesource.com/pdfium.git/+log/40c223e4ed41..d1ffda2acaee $ git log 40c223e4e..d1ffda2ac --date=short --no-merges --format='%ad %ae %s' 2018-03-15 thestig Cleanup CStretchEngine. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7d16e2a8ed63b5fcb7295d8bcb35b68abe672218 Reviewed-on: https://chromium-review.googlesource.com/964388 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543442}
-
Shakti Sahu authored
This CL adds support for upload in the download driver, model, client and entries. The upload logic and state machine changes in the controller will be added in another CL. Bug: 812327 Change-Id: Ib3b60e2ad71740a28b0aa53a08cce9b046ab6e9e Reviewed-on: https://chromium-review.googlesource.com/919867 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#543441}
-
Peter Kotwicz authored
This CL moves ReplacePlaceholders() to //content in preparation for using ReplacePlaceholders() in manifest_parser.cc Change-Id: Ia4fb6533bcc6f914e3e5499577edb2212583af8a Reviewed-on: https://chromium-review.googlesource.com/924550 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#543440}
-
Derek Cheng authored
- On channel error, erase the sink from |current_sinks_map|. crrev.com/541271 added a check in OpenChannel() to short circuit if a sink already exists on the map. In order for retry on error to kick in properly, we will need to erase the entry in OnError(). - In OnChannelOpenSucceeded, erase stale sink with the same IP. This is done to maintain the invariant of having at most 1 sink of a given ID in the map. Stale sink is defined as having the same sink ID but different IP endpoint than the current one. - In OnChannelOpenFailed, when erasing the sink from |current_sinks_map_|, also verify the sink ID. It is possible that a different sink now occcupies the IP endpoint that it is trying to erase. Change-Id: I12bfd5af5f664c4773e7587dc30c6709d2352021 Bug: 698940 Reviewed-on: https://chromium-review.googlesource.com/961555Reviewed-by:
Bin Zhao <zhaobin@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543439}
-
Ryan Landay authored
I'm splitting most of StackLayout into a base class in https://chromium-review.googlesource.com/c/chromium/src/+/957875 to support building UI prototypes on top of the tab switcher UI. This CL cleans up the interface for child classes so that they don't have to manually manage the list of Stacks. Instead, they can call a setTabList() method with a list of TabLists, and StackLayoutBase will set up the Stacks accordingly. Bug: 648314 Change-Id: I627da998baaf9d74e3fa14da3cf392097a6e0944 Reviewed-on: https://chromium-review.googlesource.com/961442Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#543438}
-
Scott Violet authored
DisplayManager's constructor is called from WindowServer's constructor. This means DisplayManager shouldn't call to WindowServer, else we get use of unitialized values like this. BUG=822246 TEST=covered by tests Change-Id: I296911502021a135276a9db49b98927efea95618 Reviewed-on: https://chromium-review.googlesource.com/963831Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543437}
-
David Bokan authored
Selection bounds are sent from Blink to CC as part of a commit cycle so that we can draw touch handles for it. Currently, the selection bounds are relative to the main graphics layer of a CompositedLayerMapping. In the case of a scroller, this will be its clip rect - rather than its scrolling contents layer. Unfortunately, this means that scrolling on the compositor isn't applied as part of the ToScreen transformation on the selection bounds so scrolling wont update the selection bounds location until another Blink commit. This went unnoticed until now because the root layer was not considered a scroller. The page would paint into a document-sized layer and the compositor would provide extra scrolling layers to handle frame scrolling. In this configuration, the ToScreen transformation from the root layer does include the scroll offset. Now that root layer scrolling has been turned on, frame scrolling works much the same as other scrollers. Thus, this shortcoming is seen on frame scrolling also. The solution in this CL is to move the selection bounds rect to be relative to the scrolling contents layer - if one exists. The ToScreen transformation done in CC will correctly compensate for any scroll offset applied in the compositor and touch selection handles stick to the selection as its scrolled. For the CC side, see ComputeViewportSelectionBound in layer_tree_impl.cc Bug: 812048 Change-Id: I219ac3209d334ac91e9c13ffaaa51cbc9db57886 Reviewed-on: https://chromium-review.googlesource.com/963006Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543436}
-
erikchen authored
The concept is only well-defined on Linux, but the measurement was only implemented and used on Windows. Bug: 819289 Change-Id: Ie69e550019e29b473c8efcae8f3c8bbc390e737b Reviewed-on: https://chromium-review.googlesource.com/956575Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543435}
-
Nate Fischer authored
This was originally disabled because we still ran tests against the old code path. That's no longer supported, so we can safely reenable the test. This also turns a comment into a proper TODO, since it shouldn't be left too long. Bug: 822124 Bug: 769126 Test: run_webview_instrumentation_test_apk -f AwContentsClientShouldInterceptRequestTest#testLoadDataWithBaseUrlTriggersShouldInterceptRequest Change-Id: I0947560b44c565edb3be2966e121d916b003ed01 Reviewed-on: https://chromium-review.googlesource.com/963647Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543434}
-
Tarun Bansal authored
Also, add tests for other client hints. Finally. use the built-in sub pipe to enable running the cross-origin test. Bug: 817049 Change-Id: Ib4155f50e0ffd3a0447cf250cd4018b650f3b419 Reviewed-on: https://chromium-review.googlesource.com/963403 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#543433}
-
Mustafa Çamurcu authored
Ozone BUILD.gn files for each platform have this line in them except headless. Now it has it too. Still no head. It was causing double definition of some symbols when building for windows. Bug: Change-Id: I3455ab67848f05c0b3596a53cf6f6279bf078f0c Reviewed-on: https://chromium-review.googlesource.com/963227Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Cr-Commit-Position: refs/heads/master@{#543432}
-
Mohamed Heikal authored
This exception was created to better understand a crash stacktrace in crbug.com/662877, and led to fixing the original cause of the crash. However new codepaths now trigger this exception (crbug.com/822203) thus renaming the exception message to be more generic. Bug: 662877,822203 Change-Id: I0c1ae488b47bab739a839073f9775c7f45d0901d Reviewed-on: https://chromium-review.googlesource.com/964387Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543431}
-
Caleb Rouleau authored
This reverts commit 242fe9d5. Reason for revert: The bot is working again before the revert when in: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/30249 Original change's description: > Revert "Fixed first_run test failure because of the global variables" > > This reverts commit 8d01fd2f. > > Reason for revert: crbug.com/822316 looks like it broke net_unittests? > > bug: 822316 > > Original change's description: > > Fixed first_run test failure because of the global variables > > > > Fixed typical problem with unit tests and global variables. > > If unit test modifies global variables then it can affect other tests > > which are runned in the same process. Added reseting of the global > > variables to avoid this. > > > > Change-Id: I2045700473ac074209f4d48a6cedbd3dad24ccd5 > > Reviewed-on: https://chromium-review.googlesource.com/952905 > > Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> > > Reviewed-by: Carlos Pizano <cpu@chromium.org> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543345} > > TBR=gab@chromium.org,cpu@chromium.org,a-v-y@yandex-team.ru,vitreb@yandex-team.ru > > Change-Id: I616e5415b0e786dc5bd3075f1360b31a6452e256 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/964621 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543423} TBR=gab@chromium.org,cpu@chromium.org,crouleau@chromium.org,a-v-y@yandex-team.ru,vitreb@yandex-team.ru Change-Id: I3e37c027b65d1df944d3246dd6c8314d9dc9a7ee No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/963853Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#543430}
-
jkereliuk authored
Spec is here: https://w3c.github.io/webdriver/webdriver-spec.html#get-element-rect Bug: chromedriver:1937 Change-Id: I6b035a9f9526fdb5b3ba29c7c0a7269086216d50 Reviewed-on: https://chromium-review.googlesource.com/963044 Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543429}
-
arthursonzogni authored
Chrome launch bug: https://crbug.com/805851 Chrome bug: https://crbug.com/705744 Design doc: https://goo.gl/Rrrc7n Bug: 705744 Change-Id: I6d7a0d748eb35dda988bd007eb8db10068db6bc7 Reviewed-on: https://chromium-review.googlesource.com/959016 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543428}
-
Charlie Andrews authored
Windows silently updated and, because we target the exact version, the benchmarks running on these machines started to fail with "out of capacity" errors. The long term solution here probably has to do with removing the OS version from the targeting criteria altogether given the fact that we already target the exact machines, but in the short term, this should get our bots greener. TBR=nednguyen@google.com Bug: 818877 Change-Id: I95ecfc8b3381eaa45c0d69d2b0caa747d1b1f9eb Reviewed-on: https://chromium-review.googlesource.com/963146 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#543427}
-
Boris Sazonov authored
This CL adds SigninView to SigninFragmentBase and introduces the first chunk of SigninView layout: SigninScrollView and a bottom button bar. SigninScrollView implements observable ScrollView similarly to AccountSigninConfirmationView, but without special onMeasure. Buttons doesn't have android:text specified as SigninFragmentBase will set texts for UI elements programmatically (similarly to AccountSigninView.updateConsentText). The rest of this layout will be added by subsequent CLs. Bug: 814728 Change-Id: I3ac2c5fbdb41101a768abc70b3d1c3daa85fccb1 Reviewed-on: https://chromium-review.googlesource.com/962792Reviewed-by:
-
Sahel Sharify authored
This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling path,if the compositor handles the GSB and during the scrolling we have to switch to main thread since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original GSB was handled on the compositor rather than being sent to the main thread. touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling in this cl I've moved the test to a new virtual test suite that has default scroll animation value. I have removed the test expectations since I have changed the test and this might fix the flake. subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to a new test suite. Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 Reviewed-on: https://chromium-review.googlesource.com/961264 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#543425}
-
Mugdha Lakhani authored
NOTRY=true Bug: 822276 Change-Id: I7a1781912c47be7bd34cf39e2f1b6f0610cf281a Reviewed-on: https://chromium-review.googlesource.com/964561 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
This reverts commit 8d01fd2f. Reason for revert: crbug.com/822316 looks like it broke net_unittests? bug: 822316 Original change's description: > Fixed first_run test failure because of the global variables > > Fixed typical problem with unit tests and global variables. > If unit test modifies global variables then it can affect other tests > which are runned in the same process. Added reseting of the global > variables to avoid this. > > Change-Id: I2045700473ac074209f4d48a6cedbd3dad24ccd5 > Reviewed-on: https://chromium-review.googlesource.com/952905 > Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> > Reviewed-by: Carlos Pizano <cpu@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543345} TBR=gab@chromium.org,cpu@chromium.org,a-v-y@yandex-team.ru,vitreb@yandex-team.ru Change-Id: I616e5415b0e786dc5bd3075f1360b31a6452e256 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/964621Reviewed-by:
-
wutao authored
This cl adds UMA to measure input latency to show/hide launcher UI. Bug: 821184 Test: tested on eve with added UMA. Change-Id: I8c87684371d92e8da0a7e7e8731932f5fd61d4d1 Reviewed-on: https://chromium-review.googlesource.com/961253 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#543422}
-
Xiaoqian Dai authored
Cros splitscreen: do not show black backdrop on the non-snapped side of the screen if there is only one snapped window. Bug: 818310 Change-Id: I08ced2fcf88da0d65c01253880e7cd49c0d0913c Reviewed-on: https://chromium-review.googlesource.com/953337Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#543421}
-
Theresa authored
Some of the items in the downloads menu were wrapping because the menu wasn't wide enough. Increase the width as a short-term fix. BUG=821949 Change-Id: If4c7445d028354b159d40182d28a263bc59438ec Reviewed-on: https://chromium-review.googlesource.com/963678Reviewed-by:
-
