GitLab

Only eat the event in subPageClosingClickHandler_ if it happens on the narrow strip part.

BUG=chromium-os:11202
TEST=Verify the radio/checkbox on overlay page works again per chromium-os:11202.

Review URL: http://codereview.chromium.org/6371009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70576
TEST=none
Review URL: http://codereview.chromium.org/6282012

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6340015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70576
TEST=none
Review URL: http://codereview.chromium.org/6282012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72408 0039d316-1c4b-4281-b951-d872f2087c98

allows us to update URL in chrome://settings when the user navigates within it.

BUG=57485
TEST=manual

Review URL: http://codereview.chromium.org/6266017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72405 0039d316-1c4b-4281-b951-d872f2087c98

This patch moves the experiments settings from the user profile to the browser's local state, since these settings correspond to command line switches. It restores 6267009 http://codereview.chromium.org/6267009/ which got reverted because it broke ChromeOS tests.  The patch also removes some migration code for ChromeOS experiments. Users' settings should be migrated by now.
This is a release blocker for NaCl, so we are pushing this through. 
TEST=manual 
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1322
Review URL: http://codereview.chromium.org/6389002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72404 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=visual

Review URL: http://codereview.chromium.org/6354011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72403 0039d316-1c4b-4281-b951-d872f2087c98

Currently, about: links all go to about:blank. This fixes that for left clicks and middle clicks, although context menu navigations (e.g. open in new tab) still won't work.

This also "fixes" file: links in the same way. Currently, file links already work as is, but after we make --new-chrome-ui-security-model the default, they will cease to work without this fix. Context menu navigations will, however, continue to work.

The fix is currently applied to the history page and one link in settings.

BUG=69140
TEST=manual

Review URL: http://codereview.chromium.org/6269015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72401 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70665
Review URL: http://codereview.chromium.org/6258019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72399 0039d316-1c4b-4281-b951-d872f2087c98

Although |ChromeURLDataManager::DataSource|s are |RefCountedThreadSafe|, at least two derived classes contain |CancellationFlag| members, which check that they are deleted in the same thread as they are created.

Normally, the |DataSource|s are destructed when |ChromeURLDataManager| (instanced via a Singleton) is destroyed, on the main thread.  This is not an issue as the classes with a |CancellationFlag| are created on that thread too.

However, occasionally (see the bug) |AddDataSource()| is called when there is already an entry in |data_sources_|, leading to a |DataSource| being released and destructed in the IO thread.

To fix this problem, I've incremented the reference count and posted a task to the main (UI) thread that will release the reference and so destruct it there.

BUG=49121
TEST=none

Review URL: http://codereview.chromium.org/6285002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72398 0039d316-1c4b-4281-b951-d872f2087c98

user's profile.

Review URL: http://codereview.chromium.org/6381007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72397 0039d316-1c4b-4281-b951-d872f2087c98

I'm TBRing as this is just a removing of unneeded CHECKs.

BUG=34135
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/6291011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70592
TEST=All downloads tests pass

Review URL: http://codereview.chromium.org/6327016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72395 0039d316-1c4b-4281-b951-d872f2087c98

1. Map the free space on the last row of the app launcher to the last valid app position.
2. Transition the app opacity smoothly.
3. Fix JS errors when starting drag from certain areas.
4. Make sure drag and drop works when the window / apps section is scrolled.

BUG=53977
TEST=none.

Review URL: http://codereview.chromium.org/6264012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72394 0039d316-1c4b-4281-b951-d872f2087c98

testZipInIncognito occassionally fails because the download hasn't finished
yet. fix it.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6275016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72393 0039d316-1c4b-4281-b951-d872f2087c98

Modify chrome to accept a pdf file on the command line and upload it to Cloud Print via the Cloud Print dialog
Contributed by abodenha@google.com
BUG=none
TEST=Run Chrome on Windows with --cloud-print-file=<Path to PDF> and --cloud-print-job-title

Review URL: http://codereview.chromium.org/6038008
Patch from Albert Bodenhamer <abodenha@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72392 0039d316-1c4b-4281-b951-d872f2087c98

Disabling find_in_page.FindMatchTests.testSearchInPDF
Review URL: http://codereview.chromium.org/6280014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72391 0039d316-1c4b-4281-b951-d872f2087c98

We should only use FilePath when working with real paths on disk.

Note:  I made a minor semantic change to downloads -- we no
longer preserve backslashes in server-suggested paths on non-Windows.
I think the previous behavior is crazy but from looking at the
blame I'm the one who wrote it originally, so I don't feel bad
about changing my mind.

BUG=69467
TEST=existing test still passes

Review URL: http://codereview.chromium.org/6241001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72390 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70659

TEST=

Review URL: http://codereview.chromium.org/6375011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72389 0039d316-1c4b-4281-b951-d872f2087c98

Add HANDLE_CRASHES to Linux callback functions, since they are plugin entry points too. This makes no difference right now because we currently don't gate Linux crash uploading on HANDLE_CRASHES, but once we change that we'll want these in all the right places.

TEST=loaded O2D on Linux, verified it works
BUG=none

Review URL: http://codereview.chromium.org/6348018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6258015

TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6256010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72385 0039d316-1c4b-4281-b951-d872f2087c98

TBR


TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6271016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72382 0039d316-1c4b-4281-b951-d872f2087c98

TBR


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=no visible changes; all tests pass

Review URL: http://codereview.chromium.org/6258015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72380 0039d316-1c4b-4281-b951-d872f2087c98

* Tab/alt-tab should cycle over to first/last focusable item.
  This wasn't working because views framework cannot handle
  views under TYPE_CHILD correctly. This is a hack to workaround this
  issue until DOMUI  login is ready.
* Fix callback names that were changed/removed in refactoring.

BUG=chromium-os:9889, chromium-os:9845, chromium-os:10655
TEST=manual.

Review URL: http://codereview.chromium.org/6329016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72379 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6392002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72378 0039d316-1c4b-4281-b951-d872f2087c98

Adding in a constant for hover slide opacity so that the hover is more visible in different windows variations (e.g., aero).

Also fixing an issue where the hover glow would disappear immediately on mouse out rather than fading with the rest of the tab.

BUG=none
TEST=visual, ui_tests

Review URL: http://codereview.chromium.org/6250011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72377 0039d316-1c4b-4281-b951-d872f2087c98

r537 Fixed gl_PointCoord Y coordinate. http://codereview.appspot.com/4093043

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/6281010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72376 0039d316-1c4b-4281-b951-d872f2087c98

Add possibility to divide chrome users into groups of equal size, and change promo code to reflect sync promo.

BUG=68671, 68672
TEST=none
Review URL: http://codereview.chromium.org/6313009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72374 0039d316-1c4b-4281-b951-d872f2087c98

OCL=http://codereview.chromium.org/3461016/
BUG=http://b/3372125
TEST=none
R=pinkerton

Review URL: http://codereview.chromium.org/6360007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72373 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59267
TEST=Manual exercise search functionality.
Review URL: http://codereview.chromium.org/6141002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72372 0039d316-1c4b-4281-b951-d872f2087c98

Fix bug where when the 3G data plan is unknown, we show a green 3G badge. We now show a grey 3G badge when the data plan is unknown.
BUG=chromium-os:9720
TEST=connect/disconnect from 3G. Verify that we transition to state with unknown plans (grey 3G badge).
Review URL: http://codereview.chromium.org/6370010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72371 0039d316-1c4b-4281-b951-d872f2087c98

containing div. Also fix a margin issue.

BUG=70650
TEST=none

Review URL: http://codereview.chromium.org/6241014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6263011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72368 0039d316-1c4b-4281-b951-d872f2087c98

just converts some CHECKs to DCHECKs.

BUG=62872
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/6360015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72367 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=chrome_frame_unittests --gtest_filter=Ready*
Review URL: http://codereview.chromium.org/6314016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72366 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6271005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70643
TEST=none

TBR=kkania@chromium.org


Review URL: http://codereview.chromium.org/6356008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots (in particular, nacl_ui_tests)

Review URL: http://codereview.chromium.org/6331011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72362 0039d316-1c4b-4281-b951-d872f2087c98

When changing Ready Mode state from within an IE process, use chrome_launcher to invoke the ProcessLauncher, so as to not cause a UAC prompt (chrome_launcher is permitted via elevation policy).

BUG=None
TEST=Install GCF in Ready Mode on Vista, interact with it.
Review URL: http://codereview.chromium.org/6355011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72361 0039d316-1c4b-4281-b951-d872f2087c98

Sometimes git-svn prints extra status info.
From a glance at the source, there's no flag to skip it.
So just skip it when parsing.

Review URL: http://codereview.chromium.org/6349010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72360 0039d316-1c4b-4281-b951-d872f2087c98