- 20 May, 2020 40 commits
-
-
Akihiro Ota authored
In addition to checking the commit footer, we should also check the commit description for the AX-Relnotes field. Bug: N/A Change-Id: Ie9839bbf02b84d97ace0c60e8b972d048bbe7eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198931 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770600}
-
danakj authored
This test was testing the web test harness' ability to synchronously hide the window. R=reillyg@chromium.org Bug: 1083585 Change-Id: I5e83e3a8bb683e3cd8a8bc01effbf7406015171f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207739Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#770599}
-
Ravjit Singh Uppal authored
This CL adds the possibility to throw away patterns with wildcards defined in the enterprise policies for a content settings Bug: 1073883 Change-Id: I99f2d742289e77f1d00081a7cf186d4b21a91f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207159 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770598}
-
Dominic Battre authored
Extend our key metrics by 1 year. Bug: 1084131,1084132,1084133,1084134,1084135,1084136,1084137,1084138,1084139,1084140,1084141 Change-Id: Ifa068177a86af8a3653c48dc35ef9f705d6608dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210441 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#770597}
-
Greg Kerr authored
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2176183 added a new histogram to track unlock time, and this will collect it in Chrome. BUG=1069904 Change-Id: Ie3dfaa047d0c6ffd5c14449246566d34a7031b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209951Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#770596}
-
Ramin Halavati authored
OffTheRecordProfileImpl::TrackZoomLevelsFromParent checks if the parent profile type is not incognito, which can never be true since the parent of an OTR is always regular. The unnecessary DCHECK is removed. Bug: 968028, 1074201 Change-Id: I274f4641f1452a3547f9337ca5026496a9520bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203002Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#770595}
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of the (Shadow DOM v0 specific) /deep/ and ::shadow pseudo element. Two tests were modified in-place to remove the dependency on these concepts. Bug: 937746 Change-Id: I082f92b47675db5537ffebad1ad273a6913a27e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209620 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#770594}
-
Kuo-Hsin Yang authored
This is required to move the experiment to beta. BUG=b:149833548 TEST=presubmit passed Change-Id: Ic8cad34d2fd49eec8fe4af144f3967758a9ea9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208884Reviewed-by:
-
Eric Willigers authored
The Blink flag UserActivationAPI has been stable since 2018-11. Bug: 846858 Change-Id: I9f014975f19083c960d0e32f54c71c105cd474ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208800 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#770592}
-
Bo Liu authored
Bug: 1081250 Change-Id: If145d532efde9f85b33ea9073dc169ee02668cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209639 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770591}
-
Eric Willigers authored
We now use web_app::ProviderType to control if a paramerized browser test is run with BMO web apps or Extensions-based bookmark apps. (ProviderType is already widely used in unit tests.) Bug: 966290 Change-Id: I73ae4eb463018324ab454c16109a898fc99401d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208585 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#770590}
-
Mario Sanchez Prada authored
This CL moves this message out of frame_messages.h and adds a new method in blink::mojom::RemoteFrameHost to allow the renderer to sent a message from a RemoteFrame to the browser, so that it gets then posted to the frame's active renderer. It also adds a helper static method to BlinkTransferableMessage to to create an instance out of a MessageEvent (i.e. FromMessageEvent()), which is used to create the transferable message to be routed through the browser process, in RemoteFrame::ForwardPostMessage(). Last, this new BlinkTransferableMessage::FromMessageEvent() method allows us to remove the only use of WebDOMMessageEvent::AsMessage(), in web_frame_test.cc, so this CL also does that small change and removes that code from Blink's WebDOMMessageEvent public API. Bug: 1047383 Change-Id: Iedaef61913a8479f1627b6196af5a03591857e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181290 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#770589}
-
Chris Sharp authored
The enum values are already listed outside of the description, no need to repeat them. Bug: 1018157 Change-Id: I3cb7a5c349fe297017f5beb87e57191eddf1ac8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209528Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#770588}
-
Chris Hamilton authored
BUG=1083912 Change-Id: I2a5662f08e295cfc7a65c5aa0ba905c3fba84524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209376 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#770587}
-
Antonio Gomes authored
CL https://crrev.com/c/2207618/ adds a map of blink::LocalFrame instances, but failed to actually populate it properly. This CL amends to it, and makes it effective. BUG=1051144 R=dtapuska@chromium.org, haraken@chromium.org Change-Id: I667ae6c4336d7b61b69f4dad8bfaeae9519edc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210482 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
Change-Id: I9ce7806db6707810ecece49d2d5a70a759262c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209213Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#770585}
-
Eric Willigers authored
The Blink flag UnifiedTouchAdjustment has been stable since 2018-05. Bug: 625198 Change-Id: I7ee53c7c1953df4d14f952378905b3572b57a9a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208836Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#770584}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4ab61cb9b449..4b860c1fb389 2020-05-20 danilchap@webrtc.org Calculate chain_diff for DependencyDescriptor from GenericFrameInfo 2020-05-20 tommi@webrtc.org Update call expectations in ReceiveStatisticsProxy, add thread checks 2020-05-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d8b1c2f5..0cd53b97 (770095:770251) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084619 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I05e962aad09ebebe1c612e694b478299d26b538a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770583}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d52ac1573f1..682fca92996b 2020-05-20 borenet@google.com [infra] Remove unused isolates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I56ea6c56d60a0a6712e72d59c598d97fc8d1b17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210378Reviewed-by:
-
Kai Ninomiya authored
Needed for reftests in webgpu_blink_web_tests (in an upcoming CL). Bug: 1061273 Change-Id: I23af7b08506f173388c39ae9972b69836a419853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209386 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Bo Liu authored
WindowAndroid requires to be destroyed explicitly. Destroy VrWindowAndroid when exiting VR. Note need a separate path for when the Activity is being destroyed as shutting down the VRShell still causes problems even in more recent versions of Android than K. Bug: 1081250 Change-Id: I9db7d32eb25820f1ed72bc122c88bd229e3ea7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205878Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#770580}
-
kylechar authored
Both [no-]skia-renderer and [no-]use-vulkan tags in GPU integration tests were based on the command line. Code assumed that if there was nothing on the command line then the feature was disabled which was incorrect. Change the tags to be based on if the feature is enabled or not. Also change use-vulkan to just be vulkan for brevity. Bug: 1069551, 1084569 Change-Id: I33fdbfb4d8078127f066f4a86a267477e4e9e020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209348Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#770579}
-
Greg Daniel authored
These spots were missed on the original update CL. Change-Id: I83563b18df9ebe7bb4e10668ba210b7712d8c547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209533Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Cr-Commit-Position: refs/heads/master@{#770578}
-
David Bienvenu authored
When a long press touch drag drop is initiated, we generate a right mouse button down event and a mouse move event, which ::DoDragDrop needs to start drag drop. Then, when we see a pointer move or pointer up event, we generate the corresponding mouse events, because DoDragDrop doesn't handle pointer events. When drag drop finishes, we generate a right mouse button up event, and we cleanup the source window's gesture state, because it has gotten a bit confused. Bug: 229301 Change-Id: Ibcc3553a873b395f51116a33143d1836ff34cfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203409Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1bfa636e36a..690f0c26c832 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: Ie577840254108c8d684fd9e3a4e515a09c53714e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210373Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770576}
-
sebsg authored
This reverts commit 79488bbd. Reason for revert: Suspecting of causing KioskTest.SpokenFeedback to fail intermitently. More info in https://bugs.chromium.org/p/chromium/issues/detail?id=1085004 Original change's description: > Reland "Batch accessibility event processing during page load" > > This is a reland of f5d9ecea > > The only change from the original is in kiosk_browsertest.cc > We need to WaitUntilSatisfied when check_launch_data is set. > > Original change's description: > > Batch accessibility event processing during page load > > > > This change allows us to defer sending events to > > improve performance during the initial page load. > > > > EventScheduleMode determines if we schedule events > > with a delay or not. > > > > EventScheduleStatus replaces ack_pending_, and tracks > > what state we are in with regard to event scheduling. > > > > This is based on: > > CL 1691523: Large batch accessibility event processing > > during page load > > > > Bug: 976849 > > Change-Id: I74cd5f31102199f8c5752e0ef5d0eb623fdbd9d0 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123310 > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > > Commit-Queue: Jacques Newman <janewman@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#769010} > > Bug: 976849 > Change-Id: Ia3450c1c59c6bac173046c389afeb403ab2991a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203772 > Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Jacques Newman <janewman@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#770405} TBR=dmazzoni@chromium.org,dtseng@chromium.org,alemate@chromium.org,adithyas@chromium.org,janewman@microsoft.com Change-Id: Id8a9156f42bd9a77dda1243446259175141662a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210484Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#770575}
-
Nick Diego Yamane authored
As observed in crbug.com/1069690, KeyEvent's repeat flag detection has regressed after crrev.com/c/1816777. Calling the repeat flag detection function after the flags "normalization" causes this issue. This patch fixes it and adds an unit test to prevent future similar regressions. R=sadrul@chromium.org Bug: 1069690 Change-Id: Idee080cb6803d2f1487e10d176b65225ae99a221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208180Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#770574}
-
Alice Wang authored
This CL adds a fake AccountManagerFacade implementation for tests and uses it in AccountManagerTestRule. Bug: 914920 Change-Id: I022671152908772b8605d3fefb3a1945570c4d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179164Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#770573}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99a56e31aca7..34dc00881b0b 2020-05-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-20 sigurds@chromium.org Typescriptify ServiceWorkerManager If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I310e6f6d128536a231fd97f756ca664fd2f85f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210375Reviewed-by:
-
Denis Kuznetsov authored
Fixed: 1067210 Fixed: 1078325 Change-Id: I02b88009f8bf646efbc9d88d1b6e58273f90859c Bug: 1067210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210235 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770571}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1589961590-b5238e477e88144b4ee977d3e9b375905cf319c2.profdata to chrome-win64-master-1589976000-30e90b5636af5c2bba45569eb90bae781c77ad14.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib1ec14be68fc81bf61f0dcf209f52582a56f8525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210377Reviewed-by:
-
Rushan Suleymanov authored
This reverts commit 9581c8be. Original change's description: > Revert "Enable bookmark sync metadata invalidation if mismatching guid by default." > > This reverts commit d13f56f8. > > Reason for revert: suspicious numbers of corrupted metadata. > > Original change's description: > > Enable bookmark sync metadata invalidation if mismatching guid by default. > > > > Bug: 1032052 > > Change-Id: I55801e98e7729d2bba895272ea21ab285ec20cb9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167282 > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Commit-Queue: Rushan Suleymanov <rushans@google.com> > > Cr-Commit-Position: refs/heads/master@{#765030} > > TBR=mastiz@chromium.org,rushans@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1032052 > Change-Id: I3bda5defd8cf41c13974c81f51858aac982bef05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199104 > Reviewed-by: Rushan Suleymanov <rushans@google.com> > Commit-Queue: Rushan Suleymanov <rushans@google.com> > Cr-Commit-Position: refs/heads/master@{#768290} TBR=mastiz@chromium.org,rushans@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032052 Change-Id: I0428b711b4be70e8ca398d9096fabf2211515a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207229Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#770569}
-
David Schinazi authored
This will allow members of the networking team to make minor changes to their networking histograms. R=rkaplow@chromium.org Change-Id: Ic9d0879745f84dfe2463adc33b392bc1d3191071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207933 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Maksim Sisov authored
This CL fixes spurious problems when new frames are sent and a buffer is attached earlier than WaylandSurface/WaylandPopup are configured. Thus, add a new interface into the WaylandWindowObserver that notifies the WaylandBufferManagerHost if the window has been configured. The manager resets |configured_| variable upon ResetWindowContents as long as the wl_surface becomes unmapped and it is reinitialized with new xdg_surface, xdg_toplevel or whatever only during the next Show() call. In that case, it will be configured again and the host will be notified about that. Bug: 1083949 Change-Id: I9895bc8876748ba69bc0461c2aeb300175a40065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207172Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#770567}
-
Alexander Timin authored
toplevel.flow trace events ended up being quite useful. Move them out of disabled-by-default for better visibility. R=gab@chromium.org TBR=rockot@google.com BUG=932167 Change-Id: I90076f2e776b591ed7a485ed42bf8b64daedc1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111310 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#770566}
-
Kamila authored
This cl adds a new variation parameter that can be used to run A/B testing on the link we display in the mini infobar on Android. Change-Id: Ifca13cd4ba9857203ee08118bbca91e1a02c2d1b BUG: 1084524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207167 Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
-
Robert Sesek authored
The MediaPlayer framework is only available on macOS 10.12+, so it has to be -weak_link'd. When the linker argument was added in a3d32982, it used all_dependent_configs to push the config with the right ldflags up the dependency tree. This had the side effect of propagating those flags all the way up to the main chrome_app_executable. That executable should not directly link on system libraries since all the code instead resides in the chrome_framework_shared_library, where is where the -weak_link should occur and stop propagating upwards. To fix this, use GN's new weak_frameworks variable. Bug: 1082896 Change-Id: I1f0336f145ad3c4281a9d91f0bf5e0025b6f0ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202938Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#770564}
-
Peter E Conn authored
UiUtils.setNavigationBarIconColor works on Android versions greater than or equal to Android Oreo. Our calling code incorrectly assumes it only works on Android versions strictly greater than Android Oreo. This CL fixes that. Bug: 1082357 Change-Id: I34794a8f5bc84ff3b7312291737a5bdd6ea9bed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209080 Commit-Queue: Peter Conn <peconn@chromium.org> Auto-Submit: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#770563}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589961590-5bcd8ca24d15822b25b9ab44f061677dc2856648.profdata to chrome-mac-master-1589976000-662c96b2b7dcbccd935f47b39ee73fe1b7f0b5b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibfc09b8c9df374d43f1edfdadaf02c422f85610a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210374Reviewed-by:
-
clamy authored
This CL marks one compositing web test as failing. Bug: 1084448 Change-Id: Id172b80285058daeef68ff82f6a23aaac3e88ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209463 Commit-Queue: Camille Lamy <clamy@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#770561}
-
