GitLab

Before this CL, SetupSync would early-out if skip_passphrase_verification
was set to true. I don't see a good reason for this, so now it always gets
called.
For reference, this logic was added in
https://codereview.chromium.org/2716413003/, but I couldn't find an
explanation for it there.

This is an attempt to fix Sync's E2E tests. Locally, it fixes some of them,
though others still fail.
The problem was that a ClearServerData task got scheduled in
SyncSchedulerImpl, but then before that task actually got a chance to run,
the scheduler was put back into CONFIGURATION mode via
SyncBackendHostImpl::ConfigureDataTypes (race condition). This change makes
sure that ConfigureDataTypes (and its async tasks) gets completed before
we try to clear server data.
More details on the failure can be found on the bug.

Bug: 835250
Change-Id: I392376d23930540ce9442911ec16e00a42abf043
Reviewed-on: https://chromium-review.googlesource.com/1028050Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553588}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2875ae01..9990de59

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I0d62089410f323a98ce721bb95b3f18f244dc060
Reviewed-on: https://chromium-review.googlesource.com/1027794Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553587}

Zoom factors are double, but the code is using uint32_t to process them.
This patch fixes it.

Output on wayland info client:
OUTPUT0:

  connection:          internal
  device scale factor: 1.000

  geometry:
    x:                 2
    y:                 24
    physical width:    443 mm
    physical height:   264 mm
    subpixel:          unknown
    make:              unknown
    model:             unknown
    transform:         normal

  modes:
    1676x998:          60.00 Hz      current       preferred

  scales:
    0.500:
    0.750:
    1.000:             current       preferred
    1.250:
    1.500:
    1.750:
    2.000:
    2.250:
    2.500:

Bug: 836782
Change-Id: Id67582a637a67a608ae096a5fac992e8215aa47e
Component: Wayland, aura shell, scales
Reviewed-on: https://chromium-review.googlesource.com/1028217Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553586}

Extensions can register service workers from URLs like
chrome-extension://blahblahblah/sw.js. To load such URLs we must
use ExtensionURLLoaderFactory instead of the NetworkService.

This patch allows extension service workers to be registered.
But it doesn't yet allow subresource requests to fallback to
the ExtensionURLLoaderFactory.

This enables 41 of 49 failing browser tests.

Bug: 836129
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I21f513d892a813ba41c2414a7f0734d1d46898b2
Reviewed-on: https://chromium-review.googlesource.com/1025674
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553585}

Fixed menu widths turned out not to work well in locales with longer
strings. This change changes the menu widths to be minimums instead.
See screenshots attached to the bug for examples.

Bug: 832239
Change-Id: I4cae9efb53b86b08c4cd8b56d4eb089446e872d9
Reviewed-on: https://chromium-review.googlesource.com/1026052
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553584}

- Migrates deleteSelectedItemsFromHistory from the legacyImplementation.
- Deletes some related unused methods.

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I513672f7abf9b8474fa600571ad275a70ac1f770
Reviewed-on: https://chromium-review.googlesource.com/1026565Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553583}

- map editing specific gestures
swipe up/down: move by line
swipe left/right: move by character
swipe left/right with two fingers: move by word
- support gestures in Learn Mode

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I62cf03eecb6cb3d555fe5bfed741b032572e7d6d
Reviewed-on: https://chromium-review.googlesource.com/1024856Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553582}

identity::IdentityManager is the new API that replaces SigninManager[Base].

Bug: 825190, 814307
Change-Id: I3cf7261fad64a63bdc449c190f7d175025408d7c
Reviewed-on: https://chromium-review.googlesource.com/1025751Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553581}

https://pdfium.googlesource.com/pdfium.git/+log/a1d344230925..ac19439e28b6

$ git log a1d344230..ac19439e2 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 dsinclair Remove m_NodeStack from CFX_XMLParser

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I539a7168cf9cd7e9fdc66078529047dfcbe8d99e
Reviewed-on: https://chromium-review.googlesource.com/1028211Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553580}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I559908461026784530214507380cda6289141cf6
Reviewed-on: https://chromium-review.googlesource.com/1015660
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553579}

This reverts commit 14ebddd2.

Reason for revert: Fixing regex.

Original change's description:
> Revert "Remove ".dd" extension from VR icons"
> 
> This reverts commit c00fe466.
> 
> Reason for revert: Breaks canary push
> 
> Original change's description:
> > Remove ".dd" extension from VR icons
> > 
> > Bug: 834499
> > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > Reviewed-by: Richard Coles <torne@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#552773}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> NOTRY=true
> 
> Bug: 834499
> Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> Reviewed-on: https://chromium-review.googlesource.com/1028092
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553577}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028095
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553578}

This reverts commit c00fe466.

Reason for revert: Breaks canary push

Original change's description:
> Remove ".dd" extension from VR icons
> 
> Bug: 834499
> Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> Reviewed-on: https://chromium-review.googlesource.com/1023049
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552773}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

NOTRY=true

Bug: 834499
Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
Reviewed-on: https://chromium-review.googlesource.com/1028092Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553577}

We should always allocate a new viz::LocalSurfaceId on auto-resize.

We no longer require a non-empty viewport along with a valid
viz::LocalSurfaceId, and so we can simplify the code here a bit.

Bug: 672962
Change-Id: Ic0c121815e869fc26cf4ba20ff218b52ec445fd3
Reviewed-on: https://chromium-review.googlesource.com/1026792Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553576}

Fix the following font, stying, and layouts based on these specs: https://folio.googleplex.com/ntp/Recent%20Tabs#%2Frecent_tabs.html
- Slimmed down spacing between stackviews and their container view.
- Changed text color of cell subtitle and cellseparatorinset.
- Made DisclosureViewHeader description label a dynamic font type.

Accessibility dynamic font is present, but changing the layout of cell contents to a vertical stack will come in future CL.

Before: https://drive.google.com/file/d/1f_lz35oaTzKXfl6J6lnt820eHHYIM_AP/view?usp=sharing
After: https://drive.google.com/file/d/1-nELR8ELhZuPmeYioPWKZVzqj3ynW8hV/view?usp=sharing

Dynamic Types:
iPad
   Regular - https://drive.google.com/file/d/1h5ej1hfmIscYx6xs7W0VuwzA15RFjQ95/view?usp=sharing
             https://drive.google.com/file/d/1qt3XEb7UornuV3q6GGxM6WCxaUf7cxdz/view?usp=sharing
   Large   - https://drive.google.com/file/d/1tV186qR4HI82dbYNioVICOhz1CoFYQcF/view?usp=sharing
             https://drive.google.com/file/d/1flOduXZUwGjGMR2hjPjNlAet74dgtS69/view?usp=sharing
iPhone
   regular - https://drive.google.com/file/d/1e_PvBbXyqFrOoJhEHKBXGJ2FAgyKZ0Vw/view?usp=sharing
             https://drive.google.com/file/d/1TSQJs-FWa0V98EEKvJLw8sEL9gQXJNXd/view?usp=sharing
   Large   - https://drive.google.com/file/d/11wXakU1vDcn2-bT8IcF_fnnnAD2O9K5t/view?usp=sharing
             https://drive.google.com/file/d/1bIKGp5zuxG8BrYV_CtTeQo38cwz_k99t/view


Bug: 825017
Change-Id: I8f82cfaebac453b898e60cb6afb9b887754f527a
Reviewed-on: https://chromium-review.googlesource.com/1017918
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553575}

Wrap the definition of member named is_broker_ in
PpapiPluginSandboxedProcessLauncherDelegate class with
USE_ZYGOTE_HANDLE || OS_WIN, since it is used only from code blocks
enclosed by either of those conditions.

The existing conditions were probably a leftover from before
USE_ZYGOTE_HANDLE was introduced.

Related: https://chromium-review.googlesource.com/862298
Change-Id: I4a2814ace7f2b4280c0c1d69082e78fd626187ed
Reviewed-on: https://chromium-review.googlesource.com/1019246Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#553574}

BUG=680698
TEST=this is a straight rename, covered by tests

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibada505d1a47feca32ef2c5b96883e35fc241594
Reviewed-on: https://chromium-review.googlesource.com/1011842
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553573}

https://chromium.googlesource.com/catapult.git/+log/0d6f84866778..55650fadabf7

$ git log 0d6f84866..55650fada --date=short --no-merges --format='%ad %ae %s'
2018-04-23 nednguyen Add android_n_armeabi-v7a platform to chrome-stable

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:828378


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I1f318c23f328cc38459617e1a43d6be253bcb1bf
Reviewed-on: https://chromium-review.googlesource.com/1028133
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553572}

https://chromium.googlesource.com/angle/angle.git/+log/023371b3af90..10434f67672d

$ git log 023371b3a..10434f676 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 lucferron Vulkan: Issue when drawing with a texture and rebinding after.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I2f811fc20d0222ffca7ee53b8a88c128a39de93b
Reviewed-on: https://chromium-review.googlesource.com/1028132
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553571}

When entering VR we hide the browser controls. However, it can take some
time for this state update to reach the FullscreenManager. As a
consequence, hover move events may have a false offset depending on
whether the initial hover enter event was processed with the updated
browser controls state or not. To fix that, also update the top offset
for hover move events.

Bug: 822384
Change-Id: Idd46e2c45e20089f2ee6c701cae386b6ce931b5f
Reviewed-on: https://chromium-review.googlesource.com/1024928Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553570}

Flakiness should be fixed by https://chromium-review.googlesource.com/1023716.

Bug: 835826
Change-Id: I2f66c96439c10f0c6d115060006c2dc8523de103
Reviewed-on: https://chromium-review.googlesource.com/1028175Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553569}

Bug: 834768
Change-Id: Ic51bcfdc7e63baca348c405f7e1f13c06d95b1f3
Reviewed-on: https://chromium-review.googlesource.com/1027899Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553568}

This CL includes manual fixes for the remaining warnings that
WeakPtrFactory should be the last member.

After this, a subset of the Chrome style plugin warnings are also enabled in
Blink:
- prompting that override/final are appropriately used
- ensuring that auto is qualified with * or & as needed
- kMaxValue is, in fact, the max value in an enum

Bug: 706466
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I296fb9be0214632a76d7faf739ee606383f50383
Reviewed-on: https://chromium-review.googlesource.com/1027437Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553567}

Upstream fix (https://github.com/w3c/web-platform-tests/pull/10616)
has landed and been imported to Chromium.

TBR=falken

Bug: 836377
Change-Id: I4ec72cdb7ef592650ff88977409dbc3f235c94f2
Reviewed-on: https://chromium-review.googlesource.com/1028214
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553566}

We experimented with following the system highlight, but it doesn't look
good in menus with icons. See the linked bug for discussion & rationale.

Bug: 829467
Change-Id: Ie3f5e74b17c5ec9956b0501582dfeef838fcc673
Reviewed-on: https://chromium-review.googlesource.com/1023318Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553565}

to DispatchBackgroundFetchedEvent.

Creation of the scope modifies V8 state, and associates scriptstate with
v8::Context. This helps in the using script state when it's needed later.

TBR=haraken@chromium.org

Bug: 836787
Change-Id: I7d0c2cb445d74f85d918d0435e6dac2511365ee6
Reviewed-on: https://chromium-review.googlesource.com/1027836
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553564}

Crash dumps that haven't been uploaded are now kept in pending, rather
than marking them as completed.
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1010970

Bug: 813163
Change-Id: Ib77479f6a3f85a3dc6a5685c9f97dd1b8e5540a4
Reviewed-on: https://chromium-review.googlesource.com/1024512Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553563}

TBR=fdoray@chromium.org

Bug: 825327
Change-Id: Iead1c89cfc21458e828db8d3b560643dcd088b08
Reviewed-on: https://chromium-review.googlesource.com/1027793Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553562}

If 'vertical-scroll' is disabled for an <iframe>, then it should not be
able to affect the vertical scroll position. One way to block is to use
scripted scrolling by calling "element.scrollIntoView()".

To block such frames (whose feature's disabled), programmatic recursive
scroll calls are not forwarded to parent frames. This means if a given
<iframe> is blocked, then all the calls to scrollIntoView() are limited
to the scope of frame (i.e., elements becoming visible in the frame).
This applies to all the nested <iframe>'s of a disabled frame as well
since they would have the feature disabled as part of propagating the
container policy.

Link to explainer/design document for "vertical-scroll":
https://docs.google.com/document/d/1qiWelnMlsOHuT_CQ0Zm_qEAf54HS5DhoIvEDHBlfqps/edit?usp=sharing

Bug: 611982
Change-Id: I0e06b399ad890e263128b997cfbb04eb3bdd1494
Reviewed-on: https://chromium-review.googlesource.com/1014191Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553561}

Bug: b:78220247
Change-Id: I530a45479afdf5e6be648d97157e0d537cc2ff81
Reviewed-on: https://chromium-review.googlesource.com/1027831Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553560}

The output is used by CrOS autotest telemetry_runner to upload
dependencies to DUT.

Bug: 834659
Change-Id: I5845fa293e07b35bdcb27030da7fc87ca5b61505
Reviewed-on: https://chromium-review.googlesource.com/1025612
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553559}

This is the initial simple implementation of proactive tab discarding. This will be ran on a Finch trial with various parameters in order to find balance between maximal resource savings and minimal impact to user experience.

Bug: 775644
Change-Id: If5048f622bd24d540804842c7e5448c48fabad36
Reviewed-on: https://chromium-review.googlesource.com/1014646
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553558}

Addgin:
-[ChromeSigninViewController showSubViewController:]
-[ChromeSigninViewController removeSubViewController:]

This is to simplify the code and to prepare for crrev.com/c/1010346

Bug: 1009906
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I10a61f77d1c3be5b79841e0710571b275aa9ad53
Reviewed-on: https://chromium-review.googlesource.com/1025658
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553557}

https://skia.googlesource.com/skia.git/+log/e1c37a7b8f21..77e95f7067e3

$ git log e1c37a7b8..77e95f706 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 enne Fix SkDashImpl::CreateProc OOM on garbage input
2018-04-25 kjlubick Migrate NUC7i5BNK to Debian 9

Created with:
  roll-dep src/third_party/skia
BUG=chromium:835418


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I25c051ac40ebbcf464beffe40852de8ccafcbd66
Reviewed-on: https://chromium-review.googlesource.com/1027994Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553556}

Test hangs on this iOS device running iOS 10.
Disable until we find the root cause.

Bug: 836808
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic2dde07f54e0af49d2bc5a5584138cd631e53248
Reviewed-on: https://chromium-review.googlesource.com/1028270Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553555}

Bug: 673362
Change-Id: Id318b8c8b7e6c3def6f38c51961032b3f3270a65
Reviewed-on: https://chromium-review.googlesource.com/1026476Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553554}

Bug: 776877
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If78208ecf3f5becb366b7860e15e1ac09d94c9df
Reviewed-on: https://chromium-review.googlesource.com/1023165Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553553}

Was causing ClusterFuzz crashes when an unknown exe type was returned.
Instead of crashing the runtime should just return kExeTypeUnknown and
let the runtime handle the problem as before.

Bug: 836803
Change-Id: I23841fc50025a9850ac322960069270cd3e524be
Reviewed-on: https://chromium-review.googlesource.com/1028212Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Cr-Commit-Position: refs/heads/master@{#553552}

Followup to crrev.com/c/1005912, missed another case where we need to inject
the status bar height for iOS10.

Bug: 819460
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2749ac4d5fcf24edd446741e5927868e856dd4c6
Reviewed-on: https://chromium-review.googlesource.com/1026420Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553551}

The internal class owns AdapterRefs which have to be destructed on the
main thread. As such, the last reference to the internal class had to
be freed on the main thread. In flaky cases, when tasks were posted to
the signaling thread, an operation performed and a task posted back to
the main thread - the main thread would finish before the signaling
thread task and the last reference to the internal class would be
released on the signaling thread, causing DCHECK crashes at
~AdapterRef for being on the wrong thread.

With destructor traits, if we are not already on the main thread we
post to the main thread and delete RTCRtpSenderInternal there.

The TearDown of RTCRtpSenderTest is updated to ensure that any pending
tasks get a chance to execute, in case the signaling thread was not
finished yet or else the destructor posted to the main thread does not
get a chance to execute and the test would flakily leak.

Before this CL: Flake's symptoms could be reproduced by adding a thread
sleep at RTCRtpSenderInternal::GetStatsOnSignalingThread. After this CL:
Unable to repro flake. The same applies for the other flaking tests
based on replaceTrack().

Bug: 827450
Change-Id: Ib594a53042e441e591ccc2c87ae8012bcb4ec75e
Reviewed-on: https://chromium-review.googlesource.com/1015002
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553550}

PolicyTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: Ifc1db03aa42db2ae367389d4ec3df4efb18573db
Reviewed-on: https://chromium-review.googlesource.com/1026073Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553549}