- 21 Sep, 2018 40 commits
-
-
Laís Minchillo authored
Fix trying to access the proxy_config_service that was moved to the url_request_context in InitializeURLRequestContext Bug: 851995 Change-Id: Icc31c661ff4bd0e6b92d899a9d427ed75db0a295 Reviewed-on: https://chromium-review.googlesource.com/1234154Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#593140}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/036176db7c24..381f401bc444 Created with: gclient setdep -r src-internal@381f401bc444 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5934306ca108be62c13c560930c751c9e0a1e5cf Reviewed-on: https://chromium-review.googlesource.com/1238313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593139}
-
Mihai Sardarescu authored
IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing. Bug: 870239 Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402 Reviewed-on: https://chromium-review.googlesource.com/1236263 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593138}
-
Andreas Haas authored
R=haraken@chromium.org Bug: v8:7295 v8:8015 Change-Id: Ie4d7a011d3c20c2997fc9ee309dcc2aa83174d1a Reviewed-on: https://chromium-review.googlesource.com/1238158Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#593137}
-
Anders Hartvoll Ruud authored
This does not currently cause a crash, entirely because of luck. A value of nullptr is passed to SetVariable whenever an invalid var()-reference is used (for example), but it just so happens that needs_resolution_ is always true in this case, so it short circuits before attempting to de- reference 'value'. R=futhark@chromium.org Bug: 641877 Change-Id: I8b3776a58efb82b5deef74b50561d2ebfd57b817 Reviewed-on: https://chromium-review.googlesource.com/1235725 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593136}
-
Anders Hartvoll Ruud authored
Currently, StyleInheritedVariables::RemoveVariable removes variable data properly (i.e. it sets the value to nullptr locally), but only nullifies the registered value if we already have an entry for that variable locally. This means that if we inherit a variable via the root bucket, calling ::RemoveVariable will not actually remove the variable. Fix by setting registered value to nullptr if a non-nullptr value would have been returned from the root. R=futhark@chromium.org Bug: 641877 Change-Id: I78f0442bd0a8eba26e74a8a152b5bee048fbc23c Reviewed-on: https://chromium-review.googlesource.com/1235724 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e25b8006115b..ab5fb5edb186 git log e25b8006115b..ab5fb5edb186 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 oetuaho@nvidia.com Reland "Support EXT_blend_func_extended in the GLES2 context" 2018-09-21 jmadill@chromium.org Remove secondary Texture rendering loop check. 2018-09-21 oetuaho@nvidia.com Fix using a large vertex attrib divisor on D3D11 Created with: gclient setdep -r src/third_party/angle@ab5fb5edb186 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:763695 TBR=jmadill@chromium.org Change-Id: I8f4813a39e32e17129ba3231ee14f49a9e0870a8 Reviewed-on: https://chromium-review.googlesource.com/1238314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593134}
-
Kouhei Ueno authored
This CL introduces OriginsList, which can be used to keep track of a {allow,deny} list of domains. The OriginsList will be used in the subsequent CLs to keep track of the origins who opt-in to "Accept: application/signed-exchange" header. Bug: 887201 Change-Id: Ie926587a016dab76a585088be76a70e0b62e51dc Reviewed-on: https://chromium-review.googlesource.com/1235362Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#593133}
-
Yoshifumi Inoue authored
Revert "If the caret is at the boundary of a misspelling, getting suggestions via context menu should work" This reverts commit 8698aaf7. Reason for revert: Causes lots of crashes on canary http://crbug.com/886589 Original change's description: > If the caret is at the boundary of a misspelling, getting suggestions via context menu should work > > If a screen reader user tries to get spelling suggestions for a misspelled word, they usually first move to the beginning of the word using Ctrl+Left/Right and then invoke the context menu. > On Windows, Ctrl+Left/Right always moves to the start of the word. On other platforms, Ctrl or Cmd + Left moves to the start whilst Ctrl / Cmd + Right moves to the end of the word. > When any of the above keystrokes are pressed, the user hears the whole word. > It is not reasonable to expect the user to first press Ctrl+Left/Right to navigate through the line until they find the spelling mistake and then have to additionally press cursor right, (or cursor left when using Cmd-Right on Mac), so that the caret is within the word before invoking the context menu. > The result is that many screen reader users might have the mistaken believe that our spell checker is broken. > > R=dmazzoni@chromium.org, yosin@chromium.org > > Bug: 790828 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Icdfc24eb85afe3217320d648183083133418fd58 > Reviewed-on: https://chromium-review.googlesource.com/1033430 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592270} TBR=dmazzoni@chromium.org,yosin@chromium.org,yoichio@chromium.org,nektar@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790828 Change-Id: Icbe0c3e14eb08cfbd167ba86f1dc0dd3a2ce0819 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1237836Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593132}
-
Boris Sazonov authored
This CL revises SigninPromoUtil.launchSigninPromoIfNeeded to defer the moment when account list is acquired. This makes sense because launchSigninPromoIfNeeded is invoked early during startup, when the cache in AccountManagerFacade isn't populated yet, so getting the list of accounts may block until it is populated. Bug: 837374 Change-Id: Ie018c8e06f0be0df4ec742475035eb3175dc27a2 Reviewed-on: https://chromium-review.googlesource.com/1234233Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593131}
-
Arthur Sonzogni authored
GetRootRenderWidgetHostView() and GetParentRenderWidget() explore the FrameTree using FrameTreeNode. Once it is done, it returns the RenderWidgetHostView associated with the current RenderFrameHost on that FrameTreeNode. The issue: there is no 1:1 association between the FrameTreeNode and the RenderFrameHost. A FrameTreeNode, contains several RenderframeHost: * The current one. * The pending one, not displayed and used for loading a new document, but this one has still not committed. * The ones in pending deletion. Those are no more displayed and are in progress executing their javascript unload handlers. Instead of exploring the tree using FrameTreeNode::parent(), explore the tree using RenderFrameHost::GetParent(). That way, it is guaranteed the functions will always returns the same object. Bug: 609963 Change-Id: Ic8972180b94763bd6a831f2754d1e3c661c0bbc4 Reviewed-on: https://chromium-review.googlesource.com/1210942Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593130}
-
Makoto Shimazu authored
Bug: 884007, 848256 Change-Id: I3dbeab15a52fc296058b1962364edb19c95d74a0 Reviewed-on: https://chromium-review.googlesource.com/1235261 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Momoko Sumida authored
Add PerfTest to compare the time it takes to set default style with and without ShadowRoot Link to the Design doc(Google internal only): https://docs.google.com/document/d/1el494btZRK7tBw2h7wIVZe4QgxRI0xNLBJqVHg2ilG8/edit?usp=sharing Link to the issue: https://github.com/w3c/webcomponents/issues/468#issuecomment-400905342 Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RQVKGUjDz9U/ltwrLQ1HAQAJ Link to related CL: crrev.com/c/1198885 ^ Apply custom element default style using simple selectors crrev.com/c/1220527 ^ Restrict the use of CSSStyleSheets to only one Document crrev.com/c/1224314 ^ Implement updates of default style Bug: 824684 Change-Id: Ib721764c86e2c757840d0c4629921a5273dbbfe3 Reviewed-on: https://chromium-review.googlesource.com/1233593 Commit-Queue: Momoko Sumida <momon@google.com> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593128}
-
François Beaufort authored
This makes sure web developers can access to the PictureInPicture window object when user agent initiates Picture-in-Picture. It does so by adding a pictureInPictureWindow attribute to the existing enterpictureinpicture event Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ibVPbqBQapU/Fgf307XJBgAJ Change-Id: I46ce1f4047b670f49dd746e39c7e62efc1b4a135 Bug: 887856 Reviewed-on: https://chromium-review.googlesource.com/1228122 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#593127}
-
Kyoko Muto authored
In this Cl, we add a button to emulate other <summary><details> features in addition to create my custom elements, <my-detail>/<my-summary>, with the imperative Shadow DOM Distribution API. Furthermore, the reftest is also changed because the appearance is changed due to these addition. Previous implementation CL: crrev.com/c/1192783 Bug: 869308 Change-Id: I4131321879524a236aefd4e2f1c846dafc548aa0 Reviewed-on: https://chromium-review.googlesource.com/1220969 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
-
Daniel Bratell authored
Rename two TestServiceImpl to not clash in jumbo build experiments, and change a kIllegalString constant to be shared. Bug: 886902 Change-Id: I513e0641834476bb198cf24d71ef088634458313 Reviewed-on: https://chromium-review.googlesource.com/1233709Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#593125}
-
Martin Robinson authored
Bug: 866337 Change-Id: I581dbbc08382b668ac503ee2ccdb5c7acf1c2995 Reviewed-on: https://chromium-review.googlesource.com/1233733 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593124}
-
Noel Gordon authored
The JS auto-formatter will keep "list-style" iff Object or Array lists have a trailing comma. Bug: 850843 Change-Id: I35a7898524d2db824cebdb7dff4dec95c3c153c8 Reviewed-on: https://chromium-review.googlesource.com/1237756Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593123}
-
Mythri Alle authored
Currently the code cache uses RenderMessageFilter to post tasks to the browser thread. This is available only on the main thread. Hence, we should not fetch code caches on non-main threads. Fetching caches would be enabled on all threads once code cache has its own thread-safe mojo interface. Bug: chromium:884135 Change-Id: I1a91307aaa8d3be6aff37b1a7fb7b4bc8270dd87 Reviewed-on: https://chromium-review.googlesource.com/1226597Reviewed-by:
-
Christopher Cameron authored
This behavior only helps on macOS and hits lots of bugs on lots of other platforms. Bug: 883276 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7b85b254c962003cf1fa5646d8a304ce04aa856a Reviewed-on: https://chromium-review.googlesource.com/1236930Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#593121}
-
Manuel Rego Casasnovas authored
Since a while ago the CullRect we get in GridPainter::PaintChildren() is really big matching the size of the grid if it's smaller than 4800x4600 pixels. For that reason the painting optimization we have is not doing anything useful if the grid is smaller than that size, as all the grid items are painted anyway. Even it's adding some overhead in some cases making things slower. For that reason we're getting rid of the optimization which allows us to simplify the grid layout code and rely on more common painting code. No new test as it's covered by existent ones. BUG=853654 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ida3cf7cc081b8671ea10a300891b0825f76258bd Reviewed-on: https://chromium-review.googlesource.com/1235998Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#593120}
-
Tatsuhisa Yamaguchi authored
This only adds "Notifications" tooltip, not describing the count or DnD status. Also screenreaders will also read the icon as "Notifications" instead of just "image". Bug: 878338 Change-Id: Ic8da790d85c950f5c2565bc7c88eb1ebccfd41f3 Reviewed-on: https://chromium-review.googlesource.com/1237735Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593119}
-
Matt Falkenhagen authored
Bug: 882661 Change-Id: I50b4c0ecf0c86577c5cfd7fb987e26c5fbc24b86 Reviewed-on: https://chromium-review.googlesource.com/1238193Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#593118}
-
Mihai Sardarescu authored
The signin.allowed policy has been deprecated. This CL removes both the signin.allowed policy and the signin.allowed preference that was used to back it up. Bug: 870239 Change-Id: I91be7a30848ceffe31eabe3287b4672ae394a6ed Reviewed-on: https://chromium-review.googlesource.com/1225800Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#593117}
-
Peter E Conn authored
When following links, Chrome decides whether it should navigate itself or allow the link to be resolved through the Android framework - this way we allow deep linking to other applications. One restriction is that links out from Chrome must come from a user gesture. Our user gesture tracking is approximate and I think boils down to "has the user interacted within the last X milliseconds". One Custom Tabs client who was using CCTs for OAuth found that their redirections back to the client app were occasionally being blocked since the redirect took too long. The logic change in this CL is to allow webpages to intent to an app without the user gesture restriction provided that the web page is running in a Custom Tab and it is intenting to the app that launched the Custom Tab. Bug: 881740 Change-Id: I0ff0701bac72dc8dd907b90390b21be8d5674e0e Reviewed-on: https://chromium-review.googlesource.com/1216062Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#593116}
-
Jan Krcal authored
This CL adds histogram checks into unit-tests for the autofill wallet data bridge. Apart from verifying we send correct metrics, this also checks that we write to DB only when needed. Since this was previously untested, this new check revealed a minor typo in one of the tests. This CL also prepares ground for a follow-up CL that refines wallet data notifications (i.e. makes the information previously only revealed to metrics also available to observers). Bug: 853688 Change-Id: Ia17d54ff81f1d04316c10d6ef548b20e3d8a9905 Reviewed-on: https://chromium-review.googlesource.com/1236275 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593115}
-
Kent Tamura authored
Currently FileChooserFileInfo::file_path has a valid path even for non-native files. However no one needs |file_path| for non-native files. We stop to set a valid path to it for non-native files, and make it easy to convert content::FileChooserFileInfo to blink::mojom::FileChooserFileInfo. * fileapi_util.cc and fileapi_util_unittest.cc: Stop to set |file_path| for non-native files. * render_frame_host_impl.cc: Do not grant read access for |file_path| for non-native files. It's unnecessary because Blink accesses such files via file system URLs. * file_chooser_file_info.h: Add a comment, move |file_path| to the 'For native files' section, and move |is_directory| to the 'For non-native files' section. * render_frame_impl.cc: Do not check |file_path| for non-native files. This check is unnecessary for non-native files because Blink doesn't use |file_path| for non-native files at all. This CL should have no behavior changes. Bug: 869257 Change-Id: Ic324300e9e7358a1eeb592f65f3046b95edda292 Reviewed-on: https://chromium-review.googlesource.com/1235780Reviewed-by:
Daichi Hirono <hirono@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#593114}
-
Christopher Cameron authored
This allows mouse type events to be passed through Mojo. Bug: 881509 Change-Id: I8bdcf980e7dce0fea5b71c285f86956cd334f7e5 Reviewed-on: https://chromium-review.googlesource.com/1211916 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Momoko Sumida authored
This CL implements updates of default style, by marking elements for styleRecalc when default style is mutated. Custom elements are marked for styleRecalc by creating an invalidation set with custom element tag name. Link to the Design doc(Google internal only): https://docs.google.com/document/d/1el494btZRK7tBw2h7wIVZe4QgxRI0xNLBJqVHg2ilG8/edit?usp=sharing Link to the issue: https://github.com/w3c/webcomponents/issues/468#issuecomment-400905342 Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/RQVKGUjDz9U/ltwrLQ1HAQAJ Link to related CL: crrev.com/c/1198885 ^ Apply custom element default style using simple selectors crrev.com/c/1220527 ^ Restrict the use of CSSStyleSheets to only one Document Bug: 824684 Change-Id: Ibbd3ab78b4c3a61afe169078d8d45c9a2d684774 Reviewed-on: https://chromium-review.googlesource.com/1224314Reviewed-by:
-
Noel Gordon authored
main_scripts.js has a defer attribute: add DOMContentLoaded if needed, ie., only if the document is loading. And modernize the remaining code while here. Bug: 887792 Change-Id: I04b9d346025d0f9a607772c2a340d80573489079 Reviewed-on: https://chromium-review.googlesource.com/1237801Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593111}
-
Uladzimir Miniailau authored
Bug: 456119 Change-Id: I1dd5f5b249efe95b7db26d0eb174092f1154dfbd Reviewed-on: https://chromium-review.googlesource.com/1204010 Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593110}
-
Makoto Shimazu authored
This CL is to use EvalJs() instead of waiting for an expected title and checking the body.innerText. This will generate more verbose errors especially in the case where the previous test times out. TBR=kinuko@chromium.org Bug: 884007 Change-Id: I8cbde52efc2da69784b4c1ca06a17c7d262a80d3 Reviewed-on: https://chromium-review.googlesource.com/1237794 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Timothy Gu authored
This fixes bug 866610 by using the IDL infrastructure to properly enter the v8::Context before calling the registered callback. Also ensure eager finalization of ScheduledAction in DOMTimer to prevent a memory leak. Added two more effective DCHECKs to confirm. Bug: 866610 Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 Reviewed-on: https://chromium-review.googlesource.com/1220486Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593108}
-
Tatsuhisa Yamaguchi authored
Prevents showing the notification icon being invisible, or in a faded color in certain conditions. - Faded color after first sign-in (crbug.com/880766) After OOBE is finished, the icon color should be updated. - Invisible do-not-disturb icon in OOBE (crbug.com/886561) Session status is UNKNOWN at the view creation during OOBE. Bug: 880766,886561 Change-Id: I82d22a5d0967ab9c0fdef3b109ea3157e0244d8c Reviewed-on: https://chromium-review.googlesource.com/1233101Reviewed-by:
-
Patrik Höglund authored
Edward has left the team. Bug: None Change-Id: Ifb8b28589b90981682242f54d31eb0fcabb6c9fb Reviewed-on: https://chromium-review.googlesource.com/1233196Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#593106}
-
Darren Shen authored
Add a new browser test for checking that a maximized window responds correctly to the virtual keyboard. Had to change how WaitUntilShown and WaitUntilHidden worked. |WaitUntilShown| used to just wait for the window visibility to change, but KeyboardController sets the window visiblity at the beginning of the show animation. So |WaitUntilShown| was more like "WaitUntilStartingToShow". This was a problem because overscrolling occurred after the animation finishes, so the tests have to wait for animations to finish. We changed it to wait instead of the keyboard visiblity as dictated by the KeyboardController. This visiblity gets updated when the show animation finishes. Unfortunately this is not true for the hide animation, but it doesn't really affect our tests since overscrolling also happens at the beginning of the hide animation. Also see crbug.com/866332 for more about the different types of "visibility". Bug: 849995 Change-Id: I9c9dbee9423b63db3df58814e59eb41a9cab2d90 Reviewed-on: https://chromium-review.googlesource.com/1233314 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#593105}
-
Daniel Bratell authored
The previous ToValue -> ToValueImpl implementation caused template resolution complexities and prevented jumbo support by having a clone of the same template in every domain_types_cc file. Bug: 883727 Change-Id: Iec49d7bde93515fe180f26073cea59db3cf4be82 Reviewed-on: https://chromium-review.googlesource.com/1236355Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#593104}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a977acc85769..e25b8006115b git log a977acc85769..e25b8006115b --date=short --no-merges --format='%ad %ae %s' 2018-09-21 jmadill@chromium.org Move sampler sync out of syncProgramTextures. Created with: gclient setdep -r src/third_party/angle@e25b8006115b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I66c33d53231f4aaacd22456aea7077d8e80ea972 Reviewed-on: https://chromium-review.googlesource.com/1237820Reviewed-by:
-
Ramin Halavati authored
kNetworkProfileLastWarningTime is removed from incognito persistent list to avoid leaking the last time the warning is shown in incognito mode to user profile. kNetworkProfileWarningsLeft is moved from temporary to actual incognito persistent list (no behavior change) to avoid annoying users who extensively use incognito mode. Bug: 861722 Change-Id: I554fc66e762579b657a4ada24a0a7243f596f670 Reviewed-on: https://chromium-review.googlesource.com/1238153Reviewed-by:
-
Dominic Mazzoni authored
Follow-up to other similar patches. This removes several more small enums that were nearly identical to ones defined in ui/accessibility/ax_enums.mojom. This time I added a couple of new enum values to ui/accessibility/ax_enums.mojom in order to synchronize them with the Blink enums. Those changes shouldn't affect any real logic. TBR=tsepez@chromium.org Bug: 882660 Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3a7556254794097e629837576a44ce477d498f87 Reviewed-on: https://chromium-review.googlesource.com/1236270 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
