- 16 Oct, 2020 40 commits
-
-
Dominic Farolino authored
It became clear during the auditing of process-global associated interfaces that the SearchBouncer interface was clinging to dead code so this CL removes it entirely. More context: https://docs.google.com/document/d/12jyv-8aBwMlSS_Y5roEl_ykZT0_eQszGiiNs7Hxktmk/edit#heading=h.4zjjh3zdcgd Bug: 1132901 Change-Id: Ib71d962d9d41c44fba52c420850b78b23b38b7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481087 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818136}
-
Corentin Wallez authored
Bug: chromium:1139232 Change-Id: I5be89203e8797a58234a2bee88f9efafc09a6d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478951Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#818135}
-
Rebekah Potter authored
This reverts commit 320837f5. Reason for revert: The tests added here (WebAppHandlerRegistrationUtilsWinTest.*) are failing on multiple Win 7 bots, see https://bugs.chromium.org/p/chromium/issues/detail?id=1139503 Original change's description: > desktop-pwas: Introduce shared file/protocol handler registration logic > > This CL refactors Windows file handler registration in a way that > exposes shared logic useful for protocol handler registration. Protocol > handler registration that consumes the shared logic will be added in a > subsequent CL. This design is detailed in section 4.4 of [1] with a > summary given below. > > The refactor splits up registration by functional concerns, > with pieces that may be shared with protocol handler registration living > in web_app_handler_registration_utils_win.h/.cc. > web_app_file_handler_registration_win.h/.cc is now significantly smaller > and addresses file-handler-specific concerns in addition to consuming > the utils API. > > File handler registration consists of several pieces: > > 1) Create an app registry entry: HKCU\Software\Classes\<app_progid> > 2) Copy (or hardlink) chrome_pwa_launcher.exe from browser install > directory to <profile_dir>\web_applications\<app_id>\<app_name.exe> > 3) Reregister an app (steps 1 and 2) with a profile-specific name when > the same app is installed to a different profile > (e.g. "App" -> "App (Profile 1)") > 4) Create a file type association registry entry: > HKCU\Software\Classes\.<file_ext> > > In this approach, 1 & 4 are contained in the existing > ShellUtil::AddFileAssociations function. 2 & 3 are moved to utils > (CreateAppLauncherFile and CheckAndUpdateExternalInstallations). > > Important note about this design: > - Reregistration logic (3) is altered in this approach. Currently, > pieces 1, 2, 4 are all executed during reregistration. Because (4) is a > file-handler only concern, it wouldn't make sense to use existing logic > from the protocol registration flow. Reregistering (1) and (2) are > sufficient to rename a duplicate app - this is because file handler > registry entries (4) only reference the progid of an app which doesn't > change if its display name is updated (or if the update fails). > CheckAndUpdateExternalInstallations only updates necessary registration > pieces to reflect an updated name while leaving existing file/protocol > pieces in place. > > Alternative design: > crrev.com/c/2309759 previously attempted this refactor by splitting the > registration process into a shared app-level API instead of a Utils API. > As a result, ShellUtil functions that are currently atomic > (AddFileAssociations) were split into non-atomic app-level and file > handler pieces. The design was abandoned for this reason. > > [1] https://docs.google.com/document/d/1NHlWLjAPZ-dyxcz3AoTWibeerDeHW7Vqrx6FmhB0XmE/edit#heading=h.qsh70q > > Bug: 1019239 > Change-Id: I5f727a5ca1483efd21935c0201ee54474a94e598 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462383 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#818065} TBR=sky@chromium.org,dmurph@chromium.org,grt@chromium.org,davidbienvenu@chromium.org,fabio.rocha@microsoft.com Change-Id: Ic050a0aaf46d1c4d9e4b8a7f2b2798d2a73cb2ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482083Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818134}
-
Nate Fischer authored
This reverts commit db9be6c9. Reason for revert: Still flaking, see https://crbug.com/1135839 Original change's description: > [AW][Dev-UI] Reland "Add some espresso tests for flag UI" > > This relands https://crbug.com/c/2438534 with a couple small changes: > > - android:windowSoftInputMode="adjustPan" attribute was missing in the > test manifest but is used in prod manifest. Adding it to the tests > manifest fixes the problem of auto-showing the keyboard on M devices > which was causing the test flakiness. When the keyboard shows up it > hides the view causing espresso to fail. > > - Merge the small change from https://crrev.com/c/2455687 to > test whether the overrideFlagsMap has the correct entries. > > Fixed: 1135839, 1130599 > Test: run_webview_instrumentation_test_apk -f "*FlagsFragmentTest*" on android M emulator > Change-Id: I973e8cd2b7a9c12651d7a6e14f11a368f6e06bad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453564 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Hazem Ashmawy <hazems@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817184} TBR=changwan@chromium.org,ntfschr@chromium.org,hazems@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1135839 Change-Id: I17327632b54350c4db8cd182f2a2163cedb2f03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481942 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#818133}
-
Gang Wu authored
This CL lets TabAndroid supports base::SupportUserData, then ChromeAutocompleteProviderClient can store stripped urls in TabAndroid to avoid stripping url over and over again. Bug: 1094056 Change-Id: If0448c825965ddc7f43bd2aacc9c1d868e27b09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472461Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818132}
-
Manu Cornet authored
Bug: 1136145, 1056219 Change-Id: Ic57ec33b0ede604127e25817e1c67aa4c04bda42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480024Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#818131}
-
zhiyuancai authored
This CL fixes a presubmit warning in TabGridDialogView by replacing setTextColor with setTextAppearance. Bug: 1135433 Change-Id: I863f09939a78fdef0a81ba99df649a771c4b9339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459066Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#818130}
-
Chris Hamilton authored
This is a reland of 85ecd948 Original change's description: > [PM] Implement V8ContextTracker business logic. > > BUG=1080672 > > Change-Id: I10d0f001f00f1f7eb566843b9e9647297569abb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466152 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817764} TBR=joenotcharles@chromium.org Bug: 1080672 Change-Id: Ib8e3eb1e2d1d0cc91adfe4ee5747d816be7b9a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479566Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#818129}
-
Sky Malice authored
TBR: yuezhanggg@chromium.org Bug: 1139475 Change-Id: I3a904e1e09e2a9330c6b4ed97b32704977f73398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481682Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818128}
-
Liquan (Max) Gu authored
Now that PaymentRequestImpl has been renamed PaymentRequestService after CL[1], the variables, methods, classes names in MojoPaymentRequestGateKeeper should be renamed accordingly. [1] https://crrev.com/c/2467359 Bug: 1137006 Change-Id: I1baa16f4220760cb7434ef9397c4a091b8425a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481249Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#818127}
-
Wenyu Fu authored
Clean up expired HomepageLocationPolicy flag, which is 100% enabled. Also remove test cases that has the feature disabled. Bug: 1110647 Change-Id: I69c92305439c631a7f4c61d09cfdf226e5f0e2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472265Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818126}
-
Sky Malice authored
TBR: dullweber@chromium.org Bug: 1139480 Change-Id: I0413c0f7d73fe811c678e8cc290609cffab5eedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481823Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818125}
-
dpapad authored
Bug: 720034 Change-Id: Ibddd393abde847d06e3c82ab3c3d4be1d1d56526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478885 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#818124}
-
Pranav Batra authored
This change is necessary for the tast tests to work properly. BUG=none TEST=tast run -buildbundle pita <DUT> printer.* Change-Id: Ic719a1c5f83f9f6b763a23f3c6bbd5dd6edc3a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470024Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Pranav Batra <batrapranav@chromium.org> Cr-Commit-Position: refs/heads/master@{#818123}
-
Sky Malice authored
TBR: gogerald@google.com Bug: 1139467 Change-Id: Ic3903e33348bd653ebdd076ca56fbae72188fb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481547Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818122}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2de509901f7c1ab54a8242ec9caa76639dac7cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818121}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2a8ada795146..875091308b04 2020-10-16 enga@chromium.org Cleanup old/deprecated wire and native APIs 2020-10-16 cwallez@chromium.org Make wgpu::Extent3D default to {1, 1, 1}. 2020-10-16 cwallez@chromium.org Add wgpu::TextureComponentType::DepthComparison If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: If589aa087737e6699e78892f4d9cbb0d8d21de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818120}
-
Yu Han authored
This CL updates the dark mode styles for the following controls: 1. <meter> - border color. 2. multi-select - foreground text color. 3. Button: Dark mode button design has no border and has unique fill color. Thus, a specific set of color enums is created for only buttons. Button's border color is styled to match its fill color in order to give the appearance of no borders and keep its dimensions unchanged. This impacts: button, file, and color controls. Bug: 1107290, 1099624 Change-Id: I141c199f93acac2b950b8af7195e863f811c2f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469357 Commit-Queue: Yu Han <yuzhehan@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#818119}
-
Achuith Bhandarkar authored
BUG=968349 TEST=bots Change-Id: Iad0eb882b81838a322a5bc5d17b1146448873f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481902 Auto-Submit: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#818118}
-
Daniel Rubery authored
This CL enables deep scanning for Advanced Protection users by default, since we're ready to launch to 100% Change-Id: I8097b38ad05a8d7133bb6f05b0daa8866628a7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481073 Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818117}
-
Toni Barzic authored
View::OnFocus has logic that should not be skipped for SearchBoxImageButton - for example, it sends focus change notification to accessibility stack. BUG=1113884 Change-Id: I0f14833b9b0158f0fb25c8876ea45b84a74d42d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481551Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#818116}
-
Josiah K authored
Fixed: 1139200 Change-Id: I7f87a0d8dd9e5284525b256da86dfa4334af5de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478145 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818115}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/19ef525ade8e..d77d4ca4c542 2020-10-16 jalyn@microsoft.com Remove customKeyboardShortcuts experiment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92c2e0bd78f2e4e1ca3a631953f67d7432d26c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818114}
-
Elly Fong-Jones authored
Now that the PurgeDiscardable test cases are split into tests, remove their indentation layers and wrapping braces. This change is purely syntactical. Bug: 1128436 Change-Id: Ib3d6805187c68ad9912a3f98d52187e26ece9b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481075Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#818113}
-
Akihiro Ota authored
This change avoids automatically opening the tutorial in OOBE if the device is in tablet mode. We want to avoid showing the tutorial in this case because none of the content is relevant to ChromeVox touch. To implement this behavior, this change adds an accessibility private API to fetch the tablet mode enabled state of the device, which is used when deciding whether to show the tutorial or not. Once we create a tutorial for ChromeVox touch, we can remove this behavior and choose which tutorial to show depending on the user's device tablet mode. and tablet mode. Verify that tutorial only opens in laptop mode. Test: Manually test change on Eve. Start ChromeVox in OOBE in laptop Fixed: 1132081 AX-Relnotes: N/A Change-Id: I30d237ba0d30f41fcda3420fe8832c70fdfb886d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472598 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818112}
-
Livvie Lin authored
First step in componentizing site engagement so that it can be used for e.g. lookalike checks on iOS. Bug: 775390 Change-Id: I23c267011907da94a95292f4e3fbc43feb98c036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473139 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#818111}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0723ad5..2851aa91 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a9c856056f4a30c071a35f6d77ab22730cf03f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480664Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818110}
-
David Sanders authored
Transfering ImageBitmap should decrement memory usage on the original V8 isolate, and closing should decrement memory usage, otherwise unnecessary GCs are triggered. Change-Id: Iff36735ad67136650869da90a4bb07ca0632d4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700636Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#818109}
-
Rohan Pavone authored
FillOSMemoryDump already does the work of populating a memory dump. This data is now being reported correctly instead of being unused. Bug: 1102040 Change-Id: I85ca28bd7543576f1c43773721832485eeb7a480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472463 Commit-Queue: Rohan Pavone <rohpavone@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#818108}
-
Lei Zhang authored
Also do some unrelated minor cleanups along the way. Bug: 1012811 Change-Id: Ie0f621f13e9bc32ec56b474c8f054edd9482fcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478682Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818107}
-
David Black authored
This CL adds special rendering for screenshots in the drag image for Holding Space UI. Note that we will only use this rendering if there are *only* screenshot type items being dragged. Per the spec, if any non-screenshot items are being dragged we will render them all as chips. Demo: http://shortn/_3ngh0ZDucQ Note that the screen recorder did not capture the cursor moving with the drag image but it actually does so on device. Bug: 1139113 Change-Id: I5f2f0012ee1fda3f1f3b51c51275889959e08e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481005 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#818106}
-
Ben Pastene authored
As part of crbug.com/1132206, I'm merging the CrOS VM pool to the main chromium.tests pool. A couple of suites have already moved over, and the isolate-input overhead looks pretty similar to those that haven't switched after I bumped max cache size in crrev.com/i/3338983 So this continues with the merging by moving over webgl_conformance tests. This suite takes up about 20% of the current run time in the current VM pool. So I'll move 20% of the VM pool's bots to the main pool in crrev.com/i/3344206 prior to landing this. Bug: 1132206 Change-Id: I05ae7b309853102eb0a9dccb5017349d85b74169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481291Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#818105}
-
Taylor Bergquist authored
Bug: 1138684 Change-Id: Ie4a64447dc71a9809d5e431e2842c45c1accc0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476729Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#818104}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71478928d7c2..68ab63fe46c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rbpotter@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rbpotter@google.com,juanmihd@google.com Change-Id: I2412c5f5d907d0ac38761ac8514ff9bd5e53e469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481090Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818103}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I3deaa9551b9927515ace9da8895a29208cc15035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481418Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818102}
-
Jan Krcal authored
This CL extends expiry for a histogram that will still be useful for experimentation in a few following milestones. Bug: 1117116 Change-Id: I4722a1452a92ceb99669b83735b542b0225f8b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478602 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#818101}
-
David Grogan authored
min-height: auto had been using the image's natural height as the content size suggestion, ignoring a specified definite inline size, but according to this spec chain, the specified definite inline size should transfer through the aspect ratio and affect the min-content size. https://drafts.csswg.org/css-sizing-3/#min-content -> https://drafts.csswg.org/css-sizing-3/#intrinsic-sizes -> https://www.w3.org/TR/CSS2/visudet.html#float-replaced-width -> https://www.w3.org/TR/CSS2/visudet.html#inline-replaced-width -> """ if 'width' has a computed value of 'auto', 'height' has some other computed value, and the element does have an intrinsic ratio; then the used value of 'width' is: (used height) * (intrinsic ratio) """ This fix also made clear that the regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/2333530 was not so harmless -- the issue wasn't a wrong test in align-items-007, but rather an incorrect block size given to a replaced element with aspect ratio but no size in the content size suggestion. We had been giving such element a 150px intrinsic block size; the correct size is the available inline size passed through the aspect ratio. This is now fixed in this patch. The changed case at the end of flex-aspect-ratio-img-column-011.html was asserting the opposite behavior of flex-minimum-height-flex-items-007.xht (Gerrit or something keeps adding a bogus "fixed" line under Change-Id, in case this CL shows up someplace random) Change-Id: I05cb4b3ca796b3df02dfa5d8e3790d6164213be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462574 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818100}
-
Eric Orth authored
Bug: 1109792 Change-Id: I92b09982b2ce2c6be9b9e81d28965cdd2e329a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472417 Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#818099}
-
Sky Malice authored
TBR: michaelbai@chromium.org Bug: 1133535 Change-Id: I3bb2ac2dbbd3e9349afca8603de90521ddf0f5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481009Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818098}
-
Aga Wronska authored
Extend the expiration date and update the ownership for the following histograms: * ManagedUsers.SafeSitesDelay* * Supervision.ParentAccessCode* Bug: 1138331, 1138414 Change-Id: Icdec80809c3195a20ed64c7ca1076d22ff8012c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471218Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#818097}
-