GitLab

The goal of the CL is to re-align the Omnibox text to match the new
Refresh spec.

In the new Refresh spec, the text has a different indentation depending
on whether or not the popup is open, so this CL resets the insets
of the OmniboxViewViews whenever the popup opens or closes.

It also updates LocationBarView to no longer ignore the left-inset
value of the OmniboxViewViews. We used to also ignore the right-inset
value, but we stopped doing that recently [1].

After no longer ignoring the left-inset value, we update the
non-Refresh value to the correct value of 0 (to keep things looking
the same), and update the Refresh value to 2, which matches mocks.

We are updating the inset of the OmniboxViewViews textfield instead of
the bounds of the textfield because we want the whole area to remain a
clickable I-beam, even if we indent the text a bit.

[1] https://codereview.chromium.org/2642893002/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc

Bug: 849779, 823535
Change-Id: I8c2a9e4934a78efec0d3d6cd60c63181be2d92c4
Reviewed-on: https://chromium-review.googlesource.com/1096491Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566834}

Adds a special treatment for the Incognito NTP: the share button is now
hidden, and there is a fake "placeholder" in the steady view.

Bug: 845956
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I761ff6d418b49527afb04ce890ca09a481e39778
Reviewed-on: https://chromium-review.googlesource.com/1095111
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566833}

The account consistency was wrong on the IO thread: it was rebuilt
from the Finch experiment config and the migration pref. However
this is not enough, and edge cases were missed, such as supervised
profiles and missing client ID.

This CL no longer rebuilds the account consistency method on the IO
thread, but instead simply passes the value from the UI thread.

Bug: 844250
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I735005277823196a31553cc85010ca0c89eed30b
Reviewed-on: https://chromium-review.googlesource.com/1097403
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566832}

Some clients do not have the sampling configuration for UKM records
and the large number of entries can cause significant bias when weighted
against those clients that are sampling.  Setting a large default
sampling value will at least bias the other way.

Bug: 766909
Change-Id: Ib6d656bd2ce4d82efb35281d09dc7b94128fadb2
Reviewed-on: https://chromium-review.googlesource.com/1095596Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566831}

Change-Id: Ifa001b139873cfff3e47d54ab9cfb205e45867f2
Reviewed-on: https://chromium-review.googlesource.com/1094440Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Art Snake <art-snake@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#566830}

It was proposed here https://github.com/WICG/feature-policy/pull/172
that "document-write" is a better name for this feature. This CL makes
the naming change correspondingly.

Bug: 841605
Change-Id: Id0a928fd3f6669eb3700736ff5770d4717d2b414
Reviewed-on: https://chromium-review.googlesource.com/1095328
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566829}

Bug: 438897
Change-Id: I74e762eca43225763b66b87fea4d6cd1cb6bd107
Reviewed-on: https://chromium-review.googlesource.com/1098621Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566828}

Bug: 849728
Change-Id: Icb434deda013b03f32048f3ed73d5c2d5b746165
Reviewed-on: https://chromium-review.googlesource.com/1096079Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566827}

Bug: 852349
Change-Id: I8367c10390caf2f5eda219eadb958e10e049c4cc
Reviewed-on: https://chromium-review.googlesource.com/1098933
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566826}

Adds snapshot_unittests to the main waterfall win bots,
the cros memory bots (already running on the others),
and the clang tot bots (all desktop platforms).

Disables the test on Win10, since it doesn't pass there.

Bug: 843511,850556,438897
Change-Id: Ifa577c3fe97bb10544addcd12e69a29a65cff01d
Reviewed-on: https://chromium-review.googlesource.com/1089655Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566825}

Two blink tests used their own SecondsToTimeTicks helpers which
clashed in jumbo builds where those files were compiled in the
same translation unit. Since it's a small function and hard to
find a suitable shared place, this moves the functions to
tighter scopes to not interfere with each other.

Change-Id: I9e04eed676e9e07f4aa5a815b655625bba03593f
Reviewed-on: https://chromium-review.googlesource.com/1095336Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#566824}

Change-Id: If9a6fd5d3c31d78c747801b63d67f6d4a277692f
Reviewed-on: https://chromium-review.googlesource.com/1098215Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566823}

Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/92020a042c..e5be80532b
Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/92020a042c..e5be80532b

Bug: 850029
Change-Id: I2a13d849fdd5822ab6b2ec769f7deeda48d1995b
Reviewed-on: https://chromium-review.googlesource.com/1097845Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566822}

The embedded 2x100 PNG is supposed to be all transparent, but it
contains some resizing artifacts in the top two rows.

This is not problematic for layout tests because when zoomed-out we skip
drawing the background altogether.  But if opened in a browser, without
zooming out, the result shows a misleading seam in the middle.

Update to all-transparent 2x100 PNG.

Bug: 851972
Change-Id: I8bf14ad9101967afc2c9046a2eea09a2370d0476
Reviewed-on: https://chromium-review.googlesource.com/1097618Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566821}

https://chromium-review.googlesource.com/1090601 copied an enum
class declaration into some LayoutNG files, which breaks jumbo
builds which see both declarations at the same time.  Let's just
include the original.

Bug: 850448
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id219bdd6a059ac1501be3d912da71468f7d3797c
Reviewed-on: https://chromium-review.googlesource.com/1098674Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#566820}

Change several LOG(WARNINGS) in chromeos::StatisticsProvider
to VLOG(1) to reduce log spam:

- "Requested statistic not found: ..."
- "Requested machine flag not found: ..."
- "CrOS region set to '...'"

Bug: 844258
Change-Id: I4a375f39ec919a62543366104d31367db715c54a
Reviewed-on: https://chromium-review.googlesource.com/1098473Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566819}

Cache the value and avoid calling base::FeatureList::IsEnabled too
frequently. This should reduce main thread execution time by 0.25%.

R=skyostil@chromium.org

Change-Id: Ib13fce75a748be5c73519ad70ffac61c072bfb8a
Reviewed-on: https://chromium-review.googlesource.com/1095514
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566818}

This CL creates a new function in NavigationController following the move of
the NavigationRequest creation to the NavigationController. This function,
NavigateWithoutEntry is called for new navigations, for which we don't have a
NavigationEntry. It creates a pending NavigationEntry and a single
NavigationRequest based on the LoadURLParams, then asks the Navigator to
navigate to it. This allows the creation of NavigationRequests based on
LoadURLParams in a function that has access to LoadURLParams.

This is part of a larger refactoring effort. I plan to follow up this
CL by additional work:
1) Adding another method for creating NavigationRequests that only uses the
LoadURLParams and does not depend on the pending NavigationEntry.

2) Introduce a NavigateToExistingEntry method that will be used for navigations
to existing NavigationEntries.

3) Unifying code in StartHistoryNavigationInNewChild and NavigateFromFrameProxy
with NavigateToExistingEntry and NavigateWithoutEntry.

4) Removing the pending NavigationEntry and instead create NavigationEntries
from the NavigationRequests when the navigation commits.

Bug: 803365, 803859
Change-Id: I325ddbab2309ce88c138e7e92755aa31cc6c4617
Reviewed-on: https://chromium-review.googlesource.com/904988
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566817}

TBR=ellyjones@chromium.org

Bug: 852285
Change-Id: Id66cec1f12b32dceb6bfaff9f10ba7147cb2db92
Reviewed-on: https://chromium-review.googlesource.com/1098962Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566816}

https://webrtc.googlesource.com/src.git/+log/1f4d7a28484f..e4a17c572d39


git log 1f4d7a28484f..e4a17c572d39 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 philipel@webrtc.org Moved timing related logic into its own function in webrtc::PayloadRouter.


Created with:
  gclient setdep -r src/third_party/webrtc@e4a17c572d39

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: If791f74d0cec752b3543f6502356174a93f28123
Reviewed-on: https://chromium-review.googlesource.com/1098936Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566815}

When parsing FormData, a few bits of information derivable from a
FormData instance deserve to be cached:
(1) Whether the field is a password field or an unmasked field.
(2) What is the parsing result of its autocomplete attribute.
(3) (In near future,) whether the the field has been typed into.

Currently, (1) is always recomputed on demand and (2) is held in an
external cache. (3) is not needed yet, but will be, and more cases may
come.

Therefore, this CL adds an internal ProcessedField structure to the
parser, which allows wrapping the FormData together with those derived
data. That spares the need to recompute the derived data, and also
stores it at a natural place, avoiding the need to do caching and
operate with std::map.

The CL also migrates the AutocompleteFlag enum values from MACRO_STYLE
to kConstantStyle. The latter seems preferred by the current style
guide.

Bug: 845426
Change-Id: I19c84e7f6e8dcc5535faf392523a71ca6f72e23d
Reviewed-on: https://chromium-review.googlesource.com/1098920Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566814}

This was the last known missing bit prior to enabling USS by default,
now implemented in SessionModelTypeController, which is a subset of
what the non-USS SessionDataTypeController does, and almost identical
to TypedURLModelTypeController.

Some unrelated tests have been updated as a preparation for toggling
the switch.

Bug: 681921
Change-Id: I2e0ebec6a3020bff350091ca63c9a8f4d74a81c5
Reviewed-on: https://chromium-review.googlesource.com/1097492Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566813}

Bug: 852174
Change-Id: I05fa4415575db7ed3617ff8e58e58177b837b3e2
Reviewed-on: https://chromium-review.googlesource.com/1098151
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566812}

The Viz team is beginning to target Android. We'd like to begin running our
tests regularly to catch unknown bugs, and regressions.

This adds our FYI test config to the Mojo Android FYI bot.

Bug: 849746
Change-Id: I906be084207610209ca6936994e28ce863ad1f15
Reviewed-on: https://chromium-review.googlesource.com/1090075Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566811}

This reverts commit a1f6d823.

Reason for revert:

This revert didn't fix SitePerProcessTextInputManagerTest in interactive_ui_tests on Mac-10.12.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13732

Original change's description:
> Revert "Move main scrolling coordinator update after PrePaint"
> 
> This reverts commit 377243e0.
> 
> Reason for revert:
> 
> SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames is failing on Mac-10.12.
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13719
> 
> Findit has 93% confident with this CL, and nothing else looks suspiciou so far (although this one doesn't look suspicious to me, neither).
> https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/13719
> 
> Let me give it a try to revert this one to see whether the revert fixes the issue or not.  Please land this again, if this is irrelevant at all.
> 
> 
> Original change's description:
> > Move main scrolling coordinator update after PrePaint
> > 
> > The main scrolling coordinator update, ScrollingCoordinator::
> > UpdateAfterCompositingChangeIfNeeded, does not depend on the PrePaint
> > phase and can be moved after PrePaint. This change will make it easier
> > to compare the new PaintTouchActionRects update
> > (ScrollingCoordinator::UpdateTouchActionRects) to the current update
> > (ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded).
> > 
> > This patch also renames UpdateAfterCompositingChangeIfNeeded to
> > UpdateAfterPrePaint and adds a comment describing what it does.
> > 
> > Bug: 851513
> > Change-Id: Idbcd515708a33d6955deb513808874b38d731c4f
> > Reviewed-on: https://chromium-review.googlesource.com/1096297
> > Reviewed-by: Robert Flack <flackr@chromium.org>
> > Commit-Queue: Philip Rogers <pdr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#566542}
> 
> TBR=flackr@chromium.org,pdr@chromium.org,xidachen@chromium.org
> 
> Change-Id: Ic1839d7e51752fd2b5f974b958dadd2b98f2569c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 851513
> Reviewed-on: https://chromium-review.googlesource.com/1098815
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566749}

TBR=flackr@chromium.org,yukishiino@chromium.org,pdr@chromium.org,xidachen@chromium.org

Change-Id: I3745bcf4c8c381c97c6373edc2b26553ffb6aaeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851513
Reviewed-on: https://chromium-review.googlesource.com/1098995Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566810}

This moves the code into the toolkit_views source list and gates Aura
specific code behind build flags.

BUG=726005,657883

Change-Id: I5e64ee0b16f2bfcb03da3bbc7c61486a786ee88d
Reviewed-on: https://chromium-review.googlesource.com/1097843Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566809}

The AccountReconcilorFactory was using the value from the Finch config
experiment instead of the per-profile value. This can lead to bugs when
these differ, which happens in particular when the client ID is not set.

Bug: 777774
Change-Id: I5c67ab704be119770d919a0ce3b8a623809ef0f2
Reviewed-on: https://chromium-review.googlesource.com/1097128
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566808}

ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad was using a time based
wait, to simulate awaiting a frame submission. However the timing on viz debug
builds on Linux64 was leading to incorrect results.

This updates the test to use RenderFrameSubmissionObserver to wait directly upon
frame generation.

TEST=ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad

Bug: 843921
Change-Id: I71cd8acdc528a3b220c8ccbbbece585ed5cf03bd
Reviewed-on: https://chromium-review.googlesource.com/1097216Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566807}

This updates some of SitePerProcessBrowserTests, PointerLockBrowserTests, and TouchSelectionForCrossProcessFramesTests to use the new hit testing api.

Based on: https://chromium-review.googlesource.com/c/chromium/src/+/1071886

TBR=piman@chromium.org
TEST= SitePerProcessBrowserTests,
PointerLockBrowserTests,
TouchSelectionForCrossProcessFramesTests

Bug: 785986
Change-Id: Ic3d7aca3f214d0ca0c1952e1f29b84a5ac31e13c
Reviewed-on: https://chromium-review.googlesource.com/1082573
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566806}

ExternalURLTabUsageRecorderTestCase.testEvictedTabReloadFailure always
fails, simulator and device.

"This site can’t be reached" can't be find (but it shown on the page).

Bug: 852341
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6ccb5d93ecd470ed3ac5e01400fca1677ebfbfeb
TBR: eugenebut@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1098923Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566805}

Introduces LayoutObjectFactory, which will be used more extensively in
follow-up CLs, so that nobody creates a LayoutBlockFlow on their own,
for instance.

Change-Id: Ib9124a6f02ee1e5f1213b1b61f18e0494d7bd268
Reviewed-on: https://chromium-review.googlesource.com/1095103
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566804}

BUG=584508

Change-Id: I10a23c45cf4671acc2dc58ff7f1b088d6e1c3356
Reviewed-on: https://chromium-review.googlesource.com/1088913
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566803}

New chrome camera app will export images and videos to Downloads/
directly. It needs to whitelist camera app to access the directory.

      browser_tests

Bug: b:74636654,845423
Test: CCA can read/write Downloads/ directory, pass unit_tests and
Change-Id: I054ee560e413e8bca46ca4147c330beec81081e8
Reviewed-on: https://chromium-review.googlesource.com/972789
Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566802}

...plus fix and reenable
SingleClientDirectorySyncTest.DeleteDirectoryWhenCorrupted.
This test waits until it sees an unrecoverable error through the
SyncServiceObserver. Since we weren't actually notifying in this case,
it relied on a random different notification. Interestingly, adding the
missing NotifyObservers() made the test hang consistently.
My theory is that there was a possible deadlock between the sync thread
and the main thread. It seems to be fixed by explicitly waiting for the
main thread tasks to run before waiting on the sync thread.

Bug: 850980
Change-Id: I2f636ddfa457b6d977f909e0d0a17a26aca5c166
Reviewed-on: https://chromium-review.googlesource.com/1097479Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566801}

The tested feature regressed, but no one realized it, because the test continued
to pass.

Instead of displaying the filenames in the <div>, a new navigation to the file
happened. Starting the navigation causes the current Document to stop and the
test to finish early. The tests finished before it has executed any assertions.

This CL fixes the test, but not the regression.

Bug: 821455, 831155
Change-Id: I61b9cca80677ca2caed72b0e9cf6074f73c2ad6a
Reviewed-on: https://chromium-review.googlesource.com/1094879
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566800}

This CL is a pure refactoring.

Change-Id: Ic3b03be80e1e2e5071c5bfc95e2212214a5af183
Reviewed-on: https://chromium-review.googlesource.com/1094819Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566799}

Instead of creating a unique_ptr<Backend*>, passing around ownership,
and having to worry about lifetime, just use a class member, since the
callback lifetime is already tied to the lifetime of the
HttpCacheDataRemover instance.

This also enables changing callback type from Repeating to Once.

Bug: 807724
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iae84f3729ed077c0599f3133cf129624bc02c1d7
Reviewed-on: https://chromium-review.googlesource.com/1093056Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566798}

Findit identified the culprit r566539 with confidence 95.6%
Which seemed plausible, but it couldn't be easily reverted due to
merge conflict.

TBR=tnijssen@google.com,kenrb@chromium.org

Bug: 852274
Change-Id: Ia8225ad0143a701f750ade4a254d4b62d6571573
Reviewed-on: https://chromium-review.googlesource.com/1098661
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566797}

https://skia.googlesource.com/skia.git/+log/7deacf4833dc..7c525e62d405


git log 7deacf4833dc..7c525e62d405 --date=short --no-merges --format='%ad %ae %s'
2018-06-12 robertphillips@google.com Plumb GrContext everywhere


Created with:
  gclient setdep -r src/third_party/skia@7c525e62d405

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: Ibfa4ea0068bdda2d94fc48feffea5544344ae0a5
Reviewed-on: https://chromium-review.googlesource.com/1098835Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566796}

Network traffic annotation tests on Windows FYI bot are failing. The
scope of tests is reduced to minimum to check for error.

TBR=georgesak@chromium.org

Bug: 844014
Change-Id: Ib6ea2b50cc4bf5ca2c869daf7e133f0feac790f3
Reviewed-on: https://chromium-review.googlesource.com/1098655Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566795}