- 09 Aug, 2018 40 commits
-
-
Cathy Li authored
Change-Id: I8086423200b43d771ad800c84ef8c1795ef18b56 Reviewed-on: https://chromium-review.googlesource.com/1168285 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#581906}
-
Nico Weber authored
Reverts https://codereview.chromium.org/2519803003 , it shouldn't be needed with lld. (Running `ninja -t msvc` directly means ninja doesn't have to be in PATH, since then clause 1 of how CreateProcessA() finds binaries can take effect: 1. The directory from which the application loaded. Due to the delete, `ninja -t msvc` was run under `cmd /c`, which means we did require ninja in PATH only for official builds. This removes this exception. But we're also making sure ninja is in PATH for now until crbug.com/872740 is resolved, so this change is more a defense-in-depth thing.) Bug: 665773,828472,828466 Change-Id: Ic86b255df1544fcb4744ff4d2bf1f3f0b25119c3 Reviewed-on: https://chromium-review.googlesource.com/1169302Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581905}
-
Oriol Brufau authored
They are implemented behind the CSSLogical runtime flag. Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/48OwfwZrbvI/A1XZFGkzAwAJ Spec: https://drafts.csswg.org/css-logical/#directional-keywords BUG=850004 TEST=external/wpt/css/css-logical/logical-values-float-clear.html TEST=external/wpt/css/css-logical/logical-values-resize.html The tests still have some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: Ieede2703368a44f3ce9996e917857226795ebaea Reviewed-on: https://chromium-review.googlesource.com/1163667Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#581904}
-
Matthew Jones authored
This patch fixes an issue with the bottom toolbar when entering fullscreen while the keyboard is visible. To conserve space while the keyboard is showing, the bottom controls height is set to 0 and reset when the keyboard is hidden. This does not account for fullscreen mode, so when the keyboard is hidden it blindly tells the controls to become visible again. This patch adds logic to update the bottom toolbar when the controls height is restored and only conditionally shows the toolbar if another browser feature isn't blocking it. Bug: 872323 Change-Id: Ic3f33fcd7ae207415a5d36b56dba86ec216d3a51 Reviewed-on: https://chromium-review.googlesource.com/1167997Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581903}
-
Sammie Quon authored
Test: manual Bug: 871985 Change-Id: I3747ce934f186acd677252ce22d748f4fe853907 Reviewed-on: https://chromium-review.googlesource.com/1166326 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581902}
-
Justin Cohen authored
Bug: 872788 TBR: rohitrao Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I55e2ba91fe5cbd0ef170d7a34d7e5104b7de735a Reviewed-on: https://chromium-review.googlesource.com/1169318 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581901}
-
Ned Nguyen authored
This is a reland of 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9 Original change's description: > Add perf/core/bot_platforms.py file that contain metadata about all perf builders > > Bug:871746,863768 > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8 > Reviewed-on: https://chromium-review.googlesource.com/1169127 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> Bug: 871746, 863768 Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi TBR=perezju@chromium.org Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797 Reviewed-on: https://chromium-review.googlesource.com/1169882Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#581900}
-
Boris Sazonov authored
This CL disables EnableAndStopTracingWithEmptyFile and DoubleStopTracing from TracingControllertest, as they are flaky on Android. Builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23169 TBR=oysteine@chromium.org Bug: 872631 Change-Id: I55612d42712a9867fce271efdefc920139a6972d Reviewed-on: https://chromium-review.googlesource.com/1169209Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581899}
-
Justin DeWitt authored
Change-Id: I5cb3c934aece88cadbd909e5162093b5b49903c7 Reviewed-on: https://chromium-review.googlesource.com/1169623 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#581898}
-
tzik authored
This CL flips `use_once_callback` flag on the Mojo code generator for //chrome/common, and fixes all compile errors after that. After this CL, Mojo interfaces there service starts using base::OnceCallback instead of base::Callback on its return value handling. Bug: 714018 Change-Id: I70823c7a0ca0032fa3223e2a2926d37acc8f6523 Reviewed-on: https://chromium-review.googlesource.com/1152342Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#581897}
-
Jun Mukai authored
Some windows, including tab-dragging window, want to suppress the window animations. This property needs to be propagated to Ash to take an effect. BUG=867074 TEST=manually Change-Id: I80847702e26cd04981cac71b02114389312d83e1 Reviewed-on: https://chromium-review.googlesource.com/1166331Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581896}
-
manuk authored
Previously, the results popup shadow color was kGoogleGrey800 (#3C4043) for both incognito and normal windows. This shadow was difficult to detect on incognito's dark new tab page. This changes the shadow color for incognito windows to black (#000). This change only affects material refresh. The results popup uses BubbleBorder to draw its border, including its shadow. BubbleBorder can be provided a shadow elevation to determine the size of its shadow, or else it will provide a default shadow. Additionally, BubbleBorder shadows consider the material refresh flag. Elevated refresh shadows (e.g. refresh flag is on and elevation is 3 or 16) are delegated to ShadowValue::MakeRefreshShadowValues. Elevated non-refresh shadows (e.g. refresh flag is off or elevation is neither 3 nor 16) are delegated to ShadowValue::MakeMdShadowValues. Un-elevated shadows are constructed inline within BubbleBorder::GetShadowValues. Previously, ShadowValue::MakeRefreshShadowValues shadows were kGoogleGrey800, while ShadowValue::MakeMdShadowValues and BubbleBorder::GetShadowValues shadows were SK_ColorBLACK. This cl adds the ability to set custom shadow colors for all 3 shadow constructions. If no color is set, SK_ColorBLACK is used by default, this is consistent with all current usages of ShadowValue and BubbleBorder. Bug: 866054 Change-Id: I6d592f290daf41a6a083e7e6214c0a30dfdfb68f Reviewed-on: https://chromium-review.googlesource.com/1165794 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#581895}
-
Bence Béky authored
Use CompletionOnceCallback instead of CompletionCallback, and CancelableCompletionOnceCallback instead of CancelableCompletionCallback in //content/browser/appcache. Bug: 807724 This exact CL has been reviewed and approved at https://crrev.com/c/1163933. However, due to a bug in Gerrit, I inadvertently submitted that CL skipping the CQ. See https://crbug.com/872722. That CL was reverted, and now I am relanding it properly in this CL, through CQ this time. Original reviewer is TBR'd. TBR=kinuko@chromium.org Change-Id: Ie1d8e275e754cc51457aca6537ad08b228cfaaac Reviewed-on: https://chromium-review.googlesource.com/1169307Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581894}
-
Tim Song authored
This makes the behaviour consistent with BLE advertisement on ChromeOS. Change-Id: I8405f5fafc6f29874abf7e988d6828d7d03828ad Reviewed-on: https://chromium-review.googlesource.com/1162689 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#581893}
-
Mark Pearson authored
and extend date of another omnibox histogram. Bug: 871485 Change-Id: Ied602a6df0748faa501112c2a0dfcd38dab49071 Reviewed-on: https://chromium-review.googlesource.com/1166192Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#581892}
-
David Black authored
Handles press of opt in to trigger onboarding flow. There didn't seem to be a great place to put this so I broke out an AssistantSetupController. Potentially this might be a good place to cache settings state on the Ash side in the future when we clean up VoiceInteractionController. Note that the AssistantOptInView is still hidden programmatically. A follow up CL will show this view when appropriate. See bug for demo. Bug: b:111315696 Change-Id: I6438abc780d2d5e5753dd22c34c477b7364324e4 Reviewed-on: https://chromium-review.googlesource.com/1166259 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581891}
-
Boris Sazonov authored
This CL adds JNI bridge for UnifiedConsentService::ShouldShowConsentBump and shows the consent bump if necessary. Bug: 869426 Change-Id: I7f1ca38673c330a86effd376f3120dae6029bb61 Reviewed-on: https://chromium-review.googlesource.com/1167846Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581890}
-
Andrii Shyshkalov authored
NOTREECHECKS=True No-Presubmit: True No-Try: True Bug: 872722 Change-Id: I78a357132559302f59848a712363d02cb2f0e91a Reviewed-on: https://chromium-review.googlesource.com/1169949 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581889}
-
Andrii Shyshkalov authored
TBR=pkasting Bug: 872722 Change-Id: Iffb249c1d61d468ac8f301b4808049e03ab52127 Reviewed-on: https://chromium-review.googlesource.com/1169912Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581888}
-
Francois Doray authored
Before this CL, recomputing occlusion too many times before occlusion states became stable caused a call to DumpWithoutCrashing(). Now that we didn't get any crash reports in the last 6 months, this CL replaces the DumpWithoutCrashing() with a simple DCHECK. Bug: 813076 Change-Id: I2ec8c5fa89a1646367035c3585df091a9a4f76cc Reviewed-on: https://chromium-review.googlesource.com/1168024Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#581887}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b04cdc9bc5e1..bca7d20ad76a git log b04cdc9bc5e1..bca7d20ad76a --date=short --no-merges --format='%ad %ae %s' 2018-08-09 nastasoiuf@google.com Integration 2018-08-09 wangge@google.com Add Test Cases for `utils.py`. 2018-08-09 wangge@google.com Add Logic to Use Monochrome After Milestone 52. Created with: gclient setdep -r src/third_party/catapult@bca7d20ad76a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390,chromium:863390 TBR=sullivan@chromium.org Change-Id: I7ebb2f0dbfb94c7af0c997dbd5826e7bd03ea455 Reviewed-on: https://chromium-review.googlesource.com/1169108Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581886}
-
Vasilii Sukhanov authored
Dismiss the generation prompt when > 5 characters typed. Bug: 869890,859472 Change-Id: Ib842b92857a79e92e411e7247ad0cc4a322dd364 Reviewed-on: https://chromium-review.googlesource.com/1167507Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581885}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 84f87556. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22574 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB mtrofin@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=kereliuk No-Export: true Change-Id: I8da40e9d8be7e1a738a8f2f1ffbe16f65f1d3f29 Reviewed-on: https://chromium-review.googlesource.com/1169123 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#581884}
-
Mirko Bonadei authored
The code that was causing the problem has been removed from absl. Removed from: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/8f96be6ca60d967bd4b37f93d0a03bcff4145200 --- 5aba0b15eaf6c5beff0e91670a7cdf5ad1151886 by Derek Mauro <dmauro@google.com>: Use std::chrono to get the current time on both Apple and Windows platforms, eliminating the unnecessarily complicated logic on Apple platforms. PiperOrigin-RevId: 206979219 --- Bug: webrtc:9557 Change-Id: Idb2858b39b2ef8ed7e69d4d740faef9d369e8747 Reviewed-on: https://chromium-review.googlesource.com/1165348 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581883}
-
Ross McIlroy authored
ready_state_ could be kErrorOccured as well as kReadyStreaming. Update the logic to check for this and add a new NotStreamingReason to log it. BUG=chromium:865098,chromium:871276 Change-Id: I7f4e17c843b74632d4cf167664f26fdb92f30a8c Reviewed-on: https://chromium-review.googlesource.com/1164943 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#581882}
-
Andrew Grieve authored
This will match up pak symbols when they have moved between grdp files. Change-Id: I55ae383498c66a11c675cb1b0eb4866da4cae721 Reviewed-on: https://chromium-review.googlesource.com/1168456Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581881}
-
chrome://sync-internalsMikel Astiz authored
The regression was introduced in https://chromium-review.googlesource.com/1160229 which overlooked the fact that the UI makes assumptions about when it's notified about the results (i.e. no synchronous reply expected). There are cleaner alternatives to the proposed fix, but it seems most conservative to go back to the previous implementation by partially reverting the offending patch. Bug: None Change-Id: I81d82d27234666d407708b1ccd366e493784e9c5 Reviewed-on: https://chromium-review.googlesource.com/1169045 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#581880}
-
Luke Halliwell authored
As a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1133975 Realized when plumbing this through in chromecast's render client that we need the RenderFrame. Bug: 862698 Change-Id: I1764dcd25dacac7a406d8b179d7abb5af2d14dad Reviewed-on: https://chromium-review.googlesource.com/1151761Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#581879}
-
Mohamed Amir Yosef authored
The server identifies bookmark commit requests by the absence of a client_defined_unique_tag. Bookmarks should be handled differently when generating server ids. This CL makes sure the client_defined_unique_tag is only populated for non-bookmark data types. Bug: 516866 Change-Id: I0c3b1f314c638878fd8780663484aec780215e99 Reviewed-on: https://chromium-review.googlesource.com/1169052 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581878}
-
Peter Wen authored
Bug: None Change-Id: I1e24a3a076ca89dcde0712620f8194fed7702183 Reviewed-on: https://chromium-review.googlesource.com/1167109Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581877}
-
Greg Kraynov authored
We're moving away from using MessageLoop in Blink, hence, we want to make SequenceManager support any missing pieces and provide a good level of abstraction on top of a thread. Specifically, this CL will unblock removing MessageLoop references from content::RenderThreadImpl. Bug: 828835 Change-Id: I5a785a26f35839eea3705ecb5abc61672c497457 Reviewed-on: https://chromium-review.googlesource.com/1167516Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581876}
-
David Tseng authored
This reverts commit ad618241. Reason for revert: <INSERT REASONING HERE> Chromeos-dbg bots are now green (for chromevox); this change was unlikely to be at fault. Original change's description: > Revert "Only alert accessibility when a notification's text changes" > > This reverts commit feb758c3. > > Reason for revert: <INSERT REASONING HERE> > SpokenFeedbackTests failing on chromeos dbg > Original change's description: > > Only alert accessibility when a notification's text changes > > > > Bug: 867426 > > Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208 > > Reviewed-on: https://chromium-review.googlesource.com/1166231 > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581474} > > TBR=stevenjb@chromium.org,dtseng@chromium.org > > Change-Id: I8b23c03e08642caa7b05d2ce88e6f330dd056c37 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 867426 > Reviewed-on: https://chromium-review.googlesource.com/1167603 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581607} TBR=stevenjb@chromium.org,dtseng@chromium.org Change-Id: I0b1270e0ebdbfbca89baefe9a9f676062862479e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867426 Reviewed-on: https://chromium-review.googlesource.com/1168329Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581875}
-
jdoerrie authored
This change simplifies FidoBleConnection by passing the obtained BluetoothAdapter from FidoBleDiscovery through the FidoBleDevice to the FidoBleConnection. This removes the need to query for the adapter within FidoBleConnection and simplifies the implementation. Bug: 763303 Change-Id: I83e0c5e715246db4c3ac0dc0427797c8d783853c Reviewed-on: https://chromium-review.googlesource.com/1167056 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#581874}
-
Jérôme Lebel authored
This CL enables unified consent given when the user signs in to Chrome. This CL also disabled and enables unified consent given when the user toggles the corresponding switch on and off in the Sync and other services settings screen. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5384052f4abe117e7816733e45dc4091afe55708 Reviewed-on: https://chromium-review.googlesource.com/1165151Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#581873}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f43cb96e..4fe3de13 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4ab8f99b744760d60f58e2d1205d5453efba0f9 Reviewed-on: https://chromium-review.googlesource.com/1168985Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581872}
-
Jérôme Lebel authored
Adds a call from -[MainController scheduleLowPriorityStartupTasks] to the BrowserViewController, to present the ConsentBumpCoordinater if needed. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If27ff2e61659489da6e61a48b9d1e252ad43f9e8 Reviewed-on: https://chromium-review.googlesource.com/1163506 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#581871}
-
vitaliii authored
virtual/mouseevent_fractional/fast/events/autoscroll-over-scrollbar.html fails. virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-nested-divs.html timeouts. virtual/mouseevent_fractional/fast/events/recorded-keydown-event.html timeouts. TBR=sahel@chromium.org NOTRY=true Bug: 872705,851090 Change-Id: I03aa2e1cac464c8a880bfd570fec2531bb26c2c8 Reviewed-on: https://chromium-review.googlesource.com/1169055Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581870}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b2db53998dc4..5f0ce99c04eb git log b2db53998dc4..5f0ce99c04eb --date=short --no-merges --format='%ad %ae %s' 2018-08-09 buildbot@webrtc.org Roll chromium_revision 474eca05..46dc99a5 (581204:581557) 2018-08-09 nisse@webrtc.org Revert "Refactor RtpVideoStreamReceiver without RtpReceiver." Created with: gclient setdep -r src/third_party/webrtc@5f0ce99c04eb The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I03c16d7d120279a4ef44dfe86d97aaf7e63a80c4 Reviewed-on: https://chromium-review.googlesource.com/1168415Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581869}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/8f612ebb15..bea85b5273 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/8f612ebb15..bea85b5273 Bug: None Change-Id: I34abe94b1abce30aa15cd0a38376b655e992ca48 Reviewed-on: https://chromium-review.googlesource.com/1165343Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#581868}
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same namespace and conflict. This happens for functions in: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc The functions are very similar but not identical. Therefore, the functions in components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc are renamed to be something more file specific. Bug: 869381 Change-Id: I8b26857cfa9fd80b42d9ff79de4b49753c824b54 Reviewed-on: https://chromium-review.googlesource.com/1169018Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#581867}
-