GitLab

There is no reason why the methods should be non-const. More importantly
it allows us to pass the observer as a const reference to lambdas or
callbacks that need to check its properties.

BUG=580406

Review-Url: https://codereview.chromium.org/2096043002
Cr-Commit-Position: refs/heads/master@{#403380}

Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ )

Reason for revert:
Breaks aura_demo target

Original issue's description:
> Link to DirectWrite directly, instead of calling LoadLibrary
>
> BUG=
>
> Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07
> Cr-Commit-Position: refs/heads/master@{#403344}

TBR=scottmg@chromium.org,jam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2117683002
Cr-Commit-Position: refs/heads/master@{#403379}

The existing 'deadline' heuristic has proven to be very flawed on some
systems, for reasons explained in the bug. This change adds a new
experimental heuristic, activated via a new command-line switch, for lab
testing: --cast-encoder-util-heuristic=backlog<N>

If the new heuristic proves to work well across our lab's gamut of test
systems, a future change will remove the command-line switch and make
the new heuristic the default.

BUG=chrome-os-partner:54806

Review-Url: https://codereview.chromium.org/2108373002
Cr-Commit-Position: refs/heads/master@{#403378}

Review-Url: https://codereview.chromium.org/2113173002
Cr-Commit-Position: refs/heads/master@{#403377}

Add QUIC unittest to make sure QuicStreamFactory does not pool sessions if
PrivacyMode differs.

Review-Url: https://codereview.chromium.org/2113873002
Cr-Commit-Position: refs/heads/master@{#403376}

There's a bug where when you activate a pending tree, the active
tree does not get the test_properties(), so if you BuildLayerList on
the active tree, the layer list drops all its layers except the root.

In fixing this, I struggled with understanding where and when tests are
building layer lists and property trees, and made some changes.

Now the test properties build the layer list when AddChild/RemoveChild
happens, which is consistent with SetRootLayerForTesting.

Also, the BuildLayerListAndPropertyTreesForTesting() and (the new)
BuildPropertyTreesForTesting() methods will now always build the trees
by setting needs_rebuild = true internally.

Also, cleaned up a bunch of LayerTreeHostImpl tests, to not have special
PrepareToDraw paths that build property trees, and just do it in the
tests.

R=ajuma, jaydasika@chromium.org
BUG=311404
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2106273002
Cr-Commit-Position: refs/heads/master@{#403375}

This CL adds closure compilation settings for several directories within
MD settings.

BUG=425627
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2112033002
Cr-Commit-Position: refs/heads/master@{#403374}

The test occasionally fails with

menu_runner_cocoa_unittest.mm:182: Failure
Expected: (runner_->GetClosingEventTime())
    <= (ui::EventTimeForNow() - base::TimeTicks())),
actual: 13647.4s vs 0.002s

It happens because menu_runner_impl_cocoa.mm uses
base::TimeTicks::Now(), but the test uses ui::EventTimeForNow() to set
expectations. Usually this isn't a problem, but if another unit test in
the same process has created a ui::EventGenerator, this sets a mock time
source with ui::SetEventTickClockForTesting(..) which isn't cleared when
the EventGenerator is destroyed.

Fix both problems. The EventGenerator destructor should reset the global
state it created, and menu_runner_impl_cocoa.mm should use
ui::EventTimeForNow() for better consistency.

BUG=623455, 624555

Review-Url: https://codereview.chromium.org/2094193002
Cr-Commit-Position: refs/heads/master@{#403373}

This field was added in https://crrev.com/dd933bda0baa6a13ab0120f0056a2b783e459efb
to limit foreign fetch to only intercept requests made from secure contexts,
but wasn't set for shared and service worker initiated requests. So this
fixes intercepting requests made from shared and service workers by a
foreign fetch service worker.

BUG=540509

Review-Url: https://codereview.chromium.org/2110163002
Cr-Commit-Position: refs/heads/master@{#403372}

This allows restarting OptIn flow for managed Arc in case user
re-activates it after stopping.

BUG=b/29121091
TEST=Manually on device for managed Arc (@google.com) and
     non-managed Arc (@gmail.com). In both cases OptIn can be
     restarted after canceling it.

Review-Url: https://codereview.chromium.org/2111733002
Cr-Commit-Position: refs/heads/master@{#403371}

This change adds support for the following NSAccessibility attributes:
NSAccessibilityEnabledAttribute
NSAccessibilityFocusedAttribute
NSAccessibilityInsertionPointLineNumberAttribute
NSAccessibilityNumberOfCharactersAttribute
NSAccessibilityPlaceholderValue
NSAccessibilitySelectedTextAttribute
NSAccessibilitySelectedTextrangeAttribute
NSAccessibilityVisibleCharacterRangeAttribute

ui::AX_ATTR_PLACEHOLDER was also not used outside of Blink, so support this
attribute as well.

Add tests for all of these attributes and plumb through textfield change
notifications for ui::AX_EVENT_TEXT_CHANGED, ui::AX_EVENT_VALUE_CHANGED, and
ui::AX_EVENT_TEXT_SELECTION_CHANGED.

BUG=610591

Review-Url: https://codereview.chromium.org/2106953005
Cr-Commit-Position: refs/heads/master@{#403370}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/44fb68ed1d6d..fd47e24b0e09

$ git log 44fb68ed1..fd47e24b0 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2109393003
Cr-Commit-Position: refs/heads/master@{#403369}

Metrics have to be persisted to disk and one possibility
is to simply use file-backed memory which leaves the
responsibility to the OS. It is simple and reliable but
there are concerns about what impact this could have on
performance.

Enabling this as an experiment will allow direct
collection of real data as to how Chrome is affected
by it and thus make possible an informed decision about
whether to use it or not.

BUG=546019

Review-Url: https://codereview.chromium.org/2010173005
Cr-Commit-Position: refs/heads/master@{#403368}

This CL includes strings for the network screen.

BUG=604119
TEST=NONE

TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2112123002
Cr-Commit-Position: refs/heads/master@{#403367}

First version of this CL was reverted (cl/2119733002).

The fonts page includes a few very large <settings-dropdown-menu> instances.
While implementing force-rendering for the purposes of "search within settings"
it was revealed that it occupied about 1.3s of the main thread to render itself.
There are two separate improvements bundled in this CL.
 1) Replace <paper-item> with a simple styled <div>. This change alone reduces
    total rendering time from 1.3s to 0.25s.
 2) Use the new initialCount feature for dom-repeat to yield, instead of
    rendering the entire template all at once.

BUG=602896,608535
TEST=Click on "Customize fonts", observe how much faster the subpage opens.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2114793002
Cr-Commit-Position: refs/heads/master@{#403366}

* Pull out the CompatibilityTextInputLayout from the EditorTextField
  so it can be used elsewhere.

* Switch to using the CompatibilityTextInputLayout instead of the
  FloatLabelLayout in the autofill preferences.

* Put the AutoCompleteTextView in its own XML file so that the imeOptions
  will be accepted properly by Android.

* Set the statusbar color to black for fullscreen windows like the
  app does.

BUG=603635

Review-Url: https://codereview.chromium.org/2113493002
Cr-Commit-Position: refs/heads/master@{#403365}

BUG=623648
TEST=KeyboardControllerTest.DisplayChangeShould

Review-Url: https://codereview.chromium.org/2101023002
Cr-Commit-Position: refs/heads/master@{#403364}

In order to build translate_core_browser from projects built
with gyp, variations is needed as a dependency.

BUG=

Review-Url: https://codereview.chromium.org/2115453004
Cr-Commit-Position: refs/heads/master@{#403363}

This CL does two things:
1. Track the performance of a toBlob API call. Because toBlob has a call
   back, so we put a timer in the CanvasAsyncToBlob class.
2. Track how often the complete timeout delay happens in toBlob calls.

BUG=612585, 608815

Review-Url: https://codereview.chromium.org/2039673002
Cr-Commit-Position: refs/heads/master@{#403362}

This CL updates strings and layout to match the latest spec.

BUG=591958
TEST=manually confirmed
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2117573002
Cr-Commit-Position: refs/heads/master@{#403361}

These match the in app activity transitions in Android.

BUG=613685

Review-Url: https://codereview.chromium.org/2108503007
Cr-Commit-Position: refs/heads/master@{#403360}

by recursively checking for shadow dom

BUG=582317

Review-Url: https://codereview.chromium.org/2101143002
Cr-Commit-Position: refs/heads/master@{#403359}

Now that we have a chooser on all supported platforms we can move the
First Device Chooser fallback to content shell, the only place where it's needed.

BUG=524780

Review-Url: https://codereview.chromium.org/2110813002
Cr-Commit-Position: refs/heads/master@{#403358}

And nukes WmShellCommon.

BUG=none
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2115663002
Cr-Commit-Position: refs/heads/master@{#403357}

This fixes a crash in SSL Interstitial code which expects that cert
exists. Error page with ERR_SSL_SERVER_CERT_BAD_FORMAT error code is
used in this case which matches other platforms.

BUG=622450

Review-Url: https://codereview.chromium.org/2096973002
Cr-Commit-Position: refs/heads/master@{#403356}

These tests often change dom/style after a complete paint and test how
the rendering pipeline handles the changes. They are good candidate
for under-invalidation checking.

BUG=619103

Review-Url: https://codereview.chromium.org/2092953002
Cr-Commit-Position: refs/heads/master@{#403355}

As we are cleaning up transform tree logic, we need to remove animation
scale computation and data from transform tree. And instead, we compute
it when we need it.

However, computing animation scale may reuse animation scale data which
belongs to other transform nodes, so we need a PropertyTreesCachedData
to store this information, and invalidate it every time we update the
transform tree.

BUG=623564
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2105673003
Cr-Commit-Position: refs/heads/master@{#403354}

This CL addresses the bug below. Earlier on, we experimented and
decided that we would fallback to SW decoded after 50 consecutive
HW decode errors. However, after an error in keyframe, non-keyframes
would be dropped and not added to the error counter. As a result,
we would wait for 50 keyframe errors before SW fallback, which
takes a long time. This CL fixes the issues resulting from this.

BUG=616968
TEST=Tried the problematic Cisco stream referred in bug.
First 3-5 seconds, we don't get a video(due to HW errors) but works
afterwards(falling back to SW).

Review-Url: https://codereview.chromium.org/2093823002
Cr-Commit-Position: refs/heads/master@{#403353}

This is to be enforced per the following spec change:
https://github.com/martinthomson/http-encryption/commit/d11c8263ef3a9fa9cec261898b5d462162045099

BUG=538576

Review-Url: https://codereview.chromium.org/2106333003
Cr-Commit-Position: refs/heads/master@{#403352}

History items with extremely long titles are very slow to render,
due to needing to layout the entire title in order to determine where to
cut it off with ellipses. This greatly degrades the performance of MD
History in a profile which has visited several of these items.

This CL trims titles down to at most 300 characters before they are
rendered, which has no visible effect, but greatly improves performance.
On a profile that has visited crashsafari[dot]com, load time is reduced
from ~5000ms to ~1800ms on my Z620. Scrolling performance is also
greatly improved.

BUG=621347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2112803002
Cr-Commit-Position: refs/heads/master@{#403351}

MCAD and AndroidVideoDecodeAccelerator share lots of code
to interact with MediaCodec.  This CL splits out much of
that into a new MediaCodecLoop class.

MediaCodecLoop manages driving the I/O loop for MediaCodec
and interacting with a client (AVDA or MCAD).

This CL only affects MCAD.  AVDA's event loop is more
complicated, and will be merged into MediaCodecLoop as
part of a separate CL.

BUG=583082

Review-Url: https://codereview.chromium.org/2016213003
Cr-Commit-Position: refs/heads/master@{#403350}

Review-Url: https://codereview.chromium.org/2118613002
Cr-Commit-Position: refs/heads/master@{#403349}

It is a dependency of SystemTray.

* Move files to //ash/common/system/chromeos/audio
* Fix include guards
* Fix IWYU

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2113113002
Cr-Commit-Position: refs/heads/master@{#403348}

This CL adds type checking for dialog elements
found by this.$.dialog. There is no functional
change aside from the type checking.

BUG=393873
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2114663004
Cr-Commit-Position: refs/heads/master@{#403347}

These libraries are dependencies for Robolectric 3.0.

BUG=522043

Review-Url: https://codereview.chromium.org/2040273003
Cr-Commit-Position: refs/heads/master@{#403346}

Since MediaCodec::release() can hang, this CL moves more cases of
it to a separate thread when needed.  Previously, we did this only
during AVDA destruction.  This CL adds support for other cases in
which we replace or clear |media_codec_|.

BUG=613238

Review-Url: https://codereview.chromium.org/2116573002
Cr-Commit-Position: refs/heads/master@{#403345}

BUG=

Review-Url: https://codereview.chromium.org/2029343002
Cr-Commit-Position: refs/heads/master@{#403344}

This jar is a dependency for Robolectric 3.0.

BUG=522043

Review-Url: https://codereview.chromium.org/2045583006
Cr-Commit-Position: refs/heads/master@{#403343}

The notifications are shown at most once per hour, or whenever the severity of the notification changes.

BUG=622590
TEST=./out/Release/unit_tests --gtest_filter=LowDiskNotificationTest.*

Review-Url: https://codereview.chromium.org/2082363004
Cr-Commit-Position: refs/heads/master@{#403342}

This jar is a dependency for Robolectric 3.0.

BUG=522043

Review-Url: https://codereview.chromium.org/2047843002
Cr-Commit-Position: refs/heads/master@{#403341}