- 02 Sep, 2020 40 commits
-
-
Morten Stenshorne authored
Test got removed in CL:2388605 TBR=rmhasan@google.com Bug: 1110003 Change-Id: Iff10ef9eaa18a65b1b0097b5d58ac61a955d22c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389182Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#803803}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2e69a28bf78..4855aad4994b 2020-09-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib51cd8905609fca7351b7247a553d3a374043aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389023Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803802}
-
Takashi Sakamoto authored
user_activation_state_unittest.cc inludes user_activation_notification_type.mojom-blink.h, but the deps doesn't have the dependency. c.f. ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. FAILED: obj/third_party/blink/common/common_unittests_sources/user_activation_state_unittest.o Change-Id: If140383d722fb2b35aef22d4eacbc5dbc9295e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387910Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#803801}
-
Erik Anderson authored
This updates from revision 7922d7c20e246552be418e8f72e577899fd30d99 (2020-02-18) to revision bd6f96933d74ad35820533cc991b4110e6e40199 (2020-08-28) Bug: 1123982 Change-Id: Iabf283b8a6eb02468124e5640447dd8f63388c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387485 Auto-Submit: Erik Anderson <Erik.Anderson@microsoft.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#803800}
-
Antonio Sartori authored
As explained in https://github.com/w3c/webappsec-cspee/pull/18, Content-Security-Policy: Embedded Enforcement source list intersection algorithm sometimes computes a wrong intersection of two lists of source expressions. Additionally, blink CSPEE source intersection algorithm was computing a wrong intersection for http://*.com and http://*.example.com. We fix those problems and add a unit test and WP tests. Change-Id: Ie7b85d8c7e978af6b5e87141d257c66e5556be95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385458Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#803799}
-
Alan Cutter authored
This CL updates the background web app install process to use the install_url instead of the start_url for registering the site's service worker. This is to avoid loading the start_url during start up (potentially very resource intensive). Note that this may cause policy installed web apps to fail to preinstall the service worker if they happen to be using an install URL that doesn't register a service worker (unlikely). This regression is very mild though as the SW will just register when the user visits the site. Default installed web apps (Canvas) already serve the service worker from their install URL. Bug: 1123435 Change-Id: I96349dddb43001ff54082b3f830d11b066378c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389483 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#803798}
-
Rob Buis authored
Implement compact operator dictionary as specified [1]. Clients of the operator dictionary can query operator values using the HasBooleanProperty method. When attribute values (stretchy, form, symmetric, largeop or movablelimits) are set or changed, dirty flags are used to efficiently recompute the operator dictionary. [1] https://mathml-refresh.github.io/mathml-core/#operator-dictionary Bug: 6606 Change-Id: I1c24cc1e91599abe985efbc1102125261d3beba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368362 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#803797}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4e51400c4f05..2c19a23d6219 2020-09-02 jleconte@google.com Add missing ids for the getElementById to work. 2020-09-02 fancl@chromium.org auto-triage: Disable email notification for adding comment to issue 2020-09-02 jleconte@google.com Add Monorail project when triaging an alert with an existing bug. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773,chromium:1113800 Tbr: nuskos@google.com Change-Id: Ieb31041460ec0935472c6f294c5c342645b9d915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389605Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599004657-692466066135c7d7137e03ca7609fab6b8e724c2.profdata to chrome-mac-master-1599025789-640f7b1f8708a3cc11acd7ca6b1de767d17f4a26.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6103bbedcaadeadbbb5d60d82e5b75db1a7691a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389606Reviewed-by:
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ie1a0515f544e0832181e85023cfae922df2ee430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382593 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#803794}
-
Joel Hockey authored
Rather than having CrostiniManager explicitly attach USB devices when termina starts, CrosUsbDetector can be a Concierge::VmObserver and do this for all VMs whether they are started by chrome, or by vmc. It also observes VmPluginDispatcherClient::OnVmStateChanged RUNNING to reconnect devices for Plugin VM. Moved USB functions from CrostiniManager to CrosUsbDetector since it is the only client and USB is not specific to crostini, but applies to all VMs. Bug: b/150341671 Change-Id: Ic14765d3b4d2911ae297b59ab5fbba7212c9957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386441 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#803793}
-
Abhijeet Kandalkar authored
This CL defines frame widget specific methods that will be invoked from the browser process to activate/deactivate the corresponding RenderWidget. Bug: 1071565 Change-Id: I2866536547d9b58fb6bd9559329e3d35b577748d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188013 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#803792}
-
Oleh Lamzin authored
Rename enumToCpuArch_ to cpuArchToString_ in trusted.js. Bug: b:158658869 Change-Id: I349e2c77c8943caa0f5f0fa37ffd86b0165c81be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389180Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#803791}
-
Oleh Lamzin authored
Rename some browsertest classes to start with TelemetryExtensionUI and end with BrowserTest. The benefit is that we can run all tests by using gtest filter "TelemetryExtension*". Bug: b:158566609 Change-Id: Id178ae867c145a7335da91fc54b011e5f3e3f551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388461Reviewed-by:
-
Oleh Lamzin authored
Remove telemetryInfo.cpuResult.cpuInfo.architecture from if statement, because architecture is a number and can be 0. Bug: b:158658869 Change-Id: Id0c064434b016175bc81849c6460fa352cb45dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387112Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/feb4151c5a11..e2e69a28bf78 2020-09-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie27226e58fe5d759c67f7621299dbe3cd6236816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389470Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fbcc21f83e83..6f5aa3945a7f 2020-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c0dda02196e8 to 6eeb3d8bf667 (8 revisions) 2020-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a2e6c1a149f4 to e1051cbaad46 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I5ddaac937ba25f3ef9851f1e54fd96ce5bb41fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389469Reviewed-by:
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/11eda3cc3e50..464928ed913b $ git log 11eda3cc3..464928ed9 --date=short --no-merges --format='%ad %ae %s' 2020-09-01 rharrison Add missing include patch 2020-09-01 tommek [spirv-writer] Generate sampler type Created with: roll-dep src/third_party/tint/src Bug=dawn:521 Change-Id: I16357b13d9a674ac97ac2399d8b3d926a9f69615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389262 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#803786}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f114a68b8f9b..5ffc1e1adb9b 2020-09-02 rharrison@chromium.org Roll third_party/tint/ 765348516..464928ed9 (3 commits) 2020-09-02 jiawei.shao@intel.com Remove Toggle LazyClearBufferOnFirstUse If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I916dca0b091f719836ead63102aa252f4d1ec763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389468Reviewed-by:
-
Amr Aboelkher authored
In that way, PSM libs are being supported on ChromeOS only. However, due to the current device_management_backend structure, PSM protos can be used by multiple platforms too. Bug: chromium:1124157 Change-Id: I0e9e6f2f2c55a5088ef1484262ada3f984ff5b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389202Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#803784}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26983dc7..52fe4c46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I693c709beb7bd92ea71b4010be6e9db0572e9cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388483Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803783}
-
Darren Shen authored
We currently uses a special key event struct designed for rule-based. However, we'll be adding a new input engine soon, which requires a more generic physical key event struct. To avoid duplicate code, share the same key event struct for both rule-based and the new input engine. Bug: 146314796 Change-Id: I995e14f9b497fdf52141fbcc9e5bcab0013bf831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371143Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#803782}
-
wutao authored
The new behaviors are: 1. When going to ambient mode page, keep user previous selection or auto-select Art if no album or selected album is deleted. 2. Click Art row will always select Art row. 3. Click any place of `Google Photos' (GP) row, will not change the selection status yet, but goes to the GP album-selection page. When user makes any change on GP album-selection page, we will either select GP row, or fall back to select Art row based on if any albums is available or un/selected. 4. Any actives on the album-selection page without first going to the ambient mode page, will trigger same behaviors as 2 & 3. 5. Click the topic source row and right arrow in that row will behave the same. Bug: b/161928422 Test: modified handler and js tests Change-Id: Id5b33ca9a7cd712c899091796cbab461e9970141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364167 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803781}
-
Devlin Cronin authored
The feature launched. Remove the flag. Bug: 1100412 Change-Id: I1aebaaae2cfd0fce078075d7ad771810b2f61df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386846Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#803780}
-
Devlin Cronin authored
A number of tests were running with both the legacy toolbar UI and the new extensions menu UI via test parameters. De-parameterize these, since the new UI has been launched for awhile. Bug: 1100412 Change-Id: Ie74b76b99ebcc553545b18907b2c1adb124e1048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387438 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I3ee09f723d34635a9baa46fe1f5f8ce7c585b276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389057Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I08656e92d07d07fea18f84f8c28c975068a7c1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389462Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05ce2817f2a0..fbcc21f83e83 2020-09-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0b89b27263b1 to 880013579381 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: I7e1c902fd120e9ac8a9ba56cff7c58fd55b9d0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389460Reviewed-by:
-
Peter Kotwicz authored
This CL: Adds to android_apk_or_module() template: - enforce_resource_overlays parameter to indicate that strict resource override checking is desired. The purpose is to enable landing this CL without breaking downstream. Adds to android_resources(): - resource_overlay parameter to indicate that the target overrides another target's resources BUG=1093825 Change-Id: I4229b343654f873c22c3e58bbbfd01209d9c880c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367352 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#803775}
-
Minoru Chikamune authored
Recent CL (https://crrev.com/c/2383406) made WakeLockTest.LossOfDocumentActivity test flaky. This CL will partially revert the change by using kForceWithoutContextObserver. Bug: 1123879, 1049056 Change-Id: I62fe7d185b857dbfda5b6a8edb5962661dc8c13e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389301Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#803774}
-
Joel Hockey authored
Terminal updated in crrev.com/c/2384669. Bug: 1114542 Change-Id: I467dec67e76d77f956352e8ce2299bfde599f5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384689Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#803773}
-
Chloe Pelling authored
(Does not apply to ARC++.) Maximizing a window typically resizes it, and resizing a non-resizable window can have undesirable results. This especially affects gaming. For many games, maximizing their "non-resizable" window causes them to render into the lower-left corner of the window but interpret mouse events relative to the top-left corner. This is bad enough on its own. It becomes especially confusing when a game allows the window size to become greater than or equal to the screen size, triggering XdgShellSurface's auto-maximize feature. Fix by disabling the maximize feature for non-resizable windows. BUG=b:163758346 Change-Id: If3e1c514f5c15094a284a518d18e4bbd6658cfb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377834 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#803772}
-
Jacques Newman authored
Adds histogram tracking time spent in the APIs tracked by the following enums: UMA_API_ELEMENT_PROVIDER_FROM_POINT UMA_API_GET_BOUNDINGRECTANGLE UMA_API_GET_PATTERN_PROVIDER UMA_API_GET_PROPERTY_VALUE UMA_API_NAVIGATE UMA_API_TEXT_RANGEFROMPOINT UMA_API_TEXTRANGE_COMPARE UMA_API_TEXTRANGE_COMPAREENDPOINTS UMA_API_TEXTRANGE_EXPANDTOENCLOSINGUNIT UMA_API_TEXTRANGE_FINDATTRIBUTE UMA_API_TEXTRANGE_FINDTEXT UMA_API_TEXTRANGE_GETATTRIBUTEVALUE UMA_API_TEXTRANGE_GETBOUNDINGRECTANGLES UMA_API_TEXTRANGE_GETCHILDREN UMA_API_TEXTRANGE_GETENCLOSINGELEMENT UMA_API_TEXTRANGE_GETTEXT UMA_API_TEXTRANGE_MOVE UMA_API_TEXTRANGE_MOVEENDPOINTBYUNIT UMA_API_TEXTRANGE_MOVEENPOINTBYRANGE AX-Relnotes: n/a Bug: 1118211 Change-Id: I9d1b7d552c2505490185917429c2e127078c49f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363722 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803771}
-
Meredith Lane authored
This change moves the state attribute serialization from BlinkAXTreeSource to AXObject to remove extra interfaces from WebAXObject. This patch should have no functional difference, it just a refactor. Bug: 1068668 AX-Relnotes: N/A Change-Id: I657d4bcf63523d6fe042893737c5ea8717f70d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336099Reviewed-by:
-
Emily Stark authored
Bug: 1097644 Change-Id: I913ad49ca0c9916a835cf2ee7df35330c78c6ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386097Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#803769}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/156bfc1f22a0..4e51400c4f05 2020-09-02 namhyung@google.com [systrace] Show absolute timestamp for selected slices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1122488 Tbr: sadrul@google.com Change-Id: Ic562419a327f7aa62e500e784006a28898859973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389054Reviewed-by:
-
David Black authored
HoldingSpaceImage will make use of the resolver to asynchronously fetch and cache a bitmap for the desired scale. This resolver is wired up to the HoldingSpaceThumbnailLoader to fetch thumbnails for HoldingSpaceItem file path. Bug: 1113772 Change-Id: I2a3a73b46f728f28fec955fd655f833f6c8e66c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388341 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803767}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/816506e1c600..000948ecdba8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic523e4a4a508164499f37eafa82134c369bb41b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389222Reviewed-by:
-
Bo Majewski authored
Exposes PDF thumbnailer to misc API. Uses it to fetch PNG bytes for a local PDF file. Alters MakeThumbnailDataUrlOnThreadPool to accept base::StringPiece. This allows the existing code path for drivefs thumbnails and the new code path to re-use it. Bug: 903742 Change-Id: I561d734a4d168c0ed96118decddab992d67889e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291914 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#803765}
-
chrome-untrusted://media-app/*Patti authored
dark_cros_styles.css, which contains the EA semantic colors for dark mode, was being shipped with the media app SWA package without being linked in the HTML. The fix for this was to dynamically link the CSS in index.ts instead, but this violates the existing SWA CSP. Fix by updating the CSP to allow styles sourced from the 'self' source, which should allow everything from chrome-untrusted://media-app/*. Bug: b/166688012 Change-Id: I1a141b324470586e02418c6aa872ca3800403a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379440 Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#803764}
-
