- 17 Mar, 2020 40 commits
-
-
danielng authored
Integrating the UI for Crostini mic settings (cl:2079718) into CrostiniManager. When mic sharing is enabled in the settings UI, CrostiniManager will hence forth allow Crostini to access the mic (this takes effect when Termina is restarted). This is all behind a flag currently, and the UI is based on PM mock-ups (see PRD here go/guestos-mic). Bug: 1016193 Change-Id: I3e0ac16032d1a8b88d91b829703ca166348759c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086359 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#750872}
-
Kai Ninomiya authored
This new isolate excludes blink/perf_tests and almost all of WPT, which are not needed to run these tests. This reduces the isolate size for our webgpu_blink_web_tests steps on CQ, reducing overhead on dawn-win-*-deps-rel from ~8min to ~2min. blink_web_tests: 36M net 920M out 92K testing 1511M third_party 2467M (total) -> 896M zipped webgpu_blink_web_tests: 36M net 920M out 92K testing 60M third_party 1016M (total) -> 272M zipped Bug: 1061273 Change-Id: I210e3a3ab279aa10144d402b4acd86548adb96bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101354 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#750871}
-
Kunihiko Sakamoto authored
This reverts commit 9b8ade13. Reason for revert: Suspected for CrostiniUpgraderBrowserTest.All failure on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4053 Original change's description: > Crostini Upgrader: Do not proceed if user cancels backup > > Previously if the user cancelled the backup, we would proceed with the > upgrade as though the user had elected not to backup at all. > > With this change, the flow will instead return to the initial screen > when the user cancels, rather than proceed. > > Bug: 1061203 > Change-Id: I7be99a2c7a6caa4b5fd143def5ba0c6f9b4d5004 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102935 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Commit-Queue: Nic Hollingum <hollingum@google.com> > Cr-Commit-Position: refs/heads/master@{#750833} TBR=nverne@chromium.org,hollingum@google.com Change-Id: I7013aeba5b114186425d4279b8ef877c2bddcb79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105664Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750870}
-
Jerome Jiang authored
Since encoder needs decoder, there is only 1 flag now for both. Bug: 1055917 Change-Id: If09ae1eddda2855371599718fda0b8f4372ab44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103318Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#750869}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/93f88af15b3c..2550e967241f git log 93f88af15b3c..2550e967241f --date=short --first-parent --format='%ad %ae %s' 2020-03-17 enga@chromium.org Fix OpenGL over-eager lazy zero initialization for textures 2020-03-17 enga@chromium.org Fix Vulkan over-eager lazy zero initialization for textures Created with: gclient setdep -r src/third_party/dawn@2550e967241f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I998101d7c83a2331c1c5316398b6396aca318021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750868}
-
S. Ganesh authored
Includes IDL changes and setup. Bug: 1053729 Change-Id: Ia36e527845c17784b761d7ec8bc5b6ee27c99d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106479Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Auto-Submit: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#750867}
-
Thanh Nguyen authored
Bug: 1061978 Change-Id: Ia656d1e96c16ae09d00aeb0eabc660b768f0d14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106037Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750866}
-
Jinsuk Kim authored
TabUma is an optional Tab UserData object that keeps track of tab restoring/state transition event, and collects relevant UMA stats. It's instantiated only for the Tab with a notable creation state or restoration results. And a new TabUma object is created every time tab restoration fails, and replaces the old one. With this CL, TabUma is always instantiated upon Tab creation and lasts till the tab goes away. This comes at a cost of having an instance doing potentially no actual work but has a few benefits: - TabCreationState doesn't need to be passed to Tab any more. TabBuilder instantiates TabUma and does the required initialization. - TabUma-related tasks can be moved out of Tab and confined within TabUma class itself using TabObserver events. Now the restoration result is passed to a single TabUma per tab through TabObserver. A new test was added to make sure tab state transition works as expected before and after the CL. Bug: 995903 Change-Id: I8f59bf52542325da06129f76a4a32229cdd9dbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087861Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#750865}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I13d481ca786243348a386bd6b85c27060d9ef0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107140Reviewed-by:
-
Dominick Ng authored
This CL de-extension-ifies ApkWebAppInstaller, and updates its tests to be run over both the extension backend and the new web app backend. BUG=1062145 Change-Id: I6277fc02873eb1b99101cf69eda57db9f332494e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106035 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#750863}
-
Koji Ishii authored
Following bot results are included. 1696 1697 1698 1700 1704 1706 1707 1708 1710 1711 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1736 1737 1738 1739 1740 1741 1742 18 lines were removed and 12 lines were deflaked by consecutive results since 1726. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I5becdff55e1644efb999c9dccd8889b77b9d40f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100429Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#750862}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d7d65c5e8ac..7fd33ba2dd8a git log 2d7d65c5e8ac..7fd33ba2dd8a --date=short --first-parent --format='%ad %ae %s' 2020-03-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@7fd33ba2dd8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibed47a90b337d622c7a4d215ad59a6f2f5d81054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106929Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/55bf4ea1..ae2152e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75e4c64648871a7d72f009dd7fe48103a9d69685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105777Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750860}
-
Kei Nakashima authored
This reverts commit 32f57805. Reason for revert: I mistakenly add a wrong file. Original change's description: > Added a function |InsertBefore| to NewLinkedHashSet. > > Implemented |NewLinkedHashSet::InsertBefore| and added test for it. > > Change-Id: I987a8c82c329565125d3a42f674b28d18e91ef38 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103015 > Commit-Queue: Kei Nakashima <keinakashima@google.com> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750825} TBR=yukishiino@chromium.org,haraken@chromium.org,bartekn@chromium.org,keinakashima@google.com Change-Id: I568bcc2ce4801c57e0e2b4f88f2be93d5e78d226 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106699Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Cr-Commit-Position: refs/heads/master@{#750859}
-
David Munro authored
Bug: None Test: crostini unit tests and browser tests Change-Id: I07aaa9e92881b522d0e533831b44ba13a46b59ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106036 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
-
Noel Gordon authored
Apparently the png was never created but its sha1 was, and that tricks ./translate.py (see bug). Remove the .sha1 file to untrick that tool. Bug: 1062142 Change-Id: I7e01ae2293ae6036118467e6eb29b6e7889043ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106700 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#750857}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d7a6643ddf5c..a58084c626ce git log d7a6643ddf5c..a58084c626ce --date=short --first-parent --format='%ad %ae %s' 2020-03-17 phoglund@google.com Make all values in the proto doubles. Created with: gclient setdep -r src/third_party/catapult@a58084c626ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: crouleau@google.com Change-Id: Ide05976a70ec5d1d59528335ca4b3eda7b00dcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106926Reviewed-by:
-
Andrew Grieve authored
Makes the tool easier to use, and easier to document how to use by not requiring it to be built first. We have only a single non-prebuilt .java file, so it's easy enough to just check in the .class file for it. Bug: 995290 Change-Id: I7b934b3337eccb044a470dd92270ce7338b1fd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106257 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#750855}
-
Daniel Hosseinian authored
Change the interface of PrintBackend::CreateInstanceImpl() to include a flag indicating that the backend is to be used for Cloud Print. The new interface PrintBackend::CreateInstanceForCloudPrint() passes |true| for the flag, but usage of the flag will follow in a future CL. The flag is necessary for runtime switching of the CUPS backend on macOS. Because cloud print is still configured to rely on PPD attributes, we want to still use the CUPS PPD backend over the CUPS IPP one. CreateInstanceForCloudPrint(), which will only be built and called on CUPS platforms, would ensure that the CUPS PPD backend is used. Bug: 226176 Change-Id: Ic9c376af9992bb70516d1de39da3c9666cff145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089987 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#750854}
-
Jing Wang authored
Removed the old setSetting/getSetting API. The new API now accept settings bundle instead of single entries so we can add type constraints on the values. The design doc: go/cros-ime-settings-migration The existing histogram values for getSetting and setSetting have never been used since the functions were not used in production code, so overwrite them with new api. Changes in input_method_private.js are auto generated by scripts. Bug Id: 1060906 TEST: tested with cl/298964323 on ChromeOS emulater. Change-Id: I2cd503d6acf696c0ad008f3894bf09f54e1a7531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099343 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#750853}
-
chrome://media-appTrent Apted authored
The `Save` operation in chrome://media-app started failing after r749464. Console errors like `createWriter` is undefined. r749464 tore out the old API and replaced it with a new one. Unfortunately, this only changed IDL files, and not the externs file that JS needs to compile against. This change updates the externs file to match the IDL file, making the regression detectable at compile time. Filed b/151394309 to investigate ways to detect when the externs file does not match the idl files and complain about it. The externs file is verbatim from cl/300232012. Bug: 1061813 Change-Id: I2de55447b640aec3338640db75a323a877beffde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103011Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#750852}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41b4ab193a14..d24752e63ae4 git log 41b4ab193a14..d24752e63ae4 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 jmadill@chromium.org Capture/Replay: Write to single binary data file. 2020-03-17 jmadill@chromium.org Re-enable optimization for angle_perftests. 2020-03-16 jmadill@chromium.org Move perf test common files to a source set. 2020-03-16 jmadill@chromium.org Refactor ANGLE common test utils. Created with: gclient setdep -r src/third_party/angle@d24752e63ae4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I4c603ea84a180d23f33557ba515846d999a2aa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106920Reviewed-by:
-
Matt Reynolds authored
When a USB device descriptor is read, a UsbDeviceInfo object is created with information about the device. This info is used to update the UsbDeviceInfo held by the UsbDevice object. However, some UsbDeviceInfo fields are not filled when the device descriptor is read and must be preserved from the original UsbDeviceInfo. This CL adds |guid| to the list of fields that must be preserved from the UsbDeviceInfo held by the UsbDevice object. BUG=1012862 Change-Id: Ib97c2e63155c432141fd57477687ca70bbfdd212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850414Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#750850}
-
Hsin-Yu Chao authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/2302d21944c8..3e21563e6e10 $ git log 2302d2194..3e21563e6 --date=short --no-merges --format='%ad %ae %s' 2020-03-12 hychao system_api: Modify dbus method name to SetNextHandsfreeProfile 2020-03-11 kimjae dlcservice: Expose Simple Polling Interface 2020-03-12 ahassani system_api: Add OWNERS file for dbus/dlcservice 2020-03-10 yhong system_api: fix comment in runtime_probe.proto 2020-03-10 kimjae Revert "dlcservice: Expose Polling Interface + Cache Memory Internals" 2020-02-26 hychao system_api: Add CRAS dbus API NextHandsfreeProfile 2020-02-28 kimjae dlcservice: Expose Polling Interface + Cache Memory Internals 2020-01-31 yichengli system_api: Add fingerprint-related definition to cryptohome protobuf Created with: roll-dep src/third_party/cros_system_api Bug: b/149188379 Change-Id: I11b43c6f7361ca88dcee1a3d6237888c1b73c0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100456 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750849}
-
Eric Willigers authored
WebAppControllerBrowserTest::SetUpOnMainThread() now starts its https server, avoiding the need to start the server in each test case. The http server and cert verifier in CustomTabBarViewBrowserTest are retired, as this functionality is already provided by WebAppControllerBrowserTest. Change-Id: I67bcd661bca0ed647d3b2e9c8efa2217f19978cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089441 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#750848}
-
Johann authored
Use the HeapMojoReceiver wrapper so that Oilpan will GC the object. Bug: 1049056 Change-Id: I99903ff70a9fe8f4c17cda12b5390c148b6c1960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105658Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#750847}
-
Anand K. Mistry authored
Native SMB integration is in active development, and other NativeSmbFileShare.* metrics are set to expire in M85. Bug: 1053060 Change-Id: I4297071694c8ff4173cf2a6aa972f5b3dbd718df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101397 Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#750846}
-
Alexander Cooper authored
Creates interfaces for BrowserXrRuntime to be consumed by classes that will remain in chrome/. This updates existing usages that will no longer be able to access the BrowserXRRuntimeImpl class to use the public interface (primarily this is everything outside of vr/service). Note that although right now BrowserXRRuntimeImpl lives in chrome/, it will soon be moving to content/, once the remaining dependencies for the rest of vr/service have been broken (so as to avoid over-exposing methods needed by these classes to talk to each other). Currently the only way to get a BrowserXRRuntime is via the XRRuntimeManager. While some of the XRRuntimeManager methods will be moved to a public interface in future changes, it will still only be possible to get an XRRuntimeManager (and therefore a BrowserXRRuntimeImpl) in chrome/ until the move actually happens. Bug: 1031622 Change-Id: I42e1cfd18842166ce1f8eeaa6003d7f84e52aef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103305 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#750845}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/34d90bebd8ba..c99efb2f8c62 git log 34d90bebd8ba..c99efb2f8c62 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 sokcevic@google.com Add gerrit_client unit tests Created with: gclient setdep -r src/third_party/depot_tools@c99efb2f8c62 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6fb8feb07ab115021510fc6c1594a888ae6836b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106914Reviewed-by:
-
Avery Musbach authored
All/SplitViewOverviewSessionInClamshellTest.ResizeWindowTest/? All/SplitViewOverviewSessionInClamshellTest.CloseWindowWhileResizingItTest/? All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.WindowResizingPerformanceHistogramsTest/0 Test: ash_unittests Test: ash_unittests Test: ash_unittests Bug: 1059477 Change-Id: I799bdc89d58e9ed4df5a1e74f9b40c48c7b82908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100890Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I9988634f003ace728c7380837c6fdd858c7622a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106657Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750842}
-
Luciano Pacheco authored
This fixes the visual glitch when opening Files app a vertical scroll bar would "blink" in the right hand side of the action bar. Fixed: 1061848 Change-Id: Ifa39df13497ebf63bfd2bd7e84bd8a6ba25d010c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105659 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
There are a couple of callsites of the method outside tab package: ReparentingTask and TabModelSelectorImpl. They are always used by ChromeActivity or one of its child Activities(CustomActivity), therefore the checking the detached state is as simple as checking the nullity of the associated WindowAndroid. This CL replaces the callsites with an expression evaluating the nullity. The only callsites left are within the tab package, so the method can be package-private. Bug: 995903 Change-Id: Ic30a0a4647d582e0a1b26f7ac0319a8b078d75af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101412Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#750840}
-
Daniel Murphy authored
Prerequisite work to avoid annoying lint errors. R=loyso@chromium.org Change-Id: I4495933115f833c0723473b24da3c39afa4a587e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106344Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9170376d36ad..1aa882626c3d git log 9170376d36ad..1aa882626c3d --date=short --first-parent --format='%ad %ae %s' 2020-03-17 btolsch@chromium.org Add first CastSocket E2E test Created with: gclient setdep -r src/third_party/openscreen/src@1aa882626c3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I80e103a4245c7cd44bd15f2e7688309d197f9863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106919Reviewed-by:
-
Katharine Daly authored
In the event that an admin configures a secure DNS policy that breaks DNS lookups, users should be able to fetch a replacement policy. Bug: 955454 Change-Id: I33381560a2166b55f1939fac4f59a267d29a5eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106413Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#750837}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f66f59d1fe63..0ad56875dec9 Created with: gclient setdep -r src-internal@0ad56875dec9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I86debc31e44d5ec95ed1ba2f92f931cbbcd17740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106764Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750836}
-
Ken Rockot authored
This adds a config entry for the experimental group in the first stage of the out-of-process Storage Service rollout. Bug: 1057802 Change-Id: I2d638fd881d0b8a39d80202278cafdd56eccbfaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106756Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#750835}
-
Hwanseung Lee authored
The AndroidSetupSearchEngine feature is enabled by default and the config has no effect anymore. Therefore, remove the config and every reference to AndroidSetupSearchEngine. Bug: 1057939 Change-Id: I5e395d7ed031d93b64d4ae9d012f72351b0dec22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102032Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#750834}
-
Nicholas Hollingum authored
Previously if the user cancelled the backup, we would proceed with the upgrade as though the user had elected not to backup at all. With this change, the flow will instead return to the initial screen when the user cancels, rather than proceed. Bug: 1061203 Change-Id: I7be99a2c7a6caa4b5fd143def5ba0c6f9b4d5004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102935Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#750833}
-
