- 06 Mar, 2020 40 commits
-
-
Greg Thompson authored
Code that uses GoogleTest assertions without using GoogleTest itself will result in calls to CurrentStackTrace without a preceding call to UponLeavingGTest. Make this easier to diagnose with a DCHECK. BUG=1039559 Change-Id: Id80aa918f2197625ec4b1025a99d778aed46c1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090413 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747635}
-
Wei Lee authored
Bug: b/149454553 Test: build pass Change-Id: I52f43b01e277ce4287b11e9cd982dc44dc37b930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089131Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#747634}
-
Mario Sanchez Prada authored
This CL starts converts the message that tells the renderer to reset and send a new accessibility tree from scratch because the browser is out of sync. Bug: 1010831 Change-Id: I38ba5d23d9ae4ad6e8ae4850e0538215db50dc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028768 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#747633}
-
Ulan Degenbaev authored
Currently workers send IsolateInBackgroundNotification to V8 signalling that memory usage is more important than performance. However there are use cases where workers are used for user visible computation and thus are performance critical. This flag will allows us to do a Finch experiment to see how overall memory metrics are impacted. Bug: 1049132 Change-Id: I99e26f36ff10a864a05eb6f30b5d8a62e99e3dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088515 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#747632}
-
Oriol Brufau authored
The logic for placing a grid item with both an integer and an identifier in a placement property was interacting wrong with auto repeat() tracks. This patch uses the same proper logic that was already implemented in OrderedNamedLinesCollectorInGridLayout::CollectLineNamesForIndex BUG=966090 TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-004.html Change-Id: I042ce1fd77a79959240d272d96eac21f06e014ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082917Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#747631}
-
Gauthier Ambard authored
When a session is restored, the restored NavigationItems have all the information of the restored items, including scroll offset, user agent... But the items were only used for their URL and all the other information were lost. This CL fixes that by storing those items until the restore is complete. At this point their information can be restored in the items associated with the WKBackForwardItem. For now those information aren't used with kEmbedderBlockRestoreUrl disabled. Bug: 771200 Change-Id: Ic04f3eb0a893899acfcfdd46b33c950b2a8e71e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061151 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#747630}
-
Stephen Nusko authored
Revert "Roll src/third_party/dawn 2de34c1791f3..56f1678437ba (2 commits)" and "Roll src/third_party/dawn 56f1678437ba..1d54767364a8 (1 commits)" This reverts commit d7a644ca & 9031851e Reason for revert: d7a644ca causes dawn_perf_tests to crash crbug/1059205 Original change's description: > Roll src/third_party/dawn 2de34c1791f3..56f1678437ba (2 commits) > > https://dawn.googlesource.com/dawn.git/+log/2de34c1791f3..56f1678437ba > > git log 2de34c1791f3..56f1678437ba --date=short --first-parent --format='%ad %ae %s' > 2020-03-05 david.turner.dev@gmail.com Vulkan: Enforce fixed subgroup size for compute shaders. > 2020-03-05 david.turner.dev@gmail.com Vulkan: Report and enable subgroup size control device extension. > > Created with: > gclient setdep -r src/third_party/dawn@56f1678437ba > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > Bug: None > Tbr: cwallez@google.com > Change-Id: I9f48a7973e626b96d1088b0b916745f02c70769b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090072 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747337} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1059205 Change-Id: I166b36e0d45492ece6e39309b30be9733295d81b Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089703Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747629}
-
Kamila authored
Added "crowd_deny_hold_back_chance" parameter, for the upcoming experiment stage http://cl/297812954. Bug: 103202 Change-Id: I26fb790cb1a4a61ec555b4a20049a7bf57f9ff00 TBR: mpearson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089731 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#747628}
-
Ulan Degenbaev authored
This removes - V8MemoryReducerForSmallHeaps - V8HugeMaxOldGenerationSize - kV8GCBackgroundSchedule - kV8GCLessCompaction - kV8GCAlwaysPromoteYoungMC Bug: 933107,958974,966832,1014943 Change-Id: Id7bebc72a0c8c6ecbb0ef2eb44339a0dcfbb5a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089758Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747627}
-
Rushan Suleymanov authored
This patch removes obsolete code which checks that bookmark_node is created. CreateBookmarkNodeFromSpecifics guarantees that the node will be always created. Bug: 1050776 Change-Id: I786e061644928548b859c38cb8ddf3550234503d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089736Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#747626}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5415e4d9aec4..ae9641b6d8b4 git log 5415e4d9aec4..ae9641b6d8b4 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 70eb5f7c..4dc8a310 (747482:747587) Created with: gclient setdep -r src/third_party/webrtc@ae9641b6d8b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id7a6b93c8fa816ea663f7277545561eaf599a9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091047Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747625}
-
Simon Que authored
This is a reland of 765c53e1 Original change's description: > infra: Migrate builders to Goma RBE (iOS Week 1a) > > These are the two builders in webrtc.fyi: > - WebRTC Chromium FYI ios-device > - WebRTC Chromium FYI ios-simulator > > These builders are small. They are expected to have a peak traffic of > 15 QPS: > https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=1721756715 > > Schedule of migration: > https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 > > R=agable@chromium.org, bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org > > Bug: 950413 > Change-Id: Id47cc7887bbefaf4dfe9f72275b80c8f04c428a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043185 > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: smut <smut@google.com> > Commit-Queue: Simon Que <sque@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739771} Bug: 950413 Change-Id: Id3ffe0babda0e347bd80dce0c253d93c5ad29946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089176Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#747624}
-
Jan Wilken Dörrie authored
This change implements PasswordCheckDelegate::OnCredentialDone, resulting in adding found leaked credentials to the password store if there is a matching saved password. Bug: 1047726, 1049193 Change-Id: I5c4b75d2a4cf1b46374d83adfc87da3a1f8eabdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087682 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747623}
-
Jérôme Lebel authored
-[<SettingsControllerProtocol> viewControllerWasPopped] was last used by ManageSyncSettingsTableViewController and removed in patch: Related to crrev.com/c/2088516 This method can be removed now. Fixed: 1055782 Change-Id: Id41898bd9b16dac24816dbe8db5ceb0d59f5773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089811 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#747622}
-
Colin Blundell authored
This CL moves knowledge of the //chrome-level IntentHandler out of ExternalNavigationHandler.java. This dependence is to set //chrome-level extras on the intent (and set state of IntentHandler itself). We abstract this functionality through ExternalNavigationDelegate, following the pattern of similar already-existing delegate methods. Bug: 1031465 Change-Id: I0301abdcf045dfdada1506cf5f14dd7c98315f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087404 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#747621}
-
Mei Liang authored
This CL enables Grid Tab Switcher for TalkBack for HighEnd Phone. Change-Id: I06afbd2dc4649db56b8fa2dd16b505e8c9bb64f7 Bug: 1019489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982241Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#747620}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9acaf6626042..1a41937a5321 git log 9acaf6626042..1a41937a5321 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 044ecc0b2c65..66a682b6a8f9 (1 commits) Created with: gclient setdep -r src/third_party/angle@1a41937a5321 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I8c15ac304f8bc5e75bdb295ccf78aa96c40da887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091046Reviewed-by:
-
Keita Suzuki authored
This commit replaces the original pywebsocket with pywebsocket3 on //net tests, and removes any deprecated features. This also tweaks some of the websocket handlers that used the old API to use new ones. Change-Id: I6b77d0ed524c3ff279aa659b2ca6c4048e5da95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Keita Suzuki <suzukikeita@google.com> Cr-Commit-Position: refs/heads/master@{#747618}
-
Marc Treib authored
Bug: 1054367 Change-Id: Ibb282217b3ac905d107035b020cbed1a33103cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089752 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#747617}
-
Mario Sanchez Prada authored
This CL starts converts the message that relies a request from assistive technology to the render, in order to perform an action such as focusing or clicking on a node. Bug: 1010831 Change-Id: I54f5088b1c85de66dd3429709c188de6e62cc4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030175Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/da7fe17f810a..7e47609cf293 git log da7fe17f810a..7e47609cf293 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 pmuetschard@google.com Adds a LAST_NON_NULL window function to the trace processor. 2020-03-05 ddrone@google.com Merge "Reusing one ProtoToArgsTable instance" 2020-03-05 taylori@google.com Merge "perfetto-ui: Fix counter quantization" 2020-03-05 ilkos@google.com Add anon RSS + swap to the java heap stats metric 2020-03-05 hjd@google.com Merge "Add AndroidProcessMetadata to startup metrics" 2020-03-05 ddrone@google.com Merge "Add more fields to ChromeLatencyInfo" 2020-03-05 skyostil@google.com Merge "TrackEvent: Add TrackEvent::GetTraceTimeNs()" Created with: gclient setdep -r src/third_party/perfetto@7e47609cf293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:150675972 Tbr: perfetto-bugs@google.com Change-Id: If5ce17e700cdc9c10ebf0bea9f47a1685c9599af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091044Reviewed-by:
-
Eriko Kurimoto authored
This CL lets SharedWorkerGlobalScope inherit outside settings CSP when response url's scheme is a local scheme. This behavior is defined here: If response’s url’s scheme is a local scheme, or if global is a DedicatedWorkerGlobalScope: ... - Insert a copy of policy into global’s CSP list. https://w3c.github.io/webappsec-csp/#initialize-global-object-csp Bug: 1056161 Change-Id: I2a41a91bf021f5dda55303dece0d49163dc7c822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082855 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Jose Lopes authored
This is a once callback because it is run to indicate the completion of the RequestEncodedFrame method: * https://cs.chromium.org/chromium/src/media/cast/cast_receiver.h?rcl=dbfabe22380e821376c625ccabce8cc92e1c4b2b&l=43 * https://cs.chromium.org/chromium/src/media/cast/receiver/frame_receiver.h?rcl=dbfabe22380e821376c625ccabce8cc92e1c4b2b&l=62 This callback is placed in a queue by RequestEncodedFrame in: * https://cs.chromium.org/chromium/src/media/cast/receiver/frame_receiver.cc?rcl=dbfabe22380e821376c625ccabce8cc92e1c4b2b&l=80 And it is extracted from the queue in: * https://cs.chromium.org/chromium/src/media/cast/receiver/frame_receiver.cc?rcl=dbfabe22380e821376c625ccabce8cc92e1c4b2b&l=281 And passed to EmitOneFrame to be executed once in: * https://cs.chromium.org/chromium/src/media/cast/receiver/frame_receiver.cc?rcl=dbfabe22380e821376c625ccabce8cc92e1c4b2b&l=301 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Iaaaa1b830c5f8e65a94124233d28614e36c8f1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077994 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#747613}
-
Armando Miraglia authored
To aid debugging issues regarding cameras that do not work well with MediaFoundation on Windows, we are exposing a flag in about://flags to be able to help users verify that disabling MediaFoundation gets the affected camera to work. Fixed: 1048805 Change-Id: I8fce344acb98eec48b8b0c062c94a7cf28baafca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087911 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#747612}
-
Ben Joyce authored
browser/browsing_data/ClearBrowsingDataTabsFragment.java and browser/firstrun/FirstRunViewPager.java need androidx.fragment to update first. Bug: 1052460 Change-Id: I6544c460c608b8c06b9ecf1fa5ffabf91c654103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089148Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#747611}
-
Koji Ishii authored
Manual maintenance due to crbug.com/1056508 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I5827006b6136d7a31a8bf9ed99af090b2a0978e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090817Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#747610}
-
Jose Lopes authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I794495614c086cef21f5c9fd75fa8599bf04e1da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087212 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#747609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2d7afd7f7c6..7ee8f43f7f37 Created with: gclient setdep -r src-internal@7ee8f43f7f37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I37d1df3feb6fe5a8397d4a5c3fa063e46e688087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091038Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747608}
-
Eric Willigers authored
The ChromeNavigationBrowserTest method StartServerWithExpiredCert() is never used. The method, and the xpired_https_server_ member, are now removed. test_ukm_recorder_ is now private with a public getter, instead of the unique_ptr itself being public. Change-Id: Ibdd236742f6ec418fbad8071310340c4eb007ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087303 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#747607}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c6a4c6d3d8b5..aa95c80e1a89 git log c6a4c6d3d8b5..aa95c80e1a89 --date=short --first-parent --format='%ad %ae %s' 2020-03-06 johnkslang@users.noreply.github.com Merge pull request #2100 from travisfoo/master 2020-03-06 johnkslang@users.noreply.github.com Merge pull request #2098 from jeffbolznv/debugprintf Created with: gclient setdep -r src/third_party/glslang/src@aa95c80e1a89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ie8ac17c898c8c3bad14f2e15066e4569a724269d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091043Reviewed-by:
-
Andreas Haas authored
This reverts commit 88941a9c. Reason for revert: I reverted the CL that caused this issue in https://crrev.com/c/2078544. We can re-enable this test Original change's description: > [Sheriff] Disable PDFAnnotationsTest.AnnotationsFeatureEnabled > > on all chrome os. > > TBR=thestig@chromium.org > > Bug: 1056295, 920684 > Change-Id: Ic5b6e0fc7fff5427e2a7c72ad49077713e1a7937 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075082 > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> > Cr-Commit-Position: refs/heads/master@{#744756} R=thestig@chromium.org,parastoog@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056295, 920684 Change-Id: Ie2c8409015ce85379ca5f0efe6e5e935ef66bd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087215Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#747605}
-
Maggie Cai authored
The test virtual/form-controls-refresh-disabled/fast/forms/autofocus-opera-008.html is failing on Mac10.11 Tests build. BUG=1058754,1058203 TBR=tkent@chromium.org Change-Id: I90c794db04f92713b6f59d12e332dbfdda8b40aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089560 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#747604}
-
Andreas Haas authored
This CL is a preparation to remove |ArrayBuffer|, |ArrayBufferView|, and |TypedArray| und to use only |DOMArrayBuffer|, |DOMArrayBufferView|, and |DOMTypedArray| instead. At the moment |ArrayBuffer| manages a list of |ArrayBufferViews|. This list should either move to |DOMArrayBuffer|, or get removed. With this CL we guarantee that for every |DOMArrayBufferView| there exists a |DOMArrayBuffer|, so that in a follow-up CL we can move the or remove the list of views. R=haraken@chromium.org CC=ulan@chromium.org Bug: chromium:1008840 Change-Id: Iaeabd9fc62e025df5ae4f7000b606cf2da49dde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089857Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 727f2393. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I3dd6f09f7b03fd9589eefb2d3e5a9f602a86ce92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090513Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747602}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/35cb0b3a4697..93a2a6b8badb git log 35cb0b3a4697..93a2a6b8badb --date=short --first-parent --format='%ad %ae %s' 2020-03-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c55fbc4064aa..9acaf6626042 (5 commits) 2020-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7c474dc8..da581c3b (457 commits) Created with: gclient setdep -r src/third_party/skia@93a2a6b8badb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I9f6bd9d0aa93ed5df8ded06320a6a0932622cf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091036Reviewed-by:
-
Kenichi Ishibashi authored
The fix (crrev.com/c/2078521) seems to be working. Enable the test. Bug: 946719 Change-Id: Idc66d61775eabb5867df6a00eb3998547fe9cdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091096Reviewed-by:
-
Hitoshi Yoshida authored
- Define NativeValueTraits<IDLNullable<DOMArrayBuffer>>'s body - Use NativeValueTraits to convert IDL dictionaries in tests - Replace a setXxxToNull to setXxx - Define V8SetReturnValue for bindings::DictionaryBase Bug: 839389 Change-Id: I672bdf0bd9b5bf6e6a0b8d3b910d5712f4476cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087243Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ye Kuang authored
This is to roll https://crrev.com/8803e5127f5b83ecc4bfb9ad86a28abeaa4ef443 Fixed: 1058286 Change-Id: I56aaf35bc93932294f4f18b51924669142f3f9e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089556Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#747598}
-
Stephen Martinis authored
I found this while looking at the #include dependency graph for browser_tests. I would guess these all got added when they got de-virtualized; https://crrev.com/c/854747 was one such CL, and it looks like they copy pasted a lot of the code, which probably meant the self includes were accidentally added. Change-Id: Ib0556461c118ce2d3698953955735391484616b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090911Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#747597}
-
Xinghui Lu authored
Metrics added in this CL: SafeBrowsing.RT.GetToken.Time SafeBrowsing.RT.HasTokenFromFetcher SafeBrowsing.RT.HasTokenInRequest SafeBrowsing.RT.IsLookupSuccessful Bug: 1041912 Change-Id: I34a0d9cc07f54f76f441e2ff130c59da0b070813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088683 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#747596}
-
