- 17 Oct, 2019 40 commits
-
-
Matt Reynolds authored
This CL adds a HidConnectionWatcher client interface for observing whether a HID connection is still open. When the connection is closed, the HidConnectionWatcher's pipe is also closed. In a future CL, this will enable HidService to track the number of open connections to HID devices for the purpose of showing a tab indicator when there are open connections. BUG=1007539 Change-Id: I2349e3169c58f1b9477b13d840b03643622500f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823980Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#707136}
-
Joshua Peraza authored
This reverts commit 2ee50cc5. Reason for revert: Breaks clusterfuzz because of missing ssl deps Original change's description: > Update Crashpad to 47a342133d60018f2ffda0037ffe2b5f0d3f7482 > > 2fb4e9e6a432 mac: Update the process_types version of > dyld_all_image_infos for 10.15 > c009b85449cb Use GTEST_SKIP() instead of custom DISABLED_TEST() > d8f85829b07b linux: fix split stack test > 7289acb78a6d linux: don't assume vdso exists > 47a342133d60 linux: use boringssl in chromium > > Change-Id: If4718ea7220543c3ca10bc3f7d123ac330625461 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863255 > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707107} TBR=jperaza@chromium.org,mark@chromium.org Change-Id: Ia4335007735e1a51ba72d2eb177f780a0db09430 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867475 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#707135}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/65adcb504d02..9bd9f4b3ed64 git log 65adcb504d02..9bd9f4b3ed64 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 9856269+sarahM0@users.noreply.github.com spvc parser for a trivial shader (#839) 2019-10-17 rharrison@google.com Rolling 5 dependencies and update known_failures & known_invalids (#840) 2019-10-17 dsinclair@google.com The glslang-testsuite is moved into glslang. (#838) Created with: gclient setdep -r src/third_party/shaderc/src@9bd9f4b3ed64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I2d0e402ce515e4e5f9a7ca1c8dc0234e38d7717a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707134}
-
Steven Bingler authored
Add metric to track SameSite cookies set which cross schemes http-to-https and https-to-http, as seen as site-for-cookies from response and which are Lax or Strict. Added histrogram to track number of SameSite cookies set with Lax or Strict in the response. Change-Id: I14668cc9ddf334b7b575e0199e407e389133de78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867205 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#707133}
-
Lan Wei authored
This reverts commit 82f9896f. Reason for revert: OverviewSessionWithDragFromShelfFeatureTest.TapOnBackgroundGoToHome is failing on linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel Original change's description: > [reland] In tablet mode, tap on overview background should go to home screen. > > Clamshell mode behavior will remain the same, i.e., tapping on the > overview background will return to its previous state, it can either be > in-app or home screen. > > Bug: 997885 > > Change-Id: I2dae82657d4d92876c834c78dd62d53830fbe6cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865264 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#707036} TBR=xiyuan@chromium.org,xdai@chromium.org Change-Id: I5dd88e82ecb8d5c3772be87fb749c3da88ba6d08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867472Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707132}
-
Patrick Monette authored
This allows to tell apart 2 different shared workers that have the same url, name and constructor origin. This is possible when the script url and/or the constructor origin have file: scheme. Also removed the SharedWorkerInstance::Match() overload that takes in a SharedWorkerInstance to make it clear we're not comparing 2 instances. Bug: 1013168 Change-Id: I7a0efbfd71dae283ecfc97f3ae87df69a0fb5695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850832Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#707131}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 04fbda1c. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 40e4a155 "Reland "[Trusted Types] Remove TrustedURL."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia8fa99b67039f0b3d7517fb96f5ca5bf482637af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866703Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707130}
-
sczs authored
- Configures the CreditCard Banner for presentation. - Implements Banner related methods like performInfobarAction and dismissBannerWhenInteractionIsFinished. - On InfobarCoordinator detachView (which is called when the Infobar view needs to be removed) we only dismiss the VC if they have been created. This is needed since now a CreditCard InfobarBanner can be created while other one is being presented, since replace is not supported it will discard the new Infobar, thus calling detachView in an Infobar that was never presented. Screenshot: https://drive.google.com/open?id=1bmPWLDNIEsJYORx8YfOs82wsYUKdoXcN Bug: 1014652 Change-Id: Icd50ed542743054b38924fba668c42f38dbcc7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865445Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#707129}
-
Garrett Beaty authored
Bug: 1011908 Change-Id: If7135dc07a320e104f997ed5780bde7d5263c886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866852Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#707128}
-
Yusuke Sato authored
Previously, the ARC start and upgrade functions in the adapter interface had two issues: * They used structs in arc.proto that were in the login_manager:: namespace although the interface is both for ARC container and VM. * Parameters for upgrade were converted from the platform-neutral one (UpdateParams in arc_session.h) into the platform specific one (arc.proto) too early in arc_session_impl.cc. This CL fixes both issues by removing arc.proto usage from everywhere but arc_container_client_adapter.cc. BUG=b:142144019 TEST=ran the unit tests + arc.Boot Change-Id: I6b14631af8a3f24f879a037df0b0c289845edf95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854465 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707127}
-
Alex Turner authored
While there are currently per-ad frame CPU usage metrics, it is difficult to measure the overall CPU usage of ads on a page. This adds a UMA histogram that tracks the sum of the ad frames' CPU usage, which is a topline metric that would allow for a better understanding of the resource impact of ads on the web. Bug: 1004815 Change-Id: I97e91b35ec75bc01bb4475375d2573928450fe34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853104Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#707126}
-
Christopher Cameron authored
Detect HDR support using the -[NSScreen maximumPotentialExtendedDynamicRangeColorComponentValue] API introduced in 10.15. Use the hard-coded kDefaultBitsPerPixel/Component constants instead of reading from the NSScreen. Move the constants to a common location. We can only promote an IOSurface to an overlay if we can set the color space on the IOSurface in a way that will make CoreAnimation draw it the same way that GLRenderer would. Merge the various checks for color space compatibility into an IOSurfaceCanSetColorSpace function, and call this from the SDR and HDR paths. Update IOSurfaceSetColorSpace to use the new constants kCGColorSpaceITUR_2020_PQ_EOTF and kCGColorSpaceITUR_2020_HLG introduced in 10.15. Note that this will not trigger HDR mode. Doing so requires making visible a CAMetalLayer with wantsExtendedDynamicRangeContent set. The next patch in this sequence will do that. Bug: 976426 Change-Id: Ic93302aa895f182713658f1eaea89c0e91953857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863449 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#707125}
-
Scott Little authored
The save-data WebAPI holdback is intended to only holdback the JS API and the save-data request header, so this CL makes automatic LazyLoad ignore the state of this holdback. Bug: 1014640 Change-Id: Idead68187789425645ae10ff2b38a8c2cf1245fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867093Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#707124}
-
Mirko Bonadei authored
WebRTC is trying to enable the support for the component build and when is_component_build=true some Chromium targets fail to link because they were relying on WebRTC to link with some .frameworks. Bug: webrtc:9419 Change-Id: I064289025aa7eab7cb5008d9d9ae71a013119c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865330Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707123}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/bc4c09df6416a3a0d0cf321c6c13023c77e2fec4..76918d016414bf1d71a86d28239566fbcf8aacf0 Bug: none Change-Id: Ib459c4fc16d6bf1b8c7147d0efa16d48ecc5a9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864322 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e2416ee17a9..74af4241e484 Created with: gclient setdep -r src-internal@74af4241e484 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:996372,chromium:None,chromium:913074,chromium:None Change-Id: Ic741b769b6fac9944b8a8cccab7cb0d84ce14dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867135Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707121}
-
Michael Spang authored
This reverts commit 6983e9fa. Reason for revert: Uses X11 headers outside X11 builds & thus Breaks Chromecast build Original change's description: > X11 and Ozone: Move static methods to DWTHLinux. > > At first, I wanted to remove these static methods, but then decided > to keep them and remove later when we no longer need them. > > Bug: 990756 > Change-Id: If6132986e25bb1c8712acdbc90ce29093616bff7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860341 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#705946} TBR=sky@chromium.org,thomasanderson@chromium.org,msisov@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 990756 Change-Id: I87deff065e2f0badc8a88feff1e6a30b42799c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867019Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707120}
-
Christopher Cameron authored
Documentation of -[CAMetalLayer setWantsExtendedDynamicRangeContent:] reads as follows. If any rendering context on the screen has this enabled, all rendered content is clamped to the screen’s maximumExtendedDynamicRangeColorComponentValue value rather than 1.0. This indeed does what it says. The exact incantation under the covers is unknown. I had previously guessed that setting IOSurface's color space to an HDR color space would do the same trigger, but it does not. This method privately exists on the CALayer base class. To ensure that this is triggered appropriately, track whether or not any IOSurfaces that we are using as CALayer contents are tagged with an HDR color space. If so, set setWantsExtendedDynamicRangeContent to YES on the root layer. Add tests verifying this behavior. Of note is that if the HDR layer is not promoted to an overlay, then the buffer that we render it in to will not be appropriately allocated as HDR-capable, and so the HDR content will end up being clipped. Bug: 976426 Change-Id: Ib389f1c36d39950ddd06beea5320e5f1890b73a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863689 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#707119}
-
Gil Dekel authored
This CL fixes a DCHECK failure (exposed by ClusterFuzz) when attempting to create an cc::ImageHeaderMetadata via ImageDecoder::MakeMetadataForDecodeAcceleration when DeferredImageDecoder::PrepareLazyDecodedFrames is executed for the first time with an underlying invalid image. Bug: 1014047 Change-Id: I027d0649a775fb854079cedaab6522397e537fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863376 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#707118}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a2b2fc8164dc..b97e8677d349 git log a2b2fc8164dc..b97e8677d349 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 saklein@chromium.org call_templates: Dump a deprecated parameter. 2019-10-17 dburger@chromium.org Do not pass gclient path for sync_chrome, get from $PATH. 2019-10-17 vapier@chromium.org lkgm_manager: switch to git.Log 2019-10-17 saklein@chromium.org sdk service: Skip toolchain upgrade when no board given. Created with: gclient setdep -r src/third_party/chromite@b97e8677d349 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibf70aaf11fe87a1c080d84467b129330ff270560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707117}
-
Lily Chen authored
This change adds a CookieAccessSemantics field to the cookie change notification interfaces, such that the access semantics of a cookie at the time of the reported change can also be included in the change notification. The CookieAccessSemantics is used to determine whether a cookie should be treated according to "legacy" rules, based on a policy setting. It affects whether the cookie may be included on a given request, and some cookie change consumers care about this because they check whether the cookie change should be observed based on whether it would have been included on a request. This is accomplished by bundling the changed cookie, the CookieAccessSemantics, and CookieChangeCause into a new struct, CookieChangeInfo, and passing a CookieChangeInfo along to notification subscribers. This change should not produce any behavior change for consumers who don't care about the CookieAccessSemantics, which is most of them, for which this will just pass them an extra parameter that they don't need. The places where behavior changes are in the CookieStore API (CookieChangeSubscription::ShouldObserveChangeTo), the RestrictedCookieManager::Listener (OnCookieChange), and CookieMonsterChangeDispatcher::Subscription (DispatchChange), where now the call to CanonicalCookie::IncludeForRequestURL is able to pass the CookieAccessSemantics in order to properly compute whether the cookie change should be observed. TBR=khorimoto@chromium.org Bug: 978172 Change-Id: I712972391ff0adcc4b94481bba156dc0e7b759a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854649Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#707116}
-
Sammie Quon authored
Test: added test Bug: 1012879 Change-Id: Ia78f06bddf0cd85ec00e76ddd7111537d03788d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865988Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#707115}
-
rajendrant authored
Lazyload should be disabled in incognito as the other LiteMode features Bug: 1014144 Change-Id: Ifeb03f0aec081f7adf25b6474d0ded3a6a929ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863758 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#707114}
-
Hesen Zhang authored
- Remove the small icon in before edit text. - Move down the error messege under edit text. - Change the color to dark red when error dialog shows. - Change extension dialog messages. Bug: 1012450,952425 Change-Id: I9a8d47121025058bdca44c4b461d20305d6c1396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865663 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707113}
-
Jonathan Backer authored
This is consistent with InProcessCommandBuffer::MakeCurrent() and CommandBufferStub::MakeCurrent(). TBR=boliu@chromium.org Bug: 1011420 Change-Id: I3179d229c45b5dc27586cdddfe757596d1b85ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866606 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#707112}
-
Clark DuVall authored
This reverts commit cf1e154f. Reason for revert: Failing weblayer_browsertests Original change's description: > [WebLayer] Load pak files correctly on Android > > Loading pak files was not quite working right in weblayer, since we were > not loading locale paks. This caused text on e.g. submit buttons to not > show up in some configurations like loading from monochrome. > > This change makes weblayer load pak assets similar to webview, and > uses the webview pak deps for the weblayer support APK, since those > should be sufficient for weblayer. > > As an added bonus this also allows l10n to work, so switching the > default language of the device will show buttons and labels in that > language. > > Change-Id: I1a2b47009e7bb74f1ea3c16dc6f52451e2b78066 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865015 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706978} TBR=jam@chromium.org,torne@chromium.org,cduvall@chromium.org Change-Id: Icd22e8a4ef49fe798280a635c62c68e911ca2e10 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866923Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#707111}
-
Connor Clark authored
Also cherry-picked: https://github.com/GoogleChrome/lighthouse/pull/9377 https://github.com/GoogleChrome/lighthouse/pull/9783 Bug: 772558 Bug: 1011228 Change-Id: Ibe9e4b3849940bf86c666bf55698a9ced4253fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867249Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#707110}
-
nancy authored
Currently kDisabledByPolicy is set for ARC apps only when ARC apps are suspended: https://cs.chromium.org/chromium/src/chrome/browser/apps/app_service/arc_apps.cc?q=apps::mojom::Readiness::kDisabledByPolicy&sq=package:chromium&l=596&dr=C When ARC apps are disabled by policy, we can still show them in launcher. The disabled apps can't be launched because the their status is not ready. Bug: b/142642189 Change-Id: I04c763bc6b70255e86117499c1937442f77440ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865921Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707109}
-
Morten Stenshorne authored
This will unblock fragmentation work in other layout modes, such as flexbox and tables. Bug: 829028 Change-Id: Iab1a76c6febedee611ef9ca52440c85688b695e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865226 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#707108}
-
Joshua Peraza authored
2fb4e9e6a432 mac: Update the process_types version of dyld_all_image_infos for 10.15 c009b85449cb Use GTEST_SKIP() instead of custom DISABLED_TEST() d8f85829b07b linux: fix split stack test 7289acb78a6d linux: don't assume vdso exists 47a342133d60 linux: use boringssl in chromium Change-Id: If4718ea7220543c3ca10bc3f7d123ac330625461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863255 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#707107}
-
meacer authored
Currently page info only sets a text for kBadReputation signal. This CL changes it so that lookalike safety tips gets their own page info strings. Bug: 1014224 Change-Id: I5e2b5a2e8c8e00881634ed521a2cec583e112109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867050 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#707106}
-
Joshua Peraza authored
Change-Id: Iccd1c76b691c734b9049a8c9a14d9b01fe0b665c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864374Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#707105}
-
Kehuang Li authored
According to audio_io interface, AudioOutputStream::Stop should be implemented in a synchronized way that no more access to source callback will happen after Stop. However, MixerServiceWrapper::Stop is posted to another thread, and complete asynchronizely, which potentially causes crash, as upstream may destroyed source callback before MixerServiceWrapper actually stops. HoweverAdd a waitable event for MixerServiceWrapper as we did for CmaWrapper. Bug: internal: 142355421 Test: On device and unittests. Change-Id: Ia545596fbb80528d4f92debe3229b64fdea22667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866294 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#707104}
-
Marc Treib authored
There's no reason to have different owners for the supervised users code in the renderer. In practice, the renderer OWNERS file was just an outdated copy of the browser one. Bug: none Change-Id: I81d74c3781ad218e2b30bd30a03e9bf4af22be1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865322 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707103}
-
Tarun Bansal authored
Separate out triggering effective connection type for LitePageRedirect feature. For LPR, we first determine the ECT using LitePageRedirect feature. If there is none present, we fallback to using kClientSidePreviewsFieldTrial. If ECT is missing there as well, a hardcoced value of 2G is used. Change-Id: Ie8eb8119edaa80baaea528991dbfc59be0d57764 Bug: 1012023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858296 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#707102}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I0e2ad7cf484d2fcabafaa8afa819b821cfc9df4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864662 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#707101}
-
Ahmed Mehfooz authored
This change ensures the system tray utilizes the collapsed state for the message center properly by altering the number of feature pod rows based on height left for the message center. Bug: 1002712 Change-Id: I744adba3496ee58e1cce7c0203f23fb491deac82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853872Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707100}
-
Peter Kasting authored
Bug: 82078 Change-Id: I03866689a25d66936d6368cd3d1570806d24cfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865143 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#707099}
-
Ahmed Mehfooz authored
Change-Id: Ie83fa6664ead99583212c5d303615f8fed7de1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864356Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707098}
-
Connor Clark authored
Instead of in _onMessage. Bug: 1011228 Change-Id: I56699d605ed2cae36361031f1ecf071ee3110e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854642 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707097}
-