GitLab

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23717031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221252 0039d316-1c4b-4281-b951-d872f2087c98

The WebRTC audio quality test has been relying on a particular
configuration for the input device name, but it has turned out to be
painful to maintain. Specifically, it used to require that the default
input source was named "render.monitor" to figure out which device
to force the volume to 100% on, but now it will just force the volume
on all input devices it can find on the system.

The volume is forced to 100% since PESQ will be confused if the
recording is too low in volume (or even refuse to run if the recording
is done at 0% volume, which obviously will make for a bad comparison).

BUG=

Review URL: https://chromiumcodereview.appspot.com/23562002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221251 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221249 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/23531029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221248 0039d316-1c4b-4281-b951-d872f2087c98

Skia ref-counted objects must always be adopted at creation time
in order to prevent memory leaks. The SoftwareRenderer was creating
an SkDrawFilter and passing it to the SkCanvas without adopting it
first, and this was leaking the filter.

R=aelias
BUG=285161

Review URL: https://chromiumcodereview.appspot.com/23619012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221247 0039d316-1c4b-4281-b951-d872f2087c98

Previously, selectBestMatchItem() is called in the 'permuted'/'changed' handlers of the data model. But in this timing, although we can make sure that the data model is updated, but the list elements in the list may not be updated (it depends on the order of registration of event listeners). Then we can't select the target item since the target item may not be created yet.

This patch delays it just after the updating of elements in list.

BUG=280155
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23618028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221246 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23558006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221245 0039d316-1c4b-4281-b951-d872f2087c98

Extracted from https://chromiumcodereview.appspot.com/23240002/

Currently we create all usage trackers for each pair QuotaClient/StorageType.
Most clients only support one storage type and filesystem support variable
list of types (it doesn't have kStorageTypeSyncable in unittests).

If filesystem has no syncable storage backend it not useless to keep create ClientUsageTracker. This tracker fails when GetHostUsage is invoked. So let's don't create it.

BUG=281252

Review URL: https://chromiumcodereview.appspot.com/23545016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=derat@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/23713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221243 0039d316-1c4b-4281-b951-d872f2087c98

ScopedPtrHashMap<>::resize() failed to compile because it's a
strict constness violation. Removing the const qualifier works.

BUG=283892
R=brettw@chromium.org,thakis@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23526014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221241 0039d316-1c4b-4281-b951-d872f2087c98

Also disable vsync to see if this improves performance.

BUG=266186
TBR=kbr@chromium.org, zmo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23477037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221240 0039d316-1c4b-4281-b951-d872f2087c98

Adding tests for error reporting and wrapper, the rest will follow.

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/23477006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221239 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

I don't understand this piece of code.
There is not side-effects. Old code? Or for debugging?

R=mrossetti@chromium.org, sky@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/22475002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23707010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=252011
TEST=manual tests on Lumpy

Review URL: https://chromiumcodereview.appspot.com/23514028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221236 0039d316-1c4b-4281-b951-d872f2087c98

When overflow bubble is shown, active state item in overflow bubble is changed
to running state item because overflow bubble get focus.

R=jamescook@chromium.org
BUG=283206
TEST=Compiles, Manual tests

Review URL: https://chromiumcodereview.appspot.com/23540013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221235 0039d316-1c4b-4281-b951-d872f2087c98

* Adds more functionality to the Chromium testshell SyncController.
* Enables GCM for sync.
* Upstream sync test framework and chrome://sync tests.
* Adds auto-login to Chromium testshell.

BUG=272584

Review URL: https://chromiumcodereview.appspot.com/22914014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23701011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221232 0039d316-1c4b-4281-b951-d872f2087c98

The request target type used to be object for all requests coming from a Pepper plug-in (since http://crrev.com/142370), but we only want it for the initial plug-in file, not for navigations.

BUG=283374

Review URL: https://chromiumcodereview.appspot.com/23548008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221231 0039d316-1c4b-4281-b951-d872f2087c98

Previously, fileBrowserPrivate.getFileTasks() returned Drive app tasks
regardless of whether files were on Drive or not, and the results were
filtered in JS side with ".driveApp" field.

It's much simpler for getFileTasks() to return Drive app tasks only if
all files are on Drive. This way, we can get rid of the filtering logic
in JS, as well as the ".driveApp" field.

BUG=284242
TEST=Install Pixlr Editor from webstore; Launch Files.app; Confirm that Pixlr Editor is an option for a JPG file on Drive, but not an option for a JPG file on the local disk.
TBR=benwells@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23477036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221230 0039d316-1c4b-4281-b951-d872f2087c98

This is a necessary step in moving PasswordForm from //content to //autofill.

BUG=263121

Review URL: https://chromiumcodereview.appspot.com/23622013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285051
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/23506031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221228 0039d316-1c4b-4281-b951-d872f2087c98

This eases debugging failures of the WebGL conformance tests run under
Telemetry.

BUG=280750
R=bajones@chromium.org, dtu@chromium.org, skyostil@chromium.org, zmo@chromium.org

Review URL: https://codereview.chromium.org/23604039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221226 0039d316-1c4b-4281-b951-d872f2087c98

Currently this only works if the window is activated with the mouse. If we Alt Tab to the window then
the focus window is not restored in AURA. The view is correctly focused though.

Fixes as below:-
1. Added a new function HandleActivationChanged to the DesktopNativeWidgetAura class. This is invoked from
   the DesktopRootWindowHostWin::HandleActivationChanged and DesktopRootWindowHostX11::HandleNativeWidgetActivationChanged
   functions.

2. Most of the common code in those functions now lives in the DesktopNativeWidgetAura::HandleActivationChanged function.
   This includes deactivating the window in the aura activation client and now additionally activating the window when
   we are being activated.

Added an interactive ui test DesktopNativeWidgetAuraActivationAndFocusTest for Windows AURA.

BUG=278000
TEST=Interactive ui test DesktopNativeWidgetAuraActivationAndFocusTest
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23702017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221225 0039d316-1c4b-4281-b951-d872f2087c98

Binary data separation from https://codereview.chromium.org/22938005/ in order
to allow trybot and CQ run on that patch.

BUG=21734
TBR=yoz@chromium.org, kalman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/23532041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221224 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240152
TEST=manual
R=hirono@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23691034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221223 0039d316-1c4b-4281-b951-d872f2087c98

Fill json data in index.html template by python script and
try to open page in chrome using xdg-open command. If page
open failed, it will output the path of generated html file.

index.html containing the content of index.js would be
generated by python script, so index.html and index.js are
deleted.

BUG=259206
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221222 0039d316-1c4b-4281-b951-d872f2087c98

Fixes r216992's regression (input not sent to Combobox/TreeView).
Call views::InputMethod::On[Focus|Blur] for Combobox and TreeView.
This correctly forwards input method input to the focused views.
(this minimal CL should be mergeable to fix this issue in M-30)

I had landed a fix that was more complex: http://crrev.com/219673
That caused regressions and was reverted: http://crrev.com/220121
Both CLs should be superceded by: http://crrev.com/23583013
(but that CL is a complex WIP proof of concept, not mergeable)

BUG=276720
TEST=Test Win (desktop, Win8 Metro, and Aura builds), CrOS, and Linux Aura's Omnibox, Find Bar, Bookmark Bubble, and Edit Bookmark Dialog's textfield text entry (and text input handling to select combobox and tree view elements) with EN, JA, and other IMEs, and related IME usage (Win+Space to change IME on Win8, Alt+` to change modes, etc.). Also test with --enable-text-services-framework.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23882003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221221 0039d316-1c4b-4281-b951-d872f2087c98

Made the ChromeViewHostMsg_CloseCurrentConnections message synchronous so
that Telemetry can't issue further network requests until it's processed.

Removed call to util.CloseConnections from _RunCompoundAction in
page_test.py. This was aborting resource requests issued by the current
test, and was the root cause of the flakiness of the WebGL conformance
tests that loaded external resources.

BUG=280750
R=dtu@chromium.org, palmer@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/23533029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221220 0039d316-1c4b-4281-b951-d872f2087c98

WebContentsModalDialogManager closes web contents modal dialogs
when the WebContents is destroyed, so there is no need for
TabModalConfirmDialogDelegate to also close dialogs on tab closing.

BUG=157161
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23820004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221219 0039d316-1c4b-4281-b951-d872f2087c98

* Rewrote in ppapi_cpp
* Remove URL loading (data is static in the .nexe)
* Cube data is no longer generated
* Added sliders for cube rotation (useful for testing)

BUG=none
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/23838002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221218 0039d316-1c4b-4281-b951-d872f2087c98

These were added to ppapi_cpp_private/library.dsc in r221149, but the files
were not landed in that CL.

BUG=none
TBR=kcwu@chromium.org

Review URL: https://codereview.chromium.org/23898005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221217 0039d316-1c4b-4281-b951-d872f2087c98

This lets browsertests and apitests use more obvious code in some
cases, especially when they need to alternate between the background
page and the test running code.

Review URL: https://chromiumcodereview.appspot.com/23874006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268640

Review URL: https://chromiumcodereview.appspot.com/23842002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221215 0039d316-1c4b-4281-b951-d872f2087c98

This way the Installer.DownloadSourcesUsed metric conveys how often
p2p is used and new metrics Installer.SuccessfulMBsDownloadedFromHttpPeer
and Installer.TotalMBsDownloadedFromHttpPeer gives additional detail.

BUG=chromium:284714
TEST=Validated the xml, pretty print succeeded.

Review URL: https://chromiumcodereview.appspot.com/23838003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281698
TEST=Link should be disabled while the user's signed-in state is unknown.
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23806002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221213 0039d316-1c4b-4281-b951-d872f2087c98

When sign in is initiated from the bookmark bubble in an incognito
browser, the sign in page is not displayed in the browser provided to
chrome::ShowBrowserSignin() but in a new/existing non-incognito browser.
BookmarkBubbleSignInDelegate was not aware of that and called Show()
on the wrong browser.

This call was unnecessary because chrome::ShowBrowserSignin() already
make it on the right browser. I removed the unnecessary call.

BUG=282305
TEST=
Pre-condition: Make sure you are not signed in to Chrome.
1.Launch Chrome, open 'Incognito window' from hot-dog menu and navigate to www.google.com.
2.Click on bookmark icon(star) in omnibox and click on 'Sign in' link of bookmark dialog box.
Expected result: Sign in page is displayed in a non-incognito browser.
This browser is displayed in front of the incognito browser.
R=rogerta

Review URL: https://chromiumcodereview.appspot.com/23726016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221212 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221211 0039d316-1c4b-4281-b951-d872f2087c98

The struct was used for keeping the app list internally in DriveAppRegistry,
but the information it holds is identical to its public cousin: DriveAppInfo.

BUG=284951

Review URL: https://chromiumcodereview.appspot.com/23608007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221210 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vadimsh@chromium.org
NOTRY=true
BUG=

Review URL: https://chromiumcodereview.appspot.com/23593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221209 0039d316-1c4b-4281-b951-d872f2087c98