- 04 Dec, 2019 40 commits
-
-
Esmael El-Moslimany authored
Change-Id: I71a7ae90419fb5da9e5d65e99e59e0fb14d9e069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948051 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#721554}
-
Dominic Mazzoni authored
Plus two other cleanups as a follow-up to http://crrev.com/c/1927974 Bug: 607777 Change-Id: I5633c5e61b4c865b5623759f5ae05371edb66610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949004Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#721553}
-
Ali Juma authored
This adds the file as an EG2 target and updates #includes. Bug: 987646 Change-Id: I10ff2d45efc784f36f2a394bfd75289617a78e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950851Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#721552}
-
Roman Aleksandrov authored
Add Packaged License screen before Login screen if device packaged with license. Bug: 1024809 Change-Id: I8bc6359658e352f1369ecb8ac94a2133a3eba756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924434Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#721551}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/e99f60bbee4f..db3c93975a8f git log e99f60bbee4f..db3c93975a8f --date=short --first-parent --format='%ad %ae %s' 2019-12-04 9856269+sarahM0@users.noreply.github.com spvc: Add missing APIs for HLSL support in Dawn - set_decoration (#924) Created with: gclient setdep -r src/third_party/shaderc/src@db3c93975a8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I7844561416b8bb11e74c342039f106f729f4ab95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950855Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721550}
-
Vadym Doroshenko authored
On the removal the old parser on CL https://chromium-review.googlesource.com/c/chromium/src/+/1814832 Password Manager started to send all forms the browser process, while only forms with password fields are needed. Bug: 875768 Change-Id: I7e212a5e8b0ad7a438666644b4a20c3f9437ab12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950504 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#721549}
-
Eric Stevenson authored
Bug: 901465 Change-Id: I4582ab90f20bb2acd1ed8f6bdfb08818ea5808b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950852 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721548}
-
danakj authored
Since the test uses a RunLoop now instead of MessageLoopRunner, the Quit action will exit the RunLoop immediately, terminating the timer and preventing CheckAnimation() from running again. We could pass a OnceClosure in, but since RunLoop is on the stack, passing a pointer to it is slightly more straightforward with less indirection. R=vasilii@chromium.org Bug: 1030275 Change-Id: I27efc585f8d63f7d9204288b45ed2d4b22b77b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947559Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721547}
-
ckitagawa authored
Adds a URL to the PaintPreviewProto. This is a simple addition that is used to attribute the Paint Preview to originating from a URL. This only applies to the root frame rather than any of its children. Bug: 1030419 Change-Id: I59028fbebf3305cb52b04fca9c190712a2bb40f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949280 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#721546}
-
Lei Zhang authored
Make ChromeWebViewPermissionHelperDelegate and ChromeContentRendererClient work when building on desktop with plugins disabled. Bug: 1027360 Change-Id: I0fff3732718169432b1595fbecf497fbaf074975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949463 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#721545}
-
Robert Liao authored
Sample Histogram Recording Histogram: WebUITabStrip.TabDataReceived.06_20 recorded 1 samples, mean = 31.0 (flags = 0x41) 0 ... 29 ------------------------------------------------------------------------O (1 = 100.0%) {0.0%} 34 ... BUG=1016031 Change-Id: Icd415eb90e7afb81ff371517f5835b3aecfb794c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947814 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:John Lee <johntlee@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721544}
-
Sebastien Marchand authored
This adds the following debug URLS: - chrome://memory-pressure-critical/ - chrome://memory-pressure-moderate/ These URLs will be useful to improve our memory pressure handlers. Change-Id: I70e709c57a19661f7c268128e467fd93f87034a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940748Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#721543}
-
Liquan (Max) Gu authored
Context: the Bottom-sheet Payment Handler UI observes the load finish of the WebContents. Upon observing that, the UI check the validity of the page of the payment handler app, and if invalid, close the page. Old behavior: closing the invalid payment handler crashes. Cause: because the load finish hook is called within WebContents, when the hook tries to destroy WebContents itself, it causes a crash. Change: defer destroying WebContents until WebContents is not being used. New behavior: Payment Handler UI destroys WebContents outside of the observer hook. So the crash is fixed. Bug: 1029995 Change-Id: I7968daaad793a949808fc30e6f08b03bb19c330f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949057Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#721542}
-
James Cook authored
Move the Wi-Fi configurations to UserSelectableOsType. Change the ModelTypeController to respect the global "OS sync enabled" pref. Refactor the printers ModelTypeController to share code. Note: This means Wi-Fi config sync cannot ship before Split Settings Sync. However, it's much simpler than trying to support Wi-Fi config being *both* a UserSelectableType and a UserSelectableOsType. I've discussed this with the engineer working on Wi-Fi sync and we're both OK with this plan. Bug: 1013466 Test: existing components_unittests and unit_tests Test: Run --enable-features=SplitSettingsSync,SyncWifiConfigurations and verify "Wi-Fi configurations" appears in Chrome OS settings. Verify turning it off and closing settings results in chrome://sync-internals showing that the Wi-Fi type is not syncing. Change-Id: I878fecaf449248ae8747e37aa2e0e897130e63ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947396Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#721541}
-
Joe Downing authored
The code which read this policy was removed from Chrome Remote Desktop in M76 but it looks like we did not officially deprecate the policy at that point. This CL marks it as deprecated and lists the last host version which supports it. Change-Id: I14e1dc3d5fc061703fc94f93ba7b75861b3fa317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949229 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#721540}
-
Brian Salomon authored
Bug: 1028116 Change-Id: Iaff6b52cb552ca7339ff895b228034d4904eef75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949201 Auto-Submit: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#721539}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a9ad36f3225d..242a9e0ffe94 git log a9ad36f3225d..242a9e0ffe94 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 danilchap@webrtc.org Fuzz RtpPacketizerAv1 2019-12-04 eshr@google.com Add new_request flag to SendFullIntraRequest 2019-12-04 sprang@webrtc.org Verifies trials are populated when creating a Call. 2019-12-04 elrello@microsoft.com Replace hostCandidate with address and port in RTCPeerConnectionIceErrorEvent 2019-12-04 handellm@webrtc.org VideoRtpReceiver: Enable encoded frame sink. 2019-12-04 ilnik@webrtc.org Implement automatic animation detection in VideoStreamEncoder 2019-12-04 handellm@webrtc.org WebRtcVideoEngine: Enable encoded frame sink. Created with: gclient setdep -r src/third_party/webrtc@242a9e0ffe94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1013564,chromium:1013590 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ica4a9da85d7c766fd1a5638e93c88251b41a8c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950847Reviewed-by:
-
Dominique Fauteux-Chapleau authored
FinishRequest() is called with UNAUTHORIZED, which lets the user upload/download the file but doesn't record UMA metrics. Bug: 1028133 Change-Id: I66405a78e0d33997f1a12b322ca5a8bb5250ada0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947362Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#721537}
-
Eugene But authored
This histogram is useful and helped me to find a new bug (crbug.com/1030164). Bug: 1029848 Change-Id: Ibedf95a4b237f3c2876005f89a82b3b6fae1e0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949277 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#721536}
-
Geoff Lang authored
BUG=982292 Change-Id: I1c44530f3fb18f1866c85433f6aaa2455deb72df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946704Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#721535}
-
Ovidio Henriquez authored
This change adds the stub interface for BluetoothChooserContext to be implemented in future patches. Bug: 589228 Change-Id: I1d4a25effa9676548e16f075a7fc6b792943043f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927391Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#721534}
-
James Vecore authored
The BT devices do not have their device type in the accessibility label in the system tray. A recent change https://crrev.com/c/1925593 added this to the settings ui. This CL adds them to the system tray. A utility function GetBluetoothDeviceLabelForAccessibility is added to the devices service public interface to generate the label. Strings from settings were moved over to the bluetooth_strings.grp to be shared between the tray and settings UI. There are two sets of are very similar device type localization strings which is intentional as they serve two slightly different purposes: display name vs accessibility label. Fixed: 1027608 Change-Id: Ic017d908b856e200694ef74a23eec48e21ab2a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931102Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#721533}
-
Mikel Astiz authored
Similarly to how it's done for keystore keys, the patch now adopts a base64-encoding of the encryption keys, prior to the Nigori key derivation (PBKDF2). The main motivation is that the underlying crypto libraries don't deal well with non-utf8 passphrases/passwords, or they diverge across implementations (Java vs C++). The rest of the code, prior to key derivation, continues to use binary keys. Bug: 1000146 Change-Id: Icaa88f285938f09e5fb8b72c9e11b8f90ab41840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950536 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#721532}
-
Mohammad Refaat authored
geo is used to direct the user to the correct global appstore. Bug: 1030346 Change-Id: I31eaffa69643f17a223808ede5051839a8669aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949791Reviewed-by:
-
Robert Ogden authored
This was using the previous page's url. Ooops Bug: 1029959 Change-Id: Ibda0079598698cfebc54c0c579f76f31355284e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948045Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Ken MacKay authored
Otherwise we get flaky build failures like: ../../third_party/blink/renderer/platform/bindings/name_client.h:9:10: fatal error: 'third_party/blink/renderer/platform/bindings/buildflags.h' file not found #include "third_party/blink/renderer/platform/bindings/buildflags.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Ie9737e7e28a3e836cce94c5ff0eff8449096b651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948053 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#721529}
-
Dana Fried authored
Many places in test code call EXPECT_TRUE(VerifyUi()), which only produces a stack trace and does not tell you which of the conditions in VerifyUi() aren't met. Adding logging allows us to look at the test logs and figure out which condition actually failed. Change-Id: If6f81dac0f10aabdf8125571295f2a55343f93ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949452 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#721528}
-
Avery Musbach authored
WorkspaceEventHandler::HandleVerticalResizeDoubleClick actually handles both horizontal resize double clicking and vertical resize double clicking. The name and header comment both say it is only for vertical. Bug: None Change-Id: I756a951ae86e0f3cf094fd889a1973c85fe63442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950854Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#721527}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c68502c177c6..82f68bc205dc Created with: gclient setdep -r src-internal@82f68bc205dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I471a365248a611b18f5385c946b88e55171cb353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950844Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721526}
-
Liquan (Max) Gu authored
This CL is regarding the toolbar of the Bottom-sheet Payment Handler UI. With a slow connection, the toolbar looks empty in the early loading stage, because the toolbar doesn't show url, title or the security icon until the Payment Handler UI has received update from the page. As an improvement, this CL populates the toolbar with the initial url as soon as it opens the PH UI. Bug: 999196 Change-Id: I72b3a9fc10976eb6dc1814cc9bda28afa03910b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944613 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Robin Lewis authored
Bug: 1027346 Change-Id: I30fac3fbc2dbfcc38a31c0c950c7fbaed4d3382d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929102Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#721524}
-
Evan Stade authored
The preferred height is used during layout of the PWA window frame (CustomTabBarView), so remove obsolete/misleading comment and restore old layout behavior. Bug: 1026519 Change-Id: I015f9bcc0fb4661f73603b3a46acfae937e2f1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949203 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#721523}
-
Clark DuVall authored
This is a follow-up test for http://crrev.com/c/1947639 Bug: 1030186 Change-Id: I3b82495a86befd4c52419047a0856ad012cc7bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949733Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e9dc4222803..4a213018b475 git log 7e9dc4222803..4a213018b475 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 thomasanderson@chromium.org Always check for GL_ARB_sync Created with: gclient setdep -r src/third_party/skia@4a213018b475 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028799 Tbr: bsalomon@google.com Change-Id: Ibbf65d1c59e41656de59a3cadeacfd63f96c0873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950665Reviewed-by:
-
Fabian Sommer authored
Increase arrow button size Decrease card icon size Increase distance between login button and card icon Use new card icon Bug: 1024254 Change-Id: I34962de9e63725b742914a68c382a7c6416b38e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942343Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Jacobo Aragunde Pérez authored
Identifies and removes usage of static Create() for those classes defined in //third_party/blink/renderer/core/animation. Exceptions have been made in some cases: * Animation::Create is considered non-trivial. * KeyFrameEffect::Create is considered non-trivial. * ScrollTimeline::Create is considered non-trivial. * One of DocumentTimeline::Create is part of Web Animations API IDL and hasn't been touched. Bug: 939691 Change-Id: I05616f8addcd9be0e2dbd3cafcc0bcdf8e163b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949474Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#721519}
-
Michael Crouse authored
This is a reland of 548b6a4e This fixes the failing tests by disabling them on platforms this feature will not support. Original CL that was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1938192 Patchset 1 of this CL is the CL that was submitted and reverted. Bug: 1001194 Change-Id: I62f5619ed7c230c168a4da914a17c998092f1e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949697 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
-
Andy Paicu authored
This is a reland of 6e91b688 There was a clash with https://chromium-review.googlesource.com/c/chromium/src/+/1948892 which renamed a file that this CL included. PS1 contains the original CL. Original change's description: > Added IPH for the mini-infobar notification permission prompt (android) > > As part of the new quieter notification prompt, add IPH for the android > quieter notification permission prompt. To be shown the first time > the setting is enabled. > > This is controlled by using the functions: > * AdaptiveNotificationPermissionUiSelector::ShouldShowPromo > * AdaptiveNotificationPermissionUiSelector::PromoWasShown > > Quick mock of how this is supposed to look: > https://docs.google.com/document/d/1hsp1j08yzIK6M6G7pbsdEihU8CLN7QQ3V2iAxESrqQM/edit?usp=sharing > > Bug: 1029595 > Change-Id: I3c90dda846a70396f1130c2ad6dcfc3622b9b25f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944173 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721442} TBR=nyquist@chromium.org,engedy@chromium.org,dtrainor@chromium.org,bcwhite@chromium.org,mdjones@chromium.org,bsazonov@chromium.org,hkamila@chromium.org Bug: 1029595 Change-Id: I33eb37e289c8bbea9f8ff3aba51db229aa523381 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950513 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Mike Dougherty authored
TBR=justincohen@chromium.org Bug: 1030701 Change-Id: I9f7ffcccf5484514d22121defe458ada25758d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950667 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#721516}
-
Lei Zhang authored
Change-Id: I37ddc01a0427105b679d6f73708e734311f5502e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947965Reviewed-by:
-
