- 06 Feb, 2020 40 commits
-
-
Yang Guo authored
We now always show the experiments section in DevTools settings to reduce the friction for users to enable experiments. This flag in the backend is now obsolete. Bug: 1048124 Change-Id: I5966cfae69b34e120bbd532d7e78a26ef912e94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041432 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738968}
-
Michael Thiessen authored
This reverts commit a25a688e. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1049536 Original change's description: > Migrate webview Webcontents#getVisibleUrl to GURL > > Bug: 783819 > Change-Id: Ib1970a41bb45a31907ea91358fd27bee6c6b20a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039301 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738694} TBR=mthiesse@chromium.org,boliu@chromium.org Change-Id: Ib9a94a412c9ac7625b37dbc6075c61f2d7bcc9fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042087Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#738967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b04bd5953150..d4802d647c64 git log b04bd5953150..d4802d647c64 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 aerotwist@chromium.org [e2e] Forces stronger reset on pages Created with: gclient setdep -r src/third_party/devtools-frontend/src@d4802d647c64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17deeec9967b9e323146d97efe9d8178015f2313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738966}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/928314e9..aeb15b1b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I343975abf2ac6a60d5a97783789b2103d61e6857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041951Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738965}
-
Maksim Moskvitin authored
InvalidatorRegistarWithMemory didn't update registrations when there are duplicates, but *did* update subscriptions. This behavior is confusing and may lead to the future bugs. This patch makes subscription/registration logic consistent. Bug: 1020117 Change-Id: I6ddf5f84f35517570c8c246c415106e71038859b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041470Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#738964}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a9e10263044b..48258acabf56 git log a9e10263044b..48258acabf56 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 hbos@webrtc.org [Overuse] Implement Resource and ResourceUsageListener. 2020-02-06 hbos@webrtc.org [Overuse] Add EncodeUsageResource and QualityScalerResource. Created with: gclient setdep -r src/third_party/webrtc@48258acabf56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ce0ce9ebb30d64204a24437cccf0dffb7cd2e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041908Reviewed-by:
-
Nico Weber authored
I never want run-swarmed to build stuff, I only want it to run already built stuff on swarming. I think that should be the default, but I'll talk to a few people who use this script before changing the default. For now, just add a flag so that folks can opt out of building. Also, as a usability improvement on Windows, if "foo.exe" is passed in, just strip the ".exe" for internal processing instead of throwing an unfriendly error about it. Bug: none Change-Id: I7762e80347f6fd529ecd4328c7161ede0c5d8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042190Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#738962}
-
Clemens Arbesser authored
Also extended test coverage for the affected methods. Added << overload for ModelValue (intended only for debugging). This is a refactoring only. Bug: b/145043394 Change-Id: I5c6a055e6b1050ac79345e51d5472b78a67ca745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041614 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#738961}
-
Kinuko Yasuda authored
Eventually we want to deprecate fetch_request_context_type entirely Bug: 1045925 Change-Id: Idd4e779b426fe64f57cd29f7ad53ed66f236d291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021563 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#738960}
-
Peng Huang authored
Bug: None Change-Id: I6b4b4208fcd5d28f572922f34ea6dc9cd1859259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041794 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#738959}
-
Maria Kazinova authored
Primarily to let it keep track of fields that have user input. CL 2035983 allowed AutoFillAgent to use FieldDataManager but it was still not used for some FormData extractions. This fixes it. Bug: 957444, 1006745. Change-Id: If4b3e080e05bb64e144bf4c9b8b08ba62aea997b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041592 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#738958}
-
Mikel Astiz authored
This reverts commit d7682c6e. Reason for revert: test HasTitleAndTwoButtons fails on ChromeOS, see e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16884 Original change's description: > [Passwords] Introduce SaveUpdateWithAccountStore bubble > > This is a mechnical fork of the existing SaveUpdate bubble without > any change in functionality. > Follow up CLs will introduce extra funcationlaity and change in the UI > elements. > > Bug: 1044038 > Change-Id: I1ab6b08a9097b4f7adc06b53317676b42b3a2bf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033072 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738913} TBR=vasilii@chromium.org,mamir@chromium.org Change-Id: Icad799cdca83d4511e2c5d7ac3784dda4ea2bf79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041660Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738957}
-
Kent Tamura authored
Also, this CL removes DEFINE_LAYOUT_OBJECT_TYPE_CASTS for LayoutListBox because this CL removes the last usage of ToLayoutListBox(). This CL has no behavior changes. Bug: 1040828 Change-Id: I0f531e1f059a3a85046711a1a11cb91450621069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040494 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738956}
-
Fredrik Söderquist authored
Change-Id: Ie4c00b4b6b6eba3b55f86793620a502780590864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041270Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#738955}
-
Fredrik Söderquist authored
Bug: 658305, 862716, 968791 Change-Id: I33a0a1648e22c1f51f8eed04219be808110a4083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041472 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/438b9bbca2aa..586d923fba12 Created with: gclient setdep -r src-internal@586d923fba12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1049528 Tbr: jbudorick@google.com Change-Id: Iea832bcdd8894f486db7d55bffc5195eacb47227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041903Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738953}
-
Anton Bikineev authored
Generational barrier is needed to track inter-generational pointers in the remembered set (which is implemented as a card table). The barrier is implemented under a macro flag BLINK_HEAP_YOUNG_GENERATION and is off by default. Design doc: https://bit.ly/2ZXGU20 Bug: 1029379 Change-Id: I9931c409d119d35e85185970cff0a62f1171fc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000726Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#738952}
-
Hitoshi Yoshida authored
- Uses (CxxFuncDeclNode and) CxxFuncDefNode for all functions. - Makes a function declaration and its definition together. Bug: 839389 Change-Id: I8e0d8c981c03bb5f7ed65478cdf6cdd19e02ab56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040974Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#738951}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4721e067812f..f6e3eaf05150 git log 4721e067812f..f6e3eaf05150 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 rmistry@google.com Change name from skia.primary->luci.skia.skia.primary Created with: gclient setdep -r src/third_party/skia@f6e3eaf05150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024947 Tbr: scroggo@google.com Change-Id: I2f3c1fc6cab8147faed27df8443837b541400ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041902Reviewed-by:
-
Andrew Grieve authored
Was broken by b2706770 where the zipfile.ZIP_DEFLATED was removed from when creating the ZipFile object. Rather than add it back, this fixes the problem by being explicit about compression for every file added. Bug: 1049461 Change-Id: I670d733792b5cf4af5fb7821fcc7efe9a670e33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040954 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738949}
-
Maks Orlovich authored
It's always created[1] with null SpecialStoragePolicy, so it doesn't actually do any cleanup, but its base class still does some bookkeeping, wasting memory. The actual cleanup for CONTENT_SETTING_SESSION_ONLY is done by SessionCleanupCookieStore in the network service process with help from its CookieSettings. [1] For the chrome-extension:// cookie jar and for Android Webview when it creates the cookie jar itself. Bug: 488710, 934009 Change-Id: I5bc34551e92e50e9cb799f99c804c24895c290a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906642Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#738948}
-
Brian Osman authored
Change-Id: I90a2e27df04b88fb49a0bf93d54b6391ed73fdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039312Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#738947}
-
Gauthier Ambard authored
The test is failing on the iOS13 beta bot. TBR= stkhapugin@chromium.org Bug: 1045950 Change-Id: I572729c0d26bab9af450779c18b3c9d264530c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041447Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738946}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef0d76ae836b..a9e10263044b git log ef0d76ae836b..a9e10263044b --date=short --first-parent --format='%ad %ae %s' 2020-02-06 mbonadei@webrtc.org Make video_replay buildable from Chromium. Created with: gclient setdep -r src/third_party/webrtc@a9e10263044b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:942546 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia9d137ff1805e966ab7276e8a84021420abaea5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041897Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49346f1e6753..b04bd5953150 git log 49346f1e6753..b04bd5953150 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@b04bd5953150 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90dfabb7bbeea526b786579f86dc033337bcfdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041901Reviewed-by:
-
Mohamed Heikal authored
missing | between paths Change-Id: Id397e887b584bb5026cb410e5b2297681ad1e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040047 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1ffa05369da3..3403d9601aa6 git log 1ffa05369da3..3403d9601aa6 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 mythria@chromium.org Remove UE bucketing in runtimeStatsTotalMetric Created with: gclient setdep -r src/third_party/catapult@3403d9601aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:958441 Tbr: sadrul@google.com Change-Id: I714bcaefeda2186b1b95550c937d3fe8155a6e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041896Reviewed-by:
-
Rune Lillesveen authored
It is perhaps not super clear from the spec, but the Note in [1] talks about: "single-page vector documents (single-page PDFs, XML files with an SVG document element)". This CL adds a test that checks that external resources are not loaded for SVG documents used as an img source. This matches the behavior of Firefox and Chrome, at least. [1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element Change-Id: I9ab713b24fdea5b7d98c5ca6463de4c3674fb8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041595 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#738941}
-
Mihai Sardarescu authored
This reverts commit 9b7b1b3a. Reason for revert: Fixed downstream compilation Original change's description: > Revert "Use EarlGrey wait condition instead of spinning the runloop." > > This reverts commit 7a4958d3. > > Reason for revert: Downstream code is using signOutAndClearAccounts > > Original change's description: > > Use EarlGrey wait condition instead of spinning the runloop. > > > > The sign-in external URL tests were spinning the runloop while waiting > > for the identities to be removed from the ChromeIdentityService. This > > was consistently failing with EarlGrey2. > > > > This CL uses an EarlGrey wait condition instead of spinning the runloop > > while waiting for the identities to be removed. > > > > Bug: 1031986 > > > > Change-Id: I0bcf6bda55caa506fe3a4d54ee607efc5c2e4d37 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039551 > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738916} > > TBR=msarda@chromium.org,sdefresne@chromium.org > > Change-Id: I87b517b4669f02af19c516997eba465f51eb0c22 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1031986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041753 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738934} TBR=msarda@chromium.org,sdefresne@chromium.org,gambard@chromium.org Change-Id: I5be4d0bad2ac69aade4f9707a55303608bfa3644 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041598Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738940}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f5d128faa213..7572c967ba08 git log f5d128faa213..7572c967ba08 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b82ed734e767..656650f461c8 (1 commits) 2020-02-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 9e52bc0d0c1d..1f03ac10270a (1 commits) Created with: gclient setdep -r src/third_party/angle@7572c967ba08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I119356dff6815ed375ac1bea809c010c1e1cf34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041329Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b18fef9..928314e9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1ec539460679b0621f8968c49769403185cdbd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041631Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f0985686143..6e49edeb0077 git log 2f0985686143..6e49edeb0077 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 lalitm@google.com Merge "tp: correct omitting sqlite order by for span join" Created with: gclient setdep -r src/third_party/perfetto@6e49edeb0077 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I663d0cb208e1fd0c9b1b133467e0af28d1918cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041891Reviewed-by:
-
Camille Lamy authored
This CL introduces ClientSecurityState, a struct that keeps track of various WebPlatform security properties which need to be enforced on each URLLoaderRequests for a particular fetch client. Change-Id: I91fac078e0a9dd4f5ec06342990dd227a71001ce Bug: 986744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013040 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
This patch moves TTL logic (crrev.com/c/1950987) to FCMNetworkHandler layer. There should be no behavioral changes. Bug: 1034510 Change-Id: I324073677027065dd50b399351f24479d3d35579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038731 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This reverts commit 7a4958d3. Reason for revert: Downstream code is using signOutAndClearAccounts Original change's description: > Use EarlGrey wait condition instead of spinning the runloop. > > The sign-in external URL tests were spinning the runloop while waiting > for the identities to be removed from the ChromeIdentityService. This > was consistently failing with EarlGrey2. > > This CL uses an EarlGrey wait condition instead of spinning the runloop > while waiting for the identities to be removed. > > Bug: 1031986 > > Change-Id: I0bcf6bda55caa506fe3a4d54ee607efc5c2e4d37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039551 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738916} TBR=msarda@chromium.org,sdefresne@chromium.org Change-Id: I87b517b4669f02af19c516997eba465f51eb0c22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041753Reviewed-by:
-
Roman Sorokin authored
The limitation is outdated and there is no reason to limit it anymore. Setting the limit to 50 to have sensible scroll view of users. This has nothing to do with the disk space exhaustion. That handled separetely. Fixed: 1040890 Change-Id: Ib13d065f55cc9cc1d1d6f65a2b4db9d65805bb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041442 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#738933}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I7bc634d2d929b56a0e4626fb32bedef1022bce7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041793Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738932}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/54ed3a9a55df..49346f1e6753 git log 54ed3a9a55df..49346f1e6753 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 yangguo@chromium.org Remove experiments query param from scripts Created with: gclient setdep -r src/third_party/devtools-frontend/src@49346f1e6753 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048124 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If982deaad7650ca3fd100e2ecbec71315b0ebfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041327Reviewed-by:
-
Alex Chau authored
Bug: 1048704 Change-Id: I29dacfd0d0b0b0f4231160decb82f4ee4099922f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036184 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The vast majority of bookmarks have already gone through the USS migrator according to metric Sync.USSMigrationEntityCount.BOOKMARK and it's no longer worth maintaining the historically-problematic USS migrator. Specifically, the proto fields originator_cache_guid and originator_client_item_id and NOT populated by the USS migrator, and this causes issues when it comes to inferring GUIDs for bookmarks, as the code started doing recently in particular with https://chromium-review.googlesource.com/c/chromium/src/+/1948430. Change-Id: I537faa4c19300e12e23ff0a97b1ad52d165d5e3a Bug: 1048381,978430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
