- 08 Sep, 2020 5 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599450822-c8039978cfc4f91681250dd400e03a84f6c9a29d.profdata to chrome-win32-master-1599492790-48f26b1814d8ee70ca5f6f24d850f389c1625719.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I248fba9375f37e3793eea364893f4937e5ee259c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804806}
-
Nathaniel Mitchell authored
Adds a network traffic annotation for Contextual Search Followed documentation standards set by: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/docs/network_traffic_annotations.md Followed the protocols at: https://source.chromium.org/chromium/chromium/src/+/master:tools/traffic_annotation/traffic_annotation.proto?q=traffic_annotation.proto Bug: 870398, 1121633, 1121634 Change-Id: Ic5bc596dd729518c108a1bb2ba792011a2c4c2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355097Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#804805}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599480000-359ed9b37932456efdafd52df427d9044e87d251.profdata to chrome-win64-master-1599501535-4517b466b7e93a6fa96665d6e0ac00556c34e7cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ibc2207476f94504e73deaa472180d77d1c807832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804804}
-
Xianzhu Wang authored
This reverts commit 723e2961. Reason for revert: no obvious changes for the metris. Tiling invalidation on change of raster translation seems not a reason of the regressions. Original change's description: > Temporarily disable tiling invalidation on change of raster translation > > This is to investigate performance regression shown on UMA. > > The disabled logic was introduced in crrev.com/798268 to achieve sharp > text in composited layers with fractional transform. It is expected to > cause performance regressions for JavaScript animations without > will-change:transform. > > This CL won't cause loss of all crrev.com/798268. A composited layer > will be still initially drawn with perfect raster translation if > eligible. Only skip update of raster translation on subsequent > fractional transform changes. > > Bug: 1123555 > Change-Id: Id220df3f05c9757ea571ea948a529b2e247d7483 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386657 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803576} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123555 Change-Id: I16a8d1bbc362d1eafe39b56814d82b29f2eedafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396577Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804803}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e00cd77675baecbf0c7cabfa030b546e4f483bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804802}
-
- 07 Sep, 2020 35 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599458176-11e2917dc2d8682a1e6ca50080f9502cff8643cc.profdata to chrome-win64-master-1599480000-359ed9b37932456efdafd52df427d9044e87d251.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4e6fd62c0663487051b1e6171a5be53a80c8dc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396282Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804801}
-
Nela Kaczmarek authored
This change records GetChangePasswordURLMetric in AffiliationService and FetchTimeMetric in AffiliationFetcher. Bug: 1108279 Change-Id: Ibbeb4fc29e30c8b28dd98e8312608f64ed9173d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385360 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#804800}
-
Nick Diego Yamane authored
Detaching a tab by dragging it upwards was not supported until crrev.com/c/2362987, which modified wl_data_device::leave event handling so that it dispatches fake motion events with [-1,-1] location, so giving higher level GUI components (e.g Chrome's TabDragController) a chance to detect when the pointer leaves that window. Such approach works, but it turns out to cause an issue in the drag offset calculation as can be seen in screen cast [1]. This issue can be avoided by keeping the 'x' coordinate value and using -1 only for 'y'. NOTE: This is a workaround targeted specifically to Chrome's tab drag and should ideally be reworked in the future, with a broader change, in higher level layers, such that they handle platforms that do not support global screen coordinates appropriately. Further context: The aforementioned problem happens because //chrome code assumes global screen coordinates are available in platform located events, in this specific case, TabDragController uses a vertical "magnetism" constant to determine when to detach the dragged tab selection [2]. Such constant may result in coordinates outside the browser window boundaries, mainly when dragging upwards, which is ok in a platform where screen positions are available. That's not the case for Wayland, where DND is used for tab dragging, where neither implicit grab is supported. [1] https://youtu.be/NKv4h4Ut-gw [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_drag_controller.cc;l=1105-1107;drc=6e8b402a6231405b753919029c9027404325ea00 R=msisov@igalia.com Test: Covered by ozone_unittests Bug: 896640 Change-Id: I4909acaa7e8a9fbb17968a4ec38632ac61915a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388762Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804799}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic94ebe50a2618bcbfa0122d94f2700dc5d8614bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396617Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#804798}
-
Roberto Moura authored
Currently the thumb strip coordinator is owned by the browser coordinator, which makes it simple to set up references to the tab strip and toolbar controllers, for example, that are needed to animate the transition from tab strip to thumb strip. However, the thumb strip will need a reference to the tab grid view controller in order to propagate the layout transition from thumb strip to tab grid. This means it's best for the thumb strip coordinator to be owned by the tab grid coordinator. - Create the ThumbStripAttacher protocol, implemented by the browser view controller. It defines an interface to set the pan handler reference and set up the thumb strip. - Create two references inside the tab grid coordinator (regular and incognito thumb strip attachers) that are set up after starting the thumb strip coordinator. Change-Id: Ic1d5706c1a9110e4387b5c1a3f8a7d0c9d88cbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340911 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#804797}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e687f6142d67..0c069f3956ff 2020-09-07 pfaffe@chromium.org Tidy up the debugger language plugins test case If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75585cf85b718e88366bb85cd6d187208189c26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396400Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804796}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7026a1db5b74..132445728c15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I30b9d8ac7493787aebea3ff4300ac4e258b35f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396595Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804795}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/132445728c15..d3b36eb57c37 2020-09-07 hjd@google.com Merge "Remove unused 'using' decelerations" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If44e59ed9b135974376c1035bfaf887157801db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396399Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804794}
-
Rob Buis authored
When laying out rows [1] lspace and rspace values from operators need to be taken into account. Since we did not introduce embellished operators yet, this CL just takes into account row children that are of type <mo> [2]. [1] https://mathml-refresh.github.io/mathml-core/#layout-of-mrow [2] https://mathml-refresh.github.io/mathml-core/#dfn-embellished-operator Bug: 6606 Change-Id: I35cb69724fa58f39c18511ce13ec941f5536a7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390652 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#804793}
-
Fredrik Söderqvist authored
Tbr: schenney@chromium.org Bug: 874567 Change-Id: Ie4301672f19f320775faa34917923d298e3eae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396087Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#804792}
-
Maksim Sisov authored
This CL fixes a copy-paste issue by always recreating wl_data_source upon Write() calls. Problem: whenever a user copies some data into clipboard inside a browser window, each second copy request gets cancelled and it's impossible to paste the copied content (see the description of the bug to have more data). The reason is that wl_data_source_listener. cancelled is called whenever wl_data_device_set_selection is called. Previously, if a user copied something into clipboard for the first time, a new wl_data_source was created and selection was set. When they did so again, the same data source was used and the same selection is set as it's required by the Wayland protocol. However, there is one problem with that - whenever wl_data_device_set_selection is called, wl_data_source_listener.cancelled is called, which means the previous selection is cancelled and the data source shall be destroyed. Though, destruction of the data source results in empty clipboard because it was used the write previous clibpoard contents. Here is the visual representation - I. offer 1) create data_source[0] 2) offer clipboard data to data_source[0] 3) set selection source from the data_source[0] 4) the data is sent and other clients are able to read that II. offer 1) reuse existing data_source[0] 2) repeat 2-3 from I. 3) get wl_data_source_listener.cancelled that results in destroying data_source[0] 4) the data is no longer available and clients are not able to read that. III. offer 1) repeats 1-4 from I. IV. offer 1) repeats 1-4 from II. etc.. As can be seen, Wayland invalidates the previous selection, which happens asynchronously, and that results in inavailability of offered clipboard data on each even offer. Thus, always create a new data source for each Write() request so that it's not invalidated. I also checked some other clients such as weston-terminal (from clients folder), glfw, and others to ensure the correctness of this patch. Bug: 1074298 Change-Id: I6cb8dd9e256ea39bf6f02eb81f230fcb92db9656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395915 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#804791}
-
Xianzhu Wang authored
Bug: 1074676 Change-Id: Icc0a378ef18a879eb9a3128bbdf5d302d9a6a155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161466 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804790}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d46db9f1523a..9e9c8b7155d4 2020-09-07 nisse@webrtc.org Delete obsolete method AudioReceiveStream::OnRtpPacket 2020-09-07 ilnik@webrtc.org Mark Cricket::VideoEncoder as RTC_EXPORT 2020-09-07 tommi@webrtc.org Make MessageHandler cleanup optional. 2020-09-07 jleconte@webrtc.org Fix makedirs error in swarming task when directory already exists. 2020-09-07 philipp.hancke@googlemail.com Reland "reenable mouse_cursor_monitor tests on linux" 2020-09-07 nisse@webrtc.org Delete obsolete TODO comment 2020-09-07 mbonadei@webrtc.org Refactor cpu_features_wrapper.h functions from C to C++. 2020-09-07 nisse@webrtc.org Rename PlayoutDelay --> VideoPlayoutDelay, move to api/video/video_timing.h 2020-09-07 mbonadei@webrtc.org Fix PRESUBMIT.py warnings. 2020-09-06 mbonadei@webrtc.org Reland "Merge cpu_features build targets into //system_wrappers." 2020-09-06 tommi@webrtc.org Trigger CI bots. 2020-09-05 mbonadei@webrtc.org Revert "Merge cpu_features build targets into //system_wrappers." 2020-09-05 mbonadei@webrtc.org Merge cpu_features build targets into //system_wrappers. 2020-09-05 kwiberg@webrtc.org Don't make up names with double underscores 2020-09-04 tommi@webrtc.org Stop using AutoThread in Thread::Send and make it test only. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116430 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If0e21cb6796bfa4ceb5a760118c1ef55233dfc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396397Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804789}
-
Christian Dullweber authored
Remove migrations older than 9/2019. Change-Id: Ibf71701fcc61dfecb0bc048c9315136d8bf5e30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390640Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#804788}
-
Alice Wang authored
This CL removes the usage of ChromeActivity in AccountPickerDelegate#addAccount() for context. Bug: 1125068 Change-Id: I73b82d63352d7d12243bbd9d28ec06455e24c270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395755Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804787}
-
Alice Wang authored
This CL sets the mOnSignInErrorCallback to null when dismissing the account picker bottom sheet. Bug: 1119360 Change-Id: I1ef49c670290983bd0c8c8ab1109384ea849b6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396295Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804786}
-
Alice Wang authored
This CL replaces the Runnable type with OnClickListener type for listener property keys in account picker MVC structure to make the code more readable. No behavior change for this CL. Bug: 1124737 Change-Id: Icca76471fbf40e72c56ba0860cf88988c5e10306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395776Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804785}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009070800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/MBa6MCxB3WE7lJhgKj4RgNE3r2vfNGc3LuUAsnjqIKsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159901790,b/161558109,b/165394926,b/167372474 Tbr: media-app@grotations.appspotmail.com Change-Id: If808fd3f63ba42dfc2f6d7f828d01a7f368f1b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396396Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804784}
-
Adrienne Walker authored
To be consistent with the base functions that are being called, rename functions to be DeleteFile/DeletePathRecursively. RemoveFile is no longer needed as DeleteFile handles both deleting files and non-recursive directories. This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2365358 Bug: 1119547 Change-Id: I4b34722e18d04fec9456753ddde525fa6c672d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391657Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804783}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e2dc5446. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ibbaf51971b26ea31c1ea7ff80edfb796c14f3bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396475Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804782}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/27e1867266a0..7026a1db5b74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id0fc23671818080452fa3ec7ac8298a302ee3382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804781}
-
Sylvain Defresne authored
ScreenTime framework is only available with Xcode 12 or later. However, Xcode 12 is still not required to build Chromium on iOS. Add compilation guard checking for availability of iOS 14 or later SDK before using code from ScreenTime framework. Bug: 1123704 Change-Id: Ia63dcea01ab5973b564db39afe56b910caf6297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396139 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#804780}
-
Richard Knoll authored
This will set the bounds rect of the ink drop container so the animation is within the inline reply text input. Also fixes the starting point of the animation to be relative to the container instead of the reply button. Before / After screenshots: https://imgur.com/CC787wK Bug: 1090324 Change-Id: I7dd9918bcd13c28b7def8725fc2f3fe3ca7adc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395655 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#804779}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e3a68fcd24b..e687f6142d67 2020-09-07 pfaffe@chromium.org [wasm-debug] Show variable values on mouse over 2020-09-07 patrick.brosset@microsoft.com Console: Fix copying content when selection reaches un-rendered items If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113215,chromium:1115011 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieaaa40fc57b9e0e7a2e562e7278a799ad3b0aa9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396435Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804778}
-
Olivier Robin authored
Manual Roll: - BottomNavigation strings file was removed https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/c627e50db7d3..01b1cbaa6621 $ git log c627e50db..01b1cbaa6 --date=short --no-merges --format='%ad %ae %s' 2020-09-03 afweiss Remove pre-iOS 10 handling for voiceover now that components support iOS 10+ 2020-09-03 no-reply Issue:- We currently disable tap for message text view. 2020-09-03 no-reply Silence warnings when including a header with a method that uses deprecated declarations. 2020-09-03 andrewoverton [TextControls] Improve TextControls test coverage 2020-09-02 yar [Ink] Official deprecation of Ink. Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: I8d503e583989e965f112e583b174b9d62e679bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396296 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#804777}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7026a1db5b74..132445728c15 2020-09-07 hjd@google.com Improve error message in chrome_slices/controller.ts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:167442237 Tbr: perfetto-bugs@google.com Change-Id: Iea38b412d14fc94f7297dc473130158bb80bd1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804776}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99f3de1e8e44..a56a85e63bec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yiyix@google.com,battre@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yiyix@google.com,battre@google.com Change-Id: I037f39d0bcbc5a9d2683ba3afa776fb228c06a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396285Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804775}
-
Antonio Sartori authored
This CL adds logic for parsing the plugin-types Content-Security-Policy directive to the services/network CSP parser. Bug: 1094909 Change-Id: I05dd7caf7b2d3c513b80f2265723bc1a0be04b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346657 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804774}
-
Polina Bondarenko authored
ArcDataSnapshotdManager starts/stops arc-data-snapshotd daemon. ArcDataSnapshotdBridge delegates ARC data/ snapshot related commands to arc-data-snapshotd via D-Bus. BUG=b:161221001 TEST=unit_tests TEST=start up arc-data-snapshotd on local device Change-Id: Ie74eac22d10bc0a1ff451d6a2187c4de534843c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335445 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#804773}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/848503c434c0..7026a1db5b74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idddb75d41a3cb34885c0a037a76a425cf22b4f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395119Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804772}
-
Irina Fedorova authored
This CL adds OnWeakCredentialsChanged to the observer interfase in InsecureCredentialsManager. Bug: 1119752 Change-Id: I6619f06d06cf99113ddb05b4e12a69110b531460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391122 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#804771}
-
Robbie Gibson authored
This reverts commit ddd44b8b. Reason for revert: Internal tests still failing Original change's description: > Reland "[ios] Turn on FullscreenControllerBrowserScoped by default" > > This is a reland of 5f4895f5 > > Original change's description: > > [ios] Turn on FullscreenControllerBrowserScoped by default > > > > Bug: 790886 > > Change-Id: Ide1eee5634376b90cfa820bb61644c871969ff86 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358589 > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > > Auto-Submit: Chris Lu <thegreenfrog@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#800354} > > Bug: 790886 > Change-Id: I279349dd1b45de347600c26e8d32e5d9d33b5b65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395695 > Reviewed-by: Mark Cogan <marq@chromium.org> > Reviewed-by: Robbie Gibson <rkgibson@google.com> > Commit-Queue: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804737} TBR=marq@chromium.org,sczs@chromium.org,thegreenfrog@chromium.org,rkgibson@google.com Change-Id: Ief9473b6d8a3eb772f78aa21e353751c0de785ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396123Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#804770}
-
Dominik Röttsches authored
After [1] unique font requests to AndroidFontLookup should be sent out in case-folded form. This matches what we do for fonts from the firmware set of font files. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2389224 Bug: 1115064 Change-Id: Iab587b7a7cea526be79b25805dad5095ca8a6617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396136Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#804769}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/aa2b76a46973..69e45dc92bd0 2020-09-07 jleconte@google.com Fix small issues with Monorail project id integration for NEW BUG triaging. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: wenbinzhang@google.com Change-Id: Ica2efd5d239619cfb0aae28e25be1883b55a6b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396277Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804768}
-
Hiroki Nakagawa authored
OutsideSettingsCSPDelegate is designed as ExecutionContext-free as much as possible. This CL reduces usage of WorkerOrWorkletGlobalScope there by... - replacing thread checks with base::ThreadChecker utility, and - logging in the use counter using blink::UseCounter interface. This doesn't change functional behavior. Bug: n/a Change-Id: Iae6ffc504e5f6513369525aeec8a3544cdb76b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391892 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#804767}
-