- 03 Aug, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9adf7905..091fee47 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib35b94b64ad14b45db621938f4ad10e2e7d907c8 Reviewed-on: https://chromium-review.googlesource.com/1161750Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580495}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/84dd183a82c3..434a112d2537 git log 84dd183a82c3..434a112d2537 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 cb4ae446080b..81f891d043cb (1 commits) Created with: gclient setdep -r src/third_party/skia@434a112d2537 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ib2399fae7ab104c5f26413e3a7077ad74625fb12 Reviewed-on: https://chromium-review.googlesource.com/1161152Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580494}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91470e7e. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22267 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ibfee270916940a6d4b630cce7a17c411eae70f0c Reviewed-on: https://chromium-review.googlesource.com/1161746 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580493}
-
BUG=762641 TBR=alemate@google.com Change-Id: I544632383b2930a1e52567c29d3b722113cae153 Reviewed-on: https://chromium-review.googlesource.com/1160729Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580492}
-
Balazs Engedy authored
Bug: 870236 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I28598b680ec8901f0b0bf2fb0c9496ec8366e190 TBR: vmpstr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1161912Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580491}
-
Michael van Ouwerkerk authored
Bug: 843161 Change-Id: I433cad8d86b34d64de99e13281d84c953d9bf3b1 Reviewed-on: https://chromium-review.googlesource.com/1150225Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#580490}
-
Bernhard Bauer authored
This will allow extracting a mediator that interacts only with the model. Bug: 847420 Change-Id: I2cfc0f816ae04570dcc12f40757339fc4ed5de0c Reviewed-on: https://chromium-review.googlesource.com/1142153Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580489}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb4ae446080b..81f891d043cb git log cb4ae446080b..81f891d043cb --date=short --no-merges --format='%ad %ae %s' 2018-08-03 oetuaho@nvidia.com Make sure ProgramGL stays usable after failed glProgramBinary Created with: gclient setdep -r src/third_party/angle@81f891d043cb The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I893a6271f0a645c116661a2e9aaa50fc1a887187 Reviewed-on: https://chromium-review.googlesource.com/1161150Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580488}
-
Boris Sazonov authored
This CL connects together ConsentBumpFragment and ConsentBumpMoreOptionsFragment. It also adds slide_out_left and slide_in_right animations resources used for the transition between two fragments. Bug: 869426 Change-Id: I1ff4f6fc1a3585bdd667bb24d567365a60ec9468 Reviewed-on: https://chromium-review.googlesource.com/1159074Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#580487}
-
Boris Sazonov authored
This CL adds a check to hide the description text view in RadioButtonWithDescription if it contains an empty string. Bug: 869426 Change-Id: I9e0b26303a0d98b2d44944818927f0acea5aaa59 Reviewed-on: https://chromium-review.googlesource.com/1159072Reviewed-by:
-
Jérôme Lebel authored
Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2f2e14ceba73ebecbc9c0222ae87ea86e4f91a49 Reviewed-on: https://chromium-review.googlesource.com/1159062Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580485}
-
Adam Rice authored
Enable WebSocketHandshakeReuseConnection in fieldtrial_testing_config.json so that it gets testing coverage on the bots before it becomes the default. BUG=423609 Change-Id: I692aa12c5685d61a47b26aa014d10db7bb91d98a Reviewed-on: https://chromium-review.googlesource.com/1151182Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580484}
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same namespace/scope and conflict. This happens for the function UserDataKey. Since the function relies on that the static int is unique this function could not be moved to a shared util file. Instead, the issue was solved by renaming the function. Bug: 869381 Change-Id: Ifd67ac865e9d0bad272cc51ef1af8c3a5b382893 Reviewed-on: https://chromium-review.googlesource.com/1160487Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#580483}
-
Oscar Johansson authored
When building using jumbo, files gets merged and enums with the same name may end up in the same namespace and conflict. This happens for he enum LoginTableColumns. This commit solves the issue by renaming one instance of LoginTableColumns to something more file specific. Bug: 869381 Change-Id: I9a0b95dcddee3bbc9f1b8969142aa683e11025a0 Reviewed-on: https://chromium-review.googlesource.com/1160496Reviewed-by:
-
Scott Wu authored
Note: This CL is almost a clone of https://chromium-review.googlesource.com/c/chromium/src/+/1060634 by removing cwv_password_controller and fixing conflicts. Bug:865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I318fba363d7f6edd8d7b187b29d7e500955f498e Reviewed-on: https://chromium-review.googlesource.com/1149778 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#580481}
-
Jakub Pawlowski authored
This template can generate code that does not compile, if there are multiple fields with different versions where at least one has version 0 and end up being laid out in a way that does not match the ordinal order Sample Mojo file: // Describes ARC package. struct ArcPackageInfo { string package_name; int32 package_version; int64 last_backup_android_id; int64 last_backup_time; bool sync; // true if package installation should be synced [MinVersion=11] bool system; // true if package is system package. // true if package registers VPNService intent. [MinVersion=25] bool vpn_provider; }; Sample badly generated code (no closing "}" for last if): @SuppressWarnings("unchecked") public static ArcPackageInfo decode(org.chromium.mojo.bindings.Decoder decoder0) { if (decoder0 == null) { return null; } decoder0.increaseStackDepth(); ArcPackageInfo result; try { org.chromium.mojo.bindings.DataHeader mainDataHeader = decoder0.readAndValidateDataHeader(VERSION_ARRAY); final int elementsOrVersion = mainDataHeader.elementsOrVersion; result = new ArcPackageInfo(elementsOrVersion); { result.packageName = decoder0.readString(8, false); } { result.packageVersion = decoder0.readInt(16); } { result.sync = decoder0.readBoolean(20, 0); } if (elementsOrVersion >= 11) { { result.system = decoder0.readBoolean(20, 1); } } if (elementsOrVersion >= 25) { { result.vpnProvider = decoder0.readBoolean(20, 2); } } if (elementsOrVersion >= 0) { { result.lastBackupAndroidId = decoder0.readLong(24); } { result.lastBackupTime = decoder0.readLong(32); } } finally { decoder0.decreaseStackDepth(); } return result; } Change-Id: I4c1b573a71b20cc6a0828a2cceff6bbfbb4ac5bc Reviewed-on: https://chromium-review.googlesource.com/1158702Reviewed-by:Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Jakub x Jakub Pawlowski <jpawlowski@google.com> Cr-Commit-Position: refs/heads/master@{#580480}
-
Gauthier Ambard authored
This CL adds a way for the user to select an option in the ConsentBump personalization screen. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4da17b939a6ada46e8a8e6418a1c11e846014ed Reviewed-on: https://chromium-review.googlesource.com/1160842 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580479}
-
Ned Nguyen authored
The extra v8 benchmarks we want to schedule on android-go-perf builder are: v8.browsing_mobile speedometer speedometer2 Steps that I did to generate this reshard: 1) Update the android-go-perf's story timing data by running: ./tools/perf/core/retrieve_story_timing.py -c 'android-go-perf' --output-file=tools/perf/core/shard_maps/timing_data/android_go_timing.json 2) Copy the story runtime of v8.browsing_mobile, speedometer, speedometer2 to android_go_timing.json 3) Generate the benchmark shardings with: ./tools/perf/generate_perf_sharding --timing-data tools/perf/core/shard_maps/timing_data/android_go_timing.json --num-shards=19 --output-file tools/perf/core/shard_maps/android_go_shard_map.json --benchmarks=memory.top_10_mobile,system_health.memory_mobile,system_health.common_mobile,power.typical_10_mobile,start_with_url.cold.startup_pages,start_with_url.warm.startup_pages,system_health.webview_startup,v8.browsing_mobile,speedometer,speedometer2 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I8a0696dc8b73092f4289b4abca60a40d92458e98 BUG: chromium:863767 Change-Id: I8a0696dc8b73092f4289b4abca60a40d92458e98 Reviewed-on: https://chromium-review.googlesource.com/1160766 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580478}
-
Gauthier Ambard authored
This CL adds the options displayed by the ConsentBump personalization screen. For now it is not possible to interact with those options. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I069f1b2c242e8a56ad15f3c45ffd85d863c0db67 Reviewed-on: https://chromium-review.googlesource.com/1160649 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f357c021..9adf7905 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If9b1743ffe295daf7be8450420b1a876f70f480e Reviewed-on: https://chromium-review.googlesource.com/1161620Reviewed-by:
-
Scott Wu authored
Metrics recording is not enabled for ios web view. In order to make it optional in current password manager logic, refactor is needed like changing GetMetricsRecorder to return a pointer as well as adding nullptr checking logic. Bug: 868817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8a5b7c9a835e72992a04cb15758a4e2ee86d748c Reviewed-on: https://chromium-review.googlesource.com/1154848 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
-
Peter E Conn authored
Split CustomTabActivity's PageLoadMetrics.Observers according to their purpose. Also create the TabObserverRegistrar class that deals with attaching these observers to Tabs as they enter and exit the TabModel. Bug: none Change-Id: Ic434ead9c5167eb876f91af33b54dfd3d50493cd Reviewed-on: https://chromium-review.googlesource.com/1154968Reviewed-by:
-
Takuto Ikuta authored
This is for more than 30 mins compile steps like below builds. 3482s https://ci.chromium.org/b/8939283904169846144 2889s https://ci.chromium.org/b/8939330795897045184 2670s https://ci.chromium.org/b/8939259288541607584 Bug: 804251 Change-Id: I052b8f2cae46fe4987f88316b67f81c17243fdb3 Reviewed-on: https://chromium-review.googlesource.com/1161705Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#580473}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e16a2e80be66..d38bbdff043d git log e16a2e80be66..d38bbdff043d --date=short --no-merges --format='%ad %ae %s' 2018-08-03 sadrul@chromium.org rendering: Fix filtering events. Created with: gclient setdep -r src/third_party/catapult@d38bbdff043d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:868650 TBR=sullivan@chromium.org Change-Id: I7264905b5a4821446dcdf3f49b95132105460608 Reviewed-on: https://chromium-review.googlesource.com/1161147Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580472}
-
Giovanni Ortuño Urquidi authored
Introduces a BookmarkAppInstaller class whose job is to create a Bookmark App with certain characteristics e.g. name, start url, launch container, etc. The BookmarkAppInstaller class uses CrxInstaller to actually create and install the BookmarkApp. Currently the installer only takes a WebApplicationInfo but in the future it'll support more options, for example, if the app will be synced, what container will the app launch in, etc. Marks BookmarkAppInstallerTest as a friend in CrxInstaller so that we can create a fake CrxInstaller that fails to install the app. Bug: 864904 Change-Id: I105d1e93160f2527ee6cb5c4951fab885a893392 Reviewed-on: https://chromium-review.googlesource.com/1152642 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580471}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d4de71b02044..64cb8d9d67fb git log d4de71b02044..64cb8d9d67fb --date=short --no-merges --format='%ad %ae %s' 2018-08-03 hinoka@google.com Don't runhooks in annotated run Created with: gclient setdep -r src/native_client@64cb8d9d67fb The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: I29df247c49c65412c57c42308c9c7d1290a9025c Reviewed-on: https://chromium-review.googlesource.com/1161148Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580470}
-
Alexey Baskakov authored
Bug: 860581 Change-Id: Id8a879d680bf220d46930543a43b92b1d74d6bcf Reviewed-on: https://chromium-review.googlesource.com/1159550 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580469}
-
Kunihiko Sakamoto authored
Mark virtual/paint-touchaction-rects/fast/events/touch/touch-latched-scroll-node-removed.html as flaky Tbr: xidachen@chromium.org Bug: 870595 Change-Id: Ie37dab1122f12a1b6b608ba7ac9976d7d9e56cdb Reviewed-on: https://chromium-review.googlesource.com/1161714Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580468}
-
Kunihiko Sakamoto authored
This reverts commit db560919. Reason for revert: This made ExtensionWebRequestApiTest.WebRequestTestOSDD flaky. crbug.com/870588 Original change's description: > Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service > > Getting this test working required a few fixes: > - Modifying a header rather than Set-Cookie for some tests, which > required switching to XMLHttpRequest (crbug.com/827582) > - Handling redirect from http:// -> chrome-extension://, and bypassing > security checks if this is from web request > - Plumbing through whether the request is async or not > > This is not handling subresource redirects because subresource > redirects to schemes other than http/https/data are not supported > yet with network service (crbug.com/868545). > > Also adds a bunch of tests for redirects. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Iabca6e5890b0d5edd066fd8945b19bdbb5d52670 > Reviewed-on: https://chromium-review.googlesource.com/1145956 > Reviewed-by: Nick Carter <nick@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580365} TBR=nick@chromium.org,jam@chromium.org,reillyg@chromium.org,karandeepb@chromium.org,cduvall@chromium.org Change-Id: Ib831aea7b5afeb6b0e06c79a1d80520d61e02dbf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414,870588 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1161821Reviewed-by:
-
Ross McIlroy authored
With scheduled script streaming and background compilation it is now worthwhile to stream smaller scripts. Enable support for streaming these smaller scripts when the ScheduledScriptStreaming trial is enabled to investigate performance impact. BUG=chromium:865098 Change-Id: Ia7691dbe9f8dd970aafda2715a34edc3ef16616b Reviewed-on: https://chromium-review.googlesource.com/1160653Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580466}
-
Kunihiko Sakamoto authored
This reverts commit 553ec6da. Reason for revert: The new tests are failing on Win10 Tests x64 and Win7 Tests (1) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/26185 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20(1)/82347 Original change's description: > [Sync::USS] Bookmark sync conflict resolution > > This patch addresses the problem of conflict in bookmarks upon > receiving a remote update for a node that has local changes. > > The general polic that is implemented is that server wins except in > case of deletion. > > Bug: 516866 > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 > Reviewed-on: https://chromium-review.googlesource.com/1157006 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580436} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I148386f4fe2391f5c895288924aefa2f4f88d00b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/1161683Reviewed-by:
-
Kyoko Muto authored
BUG= 867331 Change-Id: I886542193ed17743d8e10c11ae9c2c5036c8187b Reviewed-on: https://chromium-review.googlesource.com/1159937 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580464}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7917065. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22261 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jsbell@chromium.org: external/wpt/encoding external/wpt/resources msramek@chromium.org, mkwst@chromium.org: external/wpt/clear-site-data TBR=foolip No-Export: true Change-Id: Ic5e40a323daad97a8358872fe0dd1f70438b4d20 Reviewed-on: https://chromium-review.googlesource.com/1161617 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Marc Treib authored
Followup to https://crrev.com/c/1148392, which introduced IsSyncFeatureEnabled and made IsSyncActive depend on it. Bug: 856179 Change-Id: Icfc6e35550285ec7688b0de0cdce9c161d2049cc Reviewed-on: https://chromium-review.googlesource.com/1160850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580462}
-
Darren Shen authored
VirtualKeyboardAppWindowTest.DisableOverscrollForImeWindow tests that we don't reduce the viewport size of IME related windows (like the floating candidate window when you gesture type). However, the test uses ShowKeyboard(true), which shows the locked keyboard. When the locked keyboard appears, we don't overscroll. Rather, we reduce the size of the work area, shrinking the actual size of the window. The test still passes because shrinking the work area also shrinks the viewport size. This patch changes the test to use ShowKeyboard(false), which triggers overscrolling. This matches the original intent of the test more closely. TBR=yhanada@chromium.org Bug: 849995 Change-Id: Ifdbea75c5b84081fc67cd29e3af21f1984b4a4eb Reviewed-on: https://chromium-review.googlesource.com/1160064Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#580461}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d146987b6945..ee09b25fcad3 git log d146987b6945..ee09b25fcad3 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 vapier@chromium.org toolchain: fix default selection in toolchain.conf processing 2018-08-03 dgarrett@google.com workspace: Use a reference repo if available. 2018-08-03 tikuta@chromium.org cros_chrome_sdk: Invoke gomacc inside compiler wrapper 2018-08-03 dgarrett@google.com run_tests: Move new tests into chroot. Created with: gclient setdep -r src/third_party/chromite@ee09b25fcad3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I33d5604f2d2b82439546ffb89f5bd9b246f68a06 Reviewed-on: https://chromium-review.googlesource.com/1161347Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580460}
-
Mark Cogan authored
This CL fixes the size distortion of the incognito NTP in the new tab animation. The foreground animation view was assuming that the content view it animated had the same bounds as itself; this isn't correct for the incognito NTP, which is shorter to accommodate the toolbar. This CL instead repositions the content view correctly without resizing it. It also makes the animation view shorter (by StatusBarHeight()) to make this calculation cleaner. Bug: 868292 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id49a3de2f3f62c246356da082f74285014a7b37a Reviewed-on: https://chromium-review.googlesource.com/1160843Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580459}
-
Abhishek Bhardwaj authored
Add an |is_tethered| field to the WiFi struct embedded in NetworkConfiguration. This field will tell the instance whether a WiFi configuration is tethered. BUG=b:62926617 TEST=Verify the is_tethered field is true when Chrome OS is connected to a mobile hotspot and false otherwise. Change-Id: I5dfc9f019be585fab435000f39a10661d2d35894 Reviewed-on: https://chromium-review.googlesource.com/569099 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
-
Jennifer Apacible authored
A previous change made controls always appear when the mouse is moving on all OS except Windows. This change gates handling the ET_MOUSE_MOVED event to Windows OS. Bug: 870120 Change-Id: I556c354643a920c34b973066369e26f38130705f Reviewed-on: https://chromium-review.googlesource.com/1161300 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#580457}
-
Kunihiko Sakamoto authored
This reverts commit 381beab3. Reason for revert: Suspected of breaking browser_tests on Mac. crbug.com/870579 Original change's description: > chrome: Call SetUpBundleOverrides from ChromeMain. > > It looks like we always need to call SetUpBundleOverrides no matter > what the process type is, so we can just call it from ChromeMain. This > will save us from needing to call this function from browser-specific > code in a later change. > > While here, also remove a dead declaration. > > Bug: 855193 > Change-Id: I449d92ef9c7d80d066d4cfefb3015014bd407cc1 > Reviewed-on: https://chromium-review.googlesource.com/1159335 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580285} TBR=avi@chromium.org,pcc@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I32f905ff8f82306a85fbc9798652b8c99aa46009 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855193,870579 Reviewed-on: https://chromium-review.googlesource.com/1161722Reviewed-by:
-
