- 05 Oct, 2020 40 commits
-
-
David Tseng authored
This getter returns an instance of Cursor, but it should return an instance of either Cursor or WrappingCursor. R=akihiroota@chromium.org of a page that has a text field at the end. Bug: none Change-Id: Id52523c4b391d175303130c3f5494a1bf63c2f13 AX-Relnotes: ChromeVox will now wrap correctly when moving forward from the end Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450209Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813915}
-
Caitlin Fischer authored
This is done by updating the histograms config model and by uncommenting the call to ExpandHistogramsOWNERS() in merge_xml.py. This ensures <owner>src/dir/OWNERS</owner> is expanded into actual owners, e.g. <owner>name1@google.com</owner> and <owner>name2@chromium.org</owner>. Uncommenting this allows components to be extracted from OWNERS files as well. That way, component info, if available in an OWNERS file, is added to histogram expiry bugs, e.g. http://crbug/1088985. Also, add component documentation and add a component to two Variations.Headers.* histograms. Support was previously added for component tags, see http://crbug/989112 for details, but it wasn't explicitly used. Bug: 1133699 Change-Id: I572c877be8929923fd14df352e762a7a293ca5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442136Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813914}
-
Chris Sharp authored
TBR=qinmin@chromium.org Bug: 1106059 Change-Id: Ie241c0a80c0f6b6788f8a8ee6df7208f57f42d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449911Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813913}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/745402dd650a..96edaff6ceb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kristipark@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073584,chromium:1129255 Tbr: kristipark@google.com,csharp@google.com Change-Id: I8522a9d6cd92e9e6d353bdc85db4d7e68b342ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450520Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813912}
-
Muyao Xu authored
The user can start a new cast session by clicking on the cast device button. If the session starts successfully, the GMC dialog will be closed. If the session fails to start, an error message will show up as the subtitle on the button (This is implemented by the CastDialogController class. Bug: b/161610050, 1107162 Change-Id: Ibaad612115ba73d8e883455cf89ec6e1a6cda401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441107Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#813911}
-
Lukasz Anforowicz authored
After a recent migration (ending with https://crrev.com/c/2443398) factories are never put into the NonNetworkURLLoaderFactoryDeprecatedMap, except in a handful of tests. This CL removes these remaining uses in the test code (in DownloadTestContentBrowserClient, NavigationUrlRewriteBrowserTest, FirstPartySchemeContentBrowserClient) and proceeds to entirely remove the NonNetworkURLLoaderFactoryDeprecatedMap type alias from ContentBrowserClient. This also allows removing the following things: - |uniquely_owned_factories| parameter from RegisterNonNetworkNavigationURLLoaderFactories and RegisterNonNetworkSubresourceURLLoaderFactories methods - Code processing |uniquely_owned_factories| in callers of the two Register...Factories methods above (e.g. in DownloadManagerImpl::BeginResourceDownloadOnChecksComplete, EmbeddedWorkerInstance::CreateFactoryBundleOnUI, WorkerScriptFetchInitiator::CreateFactoryBundle) - Fields that (unsuccessfully/incorrectly) attempted to extend the lifetime of the factories in: NavigationURLLoaderImpl and RenderFrameHostImpl. Fixed: 1106995 Tbr: kmarshall@chromium.org for //fuchsia/engine Tbr: karandeepb@chromium.org for //extensions/shell Tbr: boliu@chromium.org for //android_webview Tbr: seantopping@chromium.org for //chromecast/browser Change-Id: Id1a0b8c91d07a68df3b7c907ed6315242fce8141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359402 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#813910}
-
Vincent Boisselle authored
Change-Id: I4378c135745eff9693a7d013d423a6f018dee649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440907 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#813909}
-
Chris Sharp authored
Currently print_backend_mojom_traits.h includes printing/backend/print_backend.h" so without this deps this target can't be built by itself. TBR=awscreen@chromium.org Bug: 1135263 Change-Id: Ic597468dcdaefbb83e145ef82bb4f4d6b93ef6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449916Reviewed-by:
-
Sebastien Marchand authored
This create some issues in some tests, they fail with the following stack trace: BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x56400bd836c9 base::debug::CollectStackTrace() #1 0x56400bcb90c3 base::debug::StackTrace::StackTrace() #2 0x56400b74b5e6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fdc5b8c84c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x564010b453b0 __llvm_profile_merge_from_buffer #5 0x564010b43705 writeFile #6 0x564010b43547 __llvm_profile_write_file #7 0x564010b43874 __llvm_profile_dump #8 0x56400bda6373 base::WriteClangProfilingProfile() #9 0x56400d8cb484 content::ChildProcess::~ChildProcess() #10 0x564010780118 content::RenderProcessImpl::~RenderProcessImpl() #11 0x564010688274 content::InProcessRendererThread::CleanUp() #12 0x56400bd6c2b8 base::Thread::ThreadMain() #13 0x56400bd9a8d9 base::(anonymous namespace)::ThreadFunc() #14 0x7fdc60fa16ba start_thread #15 0x7fdc5b99a4dd clone This call to base::WriteClangProfilingProfile has been recently[1] added to ChildProcess::~ChildProcess to ensure that the child utility processes properly flushed their profiling data at shutdown. This was an issue when running the PGO profiling scenarios as some child processes were terminated too aggressively and sometime didn't had a chance to fully write their profiling data. It doesn't seem to affect the coverage data (and this change brings the coverage build back to the state it was in before [1]). We should ideally also look at this crash and understand why it's happening, this CL really just prevent this crash from happening by not calling the problematic function when it's not needed. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2378272 Bug: 1065485 Change-Id: I051ab0993216a887a38863070b554e02ba60bb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450332Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#813907}
-
Solomon Kinard authored
Bug: None Change-Id: I68116f7a2973551f7dfc22fd4705574b29bd7271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450739Reviewed-by:
-
Ben Kelly authored
This feature launched to 100% on windows, mac, and android in M80. It was just enabled by default on ChromeOS in ToT after an extended period investigating performance regressions. Bug: 960012 Change-Id: I6e1edacd5f3c180f64a024cb948022aeaf130d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450495Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#813905}
-
Jeffrey Young authored
Handle failure cases better by having backup photos on disk. Refresh these images after user logs in. BUG=b:167332126 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#813904}
-
Joe Mason authored
[PM] Add WeakPtr accessors to all node types, and a PerformanceManager::GetProcessNodeForRenderProcessHost accessor R=fdoray Bug: 1134162 Change-Id: I3a47611e331d1da3193a2bdda48e5858ba2ad860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443189 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#813903}
-
Mikel Astiz authored
The number of unique clients is very low and approaching zero as the histogram expired in August 2020. Change-Id: I49d6cb443e21be64f934289c335f454287f21bff Fixed: 1097926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442014Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Matt Menke authored
It's no longer being used. Fixed: 846167 Change-Id: I3636e12cdab07188c90199329826de4ef18432f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444430Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Avi Drissman authored
Fixed: 1089369 Change-Id: I5c6a2eccee34ba5dbb6b4ea2ea6b003f86525f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442896 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Xing Liu authored
ReadingListManagerFactory should be BrowserContextKeyedServiceFactory instead of SimpleKeyedServiceFactory, since reduced mode won't work for sync and ReadingListModel. Also we build components/reading_list to Android APK, which causes android binary size increase. Bug: 1128074 Binary-Size: Size increase is unavoidable (see above). Change-Id: If5393fa5dfb133b35c1ff1b17bf709f31f8815ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441204 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813899}
-
Morten Stenshorne authored
We got it wrong when there was overflow. Use WritingModeConverter. Bug: 829028 Change-Id: Idf060c3417f254f414251a9e3287a3c8f5c6cd97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450315Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#813898}
-
Adam Langley authored
In order to make things more easily extendable in the future, make the contents of the caBLEv2 QR codes be a CBOR map. This should eliminate the need to version-switch based on a URL prefix, so drop the "/c1/" from the URL. BUG=1002262 Change-Id: Id05a38c8ba510f673594774e57d418f8259779f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444174 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#813897}
-
Eric Orth authored
These were never true timeouts but merely the period of time after querying a resolver before we would try another server or retry. The original query would keep going. Renaming these to avoid confusing myself as I add more logic for transaction timeouts (that actually will be timeouts for the overall transaction). Bug: 1109792 Change-Id: Icafcce30c5250a9164cd8b779a8ddf1b9fdbfbf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446526Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Becca Hughes authored
This reverts commit 55c1d6cd. Reason for revert: Broke official builds https://crbug.com/1135285 Original change's description: > WebUI: Replace uglify-es with terser. > > The former is deprecated and no longer receives any updates. > > Bug: 1087970 > Change-Id: I15cb6beb49eb55fb7fa7489459d7072ba8e2f66c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444486 > Reviewed-by: John Lee <johntlee@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813856} TBR=thestig@chromium.org,dpapad@chromium.org,johntlee@chromium.org Change-Id: Ifd82789f8e17dd5c19ee894fa99f08278ed5be29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1087970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450840Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813895}
-
Mason Freed authored
This CL removes the Web Components V0 APIs (Shadow DOM v0, Custom Elements v0, and HTML Imports) from the web platform. The features are still available for use by limited internal code directly, for a limited additional period. See crbug.com/1111843 for reference. These features were deprecated in August, 2018, in [1], and removed by default in Chromium M80, in [2] and [3]. For those sites that needed additional time, there was then a "deprecation extension" [4] (sometimes called a "reverse origin trial") that allowed sites to continue using these APIs through M87. Now that M87 has branched to Beta, the origin trial has now ended. These public APIs are now disabled for all sites. With this CL, several test suites are being skipped in TestExpectations, including several folders that have been prepared in advance: crbug.com/1081941 web-components-v0-only/* [ Skip ] crbug.com/1081941 virtual/web-components-v0-disabled/* [ Skip ] crbug.com/1081941 http/tests/htmlimports/* [ Skip ] Once this CL has landed and stabilized, these folders/tests will be deleted entirely. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ [2] https://chromium-review.googlesource.com/c/chromium/src/+/1850795 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1869562 [4] https://developers.chrome.com/origintrials/#/view_trial/2431943798780067841 Bug: 911943, 1111843 Change-Id: Ia7bde5af655eba43538d18ce1335ed3e72846503 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195005Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#813894}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601877511-e7db431e3df4886bdee72d3fd137fde2437674f5.profdata to chrome-win32-master-1601899131-c43b6187adc90e2cb7e0fb0be3a8513091bf4fd9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id226d83f51577d75a58974891e99401acd083b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813893}
-
Morten Stenshorne authored
A column spanner forcefully breaks a column, so any leading margins on content right after the spanner shouldn't be discarded. Bug: 829028 Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I178fab3f54a6fcf52ac41f6642c5d6b02f1408de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442889Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813891}
-
Anupam Snigdha authored
Clamped the values in |ConvertRectToScreen| to avoid integer overflow while calculating the width/height of the rectangle. Bug: 1134463 Change-Id: Ic53a8513be7393b0e58ee9d3b2019a0b71c9d703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450920Reviewed-by:
-
Darwin Huang authored
The proportion of content script reads without user activation will inform potential deprecation plan and messaging. Bug: 1051198 Change-Id: Ie9c76a6d26ee78219729ef54da7237eb061c98f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440116Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813889}
-
Haiyang Pan authored
The pool has plenty of 4-cores for extra builds: http://shortn/_koR1dg8Vvu Also the host pool also has plenty of rooms: http://shortn/_xqhW5Z67ft Bug: 997376, 1127110 Change-Id: I56b432d960c2f1821934667ac2f38d3fcb4705bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450331Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#813888}
-
Jeffrey Young authored
BUG=1103703 Change-Id: I1505384aadc98eea6e0dab4ecf51b2cd0a045e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440292Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/256b2c258767..c9e3d3e3a7e0 2020-10-05 pfaffe@chromium.org Implement support for the JavaScript formatter API 2020-10-05 sigurds@chromium.org Prepare for removal of isScrolledToBottom from Element's prototype 2020-10-05 tvanderlippe@chromium.org Typecheck sources/SourcesView.js with TypeScript 2020-10-05 bmeurer@chromium.org Fix accidentally inversed experiment. 2020-10-05 yangguo@chromium.org [ts] Type-check har_importer/HARFormat.js with TypeScript 2020-10-05 bmeurer@chromium.org [ts] Type-check worker_main/WorkerMain.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1128416,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9b23e31a76d9a4b3034134e9c0af2c18392668a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450869Reviewed-by:
-
Yu Han authored
Updates eye dropper icon for dark mode based on spec. Bug: 1125025 Change-Id: I13f8be7d4195b5ed24f781376b666668aca87c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445050Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813885}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6413f6158daede8769353c367510f44be07f7645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450725Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813884}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ef897a9c3ec2..34445b29ae40 2020-10-05 cnorthrop@google.com FrameCapture: More fixes for app updates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: Temple Run on multiple systems Change-Id: Id6000228a4b1d7c92858f5ddda0c6d6f67d1240b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448686 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Daniel Rubery authored
This metric is useful for monitoring as we work on visual features for detecting phishing. Fixed: 1089244 Change-Id: I52dc7744f3b4df1e5755f5166f2d9eac06e87b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450696 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jeff Yoon authored
These bots are specified to run on os Mac 10.14. This change adds |Mac-10.15 such that when these bots are upgraded, the bots don't fail. Bug: 1135264 Change-Id: If5e64412821f2e87815cb15d0364e5e640d6dccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450741Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#813881}
-
Xianzhu Wang authored
Previously we always baked transform origin into transform for SVG transforms in paint properties. However, when there is composited SVG transform animation, the compositor animates the transform part only, so we need to store transform origin separately in paint properties. Also disable SVG compositing when there is SMIL animation which is not supported by the compositor. Bug: 1133718 Change-Id: Icd2cf67e3952a9006ff2d74fb798a058db96a433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441386 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#813880}
-
Xinghui Lu authored
Implement OpenEnhancedProtectionSettings() in controller_client. Create an interface named settings_page_helper at component/ level and an implementation class named chrome_settings_page_helper at chrome/ level. The interface is injected to controller_client. Add Safe Browsing enhanced protection page in chrome_pages. The URL path is "security?q=enhanced". During navigation, it opens "chrome://settings/security" and expands the enhanced protection section. Bug: 1130721 Change-Id: I27b9b938d47c8ea4caed2b4da6e9b374086366e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429440 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#813879}
-
George Burgess IV authored
CrOS builders are complaining about broken flags like: `-mllvm ,-enable-dse-memoryssa=false` We should probably be dropping that `,`. This CL makes us do that. Bug: 1135234 Change-Id: I3f99498003282d8e737d3d066bc7e2e257f65dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450743Reviewed-by:
Bob Haarman <inglorion@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#813878}
-
Moe Ahmadi authored
Fixed: 1134606 Change-Id: I6e640d0680a0e737dfabcdae6b9c3e96acaa58a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446014 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813877}
-
Kartik Hegde authored
Swap the args in the function. TEST=unit_tests --gtest_filter=HttpFirewallRoutineTest* BUG=chromium:956783 Change-Id: Iffebb35c0e2971bb64d27e694e1d4412a6125268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450575Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#813876}
-
