GitLab

Default loader factories for shared workers have been created in different
places depending on the configurations of S13nServiceWorker and NetworkService.
This has been impaired code readability.

To improve it, this CL consolidates default loader factory creation.

Bug: 715632
Change-Id: Ic06cd6ab4d9f0c3ab40b45f8f8c94d26bf5b7b15
Reviewed-on: https://chromium-review.googlesource.com/1195171
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587489}

ImageFetchTabHelper uses JavaScript to fetch image data, and one of the
JS method is drawing image to <canvas> and export it as base64 string,
which does not support GIF well. Return null in that case.

Bug: 163201
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7190e74de8385b2c41ca48e00548ab2fec5151d4
Reviewed-on: https://chromium-review.googlesource.com/1194031Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587488}

This CL changes SyncAndServicesPreference to replace separate fragment
for configuring UMA reports with a checkbox. It also changes strings
used for this preference entry.

Bug: 868826
Change-Id: I8daf80eca4cf3b05f76482c236d72c923020b4ff
Reviewed-on: https://chromium-review.googlesource.com/1194041Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587487}

Bug: 878384
Change-Id: I9105fbf1d4dcd52037b2ab6a56a42f5c7124c380
Reviewed-on: https://chromium-review.googlesource.com/1194026Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#587486}

Create a new service reference instead of transferring
the existing one before resetting debug recording.

Bug: 869852
Change-Id: I2e4042c55ea4e94d582a4ef099d6076307d54497
Reviewed-on: https://chromium-review.googlesource.com/1193859
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587485}

Change-Id: Ie72c575b60f143a94268421f7199b110fc0bfdbf
Reviewed-on: https://chromium-review.googlesource.com/1179828
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587484}

Before this CL, the tooltip for an empty title attribute showed an
element-specific default tooltip message like "No file chosen" for
<input type=file>. But now it does not show any tooltip since the tooltip
message is considered as "".

The new behavior matches to Mozilla Firefox.

Bug: 872413
Change-Id: I120a2bb7f9a6d244ceca660b79f9033e3a75af9e
Reviewed-on: https://chromium-review.googlesource.com/1186930Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587483}

This reverts commit 28d0c4aa.

Reason for revert: this CL breaks saving passwords on accounts.google.com with second factor enabled.

Original change's description:
> Fix false saving positives on accounts.google.com.
> 
> In the following case false positive on accounts.google.com happens:
> 
> 1.Suppose that the user has 2 Gaia credentials (with usernames and passwords
> u1/p1 and u2/p2). Let u1 be saved in Password Manager.
> 
> 2.The user go to accounts.google.com, u1/p1 are autofilled by CPM (a username
> field is visible, a password field is invisible).
> 
> 3.The user is typing u2 in the username field and is clicking next button.
> 
> 4.At that moment the page removes password form from the DOM and Password
> Manager incorrectly thinks that it was successful submission with u2/p1
> 
> Video is on bug 764663 (actual_bubble).
> 
> This CL fixes this by ignoring accounts.google.com forms with submitted
> type DOM_MUTATION_AFTER_XHR, which means that the form disappeared from the
> DOM, without any visible submission.
> 
> Similar issues might be on different sites, this CL fixes only
> accounts.google.com, because
> 1.A general solution is unlikely without more complex changes and server-side
> support.
> 2.accounts.google.com is crucial for Chrome, in particular because it serves
> the Chrome sign-in page.
> 
> 
> Bug: 758155, 764663
> 
> Change-Id: I44f9878673bf8f419c49f63220335f6c0f26a6e4
> Reviewed-on: https://chromium-review.googlesource.com/1194011
> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
> Reviewed-by: Vaclav Brozek <vabr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587115}

TBR=vabr@chromium.org,dvadym@chromium.org

Change-Id: Idd261e61ca9c7653a1fa72cb175db4afe5ee91fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 758155, 764663
Reviewed-on: https://chromium-review.googlesource.com/1195511Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587482}

Remove BookmarkAppHelper and extensions_misc deps from BookmarkAppDataRetriever.

Introduce web_app::IconSize size presets.

Bug: 875698
Change-Id: I460ef7cf8c2c55f02c9dfabb6fdb888a19883d3c
Reviewed-on: https://chromium-review.googlesource.com/1192465
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587481}

This patch marks it removed at M73.
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/h-JwMiPUnuU/sl79aLoLBQAJ

Bug: 671907
Change-Id: I30df492e54c60d54aa45924fc71f109fe1be2420
Reviewed-on: https://chromium-review.googlesource.com/1192567
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587480}

This reverts commit 6442a850.

Reason for revert: A lot of failures on MSan bots.

Original change's description:
> CrOS shelf: switch to feature mechanism and enable by default
> 
> Fix a lot of tests that hardcode the size of the shelf.
> 
> Bug: 871846
> Change-Id: I586da09835f03beb3e92712fbf32ebefd521a5d5
> Reviewed-on: https://chromium-review.googlesource.com/1188848
> Commit-Queue: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587038}

TBR=xiyuan@chromium.org,newcomer@chromium.org,manucornet@chromium.org

Change-Id: I77dcdb3912f08cac4eb46dc93045297ff2ff02f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871846
Reviewed-on: https://chromium-review.googlesource.com/1196289Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587479}

This CL moves the pepper network anntotations to the same file, to more
easily keep them in sync, and makes the UDP one match the more complete
TCP one.

Bug: 878136
Change-Id: I7d607aacedb9298afc3796990c5a713247c32001
Reviewed-on: https://chromium-review.googlesource.com/1194958Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587478}

This CL adds UI for Marketing opt-in screen. No back-end integration for now.

Bug: 852557
Change-Id: I8eb46615cb3ff12ec0662d3b87cfdd5bc56543b6
Reviewed-on: https://chromium-review.googlesource.com/1195424Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587477}

Temporarily add some values to minidumps, to help diagnose BlobReader
crash reports.

Bug: 864351
Change-Id: I048600d890496247fc966442d8f533d4b9eb51c8
Reviewed-on: https://chromium-review.googlesource.com/1196041Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587476}

Implement BleAdapterPowerManager that handles
1) Observing BluetoothAdapter for power state change and notifying
FidoRequestHandlerBase::TransportAvailabilityObserver.
2) If BluetoothAdapter has been powered on programmatically, turning off
bluetooth adapter power on destructor.
3) Exposing API to FidoRequestHandlerBase to power on bluetooth adapter.

TBR: jam@chromium.org
Bug: 877344
Change-Id: I3a99782186e232f1242937867c5091a4ee1ec338
Reviewed-on: https://chromium-review.googlesource.com/1195150
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587475}

Now that ImageFetchTabHelper supports both fetching image data by JavaScript
and by downloading via image_fetcher::IOSImageDataFetcherWrapper, we can use
that to improve ImageCopier.

Bug: 163201
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8f3c1ad411f74f23b31948f851a1226e9bbe30a6
Reviewed-on: https://chromium-review.googlesource.com/1188581
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587474}

https://pdfium.googlesource.com/pdfium.git/+log/9e90e7987de1..e70aff80976e


git log 9e90e7987de1..e70aff80976e --date=short --no-merges --format='%ad %ae %s'
2018-08-30 thestig@chromium.org Stop using deprecated V8 APIs in CFXJSE_Context.
2018-08-29 tsepez@chromium.org Use pdfium::span<>/UnownedPtr in CFX_Font.
2018-08-29 thestig@chromium.org Stop using deprecated V8 APIs in CFXJSE_Class.
2018-08-29 wfh@chromium.org Change explicit suppression of warning 4267 to a config based suppression.
2018-08-29 thestig@chromium.org Stop using deprecated V8 APIs in CJS_Runtime.


Created with:
  gclient setdep -r src/third_party/pdfium@e70aff80976e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:588506
TBR=dsinclair@chromium.org

Change-Id: I222380ad175fc75988083d249fff38f9bc0cdf4a
Reviewed-on: https://chromium-review.googlesource.com/1195877Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587473}

BUG=876051

Change-Id: I4ffb79237e3a60abb4ffd4e63ee3f7f3cc353671
Reviewed-on: https://chromium-review.googlesource.com/1195435
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587472}

The net::DrainableIOBuffer constructors currently take in a
net::IOBuffer base as a raw pointer, then assign it to a
scoped_refptr<net::IOBuffer> member, thus taking a reference.

This CL turns the raw pointer parameter into a scoped_refptr, and uses
std::move() during the member assignment. So, the reference-increment
operation is pushed from the constructors to the construction callsites.
No new increments are introduced.

The CL also modifies the DrainableIOBuffer construction sites, using
std::move() where possible to remove reference increments.

Bug: 479898
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I95cd0973d5e25c2565ddecfa0e06a3fc15e1f7b9
Reviewed-on: https://chromium-review.googlesource.com/1188955
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587471}

Fix some nits as well.

BUG=537099

Change-Id: Ie9e13059ca2171db19c1c0e5428bd86f4c8dcbe4
Reviewed-on: https://chromium-review.googlesource.com/1188635Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587470}

This will allow identifying these extensions from //ash when recording
Chrome and ARC++ app window usage for Demo Mode.

Bug: 827380
Change-Id: I8eff3642c24ba6b1741499254711558643de4646
Reviewed-on: https://chromium-review.googlesource.com/1189168Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587469}

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I01caf114ded7b89aaa23bd9be7325a358c1eabe6
Reviewed-on: https://chromium-review.googlesource.com/1196266
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587468}

When Drive is offline, files that are 'available offline' are rendered
with 'online' CSS style. Verify that those files have the expected CSS
'online' style (opacity 1).

Also add a new Drive 'online' test case to check that all files render
with the CSS 'online' style (opacity 1).

Test: browser_tests --gtest_filter="FileDisplay/FilesApp*"
Bug: 878260
Change-Id: I2d97a414fc477acce0af877cf490944e4a087cfb
Reviewed-on: https://chromium-review.googlesource.com/1195172Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587467}

The renderer's default network loader can't handle non-network
URLs such as chrome-extension://. This means that fetch()
for extension resources from an extension service worker
wouldn't work when we use the default network loader. To make
such requests work, pass a URLLoaderFactoryBundle from browser
in a similar manner to shared worker.

Bug: 848628
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia356a668a75efec9de854828dadc69cea0294e09
Reviewed-on: https://chromium-review.googlesource.com/1187856Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587466}

So if the input starts out as UTF8, just pass it in as is.

base: :Value and subclasses will take UTF16 input and convert it to UTF8.
Change-Id: Ia738e78f9b3197a68e94eb006465ee75797e3bee
Reviewed-on: https://chromium-review.googlesource.com/1195941Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587465}

A build rule for this test was not added when moving to gn build files, so this
tests hasn't been running for quite some time. It's still functional, so this
change will re-enable it.

Changes made:
* Fixed compilation issues caused by a function that was made private and a
  missing include.s.
* Made this test part of the 'jpeg_decode_accelerator_unittest' target.
* Fixed a warning by changing constexpr char* to constexpr const char*, as
  constexpr forces the pointer to be const rather then the contents.
* Changed the testcase to first look into the local directly for testfiles, as
  this makes it a bit easier to run the tests standalone while developing.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8dc64f9596a4dcd393410983eab39cfd34bd3b5e
Reviewed-on: https://chromium-review.googlesource.com/1116509Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587464}

The _CheckUniquePtr presubmit check has the following false-positive:
it flags
  auto p = std::unique_ptr<T, D>(new T(), D());
as needing a rewrite using std::make_unique.

However, there seems to be no way to pass the second template argument
to std::make_unique, so cases like this need to be exempt from the
presubmit check.

Note that the check still needs to capture cases with

count the nesting of the angle brackets. Hence, this check cannot be
captured by a regular expression and needs just a counting loop.

std: :unique_ptr<T<U, V>>, so when looking for the comma, one has to
Bug: 867823
Change-Id: Ie21067fa83aae17dd6701b0f69b902605c797e67
Reviewed-on: https://chromium-review.googlesource.com/1193945
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587463}

Adds automation_action_egtest.mm, which is responsible for unit testing individual
Autofill automation actions. It does so by hosting a test web page (I reuse
credit_card_upload_form_address_and_cc.html, which is already used for autofill),
performing a minimal amount of automation actions, and using JS to verify result.

I also add a little functionality to credit_card_upload_form_address_and_cc.html
to make the waitFor test more substantial.

I confirmed both tests pass before uploading the CL.

so I will make one for this one in the morning

Bug: None, but I said I would make an umbrella bug for the first CL, and didn't,
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1ce3a185fc9b10ab3b8f352c8c22a092ae877eff
Reviewed-on: https://chromium-review.googlesource.com/1195144
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587462}

It looks like ServiceWorkerURLJobWrapper can be destroyed while
ServiceWorkerNavigationLoader is in the middle of a fetch event,
probably because the outer NavigationURLLoaderImpl/
ServiceWorkerControlleeRequestHandler are destroyed/aborted.

Bug: 878717
Change-Id: Ia1cd5f5e77ab860a5031729820620a2c91e71104
Reviewed-on: https://chromium-review.googlesource.com/1195180Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587461}

SyncAuthManager::GetActiveAccountInfo used to contain a DCHECK that its
currently cached active account matches the desired one. Unfortunately,
there are some edge cases where it doesn't match, e.g. if a different
identity observer gets notified of a change before SyncAuthManager.
Therefore this CL removes the invalid DCHECK.

Bug: 871221
Change-Id: Ie458365416c5d63f33cebf5bfc9832f1cdec5a68
Reviewed-on: https://chromium-review.googlesource.com/1193827Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587460}

The feature itself was added in
https://chromium-review.googlesource.com/c/chromium/src/+/1162174

Bug: 871221
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0cc3527eb25a2e015fa3e6ae458028680f069815
Reviewed-on: https://chromium-review.googlesource.com/1195507Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587459}

This CL eliminates PermissionProvider interface and merges permission
checking to WebUsbServiceImpl.

BUG=699790

Change-Id: Ic690ad807b582dde7c14c442b8973fc5da121bd1
Reviewed-on: https://chromium-review.googlesource.com/1181163Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Donna Wu <donna.wu@intel.com>
Cr-Commit-Position: refs/heads/master@{#587458}

This CL preserves the priorities of requests that go through a
Service Worker's onfetch event and are fetch()ed from there. Before this CL,
these priorities were lost and re-generated later in
ResourceFetcher::ComputeLoadPriority with the priority we naturally assign
fetch()es (kHigh). This meant that requests for things like render-blocking
CSS were downgraded from kVeryHigh => kHigh, possibly causing loading regressions.

After this CL, the priorities of these requests are preserved and communicated to
the ResourceRequest for the corresponding fetch().
ResourceFetcher::ComputeLoadPriority is still entered, and takes the maximum of
the following two priorities:
  - The one we would naturally generate (kHigh, due to fetch())
  - The one _already on_ the ResourceRequest.

This fixes priority regressions from kVeryHigh => kHigh, however what it does
not do is stop desired low-priority requests from being upgraded to kHigh. For
example, if a SW's onfetch event.request is for an image, with kLow priority,
ResourceFetcher::ComputeLoadPriority will "upgrade" this request to kHigh. This
is probably undesirable, and will need a follow-up CL.

R=kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org, yoav@yoav.ws

Bug: 872776
Change-Id: Iaa6b5420b65bc6004b5b7a2d1f8d0eb5453df872
Reviewed-on: https://chromium-review.googlesource.com/1192353
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587457}

This logic dates back 2009 https://codereview.chromium.org/460062.

Now RenderThreadImpl::IdleHandler does just ReleaseFreeMemory, I think
calling this handle more often is no longer required.

Change-Id: Iee99f8f855d2686a53ae85f75ce08cae8e5188e1
Reviewed-on: https://chromium-review.googlesource.com/1193625Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587456}

Camera app needs system property to know GCA migration is done or not.

BUG=b:73056417
TEST=manually test to see connection is built

Change-Id: Ie82a40f08a4fc61c789d6966a8688a33cc5550fe
Reviewed-on: https://chromium-review.googlesource.com/1174146
Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587455}

This adds a test to PermissionManager to verify that subscribing to
permission status changes for child frames works correctly with
permission delegation enabled. Specifically child frames that are
impacted by permission changes in parent frames should receive updates.

Bug: 802945
Change-Id: Ic6ec9bfffe5b6c5f0935c6e857dd162af84a0a14
Reviewed-on: https://chromium-review.googlesource.com/1195252Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587454}

The following preferences are removed from the persistent storage list
for incognito mode.
 - kAllowJavascriptAppleEvents
 - kAlternateErrorPagesEnabled
 - kCrashReportingEnabled
 - kConfirmToQuitEnabled
 - kDataSaverEnabled
 - kDnsPrefetchingHostReferralList
 - kDnsPrefetchingStartupList
 - kMdHistoryMenuPromoShown
 - kNewTabPageLocationOverride
 - kNetworkPredictionOptions
 - kNetworkQualities
 - kRecurrentSSLInterstitial
 - kRlzPingDelaySeconds
 - kSessionExitedCleanly
 - kSessionExitType
 - kShowMissingSdCardErrorAndroid
 - kSpeechRecognitionFilterProfanities
 - kSSLErrorOverrideAllowed
 - kURLsToRestoreOnStartup

These preferences are either never changed from incognito mode, or
the changed value is not supposed to be written to user profile.

Bug: 861722
Change-Id: Iaf271281d29964a763db0c78f2cc34407bf4b681
Reviewed-on: https://chromium-review.googlesource.com/1194007
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587453}

TBR=nednguyen@chromium.org

Bug: 878995
Change-Id: I604ab51326ff718066c592d2de42ed4af82b2e4a
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1196302Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587452}

This change prevents extensions and enterprise settings from setting embedded
exceptions for content setting types that don't support them. Namely, with
permission delegation enabled, permission types don't support embedded
patterns. In practice this only impacts the geolocation content setting when it
is set through the chrome.contentSettings API.

An additional scoping type is introduced to reflect content settings which can
set embedded patterns and those which cannot.

More details are included in the design doc:
https://docs.google.com/document/d/1x5QejvpyQ71LPWhMLsaM1lWCfSsBsSQ8Dap9kJ6uLv0/edit#heading=h.bwzi3w3lx8nz

Change-Id: I4384fd26d01862f477ba18fe7d87915ddae15446
Bug: 802945
Reviewed-on: https://chromium-review.googlesource.com/1173192
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587451}

https://chromium.googlesource.com/catapult.git/+log/cb813c8803b2..d539d9382241


git log cb813c8803b2..d539d9382241 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 benjhayden@chromium.org Add Material radio for V2SPA.


Created with:
  gclient setdep -r src/third_party/catapult@d539d9382241

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia2651b14c1efe943b4cc8acd602cd450869d39e1
Reviewed-on: https://chromium-review.googlesource.com/1195919Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587450}