GitLab

These resources were added in https://codereview.chromium.org/12412003/
, but they were uploaded as 0 byte files. Uploading the correct ones now.

BUG=181526
NOTRY=true

Review URL: https://codereview.chromium.org/12730007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187311 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jhawkins (for minor InspectUI changes)

Review URL: https://chromiumcodereview.appspot.com/12559008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187310 0039d316-1c4b-4281-b951-d872f2087c98

> Add a postbuild action for executables built with ASan on Mac OS.
> The action will copy the ASan dynamic runtime to the same dir where
> the executable is.
> 
> BUG=170629
> Review URL: https://codereview.chromium.org/11642018

TBR=glider@chromium.org
Review URL: https://codereview.chromium.org/12440020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187309 0039d316-1c4b-4281-b951-d872f2087c98

chromeactions.txt also picked up some hashes for other actions
that were added but didn't update the file.

BUG=178525
TEST=Click on a clickable doodle or search through
the omnibox and check that the new UMA action is
shown on chrome://user-actions.

Review URL: https://chromiumcodereview.appspot.com/12546011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187308 0039d316-1c4b-4281-b951-d872f2087c98

When running isolate command through the build tools, have the relative out directories get the same root, so that they all refer to the same location.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12398025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187305 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187302 0039d316-1c4b-4281-b951-d872f2087c98

See https://gerrit.chromium.org/gerrit/#/c/44991/

BUG=none

R=yfriedman@chromium.org,ilevy@chromium.org,navabi@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12496003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187301 0039d316-1c4b-4281-b951-d872f2087c98

The action will copy the ASan dynamic runtime to the same dir where
the executable is.

BUG=170629
Review URL: https://codereview.chromium.org/11642018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187297 0039d316-1c4b-4281-b951-d872f2087c98

It's dangerous to rely on hand-written, run-time binding for JNI.
By wrapping the usage in a thin class, we get build-time type-safety.
It also clarifies the boundaries, and make the code on each side clearer.

BUG=


Review URL: https://chromiumcodereview.appspot.com/12604003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187295 0039d316-1c4b-4281-b951-d872f2087c98

We want to show wallpaper picker on Google Chrome Build instead of just OFFICIAL
Build.

TBR=davemoore,miket
BUG=145508

Review URL: https://codereview.chromium.org/12737003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187294 0039d316-1c4b-4281-b951-d872f2087c98

Update the perf expectations for
xp-release-dual-core/moz/ws_peak_b/ws_pk_b to get the Win 7 Perf(2)
bot green (following the process in
http://dev.chromium.org/developers/tree-sheriffs/perf-sheriffs).
This is a temporary update that should be reverted once the bug
is fixed.

BUG=181183
TBR=cmp@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187293 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/12734005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=147299
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/12769002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187291 0039d316-1c4b-4281-b951-d872f2087c98

Fixed a glitch in the ComponentCloudPolicyUpdater where a protobuf field was read before being validated.

The updater receives protobufs that contain a secure hash of some content. When this hash
differs from the cached version then the content has been updated. The bug is that the
updater compares an empty secure_hash with an empty cached hash, which causes an early
return but should cancel a pending job, if there is one.

BUG=163318


Review URL: https://chromiumcodereview.appspot.com/12542015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179982


Review URL: https://chromiumcodereview.appspot.com/12389084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187289 0039d316-1c4b-4281-b951-d872f2087c98

Qualcomm devices (e.g., Nexus 4) run into texture corruption problems
if the same texture is uploaded to with both async and normal uploads.
Synchronize after EGLImage creation on the main thread as a work-around.

BUG=178634


Review URL: https://chromiumcodereview.appspot.com/12390020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187288 0039d316-1c4b-4281-b951-d872f2087c98

memcheck reported errors which need to be investigated

> Call version of SkFontHost_fontconfig in Skia (cloned from here).
> Retool the direct/remove plumbing to use SkFontConfigInterface.
> 
> This change allows Skia to interate on the details of SkFontHost w/o having
> to synchromize with chrome on each change. It also means Skia's internal testing
> can exercise exactly the same config that Chrome does.
> Review URL: https://codereview.chromium.org/12391070

TBR=reed@google.com
Review URL: https://codereview.chromium.org/12771003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187287 0039d316-1c4b-4281-b951-d872f2087c98

Retool the direct/remove plumbing to use SkFontConfigInterface.

This change allows Skia to interate on the details of SkFontHost w/o having
to synchromize with chrome on each change. It also means Skia's internal testing
can exercise exactly the same config that Chrome does.
Review URL: https://codereview.chromium.org/12391070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187283 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187280 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/12653005/
Review URL: https://codereview.chromium.org/12638009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187279 0039d316-1c4b-4281-b951-d872f2087c98

Regression was introduced in https://codereview.chromium.org/11734015/

BUG=181196

Review URL: https://chromiumcodereview.appspot.com/12620003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187278 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12700002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187277 0039d316-1c4b-4281-b951-d872f2087c98

File names are passed via url. Because of faulty escaping, hash in the filename was causing interpreting part of the filename as url's hash part. This patch fixes it by properly escaping the hash character.

TEST=Play a local video with a hash character in the filename.
BUG=171987


Review URL: https://chromiumcodereview.appspot.com/12674003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187276 0039d316-1c4b-4281-b951-d872f2087c98

After enabling mosaic view on every volume, a problem with videos showing up in a mosaic view appeared. This patch fixes this problem by showing a slide view instead of mosaic view if the selected files are mostly videos.

TEST=Select multiple videos and click on Open. Slide view should appear. When selecting multiple images, mosaic view should appear.
BUG=180453


Review URL: https://chromiumcodereview.appspot.com/12738005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187275 0039d316-1c4b-4281-b951-d872f2087c98

> Implement the Stream registry in content
> 
> This is the first part of the content side of the Streams api.
> See:
> https://bugs.webkit.org/show_bug.cgi?id=110194
> https://dvcs.w3.org/hg/streams-api/raw-file/tip/Overview.htm
> 
> BUG=171585
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12335087

TBR=zork@chromium.org
Review URL: https://codereview.chromium.org/12611018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187274 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the issue that the save passphrase button and the
warning label will not be reinitialized.

BUG=171370
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/12613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187273 0039d316-1c4b-4281-b951-d872f2087c98

This could fix the problem that some services do no shutdown properly in the test.

BUG=179391

Review URL: https://chromiumcodereview.appspot.com/12610003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187272 0039d316-1c4b-4281-b951-d872f2087c98

At the moment, no clients take care about that the largest_changestamp in
GetAboutResource/GetAccountMetadata is updated or not. However, in following
change, it will be indirectly used. So fix the problem at first.

BUG=174237
TEST=Ran unit_tests.


Review URL: https://chromiumcodereview.appspot.com/12700005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187271 0039d316-1c4b-4281-b951-d872f2087c98

This changes the way AndroidStreamReaderUrlRequestJob handles requests which
don't have an InputStream. Rather than immediately failing the Job we pretend
to have HTTP response headers that say 404 Not Found and empty contents (much
like fetching the data from a real server would).

BUG=180542


Review URL: https://chromiumcodereview.appspot.com/12531002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=147299
TEST=unit_tests


Review URL: https://chromiumcodereview.appspot.com/12673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187269 0039d316-1c4b-4281-b951-d872f2087c98

With this patch we can use IME extension API even in Linux Desktop with
chromeos=1 configuration.

BUG=170671
TEST=try bots


Review URL: https://chromiumcodereview.appspot.com/12481012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187268 0039d316-1c4b-4281-b951-d872f2087c98

The change in http://crrev.com/178260 only made the target visible on Windows.
When the build target is chromium_builder_tests, OSX omits the target.

BUG=138633
TEST=Target builds and runs when opted in with git cl try --clobber -bmac_rel:app_list_unittests


Review URL: https://chromiumcodereview.appspot.com/12436010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187267 0039d316-1c4b-4281-b951-d872f2087c98

Add chrome version information to extension update checks.

BUG=72262

Review URL: https://chromiumcodereview.appspot.com/12396002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187266 0039d316-1c4b-4281-b951-d872f2087c98

Patch https://chromiumcodereview.appspot.com/12319114/ requires an icon but the try bots would not accept a binary file.

BUG=179342
TBR=pfeldman

Review URL: https://codereview.chromium.org/12428016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187263 0039d316-1c4b-4281-b951-d872f2087c98

Remove a comment from url_request_context.h that was obsoleted by change
11092088. The comment described a member that is no longer present in the
class.

BUG=
TEST=net_unittests


Review URL: https://chromiumcodereview.appspot.com/12387041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187262 0039d316-1c4b-4281-b951-d872f2087c98

Before, the multiple undo was malfunctioning, however single undo worked correctly. This is because, first undo is a special case. This patch fixes multiple undo operations which uses base image.

TEST=Open the image editor, try to rotate several times, then undo several times. Try also redo.
BUG=181483


Review URL: https://chromiumcodereview.appspot.com/12761002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187261 0039d316-1c4b-4281-b951-d872f2087c98

http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Naming

R=estade@chromium.org
TBR=rdsmith@chromium.org
BUG=none, though I'll probably make one for a presubmit check.
TEST=no regressions, better js style in c/b/resources

Review URL: https://codereview.chromium.org/12560002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187259 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187258 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187256 0039d316-1c4b-4281-b951-d872f2087c98

Once the video is finished, the play button's icon is reply instead of play. The same will be done, once assets for the audio player are provided. Along the way, converted the class names from ambiguous state0/1/2 to default, playing, ended.

TEST=Launch a video in Files.app, wait until end or scroll to the end.
BUG=177591


Review URL: https://chromiumcodereview.appspot.com/12676002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187255 0039d316-1c4b-4281-b951-d872f2087c98