- 07 Feb, 2019 40 commits
-
-
Sreerenj Balachandran authored
Replace some of the const defintions with constexpr as a part of optimization based on review comments for https://chromium-review.googlesource.com/c/chromium/src/+/1383540 Change-Id: I82e8955950f526a2beb52f281efb6b9a463f1761 Reviewed-on: https://chromium-review.googlesource.com/c/1457423Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#629886}
-
Rakina Zata Amni authored
When traversing on a frame tree that has no matches and only one frame, we might get into an infinite loop because we keep traversing to the same node (due to wrapping). This CL checks if the last-traversed node is the same as the current node and stops if so, and also to stop when we're trying to traverse from an inactive frame. Bug: 889075 Change-Id: I099dcdc6353c21fa1694b4b81953cba68465ffc1 Reviewed-on: https://chromium-review.googlesource.com/c/1454161 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#629885}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/003f99ea..e09b459b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6b9e471451970554e1f696ee66627ba85a1f91b Reviewed-on: https://chromium-review.googlesource.com/c/1457731Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b32378da8f4..f4d325bdd8b0 Created with: gclient setdep -r src-internal@f4d325bdd8b0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib75f03308f0beb4b48df01e1a8ecb5a0be947dea Reviewed-on: https://chromium-review.googlesource.com/c/1457524Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629883}
-
Matt Menke authored
This CL allows a SpdySession to be created by passing a StreamSocket to its constructor directly, in addition to keeping the previous constructor, which takes a ClientSocketHandle. The new constructor is intended for use where there's no socket pool below the session. In particular, for H2 proxies, the SpdySessions are created below the highest socket pool layer, at the ConnectJob layer. Once the socket pools are flight, this will become the only socket pool layer, so we'll only be dealing with a raw StreamSockets, rather than ClientSocketHandles. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Change-Id: Ibe722bad9814879504757c03e8ad3c135d123971 Reviewed-on: https://chromium-review.googlesource.com/c/1453107 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629882}
-
Vlad Tsyrklevich authored
Add the GWP-ASan UserStreamDataSource to the macOS crashpad handler. The GWP-ASan hook determines when an exception is related to GWP-ASan and reports additional debug information. Bug: 912286 Change-Id: I1cd0227ca8aade1bd17e25b83832cdb8f3e58d5e Reviewed-on: https://chromium-review.googlesource.com/c/1457461Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#629881}
-
Mitsuru Oshima authored
Delay re-adding shadow and mask as it can interfere with still animation. Bug: 923391 Test: ScrenRotationAnimatorTest updated, OverviewSessionTest.RoundedEdgeMaskVisibility Change-Id: Ie6455a40e2c796914f4fe04f4fa04cc13fc6fefc Reviewed-on: https://chromium-review.googlesource.com/c/1453541 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#629880}
-
Antoine Labour authored
Under lost device conditions, eglMakeCurrent can fail, even when releasing the context. As we otherwise assume that we have correct bindings when GLContext::IsCurrent returns true, we need to track the lost state to ensure that after ReleaseCurrent, IsCurrent will return false. Bug: 928693 Change-Id: I5bbf2616f872532c03da1e1beeade5c94d920b92 Reviewed-on: https://chromium-review.googlesource.com/c/1457675Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629879}
-
Tommy C. Li authored
Currently, the IFRAME throttle doesn't always work on first-time use, when the Chrome process is first started. This is because the IFRAME throttle itself doesn't trigger the plugin list load. This CL updates the throttle to also trigger the plugin list load itself (only if it hasn't been loaded already), and should make the behavior less flaky. Bug: 924823 Change-Id: If51e85bf2d7005af1a5a825279388dd6d9324409 Reviewed-on: https://chromium-review.googlesource.com/c/1452771 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#629878}
-
Stefan Zager authored
These CHECKS were added by someone who left the project a year ago. Recent crash reports still show about 1-2 crashes per day, but the actual line that is crashing doesn't look like a valid CHECK condition, so I don't think there's anything left to do here. The parent_ variable was apparently added only for debugging. It is used in only one place apart from attach/detach; in that place I replaced it with a call to ParentFrameView (which goes through the frame tree, as it should). I also added a CHECK out of an abundance of caution. BUG=729196 R=dtapuska@chromium.org Change-Id: I3990c90f64901b6c797dad17376fa30821b02e2a Reviewed-on: https://chromium-review.googlesource.com/c/1457665Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#629877}
-
Nigel Tao authored
BUG=826982 Change-Id: If73d4090989a436c4f8ebd1857d1d8727a2dca50 Reviewed-on: https://chromium-review.googlesource.com/c/1457558Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#629876}
-
Alexei Filippov authored
BUG=681863 Change-Id: I5ad61c04e1af61e184e5a182234007812d75fd00 Reviewed-on: https://chromium-review.googlesource.com/c/1453542 Auto-Submit: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629875}
-
Malay Keshav authored
This patch aims at fixing one of the causes for the transparent chrome window bug. One of the reasons that caused this bug was that some of the property changes on the original ui layer were not being propagated to the mirror layer. The visibility of the original layer needs to be propagated to the mirror layers. This patch adds this functionality. Bug: 927909 Change-Id: I3767bc513f199cb7c3dd7b3c0783894b99cd4293 Component: ui layer,stale content, solid color layer Reviewed-on: https://chromium-review.googlesource.com/c/1450611 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#629874}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I7be4d81c421379440ce5f601d6fa188ea5b5c98b Reviewed-on: https://chromium-review.googlesource.com/c/1457740Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#629873}
-
Alli Murray authored
Bug: 918795 Change-Id: I3ce85373b987f572e901889082d638035acf1235 Reviewed-on: https://chromium-review.googlesource.com/c/1457557 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629872}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96982ab4da6c..1b32378da8f4 Created with: gclient setdep -r src-internal@1b32378da8f4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id871c136f5332151e3bf07032715bcef3007710b Reviewed-on: https://chromium-review.googlesource.com/c/1457485Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c1a2ea33a340..f36ad269e88a git log c1a2ea33a340..f36ad269e88a --date=short --no-merges --format='%ad %ae %s' 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-07 reed@google.com move SkMetaData into src 2019-02-06 bungeman@google.com Add BOT/EOT to Shaper. Created with: gclient setdep -r src/third_party/skia@f36ad269e88a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I0f550fc72ff90c5624726b6640f876a318daa897 Reviewed-on: https://chromium-review.googlesource.com/c/1457639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629870}
-
Marijn Kruisselbrink authored
We were already treating these responses as errors, but were using UPDATE_OK as "ResultType" when handling the error. This fixes that to treat these errors the same as any other non-200 server response. Bug: 923650 Change-Id: I5f3464bd5ae8dc940f1476297cd935f9ecb5998e Reviewed-on: https://chromium-review.googlesource.com/c/1457469 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629869}
-
Alex Danilo authored
CL:1345378 swaps out PNG files for the share and delete icons for file selected with SVG files that were 20px in size. This corrects to the proper size of 16px. side by side with SVG version to verify sizing. Bug: 793382 Test: Took screenshot of original with PNG icons, compared Change-Id: I218bc9f059f74a9bd68256ddaaa80fb298332c4b Reviewed-on: https://chromium-review.googlesource.com/c/1345756 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#629868}
-
Alli Murray authored
When partitions are grouped, the eject button is attached to the removable root label. Unmounting a removable root means unmounting all child partitions, and using the drive label in the unmount message. Bug: 918795 Change-Id: Idd175c8f3d7a814bfe0784cfa52e35b12c36a663 Reviewed-on: https://chromium-review.googlesource.com/c/1454339 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by:
-
Scott Violet authored
This is necessary as it's not uncommon to have code like this: SetCanActivate(true); widget->Activate(); SetCanActivate(false); BUG=928939 TEST=none Change-Id: I52c2d79cd7aec2fe5ab13f8ae7821227f1a0214e Reviewed-on: https://chromium-review.googlesource.com/c/1457117 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#629866}
-
Oystein Eftevaag authored
Currently the tracing service will unconditionally connect to the TracedProcess interface on all services, which is a feature provided by the service_manager client lib. This change allows RequestQuit() calls services make, to still succeed even if there's an outstanding TracedProcess bind request, as it's not the service itself which handles this request. See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/1452767 R=ssid@chromium.org Change-Id: Id7a4a6dc8eaa982b0ce24d7a699b430b3c07f833 Reviewed-on: https://chromium-review.googlesource.com/c/1457214 Commit-Queue: oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
ssid <ssid@chromium.org> Auto-Submit: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629865}
-
Dan Beam authored
Screenshots: https://imgur.com/a/icbglBw R=hcarmona@chromium.org BUG=883049 Change-Id: I64fdd208abfbc71914b8f8a13d34e08d4d305b40 Reviewed-on: https://chromium-review.googlesource.com/c/1457719 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#629864}
-
Lei Zhang authored
BUG=928411 Change-Id: I147411ea096b2c49b3c81cde29f946dc1f1a4dfa Reviewed-on: https://chromium-review.googlesource.com/c/1454087 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629863}
-
Alli Murray authored
List partitions of external media devices as subdirectories underneath a common root label to improve visual distinction. Make EntryList URL unique for removable roots (otherwise directory change won't be triggered). Bug: 918795 Change-Id: I071664a333d44e0d9f4e1ca77bcb6dafda89e181 Reviewed-on: https://chromium-review.googlesource.com/c/1449472Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f9cc785c3f6a..603ad164a6fc git log f9cc785c3f6a..603ad164a6fc --date=short --no-merges --format='%ad %ae %s' 2019-02-07 lfy@google.com GLES1: dirty bit pass Created with: gclient setdep -r src/third_party/angle@603ad164a6fc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I6c8208353e5ff39a5d14ee1bc0116adb6bf4f5f2 Reviewed-on: https://chromium-review.googlesource.com/c/1457523Reviewed-by:
-
Erik Luo authored
Bug: 927535 Change-Id: I207bc589b3d6f86b44a3b74309342e5052a9582f Reviewed-on: https://chromium-review.googlesource.com/c/1449047 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1b8d2cc9056a..82105494f27a git log 1b8d2cc9056a..82105494f27a --date=short --no-merges --format='%ad %ae %s' 2019-02-07 thestig@chromium.org Use even more size_t in CXFA_TextLayout. 2019-02-07 thestig@chromium.org Fix includes in fx_font.h. 2019-02-07 thestig@chromium.org Reorganize fx_font.h. 2019-02-07 thestig@chromium.org Use a vector inside CPDF_CharPosList. 2019-02-07 thestig@chromium.org Encapsulate CPDF_CharPosList. 2019-02-07 thestig@chromium.org Rename FXTEXT_CHARPOS and FXTEXT_GLYPHPOS. 2019-02-07 thestig@chromium.org Encapsulate CFX_GlyphBitmap. 2019-02-07 thestig@chromium.org Remove unneeded fx_font.h includes from headers. 2019-02-06 thestig@chromium.org Revert "Add --jitless to recommended v8 flags." 2019-02-06 tsepez@chromium.org Document that CXFA_Document::GetLayoutProcessor() never returns null 2019-02-06 thestig@chromium.org Do some clean up in fpdf_parser_decode test. 2019-02-06 thestig@chromium.org Fix xfa/fxfa/layout/BUILD.gn. 2019-02-06 thestig@chromium.org Roll buildtools/ 0e1cbc4ea..2f02e1f36 (3 commits) 2019-02-06 tsepez@chromium.org Break CXFA_Node direct dependence on CXFA_LayoutProcessor. 2019-02-06 thestig@chromium.org Roll build/ 67630827e..10ffa2f5e (30 commits) 2019-02-06 thestig@chromium.org Use more size_t in CXFA_TextLayout. 2019-02-06 thestig@chromium.org Fix an integer overflow inside cpdf_textpage.cpp. 2019-02-06 bungeman@google.com Roll third_party/freetype/src/ 1e7a8f30c..b66d6a911 (5 commits) 2019-02-06 thestig@chromium.org Avoid an integer overflow in CPDF_RenderStatus::ProcessType3Text(). 2019-02-06 tsepez@chromium.org CXFA_TextProvider does not need to know about layout/ objects 2019-02-06 thestig@chromium.org Avoid calling CCodec_FaxDecoder::InvertBuffer(). 2019-02-06 tsepez@chromium.org CJX_Object does not need to know about layout/ objects. 2019-02-06 thestig@chromium.org Do not build googletest/googlemock when building pdfium_test. 2019-02-06 thestig@chromium.org Add CFX_Break::IsGreaterThanLineWidth(). 2019-02-06 thestig@chromium.org Use CalculatePitch32() in CCodec_FaxDecoder. 2019-02-06 tsepez@chromium.org Separate CXFA layout hierarchy from CXFA parser hierarchy. Created with: gclient setdep -r src/third_party/pdfium@82105494f27a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:919643,chromium:917783,chromium:928820 TBR=dsinclair@chromium.org Change-Id: If0c887926e5cbeb9ce07e1c769c22d9054bb1ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1457484Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61d0c292535e..06d1040fab75 git log 61d0c292535e..06d1040fab75 --date=short --no-merges --format='%ad %ae %s' 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@06d1040fab75 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4aea79ae93e6d1ec17bc316eba9a9d79896256bd Reviewed-on: https://chromium-review.googlesource.com/c/1457638Reviewed-by:
-
Wenzhao Zang authored
maybelle@ will take over wallpaper work. For now, she will cc wzang@ and xdai@ on all the incoming reviews she will get. Bug: None Change-Id: I82c9e8e1820663d0d3fb82ecf6030178caa01d1b Reviewed-on: https://chromium-review.googlesource.com/c/1457669Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#629857}
-
Ken Buchanan authored
This reverts commit e6fd2ecb. Reason for revert: Regresses startup time on Windows. https://crbug.com/929375 Original change's description: > Add metrics for Bluetooth adapter availability > > For Web Authentication we would like to determine the prevalance of > BLE capabilities on clients to understand whether BLE security keys and > caBLE devices are viable for those users. > > This re-enables the UMA on OSX to determine Bluetooth availability and > capabilities, and adds similar metrics to Windows and Chrome OS. > > Bug: 907279 > Change-Id: I8da9165bca5177cb08176cc4ce812340456a97d4 > Reviewed-on: https://chromium-review.googlesource.com/c/1437721 > Commit-Queue: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628560} TBR=kenrb@chromium.org,isherman@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907279 Change-Id: I8287c1c8a362032f961c6723cf56545f75e41878 Reviewed-on: https://chromium-review.googlesource.com/c/1457458Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#629856}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/11e283fea253..38769c1f96a3 git log 11e283fea253..38769c1f96a3 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 charliea@chromium.org Remove spurious "o" added in crrev.com/c/1455628. Sorry! Created with: gclient setdep -r src/third_party/catapult@38769c1f96a3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib8ca246e6c876042a3fb1bad110cea56079cafec Reviewed-on: https://chromium-review.googlesource.com/c/1457276Reviewed-by:
-
Joshua Pawlicki authored
This reverts commit 4502ddc7. Reason for revert: The Clank team has raised some concerns about removing this. Until there is consensus, it seems safer to stay with the status quo, sorry. Original change's description: > [Android] Remove accounts and sign-in information from Omaha requests > > This CL removes the code that used to add _numaccounts, > _numgoogleaccountsondevice and _numsignedin attributes to Omaha > requests. > > Bug: 926273 > Change-Id: I36edef48dc4d51cbed70ad1a7e14284cfa1c772f > Reviewed-on: https://chromium-review.googlesource.com/c/1451925 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Auto-Submit: Boris Sazonov <bsazonov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629111} TBR=waffles@chromium.org,jochen@chromium.org,bsazonov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 926273 Change-Id: If778ea99524b6c199c25292f66f04a07d3271bea Reviewed-on: https://chromium-review.googlesource.com/c/1457674Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#629854}
-
Mason Freed authored
Bug: 927560,927587,928518 Change-Id: I502e1d487fefa06697c064919d5bbb78582da923 Reviewed-on: https://chromium-review.googlesource.com/c/1454090 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629853}
-
Khushal authored
Add support for PostSubBuffer to GLSurfaceEGLSurfaceControl. This should allow the display compositor to draw the minimum sub-rect necessary from the damage tracking in BufferQueue on the client-side, and also to pass this damage rect to the framework. R=piman@chromium.org Bug: 926020 Change-Id: I73d3320cab68250d4c6865bf21c5531682d8bf61 Reviewed-on: https://chromium-review.googlesource.com/c/1457467 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#629852}
-
Scott Violet authored
BUG=929455 TEST=test only change Change-Id: Iecf7c394f073c6cad59b70c59d78eea43bc44dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1457209 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#629851}
-
Jimmy Gong authored
- Adds RequestUpdatedSharePath helper function to SmbFileSystem. Bug: 922273 Test: compiles Change-Id: Ida2043d9f78b585aa70252b7a8b3937dd456d527 Reviewed-on: https://chromium-review.googlesource.com/c/1445235 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#629850}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I17c639a8a17571da8bab2224c47b08083a5a6c3f Reviewed-on: https://chromium-review.googlesource.com/c/1457482Reviewed-by:
-
Kelvin Jiang authored
activity_log.js will be split into activity_log_history.js and activity_log.js to separate the file in preparation for the real-time stream implementation. activity_log.js takes care of the UI lifecycle and common UI elements logic (i.e. back/clear button, search bar, and loading the activity log when the page is reached) activity_log_history.js takes care of fetching, handling and displaying activity log data from the activityLogPrivate API. In a later CL, the activity log stream (implemented by listening to activityLogPrivate.onExtensionActivity events) will be in a different tab under activity_log.js and will have its own file. This CL aims to prevent putting all activity logic into one large (and very bloated) file. Bug: 832354 Change-Id: I88be6309ba4c4d73e0078ce86e893dafb26594c2 Reviewed-on: https://chromium-review.googlesource.com/c/1432939 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
-
Hector Carmona authored
Also fix some const references surfaced by presubmit. Reason for revert: browser_tests are run in parallel, so they were failing on the focus check sometimes, thus introducing flakiness. Fix to prevent flakiness: Changed test to an interactive_ui_test because they are run in series. Bug: 912026 Change-Id: I3385a0e55daabb4bade7aedc77f329c5b22d9de6 Reviewed-on: https://chromium-review.googlesource.com/c/1444691 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
