GitLab

Resets the app list contents view when the app list view visibility
changes to false - the goal is to ensure that the app list is in
the initial state when it becomes visible again. This is in
particular needed in tablet mode, where AppListPresenterImpl::Show might
not get called when app list becomes visible (so app list contents is
not reset that way).

ResetForShow was also being called when app list was getting focused
while in hidden state, but that might not catch all the transitions
where app list becomes visible (and with this change becomes unnecessary).

Additionally, change when the selected apps page is reset for app list
visibility change - instead of doing it on focus change, the selected
page is now down when the visibility change is starting (i.e. in
OnVisibilityWillChange). This will make page reset happen sooner (before
the app list UI is actually shown), and cover more visibility change
cases in tablet mode.

BUG=None

Change-Id: I6240d7401091a8d778f5a3f8774db919a4cfd6bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966374Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724752}

This removes the need for custom pause/unpause logic for
ScriptedAnimationController in Document.

Also, construct ScriptedAnimationController in the Document
constructor, rather than lazily. It will get initialized on the
first frame, so we're not saving much by deferring its initialization.
This simplifies a bunch of logic around its handling in Document, and
guarantees that its lifetime will be predictable for leak detection.

Bug: 1029822
Change-Id: I4cec7985258dd24154032b4cd1812b75cc858757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953643
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724751}

This cl manually reverts the v8 roll out to v8.1.32 which happened
here: https://chromium.googlesource.com/chromium/src/+/e5cb6daa9a0748126627f010e373706113a36120

Reson for revert:
V8 roll out to v8.1.32 seems to have caused a lot of test failures on
debug builds in this range:
https://chromium.googlesource.com/chromium/src/+log/ad7921a033b89eae85da556c2917f6df1328f41e%5E..55d0dad728ea958b6e18ef069cb805b7d1dd0056


TBR=hablich@chromium.org
NOTRY=true

Change-Id: Ic5006fd9005a7c5fcb35bfd3b2c1f7af12ae3f34
Bug: 1034059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967891Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724750}

Prevent new calls to be added directly to SharedPreferences without
passing through SharedPreferencesManager.

Bug: 1022108
Change-Id: I1cda2df2fc47fed1182ccbfebd673d6bf8c82901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965935
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724749}

TBR=altimin (no-op mechanical change)

Bug: 1026641
Change-Id: I04a12b17434041d88d315ab457e1696222d9340f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962019
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724748}

When v1 and v2 DeviceSync are running in parallel, before v1 DeviceSync
is deprecated, use the SoftwareFeatureManager to indirectly call
CryptAuthFeatureStatusSetter::SetFeatureStatus(). This is to ensure an
ordering of SetSoftwareFeatureState() and SetFeatureStatus() calls.
These functions mutate the same feature states on the CryptAuth backend
and the order of the calls matters; we need to avoid race conditions.

When v1 DeviceSync is deprecated, the CryptAuthFeatureStatusSetter is
used directly.

Bug: 951969, 1019206
Change-Id: I0711b011dc91a0218503a01f3131d4062f51bc36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944888
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724747}

https://chromium.googlesource.com/angle/angle.git/+log/e1822727560b..e181f2f7cf17

git log e1822727560b..e181f2f7cf17 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 syoussefi@chromium.org Validate that image array indices are constant
2019-12-13 root@cybikbase.com Fix GGP build

Created with:
  gclient setdep -r src/third_party/angle@e181f2f7cf17

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliot@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: ianelliot@google.com
Change-Id: I7eb70bf42001a19ba18e53db476fc133201e2201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967751Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724746}

This arg never changes among all supported CrOS device builds of Chrome.
By giving it a proper default val in those builds, we can reduce the amount
of inputs needed when building for CrOS (ie: simple chrome & chromeos-chrome
ebuild).

Bug: 937821
Change-Id: I9c29024949a8c3b61a531069f8806ecc21c590ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963100Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724745}

Previously, the event's root location was compared with a View's
window-relative bounds. The root location is in screen coordinates in
some (but not all) cases.

Fixed: 1033679
Change-Id: I3921b24333751010a9b51d1ee6b05eb7ddc8960f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965938
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Auto-Submit: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724744}

Add removing feedback form at destructor of SigninScreenHandler which is
destroyed when the login is finished.

Bug: 1033572
Change-Id: Idfb55003c238faa5c8d04d9e7c11861632b67156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967652Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#724743}

They are optional API to make it possible to enhance low latency
performance.

Bug: b/143238704
Test: Internal CQ.
Merge-With: eureka-internal/344842
Change-Id: I6d231fbfc278e2d581dcaabb56c244c415335ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965553Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Guohui Deng <guohuideng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724742}

Change-Id: I96f96a22200de739af73dfac4924c75baf375c9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967603
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724741}

This cl adds a type converter for payment address init dictionary to
ensure safe conversion from blink::PaymentAddressInit* to
mojom::payments::PaymentAddressPtr. Without this change the renderer
would crashe if the diconary returned by the payment app does not
contain all PaymentAddress members.

Bug: 984694
Change-Id: I40cf3692e459168994a05b92734c4195f2ac53f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966233
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724740}

The test fixture had two DummyPageHolders but the second was only used
for one test case. This CL moves the second page holder into the test
case that needs it and avoids instantiating it for all the other test
cases.

Change-Id: I50d487059af2ebb077700453169ef0c4d356c1dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965480
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724739}

Some renderers produce no updates in their commit but keep asking for
begin frames and don't send DidNotProduceFrame until the next frame.
This causes display scheduler to extend its deadline even when other
renderers are done.

This was previously fixed partially in https://crrev.com/c/1211917, but
that CL missed the case of a renderer that requests another commit even
before finishing the current one without updates.

Bug: 1033744
Change-Id: Id60925b4b4a41515dbcb8410a9eb28534754c2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966596Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724738}

cba3dabf247e Add .gitattributes, setting “text eol=lf” or “binary” for
             all files
3e4d6a9b7f39 [log minidump] Base94OutputStream implementation
c6153f0b6e72 [Windows] Add AppContainer SID to Named Pipe DACL
097395dfca27 [crashpad] - Replace "system-temp" with "isolated-temp"
fa28ef896cd7 [log minidump] LogOutputStream implementation
af5d5468e005 Rename FIDL tables to .c due to use of designated
             initializers
a126f524fa82 Use base::BindOnce() instead of base::Bind()

Change-Id: I696b08c40a9b96e0ce893f9f2819742d7eef4f12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967419
Commit-Queue: Mark Mentovai <mark@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: Mark Mentovai <mark@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724737}

As part of removing non-OOPD code, remove software mirror related code
from overlay processor, which receives info from output surface.

R=kylechar

Bug: 1016916, 936425
Change-Id: Ic54983a1f7dca7bb1c82fc7d04ab764c712800c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966604
Commit-Queue: weiliangc <weiliangc@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724736}

I recently modified these two histogram configs, but I forgot
to remove base="true". These are now not base hsitograms.

Bug: 1032213
Test: none
Change-Id: I7e2070a259a4b731d7587d5ce49994dea7a2292a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966273Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724735}

The tool for processing aidl files supports two additional options
--checkapi and --dumpapi. --dumpapi generates aidl files in a
content suitable for diffing, and --checkapi detects incompatible
api changes by comparing results of --dumpapi.

This patch adds a presubmit check that for any aidl changes uses
--dumpapi on the original and changed to generate api dumps and
then uses --checkapi to verify the changes are safe.

The check will fail on renames, which are actually safe. I'm
assuming if we actually want to rename we can bypass the hooks.
We'll need to do similar when actually removing functions
(because of deprecation).

BUG=none
TEST=none

Change-Id: Ifc87d025c36f9cc6a04bd101580a6df04f24ae23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959583
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724734}

Skip also on EGL as it apparently fails there as well.

TBR=kbr@chromium.org

Bug: 1033113
Change-Id: I7bd35036eb33b8c43d9d31ed5da2059be28fcf01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967558
Auto-Submit: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724733}

The size of a structure changed between 10.14 and 10.15 in such a way
that the 10.15 structure can't be passed directly to a 10.14 host
over mach IPC. Deal with that by using the compatible prefix of the
structure.

Bug: 1023913
Change-Id: Ic2d5091f5e720097182436f42d94df6bf9a92fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967436
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724732}

This should fix the crashes in question, which deref |profile_| during
construction.  It also seems more obvious; it's not clear why we should avoid
providing the profile until Init().

This also does a lot of misc. cleanup, e.g. moving member inits into the
declaration.

Bug: 1033456
Change-Id: I44f57c90bb14da4ee116259340b7892a1db6802e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965899Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724731}

EG2 tests can use the utility to set the value of a boolean user pref
in browser state going through ChromeEarlGreyAppInterface.

BUG: 922813
Change-Id: I2faf3f95bdaa3bd9e53296a79d9fccdac9c0aa6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965923
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724730}

https://android.googlesource.com/platform/external/perfetto.git/+log/fffa30d10879..f94b736c58a6

git log fffa30d10879..f94b736c58a6 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 primiano@google.com Merge "Docs: fix github link"
2019-12-13 primiano@google.com Merge "Remove SlicedProtobufInputStream"
2019-12-13 taylori@google.com Merge "ui: Two small fixes for run-dev-server"
2019-12-13 taylori@google.com Merge "perfetto-ui: Show CPU slice aggregation"

Created with:
  gclient setdep -r src/third_party/perfetto@f94b736c58a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: If000b8f3f608d089bdbe9f7beec65801e7389e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966733Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724729}

Change-Id: I043670bf13ae3bb67af4fa7b1bb4fbad3f91b9d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967698Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724728}

This CL removes the flag for PerformanceObserverInit's buffered flag
since it has shipped. It also removes an unused method
NotifyObserversOfEntries() in Performance.

Change-Id: Ie491953cf90a6665773e59953c0d9a85cf3dd1e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967570
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724727}

Bug: 985581
Change-Id: I0976f2ebed5902429529ef9d905d1e0e58f59781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959054Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#724726}

Make CachedMetrics support recordLinearCountHistogram.

Change-Id: I1fa57251aa61e2e6d28cf05090a0d3e1cf6abdd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966271
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724725}

https://skia.googlesource.com/skia.git/+log/d0840ecf5831..a6069a154d66

git log d0840ecf5831..a6069a154d66 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 bsalomon@google.com Support clipRegion on GPU backend
2019-12-13 egdaniel@google.com Store GrSurfaceProxyView on SkImage.

Created with:
  gclient setdep -r src/third_party/skia@a6069a154d66

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: djsollen@google.com
Change-Id: I5dfd090532adac9a68a07e4fef8dd7639aa9a6bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967753Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724724}

https://pdfium.googlesource.com/pdfium.git/+log/a0a028072750..ea5411d97d90

git log a0a028072750..ea5411d97d90 --date=short --first-parent --format='%ad %ae %s'
2019-12-13 thestig@chromium.org Remove useless |kFormFieldTypes| constant.
2019-12-13 thestig@chromium.org Run clang-format --full on directories that start with 'f'.
2019-12-13 thestig@chromium.org Clang-format some code in core/.
2019-12-13 thestig@chromium.org Add pdfium_test --password support.
2019-12-12 thestig@chromium.org Roll DEPS for build/ and tools/clang/
2019-12-12 thestig@chromium.org Roll third_party/freetype/src/ 551bd3a90..11d4ce23a (2 commits)
2019-12-12 thestig@chromium.org Roll v8/ a423bb8be..724fd9f1e (643 commits)

Created with:
  gclient setdep -r src/third_party/pdfium@ea5411d97d90

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ic71ae571065fd527bbec5dbbaae0e7040dfffc9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966732Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724723}

This CL reverts the removal of the show-overdraw-feedback
flag that was removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1529513

Bug: 1025119
Test: Open chrome://flags and verify the flag is there.
Change-Id: I3410097067e2f607bcf68bc8a0534e45c6facf10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967194
Commit-Queue: Paulo Warren <pwarren@google.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724722}

This ensures the test reflects changes to the HTML template. Using an
external test HTML file sometimes caused the test to fail after
unrelated changes to the page's JS that happened to reference
elements present in the template HTML but missing from the external
test file.

Currently, this change applies only to
DistillerPageWebContentsTest.TestPinch, but similar tests for other
JS functionality are planned.

Bug: 1027612
Change-Id: Icbfc59e765ac4e6245cb7836da097bce1b36a2d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965988
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724721}

Clang-Tidy performed all of the transformations in this change
except for the following:
  * ios/chrome/test/app/chrome_test_util.mm
    Unrolled changes that depended on third_party/breakpad.

BUG=1030028
TBR=mahmadi@chromium.org,jdoerrie@chromium.org,zmin@chromium.org

Change-Id: I234a5c1618069032c1de46f1aac826ee6766017e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966029Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724720}

Use the UMA histogram functions instead of macros for the
GPU.ProcessLifetimeEvents.* metrics. This way the histogram calls for
the different GPU modes can be combined. Also combine the three crash
counters into |recent_crash_count_|, and reset it to zero when a new
GPU mode is crashing.

The histogram functions are slightly slower than the histogram macros
because they don't cache the histogram object at the callsite. These
calls are made once during GPU process startup and once following a
crash, so they don't occur on a performance critical path.

Bug: 1005383, 1030757
Change-Id: I98aee0d50852794270c1c9b4c156e013080d23a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961067
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724719}

This CL adds a new ContentSettingsType named SAFE_BROWSING_URL_CHECK_DATA,
which will be used to store cache of real time url check verdicts.

verdict_cache_manager is previously used to store cache of password
protection verdicts. It is expanded to support real time url verdicts
in this CL. Callers of new functions will be implemented in a follow
up CL.

Bug: 1030989
Change-Id: I06e71146a6a05986dcd3e697efbb1a92d87c8434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957175
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724718}

This excludes third_party/blink/.

These locations have all been updated to OnceCallback and
RepeatingCallback.

TBR=dcheng

Change-Id: I38a7938e0be09ca9807088f21661d156ecb0b20d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967561Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724717}

The new Translate Tab UI should use the preferred tab size rather than
fill the remaining space. This wasn't working because the TabbedPane
always had a preferred size of zero along it's main axis. This also
refactors the Tab UI to use a FlexLayout rather than Grid.

Before:
https://drive.google.com/a/google.com/file/d/1ruIsOteLlAlbHuVRfRQW8b9fyDef3NWh/view?usp=sharing

After:
https://drive.google.com/a/google.com/file/d/1cig398v0gMjI4m8Kxsf-sOjr7TkSk8bB/view?usp=sharing

Bug: 1030976
Change-Id: I30717a6c9fea673846628b8a755d446369bd8671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956486
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724716}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/138a38da0e53..1d76f03c247a


Created with:
  gclient setdep -r src-internal@1d76f03c247a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1017165,chromium:984162
Tbr: jbudorick@google.com
Change-Id: I4050d711a6a7df84d2aebaf4753e162b2d525fd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967752Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#724715}

This CL disables the content indexed content from appearing on offline
dino page. We will revisit later after UX decisions.

Bug: 1033557
Change-Id: Ief84b1a623754e8145e5a3037704cd4ae60b427f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966072
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724714}

This patch is an attempt to deflake bookmark sync integration tests,
including:
1) Adopting a BookmarkModelObserver for the waiting operations that
   depend exclusively on the state of the local bookmark model.
2) Improving the failure error strings, such that flake occurrences can
   be debugged. This includes defining PrintTo() for BookmarkNode.

Bug: 1012222,1012223,1017645,783774
Change-Id: Ie78a51f19ec4fdb5ca79b0a730b500c713ab8c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879941Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724713}