- 27 Apr, 2020 40 commits
-
-
Tanmoy Mollik authored
Replace calls to ChromeSigninController with IdentityManager API. Bug: 1074064 Change-Id: Ibe17c08c7e280633b1fac4283a6a7752df911c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165345Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#762846}
-
Alex Moshchuk authored
This CL modifies the OpenPopup (aka window.open helper) to avoid using unchecked WaitForLoadStop(), replacing it with waiting on a TestNavigationObserver for the specific URL being opened. Bug: 1014186 Change-Id: Ib28f9fe251336d1e1f3a0e6326792881e13fd671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165578 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#762845}
-
edchin authored
This is dead code. Change-Id: I587671bc66fe30fec8d597be173f1f16f35aec1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163079Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762844}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: Idc5667e6d660c2335cad0df813df1288d09b6929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164753 Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#762843}
-
Mason Freed authored
Previously, this would cause a null-reference: <template shadowroot=open>Content</template> This is now fixed. In addition, this CL adds two more tests of declarative shadow dom, for the two conditions listed at [1] and [2]. The [2] condition test also tests this CL. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#root-element-is-template-shadowroot [3] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#templates-containing-root-level-declarative-shadow-roots Bug: 1042130 Change-Id: Id697fb3f89681981ca3ecc513451d0644430fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166357 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#762842}
-
arthursonzogni authored
[Android sheriff] std::sort requires a sorter which satisfies the strict weak ordering. Otherwise some tests in debug mode crash this way: ~~~ [ RUN ] ScheduledNotificationManagerTest.DeleteNotifications algorithm:814: _LIBCPP_ASSERT '!__comp_(__l, __r)' failed. Comparator does not induce a strict weak ordering [ CRASHED ] ~~~ TBR=dtrainor@chromium.org,xingliu@chromium.org Bug: 1075541 Change-Id: Ic160e2c6201e6bd8702f71658613ab3eb7425a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166111Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#762841}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c23316f2..4bce2eef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icaf53c7d8bd1f288b3b08051397cb4f1803ddf8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165915Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762840}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/713f4f709ee7..e5a041472ebe git log 713f4f709ee7..e5a041472ebe --date=short --first-parent --format='%ad %ae %s' 2020-04-27 eseckler@google.com processor: Fix another clusterfuzz-found recursion bug in Track parsing Created with: gclient setdep -r src/third_party/perfetto@e5a041472ebe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ied30b2997cd11973cbf00afd0178cdee03132ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167933Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762839}
-
Bin Wu authored
https://quiche.googlesource.com/quiche.git/+log/b4810d5b775c..b67d2985293c $ git log b4810d5b7..b67d29852 --date=short --no-merges --format='%ad %ae %s' 2020-04-24 vasilvv Split test certificates into a separate file. 2020-04-23 dschinazi Fix TlsChloExtractor move assignment operator 2020-04-23 bnc gfe-relnote: n/a, test-only change. 2020-04-23 bnc Remove undefined and unused QuicSpdyStream::set_max_uncompressed_header_bytes() declaration. 2020-04-23 quiche-dev gfe-relnote: Replace the usage of ConnectionData::encryption_level in quic_time_wait_list_manager with a new TimeWaitAction SEND_CONNECTION_CLOSE_PACKETS. Protected by gfe2_restart_flag_replace_time_wait_list_encryption_level. 2020-04-23 nharper Add quic::ProofSource::TicketCrypter interface 2020-04-23 renjietang Add EXPECT_CALLs and use NiceMock to make tls_client_handshaker_test log look cleaner. 2020-04-23 fayang gfe-relnote: In gQUIC, move dynamic stream accounting to LegacyStreamIdManager. Protected by gfe2_reloadable_flag_quic_stream_id_manager_handles_accounting. 2020-04-23 wub Update some QuicUnorderedMap to QuicHashMap. 2020-04-23 fayang gfe-relnote: In QUIC, add exponential backoff for PTO timeout when there is not RTT measurement. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-23 wub gfe-relnote: (n/a) In QuicConfig, change some function's return value from QuicTagVector to a const reference. No behavior change, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=bnc@chromium.org Change-Id: I908aa9cd7269194e464c46c393a0426f2516abb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164689Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#762838}
-
Greg Daniel authored
Change-Id: Ib27e9405cc4c02cfdf83a6c2222f284ac57cad75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166490 Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Greg Daniel <egdaniel@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#762837}
-
arthursonzogni authored
Outcomes: - Current support for parsing COEP/COOP from the navigation response was only made for the network and serviceworker URLLoader. After this patch this is now supported universally across every URLLoader (AppCache, SignedExchange, ...) - Code for supporting ServiceWorker has been removed, since this is already taken care by ParsedHeader. - COOP is no more parsed in the browser process. This was the case previously for response served by the ServiceWorker. Design doc: https://docs.google.com/document/d/1WYoa6pHg8kUzynXLBlTg08X5PTESwP9M6pN1QCMIKow Bug: 1063832 Change-Id: I6b58e756eba68465ad0f411cf91059434c7eb923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134292 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#762836}
-
Piotr Tworek authored
The code in one of the source files of this module uses strlen but does not include cstring header. On Linux systems using glibc 2.30 or newer this leads to a build failure. Bug: 1074286 Change-Id: I9240e1846308613a071ebce4458430e64b1c59de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165893Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#762835}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I0181b660daff212d6bbd777da7f241b62fa10b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164890 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#762834}
-
Filip Gorski authored
Patch 1 for OmniboxSuggestionsList RecyclerView update. * Creates OmniboxSuggestionsDropdown interface (will be shared with a RecyclerView implementation) * Moves SuggestionListObserver from SLProperties to OmniboxSuggestionsDropdown (as a nested interface) * Moves OmniboxSuggestionListEmbedder to OmniboxSuggetsionsDropdown as an internal interface -- handles naming inconsistencies * Updates test utils that access suggestions dropdown. Change-Id: Ib44f41fbb43d57a4c43c09835d127836f5e782d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163152 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#762833}
-
Mohammed Abdon authored
Introduces ChromeOS.SAML.Provider metrics which will record SAML Provider every time SAML online flow is used. Bug: 1065080 Change-Id: I3646df19bc42a6c1d7c661bd69c6d249f66aaa64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111174 Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762832}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a67630cdfebc..821726de7bad git log a67630cdfebc..821726de7bad --date=short --first-parent --format='%ad %ae %s' 2020-04-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 4fb0e0374a39..3336e65e8801 (1 commits) 2020-04-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 7d65f09b8311..bcf6a2430e99 (3 commits) 2020-04-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src bb0380e3932a..1512acdf047f (2 commits) Created with: gclient setdep -r src/third_party/angle@821726de7bad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I5e05d6d8d8cb0e1408aadc9180369d314cb77ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167787Reviewed-by:
-
Xida Chen authored
This CL doesn't change behavior, it deletes some dead code. Bug: None Change-Id: Ic917e76b8dc5545cc7bfc7b39887c4ea859009bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167107 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#762830}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I9ca0ff68f4f9633b7a98043cba0d9def392ec4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166415Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762829}
-
Alexander Hendrich authored
This reverts commit 7c281002. Reason for revert: blink_web_tests failure on webkit linux asan bot (see crbug.com/1075517) Original change's description: > [LayoutNG] Correct IsLastForNode() and IsFirstForNode() in inline item. > > As part of the descendants walk that we perform when adding a box > fragment that establishes an inline formatting context, update the > first/last-for-node bits directly. > > Many thanks to kojii@ for suggesting and helping out with this solution! > > Once we add the last box fragment for a node, finalize the inline items. > In addition to associating with the LayoutObjects, also set the > first/last-for-node bits, if fragment traversal is enabled. > > Since we now require the layout results to be available for anything > that establishes an inline formatting context (to set the first/last > bits), we also need to store the layout results for the column > fragments. Columns are not really associated with a LayoutObject, but > we'll use the legacy LayoutFlowThread for this. Another option would be > to create an anonymous block child of a multicol container that > establishes an inline formatting context, but I decided against that for > now. > > Expanded some NGFragmentItemTest unit tests, and added a new one, to > make sure that we behave in RTL situations. > > This allows for supporting these bits in culled inlines as well. > Enabled fragment traversal in NGFragmentItemTest, so that we can test > it, and removed DCHECKs in IsFirstForNode() and IsLastForNode(). The > culled inlines test there also expects FragmentsVisualRectBoundingBox() > to return something sensible, so remove the skipping we had in PrePaint > for culled inlines, to just make this work. > > Will follow-up with cleaning up the first/last for node stuff added as > part of CL:2111158. This will no longer be needed, but doing it in a > separate CL is probably cleaner. > > Bug: 1043787 > Change-Id: Id9873300e9ac5ec01d68aafd059a4aa3d830528b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152824 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762758} TBR=kojii@chromium.org,mstensho@chromium.org Bug: 1043787, 1075517 Change-Id: I18342be3d4a42d2170f46df73cec7f9250be840e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165736Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#762828}
-
Miyoung Shin authored
This CL converts ViewHostMsg_ResolveProxy to RendererHost mojom interface and drops |Msg| from the name of ResolveProxyMsgHelper. Bug: 1071625 Change-Id: I8fa8c6c8a502e0bace9bba7dd36ed687c1a86047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164137 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/74fc574cbc14..62a0d647d9e8 git log 74fc574cbc14..62a0d647d9e8 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 mbonadei@webrtc.org Remove deprecated constant. Created with: gclient setdep -r src/third_party/webrtc@62a0d647d9e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I77e0b1b96d00bb49ec672c30d1335057df468e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167932Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I67e80ea4485f22b8a0fd8f974b9fa1a1c6edec41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167931Reviewed-by:
-
Vadym Doroshenko authored
This CL is a part of moving PasswordForm class to components/password_manager/core/browser. Bug: 1067347 Change-Id: Iebc89045547a3ea9293e794e7ee8ae43f36b6684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164611 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#762824}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I960875650dacb7ec78f04666bbbf22147e649461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164811 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762823}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/51980699f7e4..992295e37d43 git log 51980699f7e4..992295e37d43 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 jacktfranklin@chromium.org Move `UIString` into `Platform` 2020-04-27 mathias@chromium.org Revert "Roll deps" 2020-04-27 mathias@chromium.org Roll deps 2020-04-27 tvanderlippe@chromium.org Add extensions for implicit imports in named export declarations 2020-04-27 tvanderlippe@chromium.org Run Karma unittests on the Ninja output directory Created with: gclient setdep -r src/third_party/devtools-frontend/src@992295e37d43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125,chromium:1075437 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4770e154e20d39364ac824f6ef522d7558126947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167789Reviewed-by:
-
arthursonzogni authored
[Android sheriff] Disable the flaky test: testAdvancedSyncFlowPreferencesAndBottomBarShown The test has recently been added by: https://chromium-review.googlesource.com/c/chromium/src/+/2137440 TBR=bsazonov@chromium.org Bug: 1075530 Change-Id: I06aa061853dfb346a750f1913e9d4bec1f12084e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167277Reviewed-by:
-
Mathias Carlen authored
This patch introduces a repeated field of domains to be used as a browse mode whitelist when a user browses the web. In particular, subdomains should be whitelisted if they should be accessible by a user without AA shutting down. Bug: b/154305037 Change-Id: Id3a1ce078b8ece833513beacedf3c529a9cd77d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164807 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#762820}
-
Boris Sazonov authored
This CL adds IdentityManager.getPrimaryAccountInfo(consentLevel) and deprecates the old version without parameters. It also migrates all callers to the new method. Bug: 1046746 Change-Id: I6a1d9de35361fc81420eda7fc6a8b73ceb0db20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162737Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#762819}
-
Milica Selakovic authored
This CL intorduces presaving of generated password. Bug: 1064264 Change-Id: I7fd18722a2eecb883c0f62bbc7d0aaed764e37b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153109 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#762818}
-
Boris Sazonov authored
The call to SigninHelper.updateAccountRenameData() in AccountsChangedReceiver is redundant, as SigninHelper would call updateAccountRenameData in validateAccountsInternal anyway. Bug: 1074306 Change-Id: Ib02d364ee06364582816b0896e3ec96d4c3295c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164826Reviewed-by:
-
Sebastien Lalancette authored
I realized no code-path will ever trigger the error alert pop-up in the activity service component. I think it actually makes sense given that our activities are in fact commands - the command should handle reporting its failing state. Cleaned-up that scenario. Bug: 1068606 Change-Id: I677746f7216cbc975a0382d2fc98cec05a75a7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165849Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#762816}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b26111815641..74fc574cbc14 git log b26111815641..74fc574cbc14 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 tommi@webrtc.org Fork a few VideoReceiveStream related classes. Created with: gclient setdep -r src/third_party/webrtc@74fc574cbc14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib3067f5472db64c2f25bc8539703fd5a0d381d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167788Reviewed-by:
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: Id6e45887e66060a275b14489290e5aedd0379868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164511Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#762814}
-
Antonio Sartori authored
According to https://w3c.github.io/webappsec-csp/#directive-report-to, the Content-Security-Policy directive "report-to" should only accept one token (endpint). However, our previous implementation allowed several endpoints to be specified. Bug: 916265 Change-Id: Ie11ee736f577d015921a5291824dcedcbc790177 Fixed: 916265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162826Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#762813}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d2d6cca..c23316f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60d1a25eaf45aa091df396ce81db3c0dd690c099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165914Reviewed-by:
-
Harald Alvestrand authored
Bug: none Change-Id: Id2858339f46c14ee6b007c5e3b0aa4b2d7c90c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153160 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#762811}
-
Ulan Degenbaev authored
Change-Id: I2b28e30f7d4f64e53d0c95ac4224df639967afd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156413Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762810}
-
Yuki Shiino authored
{Readable,Writable,Transform}StreamDefaultConstroller expect their prototype object to have 'constructor' property, however, [NoInterfaceObject] is an extended attribute that removes 'constructor' property on the prototype object (although the current bindings generator doesn't do so). Remove the misusage of [NoInterfaceObject]. Bug: 839389 Change-Id: I12057b0a4283c9247933e7f6085f855df581e3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167743Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#762809}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b59ed7ed88a3..51980699f7e4 git log b59ed7ed88a3..51980699f7e4 --date=short --first-parent --format='%ad %ae %s' 2020-04-27 mathias@chromium.org Avoid unnecessary use of `Object.entries` Created with: gclient setdep -r src/third_party/devtools-frontend/src@51980699f7e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039620,chromium:1075437 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibeec76be4537878f65deec9f9b854727fcb018c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167783Reviewed-by:
-
Anastasiia Nikolaienko authored
If we receive mirror header for another profile (when using multiprofile mode) - don't show the dialog. If Show method was called when lock screen is open, ignore the call. Bug: 1073050 Change-Id: I5b6575bf8ef6c833c34c3de4117018818ba957c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161030Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#762807}
-
