GitLab

R=mkwst@chromium.org,clamy@chromium.org

Change-Id: I1d32699940108e69b116449309a50fae8e07c1bb
Reviewed-on: https://chromium-review.googlesource.com/1049387Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556723}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 835626
Change-Id: I404db91904dab92834a7efca5a567b2ad66d84e4
Reviewed-on: https://chromium-review.googlesource.com/1049474Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556722}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 835626
Change-Id: Ifd9d394f5cf2f4dd25146e0a0422b7bcd00b4103
Reviewed-on: https://chromium-review.googlesource.com/1049415Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556721}

This change adds a base::Feature for the BLE implementation using WinRT
UWP APIs.

Bug: 579202, 821766
Change-Id: I94d64ce60aff2286b0bcaf98e01b68b44db9bf43
Reviewed-on: https://chromium-review.googlesource.com/1046545Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556720}

An audio::GroupMember::Snooper that records the audio from a GroupMember
on one thread, and re-renders it to the desired output format on another
thread. Since the data flow rates are known to be driven by different
clocks (audio hardware clock versus system clock), the SnooperNode also
uses its resampler to compensate for skew and re-synchronize the audio
going into and out of it.

Bug: 824019
Change-Id: I87d410724fd00f9372232bfffdfbb89ada0b3de8
Reviewed-on: https://chromium-review.googlesource.com/1041657
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556719}

The UMA was added to measure the instances of large images which should
be async decoded, and whether they were on img or css tags. The data on
Android indicates that out of about 20% images which fit the size
requirement, 3% are from css and the rest 17% are img tags.

We don't need to keep tracking this anymore.

R=chrishtr@chromium.org

Bug: 802121
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I168245df6a48f3a74a630639c118925b2ed478cf
Reviewed-on: https://chromium-review.googlesource.com/1045729Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556718}

This is a change suggested by altimin@ in <crrev.com/c/1038944>.

Bug: 826203
Change-Id: Ic4b772834fea28cfcf5ed92e12418e437ca92652
Reviewed-on: https://chromium-review.googlesource.com/1046869Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556717}

It's a duplicate. Use service-account-chromeperf instead.

Bug: 839022
Change-Id: I59cbc9a1306f356375da1d2533bbd5c82a4647f2
Reviewed-on: https://chromium-review.googlesource.com/1043002Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: David Tu <dtu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556716}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5c50bf92e6fb..da3ce5f235a2

$ git log 5c50bf92e..da3ce5f23 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 yunlian add elfutils to host packages.
2018-04-29 reveman Add crosvm to video group.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:701659,chromium:837209


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ief473bca3ca4f12541910fb806f6503a6e8a6905
Reviewed-on: https://chromium-review.googlesource.com/1049275Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556715}

Change-Id: I1b8f6ab60fd5c871e0c119200a01f4ce091fdd7c
Bug: 833826
Test: Manually verified by turning on docked magnifier.
Reviewed-on: https://chromium-review.googlesource.com/1049466Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556714}

Spec: https://html.spec.whatwg.org/multipage/workers.html#dom-workerglobalscope-importscripts

"1. If worker global scope's type is "module", throw a TypeError exception."

Bug: 831420
Change-Id: I6a1976363435596562689988ed39394a3b735779
Reviewed-on: https://chromium-review.googlesource.com/1038926
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556713}

Add a histogram to collect metrics on how often handshake has been confirmed
when connection migration is triggered.

Bug: 790547, 804048
Change-Id: I593b80c1557aba30fbea52297497d9f04b51d61e
Reviewed-on: https://chromium-review.googlesource.com/1036452
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556712}

passes the test argument in promise_test and async_test
so it can be used to add cleanup.
Change done with a jscodeshift codemod that detects
there were no arguments to promise_test (or async_test):

export default function transformer(file, api) {
  const j = api.jscodeshift;
  return j(file.source)
    // .find(j.CallExpression)
    .find(j.CallExpression, {callee: {type: 'Identifier', name: 'promise_test'}})
    .forEach(path => {
        if (path.value.arguments[0].params.length === 0) {
          path.value.arguments[0].params.push(j.identifier('t'));
        }
    })
    .toSource();
};

BUG=836871

Change-Id: Ie7dd7fb0dd8a4da6c4c00f3616fd41d1d47854ef
Reviewed-on: https://chromium-review.googlesource.com/1047674Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556711}

The CL https://crrev.com/c/993761 made a change to stop all screen
capture/share sessions in ScreenTrayItem when one of the sessions is
stopped.

Unfortunately the fix does not work in UnifiedSystemTray as it's done
in SystemTrayItem. Also, the behaviors from the notification stop button
and the tray stop button were different.

This CL moves the logic from ScreenCaptureItem to
ScreenSecurityNotificationController.

Ideally we should fix Screen{Capture,Share}Observer interfaces, or
prevent multiple share sessions in the first place but it is not trivial
as noted in https://crbug.com/826041#c6.

TEST=ScreenCaptureTest,ScreenShareTest
BUG=826041

Change-Id: I3f559b95d99bfd4c04a1241e2e86de2718f1dc29
Reviewed-on: https://chromium-review.googlesource.com/1046287Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556710}

DropIndex::value is treated as an int, not a size_t.

BUG=

Change-Id: I5933c10a8b44758606e7a8bfd124e4853f42fd5c
Reviewed-on: https://chromium-review.googlesource.com/1049009
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556709}

This reverts commit 3edba584.

Reason for revert: Code not working properly on Mac

Original change's description:
> [ChromeDriver] Use Browser.close to quit
> 
> Currently, ChromeDriver closes desktop Chrome by simply killing the
> top-level Chrome process. This isn't graceful, and causes problems
> in some scenarios. This commit sends a Browser.close command to close
> the browser gracefully.
> 
> Bug: chromedriver:2311
> Change-Id: Idec9338b094f0aab89022b8453dd2a98268ad1e7
> Reviewed-on: https://chromium-review.googlesource.com/1037585
> Commit-Queue: John Chen <johnchen@chromium.org>
> Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556689}

TBR=johnchen@chromium.org,kereliuk@chromium.org

Change-Id: I53f310a7745586fdcbebb1edd58b5eb0d7873475
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromedriver:2311
Reviewed-on: https://chromium-review.googlesource.com/1049146Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556708}

https://skia.googlesource.com/skia.git/+log/9a9c25b36ce5..6198f39adc5c

$ git log 9a9c25b36..6198f39ad --date=short --no-merges --format='%ad %ae %s'
2018-05-08 angle-skia-autoroll Roll third_party/externals/angle2/ 9f394f8cd..3b9b027c5 (1 commit)
2018-05-07 khushalsagar text-blob: Fix OOM issues during blob deserialization.
2018-05-07 fmalita [viewer] Avoid per-frame json UI updates
2018-05-07 bsalomon Visit the image proxy in GrLatticeOp
2018-05-07 bsalomon Add null proxy test to SkGpuDevice::drawProducerLattice

Created with:
  roll-dep src/third_party/skia
BUG=chromium:840096,chromium:b/77917978,chromium:b/77917978


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: I73084b62ba69340f17f0f9e7d801e2558c198599
Reviewed-on: https://chromium-review.googlesource.com/1049116Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556707}

https://pdfium.googlesource.com/pdfium.git/+log/cb391259aefd..e5c0fa97c2da

$ git log cb391259a..e5c0fa97c --date=short --no-merges --format='%ad %ae %s'
2018-05-08 thestig Make one more CPDF_PageObjectHolder member protected.
2018-05-07 thestig Make more CPDF_PageObjectHolder members protected.
2018-05-07 thestig Make CPDF_PageObjectHolder::m_iTransparency protected.
2018-05-07 thestig Add some getters for CPDF_PageObjectHolder.
2018-05-07 hnakashima Restore logic of CreateChildUIAndValueNodesIfNeeded().
2018-05-07 tsepez Move codepage tables from cpdf_document.cpp to fx_codepage.cpp
2018-05-07 tsepez Use unowned ptr for CPDF_Page::m_pView.
2018-05-07 thestig Move some CPDF_TextPage methods into an anonymous namespace.
2018-05-07 thestig Initialize CPDF_RenderStatus members in the header.
2018-05-07 thestig Initialize CPDF_TextPage members in the header.
2018-05-07 tsepez Ensure that XFA Pages always have a corresponding PDF page
2018-05-07 tsepez Add test for mutltiple copies of same PDF page.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:838994


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I383e6d0de113818b5481784c690c62aa213fb394
Reviewed-on: https://chromium-review.googlesource.com/1049111Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556706}

The result of GetFocusedFrame() can be null.
I discovered this while using this value in a debug log statement, not
from actual production code, so there is no known user-facing crash or
bug at this point.

Change-Id: Ie272aa67d2c0b9d60f62f670091e6ee3ac08b82d
Reviewed-on: https://chromium-review.googlesource.com/1046505Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556705}

These AudioPlayerBrowserTest run on a target_os="chromeos" linux build
which attempts to use PulseAudio for audio, and always fails [1].

The tests still PASS, since they don't need to test lower-layer audio,
but they do output PulseAudio LOG failure messages. To avoid that, use
a fake audio layer instead, which can be requested by a media command-
line switch kDisableAudioOutput after crrev.com/539638.

[1] PulseAudio won't work in this case and the LOG output of the tests
indicate that (see bug 835626 comments #3 and #7).

Bug: 835626,835742
Change-Id: I8113c15a123bfb8048141e7a20c8d02cf3341e13
Reviewed-on: https://chromium-review.googlesource.com/1047045Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556704}

This reverts commit ddd9f0ee.

Reason for revert: Speculative revert for animation-worklet-scroll-timeline.html failure on WebKit Linux Trusty Leak bot.
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/18614


Original change's description:
> Composite ScrollTimeline scrollSource when appropriate.
> 
> This CL makes being the scrollSource of an active (i.e. the scrollSource is
> scrollable) and attached (i.e. it is being used by at least one WorkletAnimation
> as a timeline) ScrollTimeline a compositing reason. It does not change the
> requirement that the scrollSource must be composited for the WorkletAnimation to
> be sent to the compositor, nor does it change the case where a scrollSource stops
> being composited whilst a WorkletAnimation is running. Those will be addressed in
> follow-up CLs.
> 
> Bug: 776533
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Icae43e1c9cfe2720cc739401c4766b592571f231
> Reviewed-on: https://chromium-review.googlesource.com/1036934
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556541}

TBR=pdr@chromium.org,majidvp@chromium.org,smcgruer@chromium.org

Change-Id: I615c3bfd9b9c6346b3a521a6922af3f56da6c308
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 776533
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1049207Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556703}

This reverts commit 2f1216f9.

Reason for revert: Caused use-of-uninitialized-value in Linux MSan Tests bot.
https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/9657

Looks like client_socket_factory_ is not initialized?

Original change's description:
> [network service] Add an API to upgrade a TCP socket to a TLS socket
> 
> This CL:
> - Adds an UpgradeToTLS() API to mojom::TCPConnectedSocket, so consumers of
>   mojom::TCPConnectedSocket can perform TLS connect on top of an already
>   connected tcp client socket.
> - Adds a tls_socket.mojom file which includes the interface definition of
>   TLSClientSocket.
> 
> Other changes to support implementing UpgradeToTLS():
> - Uses net::StreamSocket::ReadIfReady() instead of net::StreamSocket::Read() in
>   socket_data_pump.h/cc. Using ReadIfReady() allows us to cancel the receive
>   side in preparation for UpgradeToTLS() without worrying that data might be
>   buffered by the tcp socket.
> - Adds a net::Socket::CancelReadIfReady(), so we can tell the underlying tcp
>   socket to cancel a pending ReadIfReady() and unregister their event watchers.
> 
> Bug: 721401
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ic23fc782f6e701e6b7a9f60ac2ddfeccc6031744
> Reviewed-on: https://chromium-review.googlesource.com/1034080
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556605}

TBR=mmenke@chromium.org,tsepez@chromium.org,xunjieli@chromium.org

Change-Id: Iaa5ad743e7cdf90239675cef6f34457ea8b5be8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1049206Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556702}

The name ResizeOrRepaint is a misnomer. This CL renames it to something
more appropriate. This CL also renames the resize_ack_pending_ to
visual_properties_ack_pending_.

Bug: 672962
Change-Id: Ibee6540617d0bcd4e5bf2f2492beb618aff19255
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1048113
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556701}

This reverts commit b5d6fee9.

Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel
https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672

Original change's description:
> Use GG700 / Chrome icon color for toolbar
> 
> Replaces GG800 with GG700 as icon color in a couple of places:
> 
> * Omnibox default chip (HTTP (i) icon for instance).
> * BubbleIconView inside omnibar (these used to be GG700 but regressed
>   to GG800 in Touchable / Refresh recently).
> * Toolbar button icons.
> 
> Bug: chromium:821996, chromium:834510
> Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef
> Reviewed-on: https://chromium-review.googlesource.com/1040875
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556646}

TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org

Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:821996, chromium:834510, chromium:840657
Reviewed-on: https://chromium-review.googlesource.com/1049445Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556700}

Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 835626
Change-Id: I1f2037fe9bebc3005b561440f6ead2dd3eadf80c
Reviewed-on: https://chromium-review.googlesource.com/1049090Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556699}

This test was failing in debug.

  onRemoveTap_: function(event) {
    this.showRemoveDialog_ = true;
    this.async(() => this.$$('#removeDialog').showModal());
  },

in

cs.chromium.org/chromium/src/chrome/browser/resources/settings/crostini_page/crostini_subpage.js

always comes up with

this.$$('#removeDialog').showModal == undefined

in debug. I do not know why. But this dialog is being
replace with a View dialog very soon anyway.

Bug: 838097
Change-Id: Id78b498ee9ce54849793eb9518bbb513a426f13d
Reviewed-on: https://chromium-review.googlesource.com/1036710
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556698}

Network traffic annotation is added to sockets write functions and hence
their create functions do not need to be tested in traffic annotation
tests anymore. Hence unnecessary code is removed from
traffic_annotation_auditor.

Bug: 690323
Change-Id: I70676ea7dab9f1db3a6d5c3625d85dda6ddc8a11
Reviewed-on: https://chromium-review.googlesource.com/1046166Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556697}

Method names such as StartVmConcierge are confusing. Rename to
StartConcierge etc.

third_party/cros_system_api/dbus/debugd/dbus-constants.h still has

const char kStartVmConcierge[] = "StartVmConcierge";
const char kStopVmConcierge[] = "StopVmConcierge";

as these need to match the method names in the service.

Bug: 839206
Change-Id: I48800e595a2756fd8bc8d35ca136dd73a825b08e
Reviewed-on: https://chromium-review.googlesource.com/1041365
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556696}

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1029882
with debug linkage fixed.

Original description:
The code was written with the expectation that
HostedAppButtonContainer::StartTitlebarAnimation()
is called before
HostedAppButtonContainer::OnImmersiveRevealStarted().

This is not the case when in tablet mode and results
in crashes.

This CL updates HostedAppButtonContainer to allow these
methods to be called in either order.

Bug: 836482
Change-Id: Ia862c8bfccf448322cb878892e70b38eb68818e4
Reviewed-on: https://chromium-review.googlesource.com/1045955
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556695}

Fix bug where selecting a folder in a Team Drive in the Files App
doesn't update the currently selected folder in the left-hand directory
tree.

ensure it is reflected in the LHS.

Test: Select a folder in the RHS in the Files App in a team drive and
Bug: 840207
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieeb9be680a043498bfbbb8f12eb38b8015c4d6bb
Reviewed-on: https://chromium-review.googlesource.com/1045957Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556694}

This patch inverses the ui scales before sending them as output device
scale factor.

Bug: 840107
Change-Id: I19eb520818281161abd53230b8cabcd0d40e1ebd
Component: wayland, scaling, aura shell
Reviewed-on: https://chromium-review.googlesource.com/1049115
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556693}

Currently, we don't close the existing Picture-in-Picture window when
the a new tab (i.e. content::WebContents) initiates Picture-in-Picture
mode. This change tears down Picture-in-Picture mode for the current
video before opening a new one.

This change also pauses the video on user gesture to close. When the
Picture-in-Picture window is closed, the video in tab will not continue
playing, even if it was playing in the window.

BUG: 823172
Change-Id: I15e4ada29c6447fd15751503e1ad41868a89e71a
Reviewed-on: https://chromium-review.googlesource.com/1044752
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556692}

Using wpt-import in Chromium 77db7fb7.
With Chromium commits locally applied on WPT:
8d1dda31 "Revert "Adds a test for basic WebRTC video codec conformance.""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17145

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0aaea7e106de989a660cd820d618d4a7bb774486
Reviewed-on: https://chromium-review.googlesource.com/1049029
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556691}

This commit:
- breaks the inheritance relationship of ChromeSearchResult and SearchResult;
- removes all SearchModel class references from Chrome;
- removes ChromeSearchResult::Duplicate and uses SearchResultMetadata to
  publish results.

Bug: 733662
Change-Id: Iacf407818d74a69daa06c6649cfbf255b8921df4
Reviewed-on: https://chromium-review.googlesource.com/1038766Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#556690}

Currently, ChromeDriver closes desktop Chrome by simply killing the
top-level Chrome process. This isn't graceful, and causes problems
in some scenarios. This commit sends a Browser.close command to close
the browser gracefully.

Bug: chromedriver:2311
Change-Id: Idec9338b094f0aab89022b8453dd2a98268ad1e7
Reviewed-on: https://chromium-review.googlesource.com/1037585
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556689}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cee97214012..9ad6814d5f1e

$ git log 6cee97214..9ad6814d5 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ide022b70ed3106a81564148f2e46bd710f2ffeed
Reviewed-on: https://chromium-review.googlesource.com/1048834Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556688}

Bug: 816778
Change-Id: Ib5ab2e9d89fa2e49a3e273b09ab20ce511163856
Reviewed-on: https://chromium-review.googlesource.com/938567Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556687}

TBR=bsheedy@chromium.org

Bug: 840638
Change-Id: I3acc6d00d75f6c6dce370961d7459dc3a50faef4
Reviewed-on: https://chromium-review.googlesource.com/1049274Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556686}

Previously, we'd plumbed the display rotation as an integral
angle, but the only valid values were 0, 90, 180 and 270
degrees. We then converted to an enum. With this CL, we
plumb the enum directly.

Bug: 836948
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ia99aa7543188fb56f9595cea835b2dfee496f811
Reviewed-on: https://chromium-review.googlesource.com/1045910
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556685}

We need to reduce the load on Vk N5X bots in order to be able to run
dEQP Vk tests on them.

Bug: 839893
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I036c98e02e22c269399feed20225ecd6759cb413
Tbr: kbr@chromium.org
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/1048210
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556684}