GitLab

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256733004
Cr-Commit-Position: refs/heads/master@{#413404}

Those properties are: background-image, border-image-source, list-style-image, content, and shape-outside.

Spec: https://drafts.css-houdini.org/css-typed-om/#mapping-of-properties-to-accepted-types

BUG=545318

Review-Url: https://codereview.chromium.org/2220253002
Cr-Commit-Position: refs/heads/master@{#413403}

Revert of bluetooth: Return false for IsPresent only when bluetooth is not supported (patchset #1 id:1 of https://codereview.chromium.org/2248033006/ )

Reason for revert:
device_unittests: BluetoothTest.ConstructDefaultAdapter is failing.

Original issue's description:
> bluetooth: Return false for IsPresent only when bluetooth is not supported
>
> BUG=633274
>
> Committed: https://crrev.com/784971913adcc32bdb22a92da6ac237a7de88a2b
> Cr-Commit-Position: refs/heads/master@{#413192}

TBR=jyasskin@chromium.org,ortuno@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=633274

Review-Url: https://codereview.chromium.org/2262033002
Cr-Commit-Position: refs/heads/master@{#413402}

https://chromium.googlesource.com/skia.git/+log/577e012e4058..5755cd98a749

$ git log 577e012e4..5755cd98a --date=short --no-merges --format='%ad %ae %s'
2016-08-21 reed make zoomer text clearer

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2265843002
Cr-Commit-Position: refs/heads/master@{#413401}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2257713003
Cr-Commit-Position: refs/heads/master@{#413400}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259523003
Cr-Commit-Position: refs/heads/master@{#413399}

Since deterministic_build_blacklist.json is used by not only
compare_build_artifacts.py but also remove_build_metadata.py,
let me rename the directory name to determinism to reflect
what this is.

BUG=314403

Review-Url: https://codereview.chromium.org/2260053003
Cr-Commit-Position: refs/heads/master@{#413398}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254183002
Cr-Commit-Position: refs/heads/master@{#413397}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259823003
Cr-Commit-Position: refs/heads/master@{#413396}

Cr-Commit-Position: refs/heads/master@{#413395}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254973004
Cr-Commit-Position: refs/heads/master@{#413394}

To reduce the string comparison in SiteFromURL().

This CL depends on https://codereview.chromium.org/2251633002/.

https://codereview.chromium.org/2249063004/ depends on this CL.

BUG=561209

Review-Url: https://codereview.chromium.org/2250623003
Cr-Commit-Position: refs/heads/master@{#413393}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252373002
Cr-Commit-Position: refs/heads/master@{#413392}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cda4e72f8776..947506bacfb5

$ git log cda4e72f8..947506bac --date=short --no-merges --format='%ad %ae %s'

BUG=639632

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2264903002
Cr-Commit-Position: refs/heads/master@{#413391}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253233004
Cr-Commit-Position: refs/heads/master@{#413390}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259753003
Cr-Commit-Position: refs/heads/master@{#413389}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256813005
Cr-Commit-Position: refs/heads/master@{#413388}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257763002
Cr-Commit-Position: refs/heads/master@{#413387}

Spec: https://drafts.css-houdini.org/css-typed-om/#cssurlimagevalue

BUG=545318

Review-Url: https://codereview.chromium.org/2208283002
Cr-Commit-Position: refs/heads/master@{#413386}

TBR=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2268483002
Cr-Commit-Position: refs/heads/master@{#413385}

No behavior changes.

BUG=388681

Review-Url: https://codereview.chromium.org/2246143004
Cr-Commit-Position: refs/heads/master@{#413384}

https://chromium.googlesource.com/skia.git/+log/ce25041865e7..577e012e4058

$ git log ce2504186..577e012e4 --date=short --no-merges --format='%ad %ae %s'
2016-08-21 reed add translate to exercise non-identity ctm performance

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2268463002
Cr-Commit-Position: refs/heads/master@{#413383}

Review-Url: https://codereview.chromium.org/2260813003
Cr-Commit-Position: refs/heads/master@{#413382}

BUG=350660
TESTS=Absence of these strings doesn't break any builds or tools

Review-Url: https://codereview.chromium.org/2251523002
Cr-Commit-Position: refs/heads/master@{#413381}

Commit 702d65e4
updated the underlying data file, but the
generated .gperf file was not re-generated because
I forgot to run net/tools/tld_cleanup on it.

TBR'ing because it's a file derived from the
already reviewed CL.

TBR=pkasting@chromium.org
BUG=626532, 639677

Review-Url: https://codereview.chromium.org/2263923002
Cr-Commit-Position: refs/heads/master@{#413380}

BUG=none

Review-Url: https://codereview.chromium.org/2250263007
Cr-Commit-Position: refs/heads/master@{#413379}

A response provider for DNS failures.

BUG=

Review-Url: https://codereview.chromium.org/2259393002
Cr-Commit-Position: refs/heads/master@{#413378}

BUG=638481

Review-Url: https://codereview.chromium.org/2250313002
Cr-Commit-Position: refs/heads/master@{#413377}

The current viewport resize anchor assumes the FrameView is always the layout
viewport. This is not true in the setRootScroller experiment where an arbitrary
<div> may become the layout viewport in RootFrameViewport.

I've moved the anchoring logic into RootFrameViewport to keep this information
encapsulated and used the layout viewport as reported by the RootFrameViewport
class

BUG=505516

Review-Url: https://codereview.chromium.org/2248433002
Cr-Commit-Position: refs/heads/master@{#413376}

Faking {{cpp_class}} and {{c8_class}} doesn't make sense.
Probably it made sense before the introduction of virtual
ScriptWrappable::wrap().

Checking the existence of window->document() doesn't seem
making sense to me, and CQ tests seem passing without the
check.

BUG=

Review-Url: https://codereview.chromium.org/2268433002
Cr-Commit-Position: refs/heads/master@{#413375}

This is a refactoring CL, removing the LinkPreload resource type,
as it is not really necessary.
It also matches the priority of <link rel=preload> with no `as` attribute
to regular raw resource types (e.g. XHR).

BUG=593267

Review-Url: https://codereview.chromium.org/2257943002
Cr-Commit-Position: refs/heads/master@{#413374}

https://chromium.googlesource.com/skia.git/+log/deb8136c9ce4..ce25041865e7

$ git log deb8136c9..ce2504186 --date=short --no-merges --format='%ad %ae %s'
2016-08-21 update-skps Update SKP version

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2267573002
Cr-Commit-Position: refs/heads/master@{#413373}

The shared change processor should always be cleared.

BUG=639449

Review-Url: https://codereview.chromium.org/2265703002
Cr-Commit-Position: refs/heads/master@{#413372}

BUG=

Review-Url: https://codereview.chromium.org/2257553002
Cr-Commit-Position: refs/heads/master@{#413371}

BUG=634139
TBR=kcc@chromium.org

Review-Url: https://codereview.chromium.org/2265783002
Cr-Commit-Position: refs/heads/master@{#413370}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9ac808a6..d0987fac

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2258423002
Cr-Commit-Position: refs/heads/master@{#413369}

BUG=633930

Review-Url: https://codereview.chromium.org/2254753002
Cr-Commit-Position: refs/heads/master@{#413368}

This patch makes the code more robust in that it adds a class which
automatically calls image draw finished on exit. This ensures that
any changes to the code (more early outs) won't forget to call that
function.

R=ericrk
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2256833006
Cr-Commit-Position: refs/heads/master@{#413367}

CreateAndConsumeTextureCHROMIUM is an odd function that doesn't really fit in
any of the models (it's a bit of a mix between "Create" and "PUT"). Rather than
doing a 1-off model, introduce in the generator a notion of an "internal"
function, that only generates a command, that is never directly exposed to the
client interfaces.
Introduce a CreateAndConsumeTextureINTERNAL that fits the existing "PUT" model,
and trivially implement CreateAndConsumeTextureCHROMIUM in terms of the former.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2257533007
Cr-Commit-Position: refs/heads/master@{#413366}

refer to detail spec about FlipX()[1] and FlipY()[2]

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy

BUG=388780

Review-Url: https://codereview.chromium.org/2260393002
Cr-Commit-Position: refs/heads/master@{#413365}