GitLab

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3205003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/3158032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57299 0039d316-1c4b-4281-b951-d872f2087c98

after a WebKit roll.

BUG=none
TEST=none
TBR=yuzo

Review URL: http://codereview.chromium.org/3173045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57298 0039d316-1c4b-4281-b951-d872f2087c98

Refactor: change the spdy session pool key to take a ProxyServer instead of a string representation of the proxy server.
BUG=52668
Review URL: http://codereview.chromium.org/3197018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=yuzo

Review URL: http://codereview.chromium.org/3181040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57296 0039d316-1c4b-4281-b951-d872f2087c98

implementation of IsConnected() on windows, you'll find that it can
synchronously check if the socket is connected.  This makes it so that
a CHECK (or DCHECK) on this attribute is dependent on the peer.  The peer
could send us a TCP-FIN at any time - even 1 nanosecond before our call
to IsConnected().  We can only use CHECK(!IsConnected()) to check before
we connect, we simply can't use it at runtime.

I searched the code and found 4 other instances of this broken check.  Most
were DCHECKs, which is good, but I've removed them just the same.

Turns out our MockSockets have a mechanism for simulating this error, but it
wasn't tested nor plumbed through the MockSSLClientSocket.  In the process
I added a couple of basic proxy test cases, which may be slightly redundant
with other test cases that are more advanced.  But they seem like a good
idea to cover anyway.  Added 6 tests in total.


BUG=53099
TEST=ProxyTunnelGetHangup, RecycleDeadSSLSocket

Review URL: http://codereview.chromium.org/3107036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles
Review URL: http://codereview.chromium.org/3146029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57294 0039d316-1c4b-4281-b951-d872f2087c98

When the user presses ctrl, prefer (keeping) inline autocomplete
matches to (new, surprising) exact matches that include the
desired TLD.

BUG=52566
TEST=none

Review URL: http://codereview.chromium.org/3152029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57293 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates wstrings from bookmark_model_unittest.cc, which entails removing
them from model_test_utils.*.

BUG=23581
TEST=builds and passes tests

Review URL: http://codereview.chromium.org/3141033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57292 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tfarina@chromium.org
BUG=fix your checkout/git setup/whatever
TEST=none

Review URL: http://codereview.chromium.org/3165058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57291 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=RegistryTest.ValueTest

Review URL: http://codereview.chromium.org/3132035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57289 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Open about:system. Table containing available system information is shown.
Clicking on button Expand shows associated entry, and clicking on Collapse hides it. Initialy all entries are hidden. 
Clicking on Expand all / Collapse all shows / hides all entries.
about:system/foo hides all entries but foo, and scrolls to it  

BUG=4973

Review URL: http://codereview.chromium.org/3173038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57288 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tfarina@chromium.org,rohitrao@chromium.org

Review URL: http://codereview.chromium.org/3111032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57284 0039d316-1c4b-4281-b951-d872f2087c98

The menu currently is Preferences, so the dialog title should be named Chromium Preferences to match with it.

BUG=53114
TEST=run chrome, click on "Preferences" menu item. See if the dialog title is "Chromium/Google Chrome Preferences".

Screenshot: http://imgur.com/vferP

Review URL: http://codereview.chromium.org/3151031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57282 0039d316-1c4b-4281-b951-d872f2087c98

Minor adjustments to bookmark folder menu button placement during button moves/adds/deletes.  In most cases it was a simple matter of not accounting for the vertical separation between buttons.  In the case of a button add I reworked the logic a bit.

BUG=51730
TEST=1) Cut or delete a bookmark button at the top, middle and bottom of a bookmark folder and verify that the button placement is correct. 2) Past a bookmark button at top, middle and bottom and verify button placement and that of the buttons above the insertion. 3) Drag move a button both upward and downward, including to the very top and the very bottom, and verify proper button placement and the placement of the buttons above the button moved as well as those buttons between the 'from' location and the 'to' location.

Review URL: http://codereview.chromium.org/3137038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57281 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppression for Chromoting leak.

http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20(valgrind)/builds/7228/steps/memory%20test:%20remoting/logs/stdio

Suppression (error hash=#FFFFFFFFE328E394#):
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   fun:_Znw*
   fun:_Z11NewCallbackIN8remoting14SessionManagerEPNS0_21ChromotingHostMessageEiEPN9Callback2IT0_T1_E4TypeEPT_MSA_FvS5_S6_E
   fun:_ZN8remoting14SessionManager8DoEncodeE13scoped_refptrINS_11CaptureDataEE
   fun:_Z16DispatchToMethodIN8remoting14SessionManagerEMS1_Fv13scoped_refptrINS0_11CaptureDataEEES4_EvPT_T0_RK6Tuple1IT1_E
   fun:_ZN14RunnableMethodIN8remoting14SessionManagerEMS1_Fv13scoped_refptrINS0_11CaptureDataEEE6Tuple1IS4_EE3RunEv
   fun:_ZN11MessageLoop7RunTaskEP4Task
   fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE
   fun:_ZN11MessageLoop6DoWorkEv
   fun:_ZN4base18MessagePumpDefault3RunEPNS_11MessagePump8DelegateE
   fun:_ZN11MessageLoop11RunInternalEv
   fun:_ZN11MessageLoop10RunHandlerEv
   fun:_ZN11MessageLoop13RunAllPendingEv
   fun:_ZN8remoting38SessionManagerTest_OneRecordCycle_Test8TestBodyEv
}

BUG=53277
TEST=Valgrind on Mac turns green.

Review URL: http://codereview.chromium.org/3115026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=TEST=none

Review URL: http://codereview.chromium.org/3200011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57279 0039d316-1c4b-4281-b951-d872f2087c98

The commit in http://codereview.chromium.org/3162038 fixes the win slave such that it fires up crash_service.exe during pyauto run; this makes it generate crash reports.

BUG=53149

Review URL: http://codereview.chromium.org/3152047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57278 0039d316-1c4b-4281-b951-d872f2087c98

We would like to test the impact of automatic retries when a TCP connection exceeds a certain threshold before it gets back an ACK. We are observing a fair number of sockets where the connection had been established, but the sockets
were not used thereafter.


r=mbelche


Review URL: http://codereview.chromium.org/3191019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57276 0039d316-1c4b-4281-b951-d872f2087c98

I introduced a 3-second threshold value between consecutive fetch-plugin requests
that induce a disk read (on the file thread) by forcing a refresh. Now, if
multiple requests are made within the threshold values, no disk read will be
performed. Average request times have been reduced from 11ms/request down to
1ms/request.

BUG=44813
r=brettw

Review URL: http://codereview.chromium.org/3192013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57275 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the key into the spdy session pool identifies the actual proxy used, and not the full list of possible proxies for the URL.

BUG=52668
TEST=SpdyNetworkTransactionTest.DirectConnectProxyReconnect
Review URL: http://codereview.chromium.org/3192011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE
TBR=nirnimesh
Review URL: http://codereview.chromium.org/660414

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57272 0039d316-1c4b-4281-b951-d872f2087c98

This fetches them from GTK using the same logic as is used in
the GTK port.

BUG=chromium-os:3916
TEST=built and ran it for GTK and Chrome OS Views

Review URL: http://codereview.chromium.org/3198013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57271 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=53140
TBR=rohitrao

Review URL: http://codereview.chromium.org/3191025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57270 0039d316-1c4b-4281-b951-d872f2087c98

I added an asynchronous API to libcros for setting the Owner's key
on Chrome OS.  This CL wires that out through LoginLibrary and also
refactors the OwnerManager class into the OwnershipService, a
Singleton that will provide access to the entire Ownership API --
which includes methods for whitelisting users and signed preferences.
The OwnerManager class is now just there to manage the Owner's
key and operations with that key.

A consumer of this API can call methods of OwnershipService, which will post tasks to run methods from OwnerManager (on the FILE thread if appropriate).  The OwnerManager will, in turn, call methods of LoginLibrary to perform owner key operations.  Since these calls to LoginLibrary are asyncrhonous, OwnerManager implements LoginLibrary::Delegate and passes |this|, so that LoginLibrary can call back to the OwnerManager when asynchronous operations are completed.

BUG=chromium-os:4488
TEST=unit tests

Review URL: http://codereview.chromium.org/3141031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57269 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
TBR=rolandsteiner

Review URL: http://codereview.chromium.org/3108045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57268 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3191022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57267 0039d316-1c4b-4281-b951-d872f2087c98

mode in all cases (now uses same code path for --keep-alive-for-test and for
background apps) - this is necessary because ExtensionsService does not
generate EXTENSION_UNLOADED notifications when the app shuts down as I thought.

With this fix, the extension API tests for background apps pass without
disabling background mode.

BUG=53021
TEST=extension API tests pass now with background mode enabled.

Review URL: http://codereview.chromium.org/3198007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57266 0039d316-1c4b-4281-b951-d872f2087c98

having some problems, and on Mac, those problems show up the most when
running this test suite.

TEST=none
BUG=53140

Review URL: http://codereview.chromium.org/3119042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52924
TEST=none
Review URL: http://codereview.chromium.org/3174026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify preference UI works properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3170042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57262 0039d316-1c4b-4281-b951-d872f2087c98

Changed mft_h264_decoder's API to match with video_decode_engine.h. Also changed the example and unittests.

Implementation of mft_h264_decoder.cc is similar to ffmpeg_video_decode_engine.cc. For now, a d3d surface output from the decoder is converted from NV12 to YV12 and stored in regular memory. So rendering with --enable-dxva is a bit
slower for now. Once we figure out how to connect with ANGLE, we won't need the conversion / transfer.

basic_renderer.* is now replaced with a simpler implementation of EventHandler inside the example code. d3d_util.* is also removed because d3d9 initialization is now moved inside the initialization of the decoder and it is the only place where it is used.

BUG=none
TEST=included in this patch

Review URL: http://codereview.chromium.org/3156046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57261 0039d316-1c4b-4281-b951-d872f2087c98

exists so it can't be enabled.

Review URL: http://codereview.chromium.org/3157038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52900
TEST=Valgrind Linux gets greener.
Review URL: http://codereview.chromium.org/3192009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57258 0039d316-1c4b-4281-b951-d872f2087c98

Revert 57254 - Share one thread between all AudioOutputControllers instead of creating one per stream.
TEST=unittests
BUG=39825

Review URL: http://codereview.chromium.org/3185022

TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/3192017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57256 0039d316-1c4b-4281-b951-d872f2087c98

Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to
avoid conflicts with messages in X11.

Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent.

BUG=none
TEST=remoting unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57112

Review URL: http://codereview.chromium.org/3161034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57255 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unittests
BUG=39825

Review URL: http://codereview.chromium.org/3185022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57254 0039d316-1c4b-4281-b951-d872f2087c98

Useful for plugins that make heavy use of background threads.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57233

Review URL: http://codereview.chromium.org/3104031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57253 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r57234

TBR: stevenjb

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57252 0039d316-1c4b-4281-b951-d872f2087c98

in http://crbug.com/49862.  That crash no longer occurs.

Fix cpplint.py nit: add a "// namespace" comment.

R=vandebo
BUG=49862
TEST=none
Review URL: http://codereview.chromium.org/3165057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57250 0039d316-1c4b-4281-b951-d872f2087c98