GitLab

BUG=139255


Review URL: https://chromiumcodereview.appspot.com/10834345

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151947 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr

BUG=141439

Review URL: https://chromiumcodereview.appspot.com/10857039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151946 0039d316-1c4b-4281-b951-d872f2087c98

This gets rid of an implicit ImageSkia -> SkBitmap conversion.

BUG=141146

Review URL: https://chromiumcodereview.appspot.com/10857019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151945 0039d316-1c4b-4281-b951-d872f2087c98

The Android NDK compilers, both on GCC 4.2 and on GCC 4.6, throw a warning about
incompatible pointer signedness in one of harfbuzz' APIs. That's where the fun
comes in: no flag is currently able to disable the warning when using Android's GCCs.
We therefore have to disable all warnings.

This is unfortunate, but we should still be getting sufficient coverage
for other warnings from Linux and Android-clang builds.

BUG=

Review URL: https://chromiumcodereview.appspot.com/10829354

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138550
Test=Manual
Run ChromeOS with --force-device-scale-factor=2
Go to a website for the first time. Favicon appears in HiDPI in tab strip on CrOS.

Review URL: https://chromiumcodereview.appspot.com/10824296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151942 0039d316-1c4b-4281-b951-d872f2087c98

The old code incorrectly assumed RenderView frame IDs
were globally unique, and used them to track main frame
reloads.

The corrected version tracks the provisional RenderViewHost
instead.

The new code also will now never send two LoadStart events
to the CaptivePortalReloader without an intervening load
committed/aborted event.

R=cbentzel@chromium.org
BUG=87100,115487
Review URL: https://chromiumcodereview.appspot.com/10837146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151941 0039d316-1c4b-4281-b951-d872f2087c98

WorkspaceManager. This will allow introducing different behavior.

BUG=137342
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827377

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151939 0039d316-1c4b-4281-b951-d872f2087c98

We haven't used libpam for ages :)


BUG=None


Review URL: https://chromiumcodereview.appspot.com/10829346

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151937 0039d316-1c4b-4281-b951-d872f2087c98

Some of the URLs can include both the scale factor and user email.
However, either/both may be missing at times. So make sure the path
and scale-factor are parsed correctly from the URL in these cases.

BUG=141146

Review URL: https://chromiumcodereview.appspot.com/10837270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151936 0039d316-1c4b-4281-b951-d872f2087c98

Revert 151364 - [sync] Auto-create credential cache for users who are already signed in and go on to upgrade Chrome

Reverted due to crashes in GetLastUpdatedTime(). See crbug.com/143214

CredentialCacheService on Windows 8 writes to the local credential cache
when a user actively signs in / reconfigures sync. Existing cached
credentials are not updated when Chrome is merely restarted after the
user is signed in.

This causes a problem when a user is already signed in, and then
upgrades (and restarts) chrome from a version that didn't originally
support credential caching. In such cases, we never end up caching
credentials, and therefore, the user will have to sign in separately to
Metro and Desktop.

This patch contains the following changes:

1) Adds logic to auto-heal already-signed-in users who upgrade from
older versions, by writing existing credentials to the local cache if
during restart, we notice that there is no local cache file, and the
user is already signed in to sync.

2) Simplifies the logic around checking if an alternate credential cache
file exists, and only then initializing |alternate_store_|. It turns out
that JsonPrefStore returns a useful PrefReadError field, and there is no
need for CCS to do funky stuff on the FILE thread.

3) Simplifies OnInitialzationCompleted, which was being used to observe
two separate JsonPrefStores. Instead of having CCS be a
PrefStore::Observer, we now use two helper classes -- LocalStoreObserver
and AlternateStoreObserver to cleanly divide what is done when each pref
store is initialized.

4) Updates prefs::kGoogleServicesUsername by listening to the notifications
NOTIFICATION_GOOGLE_SIGNED_OUT and NOTIFICATION_GOOGLE_SIGNIN_SUCCESSFUL
instead of directly listening to the pref change.

5) Fixes a stray instance where we were accessing the gaia username
pref via SyncPrefs instead of via the SigninManager.

BUG=141555
TEST=Sign in to chrome, exit the browser, and delete "Sync Credentials" from the default profile directory. Restart Chrome and make sure that the credential cache file is freshly written using existing sync credentials.

Review URL: https://chromiumcodereview.appspot.com/10830239

TBR=rsimha@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830362

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139039
TEST=Check KEY_WLAN (Fn+F11) toggles Wi-Fi on Parrot.


Review URL: https://chromiumcodereview.appspot.com/10830346

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151933 0039d316-1c4b-4281-b951-d872f2087c98

Also fixes precision error on Windows.

BUG=137794

Review URL: https://chromiumcodereview.appspot.com/10830347

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151932 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by: newt@chromium.org

BUG=136951
TBR=estade@chromium.org

(copied from http://codereview.chromium.org/10824324/ so I can dcommit for newt@)

Review URL: https://chromiumcodereview.appspot.com/10836294
Patch from Newton Allen <newt@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125748
TEST=ninja windows links


Review URL: https://chromiumcodereview.appspot.com/10366002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151930 0039d316-1c4b-4281-b951-d872f2087c98

This was a #define that was added when we were deciding
whether we should use the bytecode interpreter or FreeType's
autohinter when rendering UI text on Chrome OS.  The text
had different heights depending on which setting was used,
so a bunch of constants were special-cased when BCI was
enabled.  We've been using the autohinter for a long time,
and we'll need to update lots of newer code if we decide to
switch to BCI someday.

BUG=none
TEST=UI text looks the same as before
TBR=tony@chromium.org,davemoore@chromium.org,zork@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828336

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151928 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151927 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10830358

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151926 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142355
TEST=Unit test


Review URL: https://chromiumcodereview.appspot.com/10824309

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151925 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141572
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10823351

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141677
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10832240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151923 0039d316-1c4b-4281-b951-d872f2087c98

Since this touches API in WebKit, it takes 3 steps:
1. add a new function createMediaPlayer with url as additional argument (this patch);
2. corresponding change in WebKit;
3. remove the old createMediaPlayer (without url).

This is the second patch to allow render_view_impl to create different WebKit::WebMediaPlayer based on URL.
The new approach (https://docs.google.com/a/chromium.org/document/d/1lH9gzjUzA3L1pEPHWVOae6KpzB4IlIDOM-4lLbwGMgY/edit)
will have a new WebKit::WebMediaPlayer when URL is media stream (refer to prototype patch http://codereview.chromium.org/10382048/,
render_view_impl.cc shows how a different WebKit::WebMediaPlayer is created based on URL).

BUG=142988
Review URL: https://chromiumcodereview.appspot.com/10537091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151922 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143207

Review URL: https://chromiumcodereview.appspot.com/10854189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151920 0039d316-1c4b-4281-b951-d872f2087c98

This is essentially part of https://chromiumcodereview.appspot.com/10825012/
Landing it separately so I can run trybots for the mentioned patch.

TEST=none
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10827383

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151919 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by: newt@chromium.org

BUG=136951
TBR=estade@chromium.org

(copied from http://codereview.chromium.org/10854167/ so I can dcommit for newt@)

Review URL: https://chromiumcodereview.appspot.com/10855202
Patch from Newton Allen <newt@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141662

Review URL: https://chromiumcodereview.appspot.com/10829359

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151914 0039d316-1c4b-4281-b951-d872f2087c98

In particular it counts three things.
bucket 1: suggest requests sent
bucket 2: suggest requests invalidated (e.g., due to user typing another character)
bucket 3: suggest responses received

BUG=
TEST=using about:histograms, by hand with various typing speeds

Review URL: https://chromiumcodereview.appspot.com/10832323

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151913 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.
TBR=gene@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837285

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141826
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10854160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141439


Review URL: https://chromiumcodereview.appspot.com/10834307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127323
TEST=Click on a link in an extension's Panel and verify link opens in a tab.

Review URL: https://chromiumcodereview.appspot.com/10831299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151909 0039d316-1c4b-4281-b951-d872f2087c98

This adds the motion message filter, motion ipc messages, and related motion
files. This was originally part of a larger patch
(http://codereview.chromium.org/10698046/).


BUG=59201


Review URL: https://chromiumcodereview.appspot.com/10823310

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151908 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up to a previous patch (https://chromiumcodereview.appspot.com/10823318/).
The previous patch moved device_orientation to the content namespace. This patch removes
the now unnecessary qualifier of "content::" in several places.


BUG=none


Review URL: https://chromiumcodereview.appspot.com/10854185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151907 0039d316-1c4b-4281-b951-d872f2087c98

linux-release/sizes/chrome/chrome: http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=151900

Also contains a change to linux-release/sizes/chrome-text/text.
I think this was due to the range being placed to include possible
builds that weren't yet complete.

TBR=nsylvain@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10823367

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151905 0039d316-1c4b-4281-b951-d872f2087c98

These services make background network requests and aren't needed for
website testing.
BUG=none
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10837271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151904 0039d316-1c4b-4281-b951-d872f2087c98

This status tray (or status icons) are not used on mac or chromeos. So for now
it is sufficient to just convert from ImageSkia to SkBitmap using bitmap().

BUG=143104, 141146

Review URL: https://chromiumcodereview.appspot.com/10827371

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141146

Review URL: https://chromiumcodereview.appspot.com/10827368

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151902 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143151

Review URL: https://chromiumcodereview.appspot.com/10827381

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151901 0039d316-1c4b-4281-b951-d872f2087c98

On iOS, load ICU data from a file instead of compiling it in, to keep binary
size down for the low-memory environment.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/10829320

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151900 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151898 0039d316-1c4b-4281-b951-d872f2087c98

- r151890 - Fix a typo in the license metadata for openssl

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10831355

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151897 0039d316-1c4b-4281-b951-d872f2087c98