GitLab

Adds a optional dictionary passed to createNaClModule as a set of key value pairs to the DidCreate function.

R=sbc@chromium.org,binji@chromium.org

Review URL: https://codereview.chromium.org/11823042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176161 0039d316-1c4b-4281-b951-d872f2087c98

This fix required refactoring the code to pass key_system instead of using key_system_.
Due to the limited number of parameters supported by NewCallback, some of them must be grouped together. I chose to group the session-related values.

BUG=169193


Review URL: https://chromiumcodereview.appspot.com/11830042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176160 0039d316-1c4b-4281-b951-d872f2087c98

This was already the case on views and cocoa. However GTK was allowing a drag
after the large icon finishes loading. This CL also updates callers to
use GetTargetFilePath() on the DownloadItem instead of GetFullPath().
For a completed download, both methods are equivalent, but we prefer
the former as it is clear that the path being requested is the final
target path.

BUG=116551


Review URL: https://chromiumcodereview.appspot.com/11801022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=150046
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11825019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176157 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11826038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176156 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10918042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176155 0039d316-1c4b-4281-b951-d872f2087c98

This includes updated unit tests.

BUG=160251


Review URL: https://chromiumcodereview.appspot.com/11826028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169124
TBR=mukai@chromium.org
TEST=manually on parrot

Review URL: https://codereview.chromium.org/11786011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176153 0039d316-1c4b-4281-b951-d872f2087c98

[Telemetry] Fixing credentials login behaviour in case the user is already logged in and using --dont-override-profile.

Currently the page will timeout and fail if it's already logged in, since it doesn't see the login form.
I also added a warning when users specify --dont-override-profile, and a facebook_backend_unittest.py.

Note that this depends on https://codereview.chromium.org/11745002/ to work properly, since currently
the extra quotes around the user-agent string will cause us to be redirected to the wrong version of
accounts.google.com, so we won't correctly detect that we're logged in.

BUG=160268


Review URL: https://chromiumcodereview.appspot.com/11828048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176152 0039d316-1c4b-4281-b951-d872f2087c98

> [Android] Generate localized strings.xml files at build time.
> 
> This generates localized strings.xml files (e.g.
> values-fr/strings.xml) from grd and xtb files at build time. This
> means we no longer need to check in localized strings.xml files. Note:
> the xtb files are empty until translations are available.
> 
> Benefits:
>  - 41 fewer extraneous results when grepping Java string IDs
>  - Switching from maintaining strings in strings.xml over to using a
>    grd file is One Trivial CL* away: just include English in the list
>    of languages for which we generate strings.xml files.
> 
> *Restrictions may apply
> 
> BUG=167248
> 
> Review URL: https://codereview.chromium.org/11659006

TBR=newt@chromium.org
Review URL: https://codereview.chromium.org/11820058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176151 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jschuh@chromium.org
BUG=167187


Review URL: https://chromiumcodereview.appspot.com/11783096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176150 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima@chromium.org
BUG=169311
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11783103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176149 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash and failures in ash_unittests with the new focus controller by disabling launcher activation fallback tests.

mtomasz, your fallback code will probably stop working once the FocusController is turned on. You should be running with --use-focus-controller when making changes like this, and making sure your change works in this state.

BUG=none
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11783018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176148 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for the upcoming "the Web Page replay data for a page set can be
distributed across multiple .wpr files" feature.

R=nduca
NOTRY=true

BUG=155660

Review URL: https://chromiumcodereview.appspot.com/11829024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176146 0039d316-1c4b-4281-b951-d872f2087c98

See http://www.chromium.org/developers/design-documents/password-generation for more details.

BUG=118062


Review URL: https://chromiumcodereview.appspot.com/11829012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176145 0039d316-1c4b-4281-b951-d872f2087c98

There is suspicion that UDP closesocket could take a long time blocking the IO thread.

BUG=165382

Review URL: https://codereview.chromium.org/11833039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176144 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169084
R=nduca
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11778100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176143 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168818

Review URL: https://chromiumcodereview.appspot.com/11773037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176142 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176141 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jshin

BUG=165264

Review URL: https://codereview.chromium.org/11820055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176140 0039d316-1c4b-4281-b951-d872f2087c98

This rounds out my patch series to point image decoding benchmark at
image_decoding_benchmark.json but also get a tough_image_cases pageset
established.

NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11783086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176139 0039d316-1c4b-4281-b951-d872f2087c98

Also remove invalid ANNOTATE_LEAKING_OBJECT_PTR
annotation for an object that _does_ get deleted.

This is for now disabled on Windows because of tsan compile issues.

TBR=jar

BUG=30715

Review URL: https://codereview.chromium.org/11826062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176138 0039d316-1c4b-4281-b951-d872f2087c98

[net/dns] Add per-address-family histograms AsyncDNS.ResolveSuccess_FAMILY_* and per-qtype histograms AsyncDNS.TransactionSuccess_*.

Currently observed AsyncDNS.ResolveSuccess (duration of DnsTask) is almost twice as long as AsyncDNS.TransactionSuccess (duration of DnsTransaction). This could be attributed to dual-stack resolutions which involve two DnsTransactions, but at the same time the difference between DNS.ResolveSuccess_FAMILY_IPV4 and ..._UNSPEC (duration of ProcTask) is much less pronounced suggesting that SystemDNS resolves names on dual-stack hosts differently than AsyncDNS.

This measurement will allow us to determine how much of the observed overhead of DnsTask over DnsTransaction can be attributed to dual-stack lookups.

BUG=169257

Review URL: https://codereview.chromium.org/11783076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168984


Review URL: https://chromiumcodereview.appspot.com/11819045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176136 0039d316-1c4b-4281-b951-d872f2087c98

Checking the command line in LayerTreeSettings is dangerous, as both the
browser and the renderer will have the same command line args.  Moving this
flag first, as it causes asserts in debug for --enable-impl-side-painting.  The
other flags can be moved separately.

R=danakj@chromium.org
BUG=169173,155209


Review URL: https://chromiumcodereview.appspot.com/11829052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176135 0039d316-1c4b-4281-b951-d872f2087c98

This generates localized strings.xml files (e.g.
values-fr/strings.xml) from grd and xtb files at build time. This
means we no longer need to check in localized strings.xml files. Note:
the xtb files are empty until translations are available.

Benefits:
 - 41 fewer extraneous results when grepping Java string IDs
 - Switching from maintaining strings in strings.xml over to using a
   grd file is One Trivial CL* away: just include English in the list
   of languages for which we generate strings.xml files.

*Restrictions may apply

BUG=167248

Review URL: https://codereview.chromium.org/11659006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176134 0039d316-1c4b-4281-b951-d872f2087c98

The destructor for base::SharedMemory closes its handle on destruction.
To keep a shared memory region alive after using it, we need to
duplicate the handle. This uses dup(), which is available in native
client.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11817020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176133 0039d316-1c4b-4281-b951-d872f2087c98

This uses inspector timeline and telemetry to get an estimate of time consumption during page load.

NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11791043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176132 0039d316-1c4b-4281-b951-d872f2087c98

Fix the same incorrect use of "Message::PopString" for Connect previously
fixed for CreateDevice and CreatePairedDevice. grep doesn't show any other missing
usage to fix. See previous crrev.com/11669016 .

BUG=None


Review URL: https://chromiumcodereview.appspot.com/11734014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176131 0039d316-1c4b-4281-b951-d872f2087c98

Revert 176126 - the reverted change depends on another CL, so reverting it breaks the build. Undoing the revert.

> Revert 175648 because it causes http://crbug.com/169126.
> 
> > Connect to DesktopEnvironment's stubs only when audio/video schedulers are about to be created.
> > 
> > This CL localizes usage of DesktopEnvironment to a single method that creates audio/video schedulers and hook up the event executor. This prepares further refactoring of DesktopEnvironment that should become a factory for classes interacting with the specific desktop environment.
> > 
> > Related changes in this CL:
> >   - MouseClampingFilter receives screen size on the proper thread.
> >   - ClientSessionTest.* tests now run asynchronously to support MouseClampingFilter change.
> >   - ClientSession does not expose DesktopEnvironment.
> >   - InputEventTracker can be re-attached to a different InputStub.
> > 
> > BUG=104544
> > 
> > 
> > Review URL: https://chromiumcodereview.appspot.com/11781003
> 
> TBR=alexeypa@chromium.org
> BUG=104544,169126
> Review URL: https://codereview.chromium.org/11817048

TBR=alexeypa@google.com

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161769


Review URL: https://chromiumcodereview.appspot.com/11663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176128 0039d316-1c4b-4281-b951-d872f2087c98

TEST=
BUG=

Review URL: https://codereview.chromium.org/11778098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176127 0039d316-1c4b-4281-b951-d872f2087c98

> Connect to DesktopEnvironment's stubs only when audio/video schedulers are about to be created.
> 
> This CL localizes usage of DesktopEnvironment to a single method that creates audio/video schedulers and hook up the event executor. This prepares further refactoring of DesktopEnvironment that should become a factory for classes interacting with the specific desktop environment.
> 
> Related changes in this CL:
>   - MouseClampingFilter receives screen size on the proper thread.
>   - ClientSessionTest.* tests now run asynchronously to support MouseClampingFilter change.
>   - ClientSession does not expose DesktopEnvironment.
>   - InputEventTracker can be re-attached to a different InputStub.
> 
> BUG=104544
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11781003

TBR=alexeypa@chromium.org
BUG=104544,169126
Review URL: https://codereview.chromium.org/11817048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176126 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176125 0039d316-1c4b-4281-b951-d872f2087c98

r176100: disable c4267 for hunspell for building on win x64

TBR=jschuh@chromium.org
BUG=167187


Review URL: https://chromiumcodereview.appspot.com/11817046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176124 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176120 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
R=marja@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11821051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176119 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/11833028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176118 0039d316-1c4b-4281-b951-d872f2087c98

This is a second upload of https://codereview.chromium.org/11786010/
Review URL: https://codereview.chromium.org/11783098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176117 0039d316-1c4b-4281-b951-d872f2087c98