- 15 Jan, 2021 40 commits
-
-
Jarryd authored
This makes debugging a test and writing tests a little easier by allowing developers to run a single test at a time. * Add new chrome switch, kWebAppIntegrationTestCase * Add new method, GetCommandLineTestOverride() Bug: 1165832 Change-Id: I739c1fc85b115e77b881fcdab87db06ab01cf074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624033 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#844099}
-
Jon Mann authored
Chrome doesn't yet track the "Automatic" state for the metered property of networks. To avoid setting networks permanently to the current automatic state, this change temporarily marks all networks as auto until we can get the information from Shill. Bug: 1128692 Change-Id: I2a7295ed9cdfb106b5c3b894d0963b006046bfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631469 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#844098}
-
Alison Maher authored
Set the ForcedColors flag to 'stable' and update test expectations. This includes the launch of the 'forced-colors' media query and the 'forced-color-adjust' CSS property. Intent-to-ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/hkjRPJ1-Ruk Note: There is an open blocking bug for this feature. It is blocked on a spec issue, but this should be resolved next week, and I will make sure the resulting fix gets backported to the correct release. https://bugs.chromium.org/p/chromium/issues/detail?id=1166392 Bug: 970285,1148418 Change-Id: I7eeedf57f1dc66a6935ab153d166ea9718b27e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630827Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#844097}
-
Josh Karlin authored
FCP can be delayed due to x-site frames being render throttled. Bug: 1166207 Change-Id: I0f0eef93f4f8decb556eb079df453ae1ad21fe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627707 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844096}
-
Raphael Kubo da Costa authored
Screen Wake Locks were marked as a stable feature in r763697 ("[wakelock] Mark ScreenWakeLock feature as stable"), so it is no longer necessary to manually enable it support for them here. Change-Id: I69b0578349918bd9701788cc3c792c457f506f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633052 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844095}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/BhbSyh4bjbYmwfA5WJTXzE9uMvDFyyviZuft_yjZ8ZgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: I152d627b49e367683919a87128bf544689b175b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633381Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844094}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/628b7f61f813..5fcf0fa9382e 2021-01-14 pmoy@chromium.org chromite: expect hotlog user in hotline group on cfm devices 2021-01-14 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib99f592b202ac50ed6bf63242a1d27ddfb9e9422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633384Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844093}
-
Adithya Srinivasan authored
Bug: 1146627 Change-Id: Idb2ca2ba5a1053fd0439dbb473c797b53fb2ac18 Tbr: jdonnelly@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630366Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#844092}
-
Yi Gu authored
See linked bug for details. TBR=tvanderlippe@chromium.org Bug: 1167158 Change-Id: Ief155b70c1a8c0ecbc306b71665918416e347315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633342Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844091}
-
Aaron Leventhal authored
Also add TODOs for Nektarios on next round of fixes to this code. Bug: None Change-Id: I1ce3184ab3caed82746c6e06e0dc81c249f9f600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633341 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844090}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/xO6b6gm3QxUDRY3PGCD_ON0uPe2bjwP9ftauSv0ar3cC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/157694064,b/173979544,b/175515520,b/175517195,b/177375485,b/177381582,b/177382762,b/177388943,b/177620087 Tbr: media-app@grotations.appspotmail.com Change-Id: Iabc1617da20640879cbc7b957589075b34345376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633132Reviewed-by:
-
Regan Hsu authored
The EOL dates listed at https://support.google.com/chrome/a/answer/6220366?hl=en do not provide a timezone. However, they refer to UTC instead of a local time zone. (End of life occurs at a single point in time). Since users are NOT told that the time zone is in UTC, they will likely confuse the end of life date to be in their local timezone. If the end of life is on the first day of the month, the end of life will show as one month sooner than the actual end of life. This CL adds an extra parameter to base::TimeFormatMonthAndYear() to allow for time formatting in UTC instead of the local time. Fixed: 1126296 Change-Id: Iede26508a9a30e776225095bd6267bd2c2fe64eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399826 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#844088}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610700976-d7ed4801f0bf655f1a5ed007c5aa96678f4cba28.profdata to chrome-win64-master-1610711423-bdaee35d021c9a50df10abe9e0067f035c4386a3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie5929fa024e688cfba5623b55d1b6986a9526ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632833Reviewed-by:
-
Sam Maier authored
Change-Id: Ie743d4040a21b2f5c3bc9f92d53b738e8ee5f69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627991 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#844086}
-
David Maunder authored
Speedup: 28191ms -> 11164ms (60% speedup) Bug: 1166842 Change-Id: Ifbc1584870be6effa7a47970499d4e1a96836fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630298Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#844085}
-
rmrossi@google.com authored
This CL fixes a problem whereby ax trees created for iframes that have navigated elsewhere were not being destroyed after the render frame is destroyed. Prior to this CL, if a render frame host was reused after navigation, its ax tree id was being overwritten with a new tree id. When the render frame eventually gets destroyed, only the last ax tree id would get a DispatchTreeDestroyed event. This left the earlier tree parent-less inside the ChromeVox background script since it never received a destroyed event. If the reader was focused on an element from the previous tree, the user could still swipe navigate to those elements even though the page had navigated elsewhere. Solution is to listen for navigation changes in the automation web contents observer and destroy any old tree ids that are set on the render frame host. Added a chrome.automation test case to reproduce the issue. An iframe is first pointed to a resource with a button "First Button". A top level button will swap the 'src' attribute for another resource once clicked. The test makes sure that the role attribute of the first button becomes undefined, indicating it's tree was properly destroyed. Prior to this CL, it's role attribute was not undefined because the tree destroyed event was never sent for the old tree. Test: Added chrome.automation test case, would consistently fail prior to this CL Bug: 173650630 Change-Id: Ie9228b19c7e84db7c3c2a70566584605794a6b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572729Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844084}
-
Yi Gu authored
The test has been flaky recently: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BackgroundFetchBrowserTest.OfflineItemCollection_VerifyResourceDownloadedWhenDownloadTotalLargerThanActualSize&testType=browser_tests See the linked bug for details. TBR=rayankans@chromium.org Bug: 1161369 Change-Id: I063fa10ce855471b181ebeab4c9e4dc974c03e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633361Reviewed-by:
-
Benoit Lize authored
On Android, malloc() interposition is not perfect in some configurations. Use the GigaCage to explicitly detect these cases, and crash with an easy to understand stack trace. Bug: 1166558, 1166748 Change-Id: I651da1990671f3785e6262e9af3e8ac69586cf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632608Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844082}
-
Fredrik Söderqvist authored
The size of: |LocalFrameUkmAggregator::absolute_metric_records_|, |LocalFrameUkmAggregator::SampleToRecord::sub_metrics_durations| and |LocalFrameUkmAggregator::SampleToRecord::sub_main_frame_durations| should match the number of sub-metrics (kCount). These are Vectors that are sized in the constructor, but they could as well be statically sized arrays, which makes working with them a tad bit more efficient. Try to eliminate iteration using kCount, and use the size of the metric data instead. Also change LocalFrameUkmAggregator::AllMetricsAreZero to use TimeDelta::is_zero(). Change-Id: Ia423e022de80328cc8f1847086f6988bf73203f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270207Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#844081}
-
Kevin McNee authored
Currently, the PDF viewer extension tries to navigate itself using |window.location.href| when navigating the tab via the chrome.tabs API is not available. This fallback behaviour is incorrect as it would navigate the guest contents instead of the tab. We remove this fallback behaviour from the PDF viewer. Bug: 1158381 Change-Id: I5295a60c0e3d05e7058be81b39c0716c9f6e8d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618602Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#844080}
-
Caitlin Fischer authored
Several of the tests depended on 'src' being a directory in the path to expand_owners_unittest.py. However, on testing bots, this may not be the case. Note that _ExtractComponentViaDirmd() had to be mocked in several tests due to http://crbug.com/1164985. One test was skipped due to this. Also, removed testGetHigherLevelPathGivenPathInSrcDirectory since it assumed 'src' would be in the path. It's okay to remove this because we have a test checking that getting higher-level OWNERS file paths doesn't result in a recursive loop. Bug: 1126653 Change-Id: I5b6d4289dff3b5c9afe0fcc8249328d9059cedc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622320 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#844079}
-
Khushal authored
R=boliu@chromium.org, sunnyps@chromium.org, vasilyt@chromium.org TBR=pdr@chromium.org, sadrul@chromium.org Change-Id: I39d8c27a3e45528f5b4422ffd97112bfe9b3304a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629790 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844078}
-
Sreeja Kamishetty authored
This CL removes the following legacy code: 1) TestWebContents::TestDidNavigate 2) TestWebContents::TestDidNavigateWithSequenceNumber which are used in unittests to directly call the main implementation. We modify the unittests which use TestWebContents::TestDidNavigate to use TestRenderFrameHost::SendNavigateWithTransition to perform the same actions. Bug: 1163106 Change-Id: Ifd6360c310c8eef537a7628a76c5fd972588786b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606003 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/05149e977239..6d70b13800e9 2021-01-15 andoli@chromium.org [module.json extensions] Add unit tests for new action extensions registration infrastructure 2021-01-15 szuend@chromium.org Disable flaky linear memory inspector e2e test 2021-01-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-15 sigurds@chromium.org Fix height of icon component 2021-01-15 szuend@chromium.org Reland "[module.json extensions] Migrate @ViewLocationResolver in elements/" 2021-01-15 janscheffler@chromium.org [JSDOC2TS]: Migrate js_profiler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126031,chromium:1134103,chromium:1153091,chromium:1158760,chromium:1166106 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I03cc780ad16fbac3b511a1115f663c3053056ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633131Reviewed-by:
-
Evan Shrubsole authored
These metrics measure how our algorithm for opening video devices on Mac work with devices in the wild by seeing what happens on the first frame after opening the camera. We compare what we asked the webcam to do with what we actually get. We also will see how often we receive IOSurfaces in the Mac capture pipeline. correct values for histograms. Bug: 1156144 Test: Ran locally with appr.tc with 2 different cameras to confirm Change-Id: I58eb1414d9def98cf4cf2b90e15c69d29bdc0148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621817Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844075}
-
Caitlin Fischer authored
The Windows study has ended. The Mac study is only on old versions. Bug: 1126640 Change-Id: I80d2f2c98b976277a8d92f558ef9843cabd63580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631431Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844074}
-
Caitlin Fischer authored
The server-side config indicates that this has launched. Bug: 1126640 Change-Id: I6483cfaac73374e5bba1c34101f0452f266a5bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632125Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844073}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94ca9a9578a7..2d79f95e908d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I07cd78e186c6f58e94a560ded554531e34ab846a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633066Reviewed-by:
-
Natalie Chouinard authored
This task is now tracked in: https://crbug.com/1166810 Bug: 1166810 Change-Id: Ifc3b353511e8fa958bf1b7fcc7b32cb384597fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630446Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#844071}
-
Sky Malice authored
This reverts commit ddad167d. Reason for revert: Failing many XR/VR tests during activity initialization. See https://ci.chromium.org/ui/p/chromium/builders/ci/Nougat%20Phone%20Tester/16101/overview Original change's description: > Reland "Create glue-layer TabModelOrchestrators" > > This is a reland of 314cbf4c > > Patchset 1 is the original change. > > The main difference is that now the TabPersistentStore is created > with the actual index that TabWindowManagerImpl assigned to the > TabModelSelector, rather than the index that was "requested". > > Other changes are to adapt tests. > > Original change's description: > > Create glue-layer TabModelOrchestrators > > > > TabModelSelectorImpl does not create or destroy TabPersistentStore > > anymore. Instead, TabModelOrchestrators manage the lifetime of TabModelSelectorImpl and > > TabPersistentStore. > > > > Give TabModelSelectorImpl a Supplier<TabPersistentStore> instead of > > passing TabPersistentStore directly. > > > > This is a step to break the two-way dependency between > > TabModelSelectorImpl and TabPersistentStore. > > > > Bug: 1138561 > > Change-Id: Ie2fa4a2735e509ff816b3e2cf5f8f6fffda7999c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572639 > > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Ella Ge <eirage@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#835819} > > Bug: 1138561,1158259 > Change-Id: Iac6eaaed149e853536813cd627d28236638657de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590427 > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843752} TBR=dtrainor@chromium.org,eirage@chromium.org,hnakashima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id6440841c48bffa2dc0f33b89bcddb36ea2f0c3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138561 Bug: 1158259 Bug: 1167010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632386Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#844070}
-
Roman Aleksandrov authored
Mistakenly used 100% to make content div allocate all free width space in the portrait mode which is the width of dialog - 2 paddings. Bug: 1151292 Change-Id: I3374815190d928d4a3b32b3df9d022cc7fef1f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628952Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#844069}
-
arthursonzogni authored
In https://crbug.com/1153961, the RenderProcessHostObserver is crashing when iterating over its list of observers. This patches modify the observers to get new information: 1. RenderProcessHostObserver becomes a checked observer. This CHECK when iterating over a freed observer happens. 2. Similar to: https://chromium-review.googlesource.com/c/chromium/src/+/2615346 Check in observer destructor's they have removed themself from the observer list. 3. Update all the observer's crashing because of (2). BUG=1153961 Change-Id: Ic375878225c853f02bf19e82f70ac1d3b9a3455f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620566 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#844068}
-
Monica Basta authored
As requested by UX, the profile card should have a transparent background with a border. The color switched on focus or hover. This CL also reduces the gap on the profiles grid to be 16px in total. Screenshots: https://drive.google.com/file/d/1kRnl-yEAKTbuT5Jei5U5h0468BYODUpi/view?usp=sharing&resourcekey=0-xjmIvYdm0vqr64uNCT8Y2Q https://drive.google.com/file/d/1uMuHJ_RguX0cM54UFMsUztVo6gRMWFiv/view?usp=sharing&resourcekey=0-ZXmsutBgDbe5DN9pfCGLYw Fixed: 1167101 Change-Id: I0114a80efbcd545d19e34006ea85b3800b131fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632746 Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#844067}
-
Maksim Moskvitin authored
Check of kFollowTrustedVaultKeyRotation was accidentally removed. It currently doesn't lead to accidental enabling of the feature, because the feature requires specific command-line setup, but seems dangerous. Bug: 1113598 Change-Id: I298b73f2e6569232693134e8f0e0812d1121498e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627154 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844066}
-
Rune Lillesveen authored
Ignore default namespace when parsing ::cue() parameter as a type selector. Bug: 1166850 Change-Id: I4fde0fe1f36e15dbd8390ea0ace218739ed1ec7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631485Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#844065}
-
Nicolás Peña Moreno authored
Change-Id: Ifa4b0b3ac81b8166f8a29ce4e67e03ff7c0cb963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625921Reviewed-by:
Andrew Comminos <acomminos@fb.com> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#844064}
-
Marc Treib authored
...and also update its description, which was very generic and borderline plain wrong. Bug: 1165187 Change-Id: Ifed4b78e8c43663d9e6ef650ddf9128c04b2f29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628951 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#844063}
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: I34168973c296427d8b48c25d3559bbe67e7989c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629709 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#844062}
-
Anatoliy Potapchuk authored
This reverts commit af98eac8. Reason for revert: SecurityOriginTest.CustomScheme fails on debug builds after this cl. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/22213 Original change's description: > Rewrite SecurityOrigin::IsSecure() using GURL and url::Origin > > SecurityOrigin::IsSecure() is very similar to the concept of > "potentially trustworthy URL" defined in [1] and implemented by > network::IsUrlPotentiallyTrustworthy(), but it has historically been > hard to compare them. After previous refactoring they are quite close. > > This CL is yet another iteration. SecurityOrigin::IsSecure() is > rewritten to use a similar implementation based on GURL and url::Origin. > Spec comments are also added to make the difference more obvious. > > IsSecure() currently returns true if the URL scheme is in the secure > list [2] or possibly one wrapped in a blob: or filesystem:. The > constructor of url::Origin automatically unwraps this kind of URLs > but is also more restrictive about accepted schemes [3]. In particular, > about: and data: URLs or URLs with schemes registered as "secure" > but not "standard" will now generate invalid origins. > > Special cases from network::IsUrlPotentiallyTrustworthy() are added to > preserve behavior with about: and data: schemes, although some weird > edge cases like "about:about" or "blob:about" are no longer treated as > secure. Behavior for all standard secure schemes (including https, wss, > quic-transport) are preserved. All these changes makes IsSecure() > closer to the spec definition of "potentially trustworthy URL". > > The rest of the IsSecure() handles opaque and allowedlist origins, which > is again just a subset of the work done by > network::IsUrlPotentiallyTrustworthy() and can be rewritten accordingly. > > [1] https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy > [2] https://source.chromium.org/chromium/chromium/src/+/master:url/url_util.cc;l=63;drc=65a062c4528790ff3651920ba9a3934df184e1bc > [3] https://source.chromium.org/chromium/chromium/src/+/master:url/origin.cc;l=47;drc=721926d0cf09b42968ec8481792fcd6fa4edab7b > > Bug: 1153336 > Change-Id: I8f4a42f89a9ae13016a20a1e242c1efd48874162 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617709 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Frédéric Wang <fwang@igalia.com> > Cr-Commit-Position: refs/heads/master@{#844034} TBR=fwang@igalia.com,mkwst@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I720d669fd57861565991b5ad32b654f96f1281c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633048Reviewed-by:
-
Yuta Hijikata authored
This is a mechanical change replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) to ensure switching lacros' target_os from linux to chromeos does not affect the lacros binary. More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I96c231186a89d259a6fd339ebf72a144ff98b6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628634Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#844060}
-
