- 02 Nov, 2018 40 commits
-
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: If5ea187530df1f3de0e5f5f9c4b2e3be0e10b397 Reviewed-on: https://chromium-review.googlesource.com/c/1312139Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#604888}
-
Richard Knoll authored
Bug: 710925 Change-Id: I357c105c1aa40b0acca41edde0423141fb6f62c0 Reviewed-on: https://chromium-review.googlesource.com/c/1304793 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604887}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2dc1e34f9029..13853a120d5a git log 2dc1e34f9029..13853a120d5a --date=short --no-merges --format='%ad %ae %s' 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 502d2e215556..caeb1e895d7b (2 commits) Created with: gclient setdep -r src/third_party/skia@13853a120d5a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ibd23af2b5576dbfcae39ea639628513b9f9c74f1 Reviewed-on: https://chromium-review.googlesource.com/c/1314098Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604886}
-
Richard Knoll authored
This allows us to only init channel groups once, instead of multiple times, when initializing channels. Bug: 710925 Change-Id: Icb00711eb9a5c204699b73084daa3791f96740da Reviewed-on: https://chromium-review.googlesource.com/c/1304515Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604885}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee5c29c3f1a2..1294edc1cf83 Created with: gclient setdep -r src-internal@1294edc1cf83 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I180592e06f253ca8d7b85c1b7d6277689325d923 Reviewed-on: https://chromium-review.googlesource.com/c/1314097Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604884}
-
Morten Stenshorne authored
Without this fix, 3 tests would fail with https://chromium-review.googlesource.com/c/chromium/src/+/1297367 : external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-paint-clip-004.html fast/overflow/image-selection-highlight.html scrollbars/overflow-scrollbar-combinations.html Change-Id: Iabd95ead6c96cd50f25e654dda6a7f041ac77af0 Reviewed-on: https://chromium-review.googlesource.com/c/1311926Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604883}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit which also means that they share the same anonymous namespace. That means that constant names need to be unique in the whole build target even if they are in anonymous namespaces. A service worker extension just introduced a second kPrefsName into extensions/browser which broke some (but not all) jumbo build configurations. This patch renames them both to prevent confusion (from compiler or human). TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org Bug: 889687 Change-Id: I6d3d44d9941038cc8e2304bc3100c7e681ea18a9 Reviewed-on: https://chromium-review.googlesource.com/c/1314468Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#604882}
-
Mikel Astiz authored
This is generally speaking a good proxy for understanding server-side load, and one we want to keep an eye on for ongoing and near-future experiments, to avoid server-side capacity issues during rollout. Bug: 882489 Change-Id: If775026486de0ab00cfa52ee86170b4251a2ee12 Reviewed-on: https://chromium-review.googlesource.com/c/1307436Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604881}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b47ce539. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 24c885e6 "[css-properties-values-api] Invalidate paint worklet on registration." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If91c4358e70164375254477477ac51fdd2bbef63 Reviewed-on: https://chromium-review.googlesource.com/c/1314143 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604880}
-
Xianzhu Wang authored
The accepted differences are all about composited layer trees, some with raster invalidations. Each of these tests already passes the pixel/reference test if the pixel/reference expectation exists. About accepted differences of layer trees: - Lacking of SPv1-specific layers, e.g. - the root LayoutView layer - auxiliary layers, e.g. ScrollingLayer, Squashing Containment Layer, Ancestor Clip Layer, etc. - Different layer names, caused by different methods of naming layers - Removed "flattenInheritedTransform": false on some composited layers in a transform state under the LayoutView state. This seems not to cause any rendering difference. - More accurate background color. - Different layer position and transform but the combination is unchanged. - Added scroll bar layers of the root view (which was not shown in SPv1). About raster invalidations: - Equivalent raster invalidation with different client name, reason, etc. Change-Id: I98a0cf763e524625ab2bb59d29396916a38571d2 Reviewed-on: https://chromium-review.googlesource.com/c/1308903 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604879}
-
Matthew Denton authored
Preventing autofill_phone_number_i18n_fuzzer from crashing on startup due to the malformed dictionary. BUG=900809 Change-Id: I0f62807cd08875e5ff29c231e71bb02b4044dffc Reviewed-on: https://chromium-review.googlesource.com/c/1313875Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604878}
-
Jordan Demeulenaere authored
Screenshot: https://screenshot.googleplex.com/NiKQarAYkNP.png Change-Id: I98cad8d3d4a0e439f5442a7a7099543a30fb43b5 Reviewed-on: https://chromium-review.googlesource.com/c/1311925 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#604877}
-
Yuta Kitamura authored
This CL replaces the occurrences of "Platform::Current() ->CurrentThread()->Scheduler()" with "ThreadScheduler::Current()" which has the same meaning. Bug: 826203 Change-Id: I53ef4f8682620b217d8cb6158a3a3106ae75eb06 Reviewed-on: https://chromium-review.googlesource.com/c/1314080Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#604876}
-
Keishi Hattori authored
Weak HashTable's backing slots went unregistered, when it gains a backing after it has been traced. We need to register the backing slot from HashTable::Trace even when there is no backing yet. Bug: 864425 Change-Id: I09a0f6031e457242a4374429dde5360777bebc21 Reviewed-on: https://chromium-review.googlesource.com/c/1312189Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604875}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e057780671f2..ee5c29c3f1a2 Created with: gclient setdep -r src-internal@ee5c29c3f1a2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5ae093c6c65a9f826e6a3e3a80ee5f5cddcad2f5 Reviewed-on: https://chromium-review.googlesource.com/c/1314096Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604874}
-
Donna Wu authored
Record the requested devices in WebUsbServiceImpl and notify the device implementation to close the connection with Blink when the permission is revoked from settings UI. Bug: 699790 Change-Id: I51bc658f3f764f5c20f278213048ebd7d8de70c0 Reviewed-on: https://chromium-review.googlesource.com/c/1270483Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#604873}
-
Yoshifumi Inoue authored
This patch changes |Element#innerText| not to emit Tab/Newline for <td>, <br>, <tr> itself to follow the spec change[1] for improving interop. Example: - <br>.innerText -> "" (was "\n") - <td>abc</td>.innerText -> "abc" (was "abc\t") - <tr><td>abc</td></tr>.innerText -> "abc" (was "abc\n") [1] https://github.com/whatwg/html/pull/4132 Make innerText getter not run the algorithm on the element itself Bug: 897373 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4266ee28df9b44e9044dfa60c2d54257a5f82eeb Reviewed-on: https://chromium-review.googlesource.com/c/1312436Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604872}
-
Raphael Kubo da Costa authored
The latest test in the file can fail at times. TBR=tkent, hayato Bug: 901271 Change-Id: Ifac53877b1a2da53464e12ce1222d6b15220b9a7 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1313930Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#604871}
-
Asami Doi authored
handle an error when fetch a script. In previous, Dedicated Workers and Service Workers share WorkerModuleTreeClient but an error handling is different. So, added the new class ServiceWorkerModuleTreeClient to reject promise for Service Workers if an error happens when fetch a script. Bug: 824647 Change-Id: Iade530d9d046d27704bf7e0c7a9a542b1c1a9ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1304274 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604870}
-
Hiroki Nakagawa authored
This is necessary for making ThreadableLoaderClient GC-managed and fixing memory management issues around resource loading (see the issue for details). Bug: 900508 Change-Id: Ifd83b03fb80edd7cfd16034a80f3f08f122e9e88 Reviewed-on: https://chromium-review.googlesource.com/c/1314014Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604869}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e1abea653b28..2dc1e34f9029 git log e1abea653b28..2dc1e34f9029 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@2dc1e34f9029 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ib46aea474f847aa9149c080980777df4d27defc4 Reviewed-on: https://chromium-review.googlesource.com/c/1314093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604868}
-
Yutaka Hirano authored
As CORS is enforced, there is no need to use AccessControlStatus. Bug: 875153 Change-Id: I2fb14abf9bd23e3b6d4743c6e1fef4c4d30a34b1 Reviewed-on: https://chromium-review.googlesource.com/c/1304278 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604867}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da627bb2e1dc..e057780671f2 Created with: gclient setdep -r src-internal@e057780671f2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id8130828a365fb90b1d9c10d4d49759b78fac6a8 Reviewed-on: https://chromium-review.googlesource.com/c/1314094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604866}
-
weigua authored
Bug: 900873 Change-Id: I684ac77608c8274cc8e221300b310f37bc41e9cf Reviewed-on: https://chromium-review.googlesource.com/c/1312149 Commit-Queue: Wei Guan <weigua@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604865}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib3dfa6423735abcbcf4dae62c70702231732c5fb Reviewed-on: https://chromium-review.googlesource.com/c/1314095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604864}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c0b6c639b109..caeb1e895d7b git log c0b6c639b109..caeb1e895d7b --date=short --no-merges --format='%ad %ae %s' 2018-11-02 jmadill@chromium.org Vulkan: Allow unlimited simultaneous descriptor sets. Created with: gclient setdep -r src/third_party/angle@caeb1e895d7b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I488a54ffafca65ba16fa9917c3c6d1b971c45e94 Reviewed-on: https://chromium-review.googlesource.com/c/1314092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604863}
-
Dominic Farolino authored
This CL changes the default classic script fetch options credentials mode from "omit" to "same-origin", as per the recent spec change [1], and adds descendant worker credentials tests as a follow-up to said spec change and [2]. [1]: https://github.com/whatwg/html/pull/3656 [2]: https://github.com/web-platform-tests/wpt/issues/13426 R=domenic@chromium.org, kouhei@chromium.org, nhiroki@chromium.org Bug: 849101 Change-Id: I958f552f0ee91beb8aab98269f79a1eb219fb40a Reviewed-on: https://chromium-review.googlesource.com/c/1301964 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604862}
-
Yoshifumi Inoue authored
This patch introduces |LayoutNGTextFragment| to make layout text objects in NG layout tree to have |NGInlineItem| for utilizing it in Element#innerText to handle |Text| nodes with ::first-letter. Before this patch |Text| node applied ::first-letter is represented with two |LayoutTextFragment| objects for first-letter part and remaining part. After this patch, they are represented to |LayoutNGTextFragment| with |NGInlineItem|. [1] http://crrev.com/c/1309562 Make Element#innterText to utilize NGInlineItem instead of NGPaintFragment Bug: 873957 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4cd6b43fdc4caf0d92b1030cfbb75f37d4fe67b8 Reviewed-on: https://chromium-review.googlesource.com/c/1309391Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604861}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 86a99a1c. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 24c885e6 "[css-properties-values-api] Invalidate paint worklet on registration." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I8029188a5087781c419c842d8c04590279294abd Reviewed-on: https://chromium-review.googlesource.com/c/1314138 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604860}
-
Hirokazu Honda authored
VaapiDmabufVideoFrameMapper does format conversion to I420. This is not good from design perspective as VFMapper should map a buffer as it is. This eliminates the format conversion from VaapiDmabufVFMapper. BUG=chromium:856562 TEST=VDA unittest --test_import --frame_validator Change-Id: Ic5e12e7875a9bb91ca2e21fc50c2de3a1d913199 Reviewed-on: https://chromium-review.googlesource.com/c/1312440Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604859}
-
Yuke Liao authored
This CL hooks the Clang code coverage wrapper into the build toolchains, and specifically, a new build flag: coverage_instrumentation_input_file is added to allow turning on/off the wrapper and pass the list-files-to-instrument around. Bug: 898695 Change-Id: I405ccbfc1796afa44534794d711f2953fac78f6d Reviewed-on: https://chromium-review.googlesource.com/c/1309999 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#604858}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. event_target_names.json5 contains items like: { name: "core/frame/Window", ImplementedAs: "DOMWindow", }, This CL updates _symbol() in make_names.py so that it produces 'kWindow' for it. _legacy_symbol() produces 'DOMWindow', however we don't need to use C++ implementation class name here. This CL has no behavior changes. Bug: 889726 Change-Id: I02a796015ba7ca63d9331f16f4f715445c44ed55 Reviewed-on: https://chromium-review.googlesource.com/c/1314008Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#604857}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/26fcd7166c74..e1abea653b28 git log 26fcd7166c74..e1abea653b28 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@e1abea653b28 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ife30f0d9e318088f12dfa684648654406207c217 Reviewed-on: https://chromium-review.googlesource.com/c/1314091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604856}
-
Erik Luo authored
Introduces a common interface between ElementsTreeOutlines and ObjectPropertiesSections. This allows both to be keyboard navigable in Console. Bug: 865674 Change-Id: I405d161692147374827918cce2369d129620a9fd Reviewed-on: https://chromium-review.googlesource.com/c/1275225 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#604855}
-
Giovanni Ortuño Urquidi authored
Patch to remove the no longer used TrayBluetooth code. Bug: 898419 Change-Id: I3f2393dc562a91b42345d107f6faf3292124d232 Reviewed-on: https://chromium-review.googlesource.com/c/1312137Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#604854}
-
Ken Rockot authored
Adds a new test support library with a single helper class, FakeNavigableContentsFactory. This allows unit test code to fake out a basic Content Service implementation to help drive Content Service client code under test. Bug: 854367 Change-Id: I3e81aa7b6540aa35347e6c3311c0f816cb945a01 Reviewed-on: https://chromium-review.googlesource.com/c/1277960 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604853}
-
Anand K. Mistry authored
Metadata requests in the chrome.fileSystemProvider API declare what metadata fields they are requesting (i.e. size, modifiction time, etc). Fields that are provided but not requested will be logged as warnings. BUG=721790 Change-Id: Ia2c1c1b39f72048be654069557cfc951c5cfc325 Reviewed-on: https://chromium-review.googlesource.com/c/1313989Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#604852}
-
Kouhei Ueno authored
Bug: 711706 Change-Id: I46271b96329d45d4b2ad6ad0988490dcad98943e Reviewed-on: https://chromium-review.googlesource.com/c/1314013 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604851}
-
BUG=762641 TBR=oshima@chromium.org Change-Id: I512f29e5f8d9bba022890b401ef8e938683baa1a Reviewed-on: https://chromium-review.googlesource.com/c/1314132 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604850}
-
Asami Doi authored
changed. Some tests in update-registration-with-type.https.html fail because a new worker is not created when a script type is changed and a script content is identical. This CL makes |skip_script_comparison_| true when a script type is same. Also, I replaced has_installed_version() newest_installed_version(). Bug: 824647 Change-Id: I755e3d031b97d6659a7a35a1f93f9acfc654368c Reviewed-on: https://chromium-review.googlesource.com/c/1312828 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604849}
-