- 06 Aug, 2020 40 commits
-
-
Ioana Pandele authored
This CL adds - the ability to start/stop the check - check status update - compromised credentials change message to the UI - saved passwords fetched call for the UI (this is used by safety check) The list of compromised credentials as well as check progress updates will be added in the next CLs. Bug: 1102025, 1092444 Change-Id: I3ad9af201d2158f956479a76b9ca8c184a05d397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333845 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#795413}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7f6b8b6f018..3a560b36ad16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fernandex@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fernandex@google.com Change-Id: I415a16c1742858293cd4dccebb7a02d1f04c8e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340574Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795412}
-
Xida Chen authored
This reverts commit d6905eb4. Reason for revert： Per offline discussion with sadrul@ and flackr@, will limit this change to universal tracker. Original change's description: > Change to report the throughput metrics every 1 seconds > > After compared with interval of reporting the throughput metrics every > 1 second and 5 seconds, we found out that 1 second is closer to the real > data, so we decide to change to the interval to 1 second. > > Bug: 1040634 > Change-Id: I94527a45ffe390fc6d44a2430f52dcb2346d6cbe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332978 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795132} TBR=flackr@chromium.org,lanwei@chromium.org,xidachen@chromium.org Change-Id: Ic6ed30890891a59b02fff03cf9d80189a8b14a59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340983Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795411}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4f52dde7..351fdfe7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8cb6b17de69c96b44145019992c01073d2b55966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340982Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795410}
-
Mohamed Amir Yosef authored
This CL checks body_container_ for nullness. body_container_ could be null if there are only footer items. Bug: 1113255,1108181 Change-Id: I9ed145c1d18baf8b13deab8c44cc510b3bb781eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339479 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#795409}
-
Robbie Gibson authored
Before, this happened by default. However, this was confusing, so now there are two separate flags, so zoom can be enabled without changing the default zoom level. Bug: 1113270 Change-Id: I34e340c585c5ccccdfd278d96c21a53510b6a234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339482 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795408}
-
Hiroki Nakagawa authored
Bug: 1086227 Change-Id: I7021ac08ce08e6ce1ddae766a362c76b8c296851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339496 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#795407}
-
Ricky Liang authored
There are some devices with camera sensors of non-zero physical orientation. For these devices, we still have to rotate the camera frames to compensate for the sensor orientation if we disable pre-rotation in the video capture stack. Otherwise, the video recorded in the camera app will have wrong orientation because we don't rotate the frames at all on the video stack. Bug: 990682 Test: Manually on Nocturne Change-Id: Iba471e318f6d15770491b5677769e5d6c5d1c241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335849 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#795406}
-
Anders Hartvoll Ruud authored
In CSSPropertyValue/CSSPropertyValueMetadata, we're (for custom properties) storing a pointer to the static Variable instance, and transporting the real name of the custom property in the value part of the CSSPropertyValue. These are both concepts that I want to remove (see bugs for details), and this CL is a step towards doing that. The two most important changes here are: - In css_parser_impl.cc, notice that the call to GetCSSPropertyVariable() has been removed, and we pass the actual name instead. - In css_property_value_set.cc, notice that the function CSSPropertyValueSet::PropertyReference::Name() no longer digs out the name from the value for custom properties, but accesses the "natively" stored name in the metadata (see header file). All other changes in this CL should be relatively uninteresting: they're just adjustments that follow from now taking a CSSPropertyName in the CSSPropertyValue constructor. The sizeof(CSSPropertyValueMetadata) should not increase, since the CSSPropertyName is stored "unpacked" such that the property ID can be stored as a bitfield. Bug: 980160, 1112291 Change-Id: I3dd1e0edac5d07d6a2a8c4a8057b95954a131711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339419Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#795405}
-
Hiroshige Hayashizaki authored
To unify WorkerOrWorkletScriptController entry point, this CL - Renames WorkerOrWorkletScriptController::Evaluate() to EvaluateAndReturnValue(), - Makes it (and EvaluateInternal()) return v8::Local<v8::Value>, - Moves ScriptState::Scope to callers of EvaluateAndReturnValue(), and - Merges EvaluateAndReturnValueForTest() to EvaluateAndReturnValue(). This CL doesn't change the non-test behavior. This CL changes EvaluateAndReturnValue() behavior in tests: Previously, for EvaluateAndReturnValueForTest(ScriptSourceCode("someJavaScriptValue")), when `someJavaScriptValue` is evaluated to `undefined`, EvaluateAndReturnValueForTest() returned an empty ScriptValue(). After this CL, EvaluateAndReturnValue() returns a v8::Local<v8::Value> representing `undefined`, not an empty v8::Local<v8::Value>. However, this doesn't affect observable test behavior (`undefined` is not expected anyway in existing tests). Bug: 1111134 Change-Id: If4a319d1fce2a69a4f39d7ab611ebc6ea0d9f957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331999 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#795404}
-
Alex Rudenko authored
With the new StyleEngine API for getting cascaded CSS values[1], previously introduced InspectorCSSCascade is not needed anymore. This CL renames it to InspectorStyleResolver and its responsibility is to resolve styles for elements as required by the InspectorCSSAgent. The new StyleEngine API is used by InspectorHighlight directly because it's independent from the logic required for InspectorCSSAgent. [1]: https://crrev.com/c/2324423 Bug: 1108356 Change-Id: Ib14e09a41f35356bac7a84045c71579debd31134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340043Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/695e1de8318d..b60e067b4374 2020-08-06 john@johnkgo.com SPV: Fix #1829: don't emit OpModuleProcessed use-storage-buffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Icd46a0cc55a910b36439ae5bb3e0b0299d34e4f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340930Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795402}
-
Ana-Cosmina Popescu authored
Bug: 1095605 Change-Id: Ic09d3f0fcc098ab1b19b9a09eba33a7de0e10ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332579 Commit-Queue: Ana-Cosmina Popescu <anacosmina@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#795401}
-
Alice Wang authored
This CL adds an access point to AccountPickerCoordinator so that we can separate the where the account picker is initiated in order to set it up in different ways. We also removed the |Go incognito mode| row in the account picker dialog used in Settings > |Turn on Sync?|. Bug: 1093795 Change-Id: Ie2823b296a4d6574560811b60e4059ddb52dd889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303390Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795400}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1Sj_NH5SekuGy-XEQa-rAcbJua-CEyC5x/view?usp=sharing Bug: 1063856 Change-Id: I2e553c6891a3ca3e7bf74db17bcca671c8fe8353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339420 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#795399}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1Dzm0pf53Dt8vpupSamZnmApXmWRAPhoY/view?usp=sharing https://drive.google.com/file/d/13uoDJZewRqDM5PE9cUoWtFXUFy1E1mIY/view?usp=sharing Bug: 1063856 Change-Id: I2cbaa99ac61ea87ce1caa7a58952b7437f388769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339486Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib94f4ea3ef1372a613beeee1983789a8e3075612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340850Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795397}
-
Eric Seckler authored
This is a reland of 50136be2 Disabling the test on non-Android. We only care about this on Android at the moment. linux-trusty-rel also seems to fail on sched_setaffinity, likely a limitation of the host. Original change's description: > Reland "base: Add API to restrict thread affinity to little cores on Android" > > This is a reland of 027aa92e > > Relanding but disabling test on CrOS devices (some of our CrOS devices > seem to have asymmetric CPUs that aren't covered by the test). > > Original change's description: > > base: Add API to restrict thread affinity to little cores on Android > > > > Adds functions that facilitate setting the CPU affinity of a given > > thread or process to all little cores on the system. > > > > We intend to use this API to run a power experiment. > > > > Bug: 1111789 > > Change-Id: I6c3d32c2338e9f00464e8b6a8c96af93658a3ae2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335176 > > Commit-Queue: Eric Seckler <eseckler@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794998} > > TBR: dcheng@chromium.org > Bug: 1111789 > Change-Id: I59315ec0e9a1727986278a04fa5bde409143dfb5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339416 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795126} TBR: dcheng@chromium.org Bug: 1111789 Change-Id: I0c9770f2e0c7d5b8caba9432e55c5f3ebe198322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339342Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#795396}
-
Anders Hartvoll Ruud authored
In order to update a CSSAnimation when an associated @scroll-timeline changes, we'll need to be able to detect whether or not scroll offsets changed. This CL prepares for that. Bug: 1074052 Change-Id: I6059062499e4d7893db413908083d41fae5ac2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332598 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795395}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dbbc1ffe9924..d3b495fd53af 2020-08-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id69a8e9dc885dc0af55f45ff5fb979a1cc48fc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340928Reviewed-by:
-
Jose Dapena Paz authored
Build with libstdc++ fails: ../../base/cpu.h:93:15: error: ‘vector’ in namespace ‘std’ does not name a template type 93 | static std::vector<CoreType> GuessCoreTypes(); Bug: 957519 Change-Id: I83808e1714146c6fa1dbefea205620c600b32e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339339Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#795393}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8bc27a1cfbc1..5fd92a7e0c84 2020-08-05 jaebaek@google.com OpenCL.DebugInfo.100 DebugTypeArray with variable size (#3549) 2020-08-05 andreperezmaselco.developer@gmail.com spirv-opt: Improve the code of the Instruction class (#3610) 2020-08-05 vasniktel@gmail.com spirv-fuzz: Handle OpPhis in livesafe functions (#3642) 2020-08-05 vasniktel@gmail.com spirv-fuzz: Handle OpPhi during constant obfuscation (#3640) 2020-08-05 vasniktel@gmail.com spirv-fuzz: Fix FuzzerPassCopyObjects (#3638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I68882922b1ce41aa0ad6b3ae2d1cd3437e3c9cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340575Reviewed-by:
-
Yuke Liao authored
Win PGO trunk builders are having issues and result in uploading broken profiles. The auto rollers have been stopped and this CL reverts their profiles to last known good versions. Bug: 1113316 Change-Id: I51c3d4533a0f0845a302d9f71c8a18df33775fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340114 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#795391}
-
Maxim Kolosovskiy authored
Bug: 1086114, 1092444 Change-Id: I2906d756d0090734b23a711da27f497ec7296937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336595 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Lukasz Suder <lsuder@chromium.org> Reviewed-by:
-
Benoit Lize authored
Bug: 1112840 Change-Id: Ie903e92ac8d393c6cf1c0123656c4270cc9df113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339476 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1362c1eac458..7a171cca0ca4 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6c873cfde957 to bedac4f06b5c (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1104516 Tbr: herb@google.com Test: Test: Test: CQ Change-Id: I11a7da040639041e1f7826d8f8847029b92ecc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340929Reviewed-by:
-
Wan-Teh Chang authored
Do not DCHECK CanDecodeToYUV() is true in GetYUVSubsampling(), because GetYUVSubsampling() is called by the hardware decoding code paths, not by the decoding-to-YUV code paths. Do not assert that the AVIF_PIXEL_FORMAT_YUV400 case is not reached, because that is the YUV format of monochrome AVIF images. Please refer to https://crrev.com/c/2327461. Bug: 915972 Change-Id: Iced2abe0f86b0f407855c371dbf5e6abef561946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340071Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795387}
-
Peter Kasting authored
* Error and warning icon use was reversed from Material guidelines, other Chrome use, etc. Swap these to fix. * "Warning" icon + "normal" color doesn't make sense; use the warning color there. * Apply the same styling to the filename in |file_name_label_| as in the other labels. This only has a visible effect when new-style warnings are enabled. * Schedule a paint when |complete_animation_| ends, too, not just when it progresses; this ensures the download item doesn't get "stuck until mouseover" when canceling, for example. Bug: none Change-Id: Icffc49980c23c3b42133c5c54af195924b33084c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333658 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#795386}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a28c7896f97f..32be4523385c 2020-08-06 fancl@chromium.org chromeperf: Return multiple change points in FindChangePoints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091864 Tbr: oysteine@google.com Change-Id: I32296c69cb27fde4a1bfc7aa40f4647c27aea6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340927Reviewed-by:
-
Yutaka Hirano authored
RenderFrameImpl::WillSendRequest creates ThrottlingURLLoaders for redirects, which is weird because ThrottleURLLoader's lifetime spans across redirects. Bug: 1112310 Change-Id: Ib40f45cb0f044fea23cf5499ea94f421ad482c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335293Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Eric Willigers authored
We do not enforce permissions policy for Web Share. Instead, we use count if permissions policy would have allowed or rejected the share. https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/E90gFDnqAQAJ Bug: 1079104 Change-Id: I003a5940bdcac3e567ede9ff17f174b3a912267b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336382 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795383}
-
Eric Willigers authored
As discussed in github, the ShareData dictionary now contains a sequence instead of a FrozenArray. https://github.com/w3c/web-share/issues/165 Bug: 1112600 Change-Id: I58238f36158902ddcacf228ab32cd3ffbffdf2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327774 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL adds the wiring of the delete call to the native side. The actual deleting does not happen yet. Bug: 1108358, 1092444 Change-Id: Ibe312ca2eb5218188e8eefe3a064ad005a75b0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332825Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#795381}
-
Christian Dullweber authored
Bug: 1104836 Change-Id: Icb2c9b31aea8d523d2dfbeaf67e7e92bd160a94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328907Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#795380}
-
Morten Stenshorne authored
Not sure what (or who) fixed it, but it's no longer flaky. Adding a simplified and non-flaky test that also passes now. Bug: 1066640 Change-Id: Ia82810e240eab6f3ee955afe89ebeeffebf808d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339521Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795379}
-
chrome://flagsAlexey Baskakov authored
This reverts commit dcf6cef1. Reason for revert: Fails https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7545 Original change's description: > Reland "Tab Search: Add chrome://flags entry for Tab Search" > > This is a reland of 5da77d64 > > Original change's description: > > Tab Search: Add chrome://flags entry for Tab Search > > > > This addition is necessary to allow users to disable the feature once > > the experiment is enabled. > > > > Bug: 1099917 > > Change-Id: I4e537a1fe92d1329c75ff8c190f92ce7f1cde8b7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336020 > > Reviewed-by: Robert Liao <robliao@chromium.org> > > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#794867} > > Bug: 1099917 > Change-Id: I639aea54269a221d32049f98b715b4853c94f2bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339922 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795337} TBR=robliao@chromium.org,tluk@chromium.org Change-Id: I5b4d345cc87d982139157babd52918c2fd89e70d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340353Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#795378}
-
Milica Selakovic authored
Reland https://chromium-review.googlesource.com/c/chromium/src/+/2332164 with proper sha1 file instead of png. Previous cl was reverted because: IDS_AUTOFILL_ASSISTANT_INIT_MESSAGE_PASSWORD_CHANGE.png.sha1 needs to be a sha1 not a PNG file Bug: 1110309 Change-Id: I50ba1f30e9b0bd6ed1539216b05cffdf3f0a614d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339324Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Milica Selakovic <selakovic@google.com> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#795377}
-
evliu authored
This CL updates |CaptionBubble::OnTextChanged| to support non-ASCII characters. Bug: 1111919 Change-Id: I1733160390f4e3fd6cae5da6d02edbcee0258fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332305Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#795376}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d2f4008a5291..1362c1eac458 2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b133b38a to 69b685d4 (479 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: Idceee762a6732486eddd89ca610b6573154a99bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340628Reviewed-by:
-
Tal Pressman authored
Bug: 1090251,1113134 Change-Id: I4d2efea46316d87332e700fe4dccd2aabfa87149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340569Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#795374}
-
