GitLab

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178289:178301&mode=html
TBR=falken@chromium.org,abarth@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283675 0039d316-1c4b-4281-b951-d872f2087c98

When collecting upon resume from suspend or session restore, don't always
collect right away. Introduce a random delay before collecting.

BUG=chromium:358778
TEST=Do the following:
- Add logging to ParseProtoIfValid().
- Set kResumeSamplingFactor=1 and kRestoreSessionSamplingFactor=1. This makes
  collection happen 100% of the time.
- Set kPerfProfilingIntervalMs=20000. This makes the periodic collection happen once every 20-second interval.
- Trigger both types of collections, resume and restore:
  = Suspend and resume the system.
  = Open some tabs in ChromeOS, log out of Chrome, and then log back in so that
    the session is restored.
- Should see the logging trace displayed in /var/log/ui/ui.LATEST after a
  random delay.
- Should also see the periodic collections take place.
  = Open an incognito window. It should continue to attempt to collect. (Add a trace to ScheduleIntervalCollection to see that this is the case).
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/364913007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283674 0039d316-1c4b-4281-b951-d872f2087c98

In preparation of removing RootView::DispatchGestureEvent(),
replace its two overrides with overrides of
ui::EventProcessor::OnEventFromSource() and then make
the function DispatchGestureEvent() non-virtual.

BUG=353641
TEST=none

Review URL: https://codereview.chromium.org/395563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283673 0039d316-1c4b-4281-b951-d872f2087c98

minor changes
- print offset/mask info when printing layer hierarchy.
- copy the offset when cloning layer.

BUG=391822
TEST=Added new tests in layer_unittests and views_unittests

Review URL: https://codereview.chromium.org/375693006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283672 0039d316-1c4b-4281-b951-d872f2087c98

This patch just adds the API to get a download URL with an drive read only token.

BUG=305511
TEST=manually teste
R=asargent@chromium.org, hashimoto@chromium.org, kinaba@chromium.org
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/371883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283671 0039d316-1c4b-4281-b951-d872f2087c98

In a previous design iteration we planned to have the sync server assign
an attachments id after receiving an attachment upload. We have since
changed the design so the client is responsible for assigning the
attachment id before upload occurs.

Remove comments related to updating attachment id after upload.

Rename UpdateAttachmentIdWithServerInfo to MarkAttachmentAsOnServer.

Rename UpdateEntriesWithAttachmentId to
UpdateEntriesMarkAttachmentAsOnServer.

BUG=371522

Review URL: https://codereview.chromium.org/394293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283670 0039d316-1c4b-4281-b951-d872f2087c98

Set up message passing between C++ and JavaScript for end-to-end testing of print preview. Allows preview settings, such as the page range, to be set during a browser test.

BUG=388517

Review URL: https://codereview.chromium.org/381453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283669 0039d316-1c4b-4281-b951-d872f2087c98

As far as I can tell, these defines shouldn't have any effect. I'd like to make
the trusted plugin build more similar to what we have for the renderer so that
the transition will be easier when we get rid of the trusted plugin shared
library.

This mirrors a change made to native_client in 2012:
  http://git.chromium.org/gitweb/?p=native_client/src/native_client.git;a=commitdiff;h=c0a9077e3a604521f67f35c9bec3be031dd21465

BUG=394497

Review URL: https://codereview.chromium.org/391343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283668 0039d316-1c4b-4281-b951-d872f2087c98

This CL follows https://codereview.chromium.org/392783003, and will be followed by another CL to remove redundant fields & methods in blink.

BUG=350531

Review URL: https://codereview.chromium.org/393653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283667 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni@chromium.org
BUG=393489

Review URL: https://codereview.chromium.org/395023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/397793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283665 0039d316-1c4b-4281-b951-d872f2087c98

This implements RAII semantics so that when the destructor runs, the source
is cancelled and event handler blocks cannot call methods on a destructed
object.

BUG=382931
R=mark@chromium.org

Review URL: https://codereview.chromium.org/392273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283664 0039d316-1c4b-4281-b951-d872f2087c98

This resulted in needing to make structural changes. For example, if
connection 2 has a root of A, and A has the children B and C then if A
is assigned to another connection (by way of the owner calling Embed
again), then connection 2 is told A has been deleted and B and C are
removed as children of A.

Because this does structural changes the server change id is advanced.

BUG=389339
TEST=covered by unit tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/397803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/399493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=181277
TEST=Everything still works
TBR=shess@chromium.org, gab@chromium.org
(shess@ for logins_table, gab@ for profile_writer both file-moves)

Review URL: https://codereview.chromium.org/380023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283658 0039d316-1c4b-4281-b951-d872f2087c98

Add a bunch more baked-in configs, and update the existing ones.
Also, improve bake_in_configs.py so it will display multiple errors before
failing, and re-enable the unit test that failed when the existing configs
expired.

BUG=

Review URL: https://codereview.chromium.org/391383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283657 0039d316-1c4b-4281-b951-d872f2087c98

Allow a menu to stay open when a child View (not a MenuItemView) is doing a drag-and-drop operation.

We need this in order to allow the wrench menu to stay open during browser action drag-and-drop when the extension action redesign switch is enabled.

BUG=393038

Review URL: https://codereview.chromium.org/378333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283656 0039d316-1c4b-4281-b951-d872f2087c98

It seems this file doesn't exist anymore, so the exclusion
rules aren't also necessary. And GN reports error for 
excluding non-existing files.

BUG=None
R=brettw@chromium.org, szym@chromium.org
TEST=None

Review URL: https://codereview.chromium.org/399723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283655 0039d316-1c4b-4281-b951-d872f2087c98

Moved all files from remoting/jingle_glue to remoting/signaling and
remoting/protocol.
The new remoting/signaling directory contains signaling layer implementation
for remoting that can be used independently of remoting/protocol.

TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/390983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283654 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47554

Review URL: https://codereview.chromium.org/394703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283653 0039d316-1c4b-4281-b951-d872f2087c98

This is breaking ipc fuzzer build.
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/391373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283652 0039d316-1c4b-4281-b951-d872f2087c98

Previously CdmAdapter only allows one outstanding SendPlatformChallenge() call.
However, CDM actually needs to make parallel SendPlatformChallenge() calls. This
CL fixes CdmAdapter to allow this.

BUG=393722
TEST=Tested on ChromeOS build on Linux with hack in
PepperPlatformVerificationMessageFilter to return faked challenge platform reply.

Review URL: https://codereview.chromium.org/393713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283651 0039d316-1c4b-4281-b951-d872f2087c98

-----------------Reland 2 Description------------------
Turned on layers for the test for fullscreen windows.

-----------------Reland 1 Description------------------
Reland 1 link: https://codereview.chromium.org/393933003/
Core animation was turned on in M35. The fullscreen window was not layer
backed, but should have been. This original CL exposed this bug.

-----------------Original Description------------------
Original CL link: https://codereview.chromium.org/379293003/

In OSX 10.10+, all views must be added to the NSWindow's contentView. Some
views (like the tab strip and the profile icon) are placed on top of the title
bar and require special treatment. All other views are added as subviews of
'chromeContentView' in TabWindowController. This allows tab dragging and
fullscreen logic to easily move the views that don't need special treatment.

This CL also removes the instances where a VersionIndependentWindow's
contentView gets replaced by setContentView:. Instead, the 'chromeContentView'
gets passed around as a subview. This allows VersionIndependentWindow to remove
another of its internal hacks.

BUG=392239

Review URL: https://codereview.chromium.org/399803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283650 0039d316-1c4b-4281-b951-d872f2087c98

will remove the flag from the skia side after this lands

BUG=

Review URL: https://codereview.chromium.org/396733009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393266
For log only change to profile_io_data.cc (reviewed by mattm)
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/385993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283648 0039d316-1c4b-4281-b951-d872f2087c98

This CL handles create a helper method in browser_tests to dismiss the host-out-of-date warning if it is displayed.

BUG=393072

Review URL: https://codereview.chromium.org/389673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283647 0039d316-1c4b-4281-b951-d872f2087c98

build/grit_target.gypi does this for us, clients/consumers just need to define grit_out_dir variable and include grit_target.gypi for the magic happen.

Found these entries with the following command line:

$ for f in $(g ls-files | grep resources.gyp); do grep direct $f; echo $f;
done
$ for f in $(g ls-files | grep strings.gyp); do grep direct $f; echo $f;
done

BUG=None
TEST=None
TBR=keybuk@chromium.org,yoz@chromium.org,darin@chromium.org

keybuk for device/bluetooth/
yoz for extensions/
darin for webkit/

Review URL: https://codereview.chromium.org/389223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283646 0039d316-1c4b-4281-b951-d872f2087c98

Fix the MIPS Linux build that was broken by r282266 (and r282246).
Related r282266 review is at https://codereview.chromium.org/382743002

TEST= build Chrome Linux for target_arch=mipsel

Review URL: https://codereview.chromium.org/396243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283645 0039d316-1c4b-4281-b951-d872f2087c98

r280376 changed the button drag image painting code.
The label colors used make the text appear blurry.

Use label native theme colors instead of button colors.
(the black-on-white looks better than black-on-gray)

See before/after pics at http://crbug.com/394245#c4

BUG=394245
TEST=Bookmark/URL drag images look okay.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/400443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283644 0039d316-1c4b-4281-b951-d872f2087c98

If no override is given, simHomePath needs to be initialized or iossim
won't know where to find files (e.g. the simulator's sandboxed
system.log)

BUG=None

Review URL: https://codereview.chromium.org/398133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/395303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283642 0039d316-1c4b-4281-b951-d872f2087c98

Currently we associate touchscreen to display based on matching
resolution. But there could be cases the internal touchscreen
reports a resolution that does not match any display resolution,
or the internal display and external display have the same resolution
so we don't know which display to match the touchscreen to.

This patch adds a logic that if we have internal touchscreen and
internal display, we should match them first regardless of the
resolution.

We already have the information about which display is internal display.
For deciding internal touchscreen, we query X to get the touchscreen's
/dev/input/eventX  node, and call a script is_touchscreen_internal
(which checks if the device is a I2C device) to decide whether the
touchscreen is internal or not.

BUG=chrome-os-partner:29398
TEST=touch position is correctly mapped on Blaze in extending mode, with
     external monitor having 1920x1280 resolution.

Review URL: https://codereview.chromium.org/394063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283641 0039d316-1c4b-4281-b951-d872f2087c98

With https://codereview.chromium.org/331993009/, GetMenu() may return
NULL if running a native Cocoa menu.
This patch deletes GetMenu and updates call sites to no longer call it.

BUG=388455

Review URL: https://codereview.chromium.org/393943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337829

Review URL: https://codereview.chromium.org/402433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283639 0039d316-1c4b-4281-b951-d872f2087c98

In the "delete the only active profile and create a new one" case, the newly
created profile should use the placeholder avatar, and not one of the custom ones. 
The same should happen for the first run default profile.

BUG=NONE
TEST=Start Chrome with --new-profile-management. Delete all the profiles you have.
The newly created profile should use the default guest-looking avatar (which you
can check in the avatar bubble).

Review URL: https://codereview.chromium.org/392313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283635 0039d316-1c4b-4281-b951-d872f2087c98

KeygenHandler defaulted to use the persistent key slot. However, the Handler is also used in ChromeOS where no such global persistent slot exists.

This change removes this default behavior from KeygenHandler.
Instead only the slot provided by the CryptoModuleDelegate will be used.
If no CryptoModuleDelegate is set, then an error will be thrown on keygen usage.

The unit test of KeygenHandler now explicitly provides the slot through a StubCryptoModuleDelegate.
In a follow up, the crypto::GetPersistentNSSKeySlot() call will be removed from the unit tests as well and instead the test slot will be get()'ed from the ScopedTestNSSDB.

BUG=210525

Review URL: https://codereview.chromium.org/384413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283634 0039d316-1c4b-4281-b951-d872f2087c98

In particular, Widget::SetCapture() fails if the widget is not visible.

BUG=None
TEST=WidgetCaptureTest.FailedCaptureRequestIsNoop

Review URL: https://codereview.chromium.org/375593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283633 0039d316-1c4b-4281-b951-d872f2087c98

Adapts to changes in https://codereview.chromium.org/381113004.

R=lcwu@chromium.org,brettw@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/396733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/395503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283631 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283630 0039d316-1c4b-4281-b951-d872f2087c98