GitLab

Revert of Fragment blocks with non-visible overflow as normally when printing. (patchset #1 id:1 of https://codereview.chromium.org/2298193002/ )

Reason for revert:
Suspected cause of "virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html" failures in webkit_tests on "WebKit Linux (dbg)" bot.

example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/9099

Original issue's description:
> Fragment blocks with non-visible overflow as normally when printing.
>
> Splitting scrollbars into multiple fragmentainers is only problematic in
> interactive media. We don't need to impose any such pagination restrictions
> when printing, since printing is non-interactive,
>
> BUG=641983
>
> Committed: https://crrev.com/53d4d7aff8e25eae2ece5bbf5a53eec940871fa8
> Cr-Commit-Position: refs/heads/master@{#415645}

TBR=eae@chromium.org,mstensho@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641983

Review-Url: https://codereview.chromium.org/2300763002
Cr-Commit-Position: refs/heads/master@{#415712}

It tests whether ResizeObserver is kept alive by:
- direct javascript reference
- observing a live element.

BUG=612962

Review-Url: https://codereview.chromium.org/2272163003
Cr-Commit-Position: refs/heads/master@{#415711}

BUG=

Review-Url: https://codereview.chromium.org/2298303002
Cr-Commit-Position: refs/heads/master@{#415710}

Review-Url: https://codereview.chromium.org/2297273002
Cr-Commit-Position: refs/heads/master@{#415709}

Forward ScrollEvent/MouseWheelEvent to the hosting widget so that
it is processed and reaches the containing ScrollView.

Also not forward touch events to ArcCustomNotificationView since
a View is not supposed to receive touch events. This gets rid of
the NOTREACHED() warning in chrome log.

BUG=b/31115616
BUG=642501

Review-Url: https://codereview.chromium.org/2291193003
Cr-Commit-Position: refs/heads/master@{#415708}

https://pdfium.googlesource.com/pdfium.git/+log/21ce1a68bb9f..4d9df422c340

$ git log 21ce1a68b..4d9df422c --date=short --no-merges --format='%ad %ae %s'
2016-08-31 tsepez Make CPDF_GraphState have a CPDF_GraphStateData instead of inheriting.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2291343003
Cr-Commit-Position: refs/heads/master@{#415707}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/dcb82a6eedd3de602c008dca3d69489df036cbc7 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/7b787b8642623e39eafce83595c187660528af9f Revert of It's time to bring subprocess42 to depot_tools. (patchset #1 id:1 of https://codereview.chromium.org/2291223003/ ) (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2298923002
Cr-Commit-Position: refs/heads/master@{#415706}

BUG=614963

Review-Url: https://codereview.chromium.org/2280283002
Cr-Commit-Position: refs/heads/master@{#415705}

This move allows the BezierEditor to also be used in Sources panel.

BUG=642782

Review-Url: https://codereview.chromium.org/2299473002
Cr-Commit-Position: refs/heads/master@{#415704}

It was never added to histograms.xml

BUG=642287

Review-Url: https://codereview.chromium.org/2298513002
Cr-Commit-Position: refs/heads/master@{#415703}

BUG=639315
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2272993003
Cr-Commit-Position: refs/heads/master@{#415702}

These tests assume that no extension background pages have loaded at the start
of the test, but for some reason DevTools is reporting these earlier than it
used to. It's valid to have these background pages in the window list, so I've
removed the assertions.

BUG=
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2299723002
Cr-Commit-Position: refs/heads/master@{#415701}

In the current code base, a float number is used when users try to control
the volume slider by using keyboard. It increases/decreases the volume by
0.1 (or 10%) after each press. In the CL2281173002, it accidentally
changed this increment to an integer, so the volume either jumps to silent
or max.

BUG=631775

Review-Url: https://codereview.chromium.org/2297833002
Cr-Commit-Position: refs/heads/master@{#415700}

Adds new message field to the Password Scpecific proto and implements clearing of the data in case custom passphrase is turned on.
The population of the metadata is not implemented in this CL.

BUG=638963

Review-Url: https://codereview.chromium.org/2278333002
Cr-Commit-Position: refs/heads/master@{#415699}

WorkAreaChanged -> DisplayObserver::OnDisplayMetricsChanged.
ShelfAlignmentChanged -> ShellObserver::ShelfAlignmentChanged
TODO: Add checks for matching Display id? (didn't happen previously)

Notify ShelfLayoutManager of alignment changes before ShellObserver.
(to replace RootWindowControllerObserverImpl's apparent intent)

Add default empty DisplayObserver function impls.

BUG=NONE
TEST=No behavior changes.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2295003002
Cr-Commit-Position: refs/heads/master@{#415698}

There are two problems here:

1) The GuestViewBase received a FindReply while its WebContents was in the process of being destroyed. This patch adds a check in WebContentsImpl::NotifyFindReply to prevent this.

2) During destruction of GuestViewBase, there is a period of time when there is no owner WebContents, but attached() still returns true. This patch ensures that that attached() will return false as soon as |owner_web_contents_| is cleared.

BUG=642733

Review-Url: https://codereview.chromium.org/2300663002
Cr-Commit-Position: refs/heads/master@{#415697}

BUG=634156

Review-Url: https://codereview.chromium.org/2282673003
Cr-Commit-Position: refs/heads/master@{#415696}

This bot is currently FYI-only, and adding the test
will allow us to add the correct suppresions in ANGLE.

BUG=641080
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2273393002
Cr-Commit-Position: refs/heads/master@{#415695}

When the viewport has fixed background, we may create a dedicated
GraphicsLayer (CompositedLayerMapping::m_backgroundLayer) for the
root background. Previously we used PaintLayerPaintingRootBackgroundOnly
and PaintLayerPaintingCompositingForegroundPhase flags when painting
the layer. The second flag was necessary before we refactored viewport
background painting into ViewPainter, because we needed the layout
objects of the document element or the body element to paint the
viewport background.

Now we need only the root layer to paint root background.

BUG=595839
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2294313002
Cr-Commit-Position: refs/heads/master@{#415694}

MessagingBindings contains the custom bindings for extension messaging,
but most of the implementation is buried in an "ExtensionImpl" class
in an anonymous namespace. Apart from being a misleading name (I think
this dates back to the chrome.extension API), this makes the code hard
to read. Since I'm making changes here for crbug.com/642380, clean up
the code here with no behavior changes.

Make MessagingBindings (which previously just had static methods)
encompass ExtensionImpl, and remove some unneeded includes.

BUG=642380

Review-Url: https://codereview.chromium.org/2295753003
Cr-Commit-Position: refs/heads/master@{#415693}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/be52565c2553c03b801f4bfc080c7ebc63b550fa Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2299543006
Cr-Commit-Position: refs/heads/master@{#415692}

Disable Download button if current tab is showing offline page already, or an error or interstitial.

BUG=641391,641393

Review-Url: https://codereview.chromium.org/2296603004
Cr-Commit-Position: refs/heads/master@{#415691}

This small refactoring removes device scale factor from AwContents
cache and uses the value from ContentViewCore.
The device scale factor in ContentViewCore is defined after
ContentViewCore native initialization, therefore this CL also
moves the device scale propagation until after that.

This is a prerequisite for https://codereview.chromium.org/2300463002

BUG=620929

> Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97
> Cr-Commit-Position: refs/heads/master@{#415546}

Reland after fix related to PopupTouchHandleDrawable.

Review-Url: https://codereview.chromium.org/2288273003
Cr-Commit-Position: refs/heads/master@{#415690}

Add an uma counter to log how often dtls handshake fails because of incompatible cipher suites.
Related CL: https://codereview.webrtc.org/2167363002/

BUG=webrtc:5959

Review-Url: https://codereview.chromium.org/2292253002
Cr-Commit-Position: refs/heads/master@{#415689}

Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug.

BUG=b/31022395
BUG=642827

Review-Url: https://codereview.chromium.org/2295923004
Cr-Commit-Position: refs/heads/master@{#415688}

Add command line flag to allow testing clients not connected to localhost. Otherwise, restrict connections to localhost

BUG=582102
TEST=Run the engine without the "listen-outside" flag and make sure incoming connections are limited to localhost. Run with --listen-outside=1 and make sure it allows incomiong connections from outside localhost

Review-Url: https://codereview.chromium.org/2292563003
Cr-Commit-Position: refs/heads/master@{#415687}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3e5d344f..a7db6458

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2296233002
Cr-Commit-Position: refs/heads/master@{#415686}

BUG=626752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2295533002
Cr-Commit-Position: refs/heads/master@{#415685}

Fix the problems that on some models of phones such as Sony Xperia Z3 & Z5, Chrome widget blocks in showing the bookmark information.

It comes with two problems and both happens when there are thousands of
bookmark to display:
1. If Chrome is not initialized, GC might recycle the BookmarkLoader
before BookmarkModel is loaded which blocks retrieving bookmark info.
2. Even Chrome is already intialized, fetching meta data is not always
guaranteed to wait until onDataChanged is finished(even though Android doc
claims it is). So need to manually check if bookmark info is loaded and
keep refreshing if not.

BUG=621643

Review-Url: https://codereview.chromium.org/2258113003
Cr-Commit-Position: refs/heads/master@{#415684}

This field trial has expired.

BUG=557984

Review-Url: https://codereview.chromium.org/2286903002
Cr-Commit-Position: refs/heads/master@{#415683}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/aa7c58eb0459..08327b978d86

$ git log aa7c58eb0..08327b978 --date=short --no-merges --format='%ad %ae %s'
2016-08-31 eakuefner [Catapult] Add common/node_runner

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2298803002
Cr-Commit-Position: refs/heads/master@{#415682}

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676

Review-Url: https://codereview.chromium.org/2281943002
Cr-Commit-Position: refs/heads/master@{#415681}

BUG=642534

Review-Url: https://codereview.chromium.org/2291193004
Cr-Commit-Position: refs/heads/master@{#415680}

This is unused and no longer needed. We can revive it from git history if
we need it again.

BUG=641996
TEST=compiles

Review-Url: https://codereview.chromium.org/2298603002
Cr-Commit-Position: refs/heads/master@{#415679}

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/BkPSl0Oey8k/BqJ3_ck0BAAJ

BUG=569690

Review-Url: https://codereview.chromium.org/2217763003
Cr-Commit-Position: refs/heads/master@{#415678}

BUG=3333

Review-Url: https://codereview.chromium.org/2298023002
Cr-Commit-Position: refs/heads/master@{#415677}

This CL implements the new <fit-content> track size which is defined as
follows: "Represents the formula min(max-content, max(auto, argument)),
which is calculated similar to auto (i.e. minmax(auto, max-content)), except
that the track size is clamped at argument if it is greater than the auto
minimum."

From the parsing POV fit-content was implemented as a new type of function
which only takes one argument. That forced us to refactor some code because
minmax() was the only allowed function for <track-size>s so far.

The implementation key is a new attribute in GridTrack called growthLimitCap
which is precisely the attribute of fit-content(). Some parts of the track sizing
algorithm were adapted to this change like for example the sorting of tracks by
growth potential (we need to consider the caps).

BUG=618972

Review-Url: https://codereview.chromium.org/2287113004
Cr-Commit-Position: refs/heads/master@{#415676}

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.

BUG=642028

Review-Url: https://codereview.chromium.org/2296973003
Cr-Commit-Position: refs/heads/master@{#415675}

BUG=621773

Review-Url: https://codereview.chromium.org/2293203002
Cr-Commit-Position: refs/heads/master@{#415674}

Losing network connection while prerendering can show up as an Unsupported Scheme failure
currently as it sees a special data URL in path toward rendering an error page. We don't want
a flakey network connection fail a background load request on just a single try, so for now,
we will treat this specific error type as a cancel rather than a failure so that it is subject
some limited retrying. The down side, is that for some page that has a repeatable redirect
to an unsupported scheme, we will waste some retries on it that we otherwise could skip.

Ideally, we could get a different final status code from the prerenderer if it could clearly distinguish a network failure condition but it does not currently have such knowledge.

BUG=642025

Review-Url: https://codereview.chromium.org/2294933003
Cr-Commit-Position: refs/heads/master@{#415673}