- 10 Apr, 2020 40 commits
-
-
Sam Bowen authored
Bug: 1064748 Change-Id: I74627723099d1b09359cd6fa7575136a39b0d01a Binary-Size: The binary size of the generated code was reduced as much as possible in https://crrev.com/c/2144773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137514 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#758316}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68353dd74e3e..3431cbde4e5a Created with: gclient setdep -r src-internal@3431cbde4e5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046880,chromium:1058152 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I6b3191fd5ddc060cb9b60ecbb79d2b49df254c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145914Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758315}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ib65dd541d00deed6c72dcf5596358c00974b4b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145382Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#758314}
-
Jian Li authored
Bug: 1044139 Change-Id: I1ecaf8f68dd047353ea746fa94f73004a5a35205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142952 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#758313}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cf9ec0ae80a4..b36549d189fb git log cf9ec0ae80a4..b36549d189fb --date=short --first-parent --format='%ad %ae %s' 2020-04-10 brgoddar@microsoft.com Network: Update Search to Activate Requests when clicked Created with: gclient setdep -r src/third_party/devtools-frontend/src@b36549d189fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068747 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I15a2a576a693f60226b00cc28f5f85fe468134fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758312}
-
ssid authored
The experiment is not launched yet due to few bugs and the current release delays. So, extend till 86. BUG=1068217 Change-Id: Ia1562665588d7fa6872e929990905381e1000051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143887Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#758311}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I2aa3940ad452f340d6d50361fb742f9d653e5e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145374Reviewed-by:
-
Robert Sesek authored
Also removes all the unused #includes for the types. Change-Id: I50b28c65bf132d8bf970863f9375bc4316781bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138504Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758309}
-
Gang Wu authored
This reverts commit 3f46dedb. Reason for revert: The test is still flaky Original change's description: > Increase the timeout for criteria check > > From previous enabled test run, > https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_shell_test_apk&tests=ClipboardTest%23testCopyDocumentFragment > It seems most of failure happened on slow devices, like x86. > So increase the timeout for CriteriaHelper.pollUiThread(). > > Bug: 791021 > Change-Id: I89430d2fbf89196a3813b1e175d2fd56090e079b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144814 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758050} TBR=yfriedman@chromium.org,gangwu@chromium.org Change-Id: Ie5e138111645d19193b319ae1210b863fe721000 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146073Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758308}
-
Rakib Hasan authored
This reverts commit d8f56276. Reason for revert: The original CL should not have been reverted. That was a planned outage. CL's post Chrome internal roll are compiling correctly. Original change's description: > Revert "Remove ImmersiveModeManager and related code." > > This reverts commit b5fff4e4. > > Reason for revert: Causing android perf builders to fail compiling Clank. crbug.com/1069913 > > Original change's description: > > Remove ImmersiveModeManager and related code. > > > > BUG=949819 > > > > Change-Id: I09e3546e3e14f469e3a68fcddfd840ec3fd76e8e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140928 > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Commit-Queue: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758248} > > TBR=twellington@chromium.org,mdjones@chromium.org > > Change-Id: I2dbc931d813fbbdf804f505632508caff373e439 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 949819 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144470 > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#758306} TBR=twellington@chromium.org,mdjones@chromium.org,rmhasan@google.com Change-Id: Ie955c8aff2adb2573b8d62ced97228f4abbc3836 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145962Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#758307}
-
Rakib Hasan authored
This reverts commit b5fff4e4. Reason for revert: Causing android perf builders to fail compiling Clank. crbug.com/1069913 Original change's description: > Remove ImmersiveModeManager and related code. > > BUG=949819 > > Change-Id: I09e3546e3e14f469e3a68fcddfd840ec3fd76e8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140928 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758248} TBR=twellington@chromium.org,mdjones@chromium.org Change-Id: I2dbc931d813fbbdf804f505632508caff373e439 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144470Reviewed-by:
-
Rakib Hasan authored
This reverts commit d60e79d1. Reason for revert: CL is causing 40+ rendering.mobile benchmarks to fail for webview on nexus5x and pixel2. crbug.com/1069834. Original change's description: > Limit access to gpu thread in DisplayResourceProvider > > This CL makes sure that DisplayResourceProvider return resources only > when GPU Thread is available to make sure ReleaseImageContexts will > complete in finite time. > > This doesn't change anything for Chrome where GPU Thread is always > available, but on webview RenderThread that used for gpu access during > composition is available only during specific times (init, dtor, > DrawAndSwap) > > Bug: 1068716 > > Change-Id: I8fa482ab7399d6ce7639c1d76187be86ce152059 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138551 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757967} TBR=backer@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068716, 1069834 Change-Id: Ibc08eb8ce77d8cb620b6f3c249211e4f425802ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145953Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f0b36c4610d..fdabfbc3349a git log 9f0b36c4610d..fdabfbc3349a --date=short --first-parent --format='%ad %ae %s' 2020-04-10 marinaciocea@webrtc.org [InsertableStreams] Pass ssrc on TransformedFrameCallback registration. Created with: gclient setdep -r src/third_party/webrtc@fdabfbc3349a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065838 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b69cad7cc40f0211532dd42a7a016d5977ec83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145789Reviewed-by:
-
Rakib M. Hasan authored
We want to create a layout-test-results folder and put the json results file in there. The bot will be changed so that it creates a storage bucket where the results file can be retrieved by the rebaseline tool. TEST: Look for the "archive results for weblayer_shell_wpt (with patch)" step in trybot. Check for full_results.json file in downloadable archive. TBR=robertma@chromium.org Bug: 1050760, 1050754 Change-Id: If0912629053b4972e1426af6ea3bb3f061fbb128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140095 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758303}
-
Lukasz Anforowicz authored
This CL modifies tests that expect that a request is blocked by CORS. Before this CL, such tests would only verify that the request errored out (which can happen for non-CORS related reasons - see https://crbug.com/1051594#c9). After this CL, such tests also verify that CORS emitted an error message to the console. Bug: 1051594 Change-Id: I0230e915e56398a70cd511fc7febe39d264e4a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137851 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#758302}
-
Lukasz Anforowicz authored
Fixed: 1069593 Change-Id: I43566687b2631634529b0f41e49f3ba92bcd04ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144680 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#758301}
-
Roberto Carrillo authored
R=chanli,nodir,bpastene Bug: 1027762 Change-Id: I39a7ed5a098566e28bd4c13345c1e5a2495ad15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144462Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#758300}
-
Daniel McArdle authored
Change-Id: Ie79129dc38ac5c85388c7875e969b19d3a7e4e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143863Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#758299}
-
Matt Menke authored
Also convert all of net/ to use it instead of the one-argument constructor. The one argument constructor takes arguments in the form of "foo: bar", which results in a bunch of code redundantly merging keys and values into a single string to pass it in. Also add a SetHeader convenience method which is a combination of RemoveHeader and AddHeader. Having AddHeader itself do this in only one place is safer and allows it to validate the key and value arguments are reasonable. Also, the single argument overload places limitations on the implementation of AddHeader works, unless we want to have AddHeader potentially parse the single string (that many consumers just merged from two separate strings) into a name/value pair, so ideally we can just remove it, once consumers are all converted to use the two-argument overload. Bug: 1068194 Change-Id: I19734b9e597799234c0f50b2312540be559dc302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140553Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#758298}
-
Esmael El-Moslimany authored
Bug: 1032328 Change-Id: Id2c69183598d01f08f8fd20f4134b0c3cba863ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145599 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758297}
-
Chris Thompson authored
Before we required Organization, Country, and Locality to be set, but EV certificates require Organization, Country, and at least one of Locality OR State. This updates the check in PageInfoBubbleView to only check the fields that are actually used in the UI, and adds a regression test (and certificate) exercising this case. Fixed: 1069113 Change-Id: I5a5eff339eb875fa4d36c61f0e5ffc1d4ba95ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142714Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#758296}
-
Garrett Beaty authored
This will provide a more helpful error message than what some users have already experienced where it just complains about an undefined symbol. Change-Id: I9dabe2333650b29d2dd585efd386edef8ff84d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144466 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758295}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I45649ec0896194dbbb7ad9753046d655ae0b88f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140927Reviewed-by:
-
Reilly Grant authored
This test appears to be flaky. See the attached bug for details. Bug: 1069870 Change-Id: I12f20a5261ae0e5e5888904c409d399f655a06d9 Tbr: afakhry@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145864Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758293}
-
Collin Baker authored
This is intended to show redundant layouts occurring on the switch between touch and non-touch mode. Especially, traces produced by perf bots will be easier to debug. See the bug for a motivating case. Bug: 1054489 Change-Id: I108053677429b2b9c6c62c5f97ba81b4e63e8e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134699Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#758292}
-
Esmael El-Moslimany authored
This CL uses the same approach to update the OneGoogleBar theme as the following CL. https://chromium-review.googlesource.com/c/chromium/src/+/605951/ After the theme and OneGoogleBar are loaded, a message is posted to the OneGoogleBar iframe to turn on/off dark theme based on the theme. When a background is selected in the customize dialog, the OneGoogleBar is also updated by setting dark theme when previewing an image. Bug: 1039913 Change-Id: I7d420be98006185e0d55d5d41fdbe0f267c08875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145818 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Wan-Teh Chang authored
Replace the four very similar conversion functions (YUVAToBGRA8888, YAToMono8888, YUVAToRGBAHalfFloat, YAToMonoHalfFloat) with the YUVAToRGBA template function, with the color_type (kMono or kColor), InputType (uint8_t or uint16_t), and OutputType (uint32_t or uint64_t) template parameters. This avoids code duplication and was suggested by Peter Kasting. Also remove the pixel.Scale(alpha / max_channel) call in YUVAToBGRA8888. It might be left over from Dale's attempts to get alpha right, i.e., forcing premultiply alpha. Bug: 960620 Change-Id: Ibc8dd429d6360f7dc5f37721f1fb2b67d8ec0d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142341 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758290}
-
Alison Maher authored
This change takes the amount of the border block-start/end that had been consumed previously when calculating the block size taken up by the legend. This ensures that adjusted_padding_box_size does not overcompensate for the border and is consistent across multiple fragments. Making this adjustment fixes an associated crash that was introduced to virtual/layout_ng_block_frag/external/wpt/css/css-break/fieldset-001.html Bug: 875235 Change-Id: Idcd1c6eba435eac41ca90acd2e4a0cabe4015a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140720Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#758289}
-
Charlie Hu authored
Because image policies have all been migrated to document policy(https://chromium-review.googlesource.com/c/chromium/src/+/2058702), support in feature policy to report image URL can be removed. Bug: 993790 Change-Id: Idcc8bd8d42bca8c757a3dcb1f43d0d41f4b5f3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076523 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
-
Hans Wennborg authored
This provides cheaper (in terms of compile time) alternatives for code that just wants to do a few simple CHECKs without pulling in the full weight of logging.h. On Linux, the preprocessed size of check.h and check_op.h are 2% and 62% of logging.h, respectively. Splitting the CHECK and CHECK_op macros out to separate files also reduces the complexity of logging.h which has become very complicated. As a bonus, the new implementation is leaner, causing a 3% local compile-time reduction for the chrome target on Linux even though no includes have been changed yet. Bug: 1031540 Change-Id: If7aca321f077110bea0907e487d2e8d29a8c50fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128112 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Xinghui Lu authored
This metric is useful to monitor the success rate of requests and the distribution of each error type. Metrics added in this CL: SafeBrowsing.TokenFetcher.ErrorType Bug: 1051679 Change-Id: I7e6242e932700c9c8906c374941b54ac2e1437cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138157Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Arthur Eubanks authored
Bug: 1067752 Change-Id: Ib24d6e6542fc9a21e8105f8bcd9776ab34968ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137542Reviewed-by:
-
Matt Menke authored
This is part of an effort to merge SiteForCookies, NetworkIsolationKey, and the information on how to update them into a single object that renderers cannot set, to ensure consistency and help protect against compromised renderers. This CL also makes NavigationRequests get a single IsolationInfo from the RenderFrameHost, instead of getting NIK and SiteForCookies separately. This will change behavior when using view-source from an iframe - the iframe's cookie behavior will be used for the view-source request, though after the first redirect, it will act like a main frame. This behavior will switch to acting like an iframe after redirects, too, once IsolationInfo is fully wired through the navigation code. Bug: 1065152 Change-Id: I4b4ea59dcd72ece35730953536ff5b899fc6c43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122816 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#758284}
-
Dan Harrington authored
- Feed.LoadStreamStatus* histograms - Feed.UserAction histogram Removed FeedStream::EventObserver, since we can now use MetricsReporter directly. Bug: 1044139 Change-Id: Ie48152550e39e2759c3799566c5c8cf5b60d93ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144675Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#758283}
-
Mathias Carlen authored
Before this patch, a render side triggered reload while in a prompt state would not allow a script to restore exactly the same prompt state. This patch introduces an option to end an ongoing prompt upon a render side navigation request. By setting |end_on_navigation| for a prompt action, the latter will end successfully and continue with the next action in the script. This is communicated to the backend via a |navigation_ended| flag in the result choice section. Bug: b/152724265 Change-Id: I182365bc018c0217138d867c48fbe37288f923d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141901 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#758282}
-
Jon Mann authored
Previously we were saving entries from the saved_ip_config (used to remember the last config if the user switches back to DHCP) instead of the actual active static_ip_config. This also implements some missing work during deserialization/application of the proto. Bug: 966270 Change-Id: Icf47bbbec9d4884071f3c324196c90722deb280a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145259 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#758281}
-
Ian Wells authored
* Encodes request payload as base64 * Skips the leading varint message size before trying to parse the response Bug: 1044139 Change-Id: I4736625ffdec1ba6e9b6ad0d4b64265183bdedc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142957Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
John Delaney authored
This CL implements reporting for the Conversion Measurement API. Reports are periodically fetched from ConversionStorage once every 30 minutes by the ConversionManager, which puts them into a queue to be sent. ConversionReporter implements this priority_queue and keeps a timer which fires when the next report is eligible. Reports are sent via SimpleUrlLoaders using the browsers SharedUrlLoaderFactory. Once a report is sent, it is deleted from storage. There is currently no logic for retries due to connection errors. Change-Id: I5ad28ebc6940618fe24b965b371e6097dbabf177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050848 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
rbpotter authored
Migrating sign_out_a11y_test and manage_profile_a11y_test to Polymer 3. Also fixing a missing aria label for the "manage profile" page's input field, which was found by the Polymer 3 version of the test (test was somehow passing in Polymer 2). Bug: 1026426 Change-Id: I327d39ef9f760348ac0dc01622fc27497f4c32f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144842Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#758278}
-
wutao authored
This metric is useful to catch UI perf regressions. Bug: 1055381 Test: NA Change-Id: I8139fe6e595c23a2f139a8623a0d873ed0e5b949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137731Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#758277}
-
