- 19 Nov, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47d4ef3f..94b2c943 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1172cb6f37646d67529eeb37ebf8448e3a6c4655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550363Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829302}
-
cfredric authored
initializer. Deleting the default ctor disallows default aggregate-initialization. Defining our own ctor ensures that aggregate-initialization must provide a value for all members initialized by the ctor, in the same order as the ctor. Thus if a new field is added to the struct and initialized by the ctor, compilation will fail until callsites are appropriately updated. This is a contrast to aggregate-initialization when there is no ctor defined; in such a case, members are initialized in the order they are defined in the struct, and *any number* of members may be initialized. Change-Id: Ib683a6ed6c1380977620fcc873c7fd1edd443803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549686Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#829301}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/75ae8fcc319e..753e7983e04e 2020-11-19 kjlubick@google.com [infra] Remove deleted taskdriver 2020-11-19 adlai@google.com Revert "Remove GrDrawingManager::fActiveOpsTask ivar" 2020-11-19 jvanverth@google.com Update docs for iOS deployment 2020-11-19 kjlubick@google.com update infra repo 2020-11-19 johnstiles@google.com Update DeviceSpaceEffect and ColorSpaceXform to return half4s. 2020-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2ffff6d024c7 to 8b76d37f9f9a (13 revisions) 2020-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb96f79d0e15 to 060020166679 (4 revisions) 2020-11-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from a0758a1aef12 to ce207be41fd6 (4 revisions) 2020-11-19 michaelludwig@google.com Move clip operations on SkDevices into a helper macro 2020-11-18 robertphillips@google.com Update GrTTopoSort to use pre-existing memory ... 2020-11-18 michaelludwig@google.com Simplify internal logic in androidFramework_setDeviceClipRestriction 2020-11-18 johnstiles@google.com Add fix for fuzzer-discovered crash with negated constructors. 2020-11-18 brianosman@google.com Always enable SkSL's ByteCodeGenerator, disable interpreter in Google3 2020-11-18 jvanverth@google.com Add ios_min_target. 2020-11-18 jvanverth@google.com Fix typo in gn/ios.gni. 2020-11-18 johnstiles@google.com Add fix for fuzzer-discovered crash at oss-fuzz:27614. 2020-11-18 michaelludwig@google.com Hide SkCanvas::AutoValidateClip in cpp file 2020-11-18 michaelludwig@google.com Fix SkRegion::setPath to respect inverse fills when path isn't finite 2020-11-18 michaelludwig@google.com Rename fDeviceClipBounds to fQuickRejectBounds 2020-11-18 bsalomon@google.com Remove unused macros from GrGLConfig.h, GrGLConfig_chrome.h, and scripts 2020-11-18 michaelludwig@google.com Track AA-ness and rect-ness in SkConservativeClip 2020-11-18 mtklein@google.com allow JIT on ARM Mac 2020-11-18 johnstiles@google.com Fix worklist files with skslc. 2020-11-18 adlai@google.com Remove GrDrawingManager::fActiveOpsTask ivar 2020-11-18 fmalita@chromium.org [skottie] More robust font style parsing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Ic856b21f450b350756a8f6ad3395b5f0191d4016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829300}
-
Eugene But authored
14.3 has high volume crash with no known fix. Disabling HeapProfiling feature until we understand the reason of the crash. Fix is disabled on all OSes to avoid unexpected breakages in minor iOS releases during the holidays. Bug: 1150599 Change-Id: I5f8627f95ddae013b880194fe9510a87ed9225da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548369 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#829299}
-
Aaron Leventhal authored
Slider thumb is a mock object that was not used in any platform API, and although exposed in automation, is not used by ChromeVox. TBR=mkwst@chromium.org Bug: None Change-Id: I4e43e86882429641c14b75469bdd5b7f1d0bc0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548465Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#829298}
-
Alex Newcomer authored
Move the deactivation of ClipboardImageModelFactory closer to the paste. This ensures all paths to a paste deactivate the factory. Bug: 1148077 Change-Id: I8afdc90a3d4d0f6d4a47f7b8f57457d47e96ff59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548212 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829297}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bsep@chromium.org Bug: 1145565 Change-Id: Idda03ba1fa22200f7637e542e9bca67abc246dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548022 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#829296}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605765502-3ccba7e07e5cf94b5756f4641a727d60a578a62b.profdata to chrome-win64-master-1605776317-40958ff5156f07254d2cc2984d12fc2fc0f55b26.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7c17d2fc584c8e81a2b90aeaf576625fd4771e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549153Reviewed-by:
-
Nate Chapin authored
NavigatorBase is a newly-added base class for Navigator and WorkerNavigator. Making LockManager a Supplement of NavigatorBase allows a single class to handle all of the work of exposing the navigator.locks getter for both windows and workers, and greatly reduces boilerplate. Bug: 1147612 Change-Id: I2eea54d27af56ed1ede3e9f07c2346bffe0796ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545578 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829294}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/f9e6f257d1a0..3ac0b060c794 2020-11-19 thakis@chromium.org Stop accepting mac_xcode_version as a gclient gn var. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147839 Tbr: mseaborn@chromium.org Change-Id: I3ea20e483b1c4b2e1da7f15a53383acd22cc9af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550225Reviewed-by:
-
Renato Silva authored
Prepare parts of the code to work with the HTMLImports polyfill by removing some global definitions usage in cr_ui.js and explicitly making oobe_types.js a dependency of security_token_pin_browsertest. Bug: 1111387 Change-Id: Ifbd2374fc7117f2cefa76c1baa3f96ec813a57a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550221Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#829292}
-
Yusuf Sengul authored
Bug: 1148565 Change-Id: I72a19753fe0ebf3ff770ae1753b946d89c1ed59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536098 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#829291}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=felt@chromium.org Bug: 1145565 Change-Id: I7cc9a4f07f542eebb584138cb673fcbca89131ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547886 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829290}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=vasilii@chromium.org Bug: 1145565 Change-Id: Iaa725d308af52140f8eaf080ca66b71d6aecba78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547887 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#829289}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was created by git cl split. Bug: 1145565 Change-Id: I1480c826c9a9176d6489c4aa36672844cdb290a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550222Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829288}
-
Dave Tapuska authored
Collapse into a single implementation. BUG=1097816 Change-Id: Idae56771c51bc475aef708a7cfe616cd5598540e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543688 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#829287}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3db6c585a2b..9c260034ecc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC iclelland@google.com,mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131897 Tbr: iclelland@google.com,mkwst@google.com Change-Id: I0b7bc364d478395025a9dd1a30720f5007b6b1e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550167Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829286}
-
Peter McNeeley authored
Overlay prioritization solves the problem of selecting the best overlay candidate for hardware overlay promotion. The best candidate is defined as the selection that minimizes power and maximizes performance. Power is the primary concern with the exceptions being low latency rendering and protected content. Prioritization operates at an inter-strategy level so the key changes here operate as a function of the overlay processor. The strategies propose candidates and the prioritization scheme merely sorts them. This sort is of two types. The first pass is a thresholding phase where candidates that do not meet a criteria are discarded. The second pass is a real sort that simply arranges the remaining candidates into best priority order. It should be noted that significant care was made in this change to reduce risk. The older strategy code and the newer prioritization code sit side by side and can be enabled/disabled via a feature flag. The rational for these changes and the heuristic sort can be found in original design document: https://docs.google.com/document/ d/1lFVQeHkCz1UOwtVTf_wTI2twsn48iNbS4UY4srZ0BhE/ The power model for overlays is based on arguments found in this design document: https://docs.google.com/document/ d/1IYcEkbJvH70wh3YUayci9yUx9dFR4j4joIX0kauiOtA/edit?usp=sharing Bug: 1113306,1143937 Change-Id: I01146513b68503c10853998a1d351d2c175e9b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426723 Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#829285}
-
Dave Tapuska authored
Move the two implementations into one common one in the base. BUG=1097816 Change-Id: Ia4187c07676256e62e8d019e90f79b4acc24f97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542596 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ic93a11bc58041721e14781f31d8f4b9bc590f9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544854Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#829283}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4d79f96b5ec9..20cc9eb2a7f5 2020-11-19 aerotwist@chromium.org TypeScriptify HeapProfileView.js 2020-11-19 sadym@chromium.org Fix node screenshot. Part 2. DevTools. 2020-11-19 yangguo@chromium.org [ts] Typecheck SourceCodeDiff.js 2020-11-19 janscheffler@chromium.org [Recorder] Add recording to DevTools 2020-11-19 patrick.brosset@microsoft.com Flex: Draw the hatching pattern in empty space of the flex overlay If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1003629,chromium:1011811,chromium:1139949,chromium:1144127 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4d3fcd7a8e913281e7a2c2a0494a84aede7cc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550165Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dad44f4d824e..1a14e7e02441 2020-11-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 46d9c7745efa to 36d9a061c847 (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Idf57d4542ee09737c5cf255acdaf39b8adbdcd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550174Reviewed-by:
-
Jack Franklin authored
https://crrev.com/c/2544131 renamed the method to remove the underscore but shipped both names in order to avoid layout test breakages. Once that's landed, we can land this change, and then remove the old `_linkInfo` method as it will then be entirely unused. Bug: 1149403 Change-Id: I21bcf71fb8e87fe4202d07ee83b3bbf481905f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546760 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#829280}
-
Kelvin Jiang authored
This CL releases an extension's allocation when it is unloaded for the following reasons: - when it's blocklisted - when it's disabled by policy - when it's disabled for malware Rationale on why certain UnloadedExtensionReason/DisableReason will cause the allocation to be released (or not) are detailed in the doc (internal): docs.google.com/document/d/1oGpntLGf9myZ6lI4XWJNMPaZX1_zooJni6ROsqidC6A Bug: 983299 Change-Id: I2523ee9794a24bd1ffa320b04ff7941842781969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545735Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829279}
-
Henrik Boström authored
This is part of investigating https://crbug.com/1148964. It may or may not cause Canary crashes again. We are monitoring crashes. TBR=handellm@google.com Bug: chromium:1148964 Change-Id: I5e778cd024f126811319ba750cb46adbdf3ce090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550206Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#829278}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3a578ae35233..16973d613fed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I23624f575a9bfbcf6251d66dad0a52586f034abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550361Reviewed-by:
-
Ryan Daum authored
When obtaining initial focus when a webview becomes visible, ensure that the contained web contents within a webview are valid before attempting to focus it. Bug: internal b/173633818 Test: manual Change-Id: I7abec0ca2ccf4d4a804fbafc3c630d0def7ce242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550161 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#829276}
-
Robert Sesek authored
Bug: 417532 Change-Id: Ie5973223b6f4434bb141e1d7f9e77d9a4f9704b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548342Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#829275}
-
Dave Tapuska authored
Use a common implementation in WebViewImpl for adjusting the page focus inside a local root. BUG=1097816 Change-Id: Ife309e622a301c1790f098b73166582593777137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543834Reviewed-by:
-
Gang Wu authored
Bug: 1150497 Change-Id: I792c7831f860211a11dd548a04bd7f7ff5dce094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548265Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829273}
-
Benoit Lize authored
There is no reason to use FastMalloc() when PartitionAlloc is malloc(). Aside from increasing memory usage and heap fragmentation, this reduces the number of pointers allocated out of the GigaCage, which matters for CheckedPtr. To address that, make USING_FAST_MALLOC() a no-op in this case, and redirect the remaining callers of FastMalloc() to malloc(). Bug: 998048 Change-Id: I3bd04570cabc7c8e9d36908013bb1c82a65acddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310334 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#829272}
-
Martin Kreichgauer authored
This replaces the bits of GetAssertionRequestHandler that request a PIN/UV Auth Token by calling out to AuthTokenRequester instead. See CL:2469445 for the equivalent CL for MakeCredential. Bug: 1139111 Change-Id: I1669258ffabc679a5b6d0592ed14fbdaa710dc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536930Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829271}
-
ckitagawa authored
The capture experiment was removed in: https://chromium-review.googlesource.com/c/chromium/src/+/2299184 However, some histogram deletions were missed. This CL makes those histograms obsolete. Bug: 1147100 Change-Id: Ie6d5f5d917ac1d7f14302648bbbc279ac745f263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544046Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#829270}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/060020166679..de9e649438ed 2020-11-19 capn@google.com Fix GN build for aarch64 2020-11-19 zzyiwei@google.com AHB: minor clean up to avoid build failures on different platforms 2020-11-19 capn@google.com Add GN builds for Reactor unit tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie91c87ffd94b4b2af5771df9e66b4ec29e0f1db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550241Reviewed-by:
-
Illia Klimov authored
This reverts commit 444c343b. Reason for revert: Flash is deprecated and should be removed. Original change's description: > Discard wildcard patterns for plugin enterprise policies > > This CL adds the possibility to throw away patterns with wildcards > defined in the enterprise policies for a content settings > > Bug: 1073883 > Change-Id: I99f2d742289e77f1d00081a7cf186d4b21a91f1f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207159 > Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770598} TBR=engedy@chromium.org,ravjit@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1149318 Change-Id: I1cc4691f41e5149a6419c94be756f681dcf9add9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537842Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#829268}
-
Rayan Kanso authored
The crash report seems to imply that this can be null, although I'm still unsure when that would happen. Bug: 1150628, 1143619 Change-Id: Ifceb52846deaab48ec749ee11992b3c586ecbcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550182 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#829267}
-
Leonid Baraz authored
The purpose is to make max_total_files_size, max_total_memory_size, single_file_size and max_record common parameters for all queues, and have them available in StorageQueue. The next step would be to manage queues based on them. Also, parameterize StorageTest (like StorageQueueTest was). Bug:b:157943192 Bug:b:159361496 Change-Id: I073ba6f3a4d3dd4e9c92ef263a3f569a9343c3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548101Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#829266}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fa9411e0a242..f577788041b6 2020-11-19 mmortensen@google.com Port FindSymbolFiles from scripts/upload_symbols.py, refactor for BuildAPI. 2020-11-19 vapier@chromium.org simplify gitiles links 2020-11-19 engeg@google.com api.payload: Add dlc support to api 2020-11-18 kimjae@chromium.org dlc_lib: Sort global variable names 2020-11-18 navil@google.com dependency: Only return changed packages. 2020-11-18 saklein@chromium.org scripts/OWNERS: Add autotest_quickmerge OWNERS. 2020-11-18 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I7c8533dcb563beedcdb1cbe2208ad941ebbca111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550166Reviewed-by:
-
Amr Aboelkher authored
policy namespace Accessing the PSM UMA constants will be useful to be used in its corresponding testing file, instead of using a literal strings. As PrivateSetMembershipStatus is being used twice, once as the expected status of the request in AutoEnrollmentClientImpl, and another usage to indicate whether PSM is enabled or not in the test file. Thus, the one inside the test file has been renamed. BUG=chromium:1150248 Change-Id: I31944094c63e505592197400d3a8d63a3db3e852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545387 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Auto-Submit: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#829264}
-
Adam Langley authored
I tightened up a lot of visibility in f50ddd34 but, while this class isn't used directly from outside of the package, the Android system uses reflection in ways that require it to be public. BUG=1002262 Change-Id: Ie2c921e465e89de4f6ff650a240c0bebe799737c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548384 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829263}
-
