- 03 Dec, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I776061a12b4c2bc3501fdee6350c06fa58d64059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569344Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833232}
-
Christoph Schwering authored
Bug: 1121990 Change-Id: I6ce17cc938c1c62b53e647058c086d818322f64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569666Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#833231}
-
Alexander Hendrich authored
The increased task priority was added to improve login screen extension's start-up time. However, login screen extensions use a different caching mechanism now (see crbug.com/1012892) so this increased task priority is no longer needed. This CL is basically a revert of https://crrev.com/c/1670898. With that task priority change we can also get rid of the added ProfileHelper::SigninProfileHasLoginScreenExtensions() method. Bug: 1012892, 1030291 Change-Id: I31f7b89b6aa2badd125691417def18b4291c6c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562145Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#833230}
-
Alice Wang authored
This CL moves ProfileDownloader to signin.services target. Bug: 1153048 Change-Id: I124b84b3c6331ec8871a9b2f6f4a5090fbcef528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567223 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#833229}
-
Daniel Libby authored
For composited selection to work in CAP, we'll need to record the start and end of the selection at paint time. To facilitate this, we'll need to know whether the selection rect we compute in order to paint the selection background contains the start/end of the frame's selection. This CL adds a way to query this information for a given cursor position which will be consumed at paint time. There is a mechanism to understand the selection state relative to a layout object, which we use to determine which offsets are valid for comparison. The state returned will inform the caller of the intersection of the frame's selection. Bug: 1065049 Change-Id: I217f9e8859b0790543285ddd5de100adba1e5ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567021 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#833228}
-
Alice Wang authored
This CL moves DisplayableProfileData to signin.services target. Bug: 1153047 Change-Id: If992b97b7373e4d0e55e2aa10e9793479bf326f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567916Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833227}
-
Heng-Ruey Hsu authored
Presubmit add a check for TimeDelta and TimeTicks. Bug: b:174443814 Test: Build pass Change-Id: Ice363456eb2207945d0eb3a27668a9a862b04053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557124 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#833226}
-
Shik Chen authored
Bug: b/172340451 Test: Manually with tsc and open CCA Change-Id: I7ded3f05c0f416e498bed3de35038494c851ff70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569565Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#833225}
-
Titouan Rigoudy authored
This extracts the computation of the response's address space to live next to its close cousin, CalculateClientAddressSpace(). This helps ensure that the two will co-evolve in the future. In particular, we will probably want to treat more schemes than `file:` as local by default (looking at you, `chrome-extension:`...). Bug: chromium:955213 Change-Id: Ic4794cc115b35e28702ff9e7a92e1df92ee0782a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461273 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833224}
-
Peter E Conn authored
Change-Id: I5dc70d6a7cfa877f8c402339979d5143759e69c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556643Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#833223}
-
Norman Rosas authored
also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I6c2e03dc11f647717a08baf2c4825774c1499eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569814 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#833222}
-
Thanh Nguyen authored
Add search metrics reporter for the new sandboxed Index. The logic is similar to what we have done with IndexSync. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I4f54cf8eaa0f0f54db0e64b71749ea87c860d26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569563Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833221}
-
Philip Jägenstedt authored
Bug: 1155036, 1154650 Change-Id: I612c1219698ae4602e213d894cad7f705c7ce4dc No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568287 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#833220}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bdcd87cfa31e..d4be156e9f6d 2020-12-03 michael.liao@microsoft.com [e2e]: Stabilizing Font Editor e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154489 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2db4ae8d10bab447b0a2bdef22cb147367dee446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833219}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ibb2d9bdc15b0292d841273faa57719ade9b27a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570250Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833218}
-
Stephen Chenney authored
We were checking for the existence of p3 then using p4. Bug: 1150401 Change-Id: Ib7be08cd86f8962399c051b96ac837cda7934d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570128 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#833217}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ice6da20dbccc5a010b315f420e730959536a0302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569347Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833216}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff0c8040cec4..8e7d45601101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I920c3ddcdd44968e30f78a88e08f580b325a917b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569348Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833215}
-
Ramin Halavati authored
ProfileImpl::SetCorsOriginAccessListForOrigin is updated to cover all off-the-record profiles. Bug: 1060940 Change-Id: I70c6a5b80b9d15d1bdbf11a59ee18c42cafb6108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564761Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#833214}
-
Illia Klimov authored
This CL obsoletes deprecated Flash histogram. Bug: 1153735 Change-Id: I2bef66b742305ef7ed3783110ee9ac9d62925773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568281Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#833213}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606942778-d5d5cc9b57e062a2c1a80c892b64ebbae55abc2c.profdata to chrome-win64-master-1606953494-c677054002543491cd062484a79764b665817c55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icaba1d4bee04bed217362ce5919fe7420a506f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570557Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833212}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606953494-1095cc05af875eadbe87fc6109d3867a4076cbf5.profdata to chrome-mac-master-1606975184-196f68b969b73bc3452eae4d054586312080107c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If5d9ac7fd8b9aad6680c404e18b32375ef1dc7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833211}
-
Sophey Dong authored
Bug: 1135311 Change-Id: I6a19811ebd86128ded2a6375313d38c55bc773d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561701Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833210}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I66a64a3052b532cad518799af7305d9795154590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569342Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833209}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606953494-bd74c7c56f61c746e2347181ab9ffd8bac2372a6.profdata to chrome-linux-master-1606975184-aefe3d214a47b5e57d9dcedd54737f7057f97fb8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I43934b080af9ec3390a5447e2eb546c0fe6dcfb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833208}
-
sandromaggi authored
This hopefully makes the test more stable on slower devices. There is a small delay when coming back from to the tab. The BottomSheet is in SCROLLING state and we don't show the Scrim until the state has settled on FULL. Bug: b/174133097 Change-Id: I5016b64defa5119a411a1a4494ab92d850381359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570367Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#833207}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I049d4350c594b8383a311de25dc7aa005418b13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570740Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833206}
-
Marc Treib authored
ClearPrimaryAccount is somewhat misnamed: It doesn't actually remove the account, it only clears the sync-consented bit, so the account will change from ConsentLevel::kSync to ConsentLevel::kNotRequired. If the primary account doesn't have sync consent to begin with (i.e. it's a Sync-the-transport user), then ClearPrimaryAccount should be a no-op. However, currently it still records metrics, and it notifies identity observers (even though nothing actually changed). This CL is a quick-fix for that issue, until ClearPrimaryAccount is actually fixed/redesigned. Bug: 1155042 Change-Id: Icc711cbd8eb118fd3d1b2ff28b2f74df4d8cde65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566947 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#833205}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/417f359d..2c039921 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia3d21d830900ba5dfb45093eda420c981f8159b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570855Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833204}
-
chrome://syncfs-internalsdpapad authored
Bug: 1154192 Change-Id: I9e2ac2b6554cf800b600524db03b07c0daa10f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569096 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#833203}
-
Ewann authored
This CL updates the icon size and padding from Settings. Bug: 922511 Change-Id: Ia72ccb117bd3b6312698b572dbabe731ce6bab5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567212Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#833202}
-
Nektarios Paisios authored
This patch is a followup to https://crrev.com/c/2435645 Previously, we were only considering a View to be ignored in the accessibility tree if the View had been explicitly marked as such via ViewAccessibility::OverrideIsIgnored. However, other factors, such as the View's accessibility role and its ignored state, which could also be set programmatically, should be taken into account. Also, ensures that only the ignored state is set when a ViewAccessibility is ignored, so that role information will not be lost when logging the internal accessibility tree, which was making debugging such errors hard. Using the correct role would also enable a smooth transition to AXTree for Views, since Blink only uses the ignored state to indicate that a node should not be visible to platform APIs. AX-Relnotes: NVDA now reads all menu items with the "read line" command, including menu items that contain an extra icon. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I61e4be68921f34a26f00da8f66e17475eed2c4ee Bug: 1098528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553003 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833201}
-
Polina Bondarenko authored
Extend ArcDataSnapshotdClient with the next methods: * ClearSnapshot * TakeSnapshot * LoadSnapshot * Update TEST=components_unittests BUG=b:161221001 Change-Id: I0ee05adb416919eb4cc415bbd2ddc2f191447f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548627 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833200}
-
Bao-Duy Tran authored
Almost all of input_methods.txt is obsolete; it's on track for complete deprecation and hopefully removal. It's a remnant from before the migration to extension-based input methods, approx 9 years ago. This CL clarifies exactly what's still being read [1] from this legacy config file by trimming the script that autogens C++ from it for use by Chrome-on-CrOS, and updating comments in input_methods.txt itself. The file unfortunately has to remain as-is for a bit longer because other systems may still be reading it, likely incorrectly, from the copy shipped in CrOS install image. However, the clarifications here should at least help avoid further inadvertent misinterpretation. Nowadays, the canonical configs for 1P input methods on CrOS is google_xkb_manifest.json [2], not this input_methods.txt. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/component_extension_ime_manager_delegate_impl.cc;l=167;drc=0f697af9f4e6e3667b32735ddd133177fb5862dd [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json;drc=03ae97c2c311ac00d3e9a59203f4921c9e87e707 Bug: 1134526 Change-Id: I4e2a44c9286d40ee6802f178a11d4d4ec9f4d6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569231Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#833199}
-
Jasmine Chen authored
Authenticates the token for RegisterServerWithToken. Should be submitted after the prior CL crrev.com/c/2534552 is upreved. - Build and deploy simple; Verify server is authenticated. - Intentionally fail authentication and verify server is not crashed. - capture_unittests --gtest_filter='*CameraHalDispatcherImplTest*' Bug: b/170075468 Test: With the following Change-Id: I37b47137814a18d2dc72f3156b19f065c2822d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537455Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#833198}
-
hscham authored
This is used (via libchrome) in Chrome OS programs which uses -Wc++11-narrowing. BUG=chromium:1144735 TEST=autoninja -C out/Default chrome Change-Id: Ib5ce7d8d88376fda2c8829794499e767f16ec26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568915Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Grace Cham <hscham@chromium.org> Cr-Commit-Position: refs/heads/master@{#833197}
-
Hirokazu Honda authored
As well as GpuArcVideoDecodeAccelerator does, this CL makes GpuArcVideoEncodeAccelerator::Initialize() return Insufficient resources error if too many ARC++ encoders are created. Bug: b:168422427 Test: android.media.cts.MediaCodecCapabilitiesTest#testGetMaxSupportedInstances on elm-kernelnext Change-Id: Iba2abbc0d1e140997781e3bb55e4ea0ac8427443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569137 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#833196}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/27c78da79fce..9f3f2c24ae44 2020-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0f083ab02635 to 8670d6183a84 (11 revisions) 2020-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bfb211914759 to bae138de13ac (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I5aa741017f986429d7629c7f759311b58e2fdc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570023Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833195}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I28a20da5a0b77f29811f8ecaaf62a212f3e5385f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570712 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833194}
-
Ricky Liang authored
We need the flag for a few more milestones on Chrome OS for testing and development. Bug: b:172343868 Change-Id: I3ff3e6db5939b89ef1e64cc447edb2cd55a532b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569496 Commit-Queue: Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#833193}
-