Commits · 09665d8240f02c7f32c1996a49b8006740821101 · eriksson monteiro / tangled

08 Aug, 2019 40 commits

Roll src/third_party/catapult 5508416f1958..bca4ad25f4fd (1 commits) · 09665d82

chromium-autoroll authored Aug 08, 2019

https://chromium.googlesource.com/catapult.git/+log/5508416f1958..bca4ad25f4fd

git log 5508416f1958..bca4ad25f4fd --date=short --no-merges --format='%ad %ae %s'
2019-08-08 perezju@chromium.org [Telemetry] Do not depend on sys.argv to sniff benchmark name

Created with:
gclient setdep -r src/third_party/catapult@bca4ad25f4fd

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:985712
Change-Id: I7312d37dd2f523d615caf2f5bd645bcc54396a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743815Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685162}

09665d82

[WebSocket] Use Datapipe to transfer DataFrame buffer instead of ReadOnlyBuffer · 1007403a

Yoichi Osato authored Aug 08, 2019

This CL introduces mojo DataPipe instead of ReadOnlyBuffer.
With DataPipe, we can reduce memory copy and optimize quota control.

Unfortunately, this CL makes performance slower:
ToT:   147 MB/s
Patch: 128 MB/s
That's because this CL replaces minimize part and we will do
the optimization later on.
If the optimization doesn't go over the original score before
M78 (will be branch cut on Sep 5th), we will revert this change.

Bug: 865001
Change-Id: I28613817e3104af7ca9e347a6a906ee8eaed2dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738011
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685161}

1007403a

[AF] Remove dead AutofillSettingsCardTypeSplit flag · e96e385a

Jared Saul authored Aug 08, 2019

Bug: 917396
Change-Id: I34e93f410c4587944114269eaca5ab661423037f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743268
Commit-Queue: sebsg <sebsg@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685160}

e96e385a

extensions/browser/api: Always specify thread affinity when posting tasks · 94045959

Sami Kyostila authored Aug 08, 2019

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 968047
Change-Id: Iffc349a1cfd3e51e254ae784fbe53f2d62a04b3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729211
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685159}

94045959

Import wpt@0d4300c5045a5587c2eb3d1416b11ffeecf5dadc · 692df613

Chromium WPT Sync authored Aug 08, 2019

Using wpt-import in Chromium 2f821af7.
With Chromium commits locally applied on WPT:
329c91e5 "Attempt to make test more stable"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org:
  external/wpt/css/css-text-decor

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Icecc8279870f0fd2a31b8f3e5cdd9d2037d067ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744046Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685158}

692df613

chrome/browser/themes: Always specify thread affinity when posting tasks · 32f67d8a

Sami Kyostila authored Aug 08, 2019

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=pkotwicz@chromium.org

Bug: 968047
Change-Id: Ib0211043f7ac0fdd8b56f6562bcb9880f3e602c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739946
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685157}

32f67d8a

chrome/browser/win: Always specify thread affinity when posting tasks · a49857b4

Sami Kyostila authored Aug 08, 2019

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=pmonette@chromium.org

Bug: 968047
Change-Id: I1bf55db696228a2248ade20a142b5c3015ba8da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739889Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685156}

a49857b4

Roll src-internal 619e49fa7df7..98b6993915c3 (1 commits) · 699d44e8

chromium-internal-autoroll authored Aug 08, 2019

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/619e49fa7df7..98b6993915c3

Created with:
gclient setdep -r src-internal@98b6993915c3

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I61001531bbf7f69fb5fd4bd25e654cc5f0356d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743813Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685155}

699d44e8

Roll src/third_party/angle 0fec5eabc671..7270a6d578f5 (1 commits) · 7ad14d7f

chromium-autoroll authored Aug 08, 2019

https://chromium.googlesource.com/angle/angle.git/+log/0fec5eabc671..7270a6d578f5

git log 0fec5eabc671..7270a6d578f5 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 kkinnunen@nvidia.com Fix ShaderStorageBufferTest31.LoadAndStoreBooleanVarAndArray to be more correct

Created with:
gclient setdep -r src/third_party/angle@7270a6d578f5

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Bug: None
Change-Id: I5f199e7aa3f7381633a504bdb0ef13363100f5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743814Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685154}

7ad14d7f

Put Chrome installer logs into isolated outdir on test failure. · 01c7a28b

Greg Thompson authored Aug 08, 2019

This will help in diagnosing failures that deposit error messages in the
installer's log file.

BUG=907979

Change-Id: Ib9ddf7d120ab4f29b33cce4d64f866e071dca362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744146
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685153}

01c7a28b

[DevTools] Do not debug worker shadow pages · 5dc1be4c

Joey Arhar authored Aug 08, 2019

This change breaks pausing on start when inspecting a shared worker that
gets reloaded. More detail here: crbug.com/987024

Bug: 882467
Change-Id: I074b547996fd7f11d835fcebfdae32a4f7063a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636110
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685152}

5dc1be4c

Convert AccountTrackerService to new convention for JNI · ecfbe86e

Sylvain Defresne authored Aug 08, 2019

The convention to call native methods from Java has been changed
(see //base/android/jni_generator/README.md). Convert the methods
in AccountTrackerService.java to the new convention.

Bug: 934688
Change-Id: I0075a76653f71a40ae79140b20b425af959f29de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741819Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685151}

ecfbe86e

Remove DCHECK which can fire spuriously in a race. · ffaa9ab0

W. James MacLean authored Aug 08, 2019

It seems we may be hitting a race condition where (1) a BrowserPlugin
is created in a mainframe, but (2) before the browser knows about the
BrowserPlugin it routes an event to a main frame that ends up
targeting the newly created BrowserPlugin. In this scenario the
HandleInput function will correctly return kNotHandled, but the DCHECK
firing really doesn't indicate a problem.

Since BrowserPlugin will go away soon, let's just remove this DCHECK.

Bug: 985944
Change-Id: I6fcaf54a2cecdcc4a53c79cbc7fa260bf6697c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742368Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685150}

ffaa9ab0

Use PrimaryAccountMutator in SigninManagerAndroid · 498f5876

Pâris MEULEMAN authored Aug 08, 2019

Use the public API of IdentityManager, PrimaryAccountMutator, to set the
primary account instead of using IdentityManager's internals
(PrimaryAccountManager).

PrimaryAccountMutatorImpl::SetPrimaryAccount calls PrimaryAccountManager::Signin, with added pre-conditions:
- Preferences allow the signin
- There is no primary account already set (IsAuthenticated)
- AccountTrackerService knows about the account, and it has both a
valid account_id and email.
If those are not met, SetPrimaryAccount does not call PrimaryAccountManager::SignIn and returns false.

In practice, those are already met or were already required:
- Most of SignIn calls do check the preferences beforehand. Two
exceptions: Re-authentication cases (SyncAndServicesPreferences, SignInHelper), SigninFragment.
- PrimaryAccountManager::Signin and
PrimaryAccountManager::SetAuthenticatedAccountId also verify that.
If the user is authenticated, the signin is not completed, no
notifications are sent. A slight behavior change could happen here
though: a DCHECK verifies that the same user is re-authenticating.
- PrimaryAccountManager::SignIn also needs AccountTrackerService to be
properly initialized with the account.

Bug: 987965
Change-Id: I70f30bcf3536a79bb5983333233c59aeb5b8a5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738696
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685149}

498f5876

[ozone/wayland] Do not use possibly blocking dispatch API · 87b0923f

Maksim Sisov authored Aug 08, 2019

Using wl_display_dispatch is a wrong thing to do as it is a blocking
method (see [1]). It can cause freezes and deadlocks.

Instead, we need to do something like this -

while (wl_display_prepare_read_queue(display, queue) != 0)
        wl_display_dispatch_queue_pending(display, queue);
wl_display_flush(display);

ret = poll(fds, nfds, -1);
if (has_error(ret))
        wl_display_cancel_read(display);
else
        wl_display_read_events(display);

wl_display_dispatch_queue_pending(display, queue);

However, there is no need to do a second poll as long
as we are notified by libevent that the display fd is
non-blocking. However, to ensure we can read, we have
to prepare the queue, which tells other clients we
are going to read from the queue. If prepare fails,
it means there is nothing to read. Thus, we push
the events into the queue and return early instead.

We have also to add an "automatic" flush as part
of the polling mechanism. This poll must ensure
that all the data has been written to the queue.
If not, -1 is returned and EAGAIN is set. In this
case, we have to stop watching the fd for read
access and start watching it for the write access.

As soon as all the data is written, we can get
back to reading.

[1] https://people.freedesktop.org/~whot/wayland-doxygen/wayland/Client/classwl__display.html#a30a9c4f020f3e77581c7a81ecdb4913d

Bug: 987821
Change-Id: I536513034c18a47da079a2b56a75d32f20f72ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730159Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#685148}

87b0923f

[MFill Android] Use network origin to set fallback sheet card icons · 8b6fe13d

Friedrich Horschig authored Aug 08, 2019

This CL maps the origin of a credit card to its icon. The used icons
still have the gray borders but they will be replaced with the
borderless version in https://crrev.com/c/1730916

(The "title" in UserInfo was renamed to "origin" to be consistent
with the native side and because it reflects what it actually means)

Bug: 985318, 969708
Change-Id: I9a54b26a2a7c52f0c4413c95b4a25f46c81a81d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736683Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685147}

8b6fe13d

[Signin][Android] Remove unused SigninManager.sTestingSigninManager · c095d3f2

Boris Sazonov authored Aug 08, 2019

Bug: None
Change-Id: I228d535628657ac81248b44748c3534bb181dc4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741912
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685146}

c095d3f2

Roll src/third_party/catapult 0bbcb5b8e80b..5508416f1958 (1 commits) · 4d45cfb3

chromium-autoroll authored Aug 08, 2019

https://chromium.googlesource.com/catapult.git/+log/0bbcb5b8e80b..5508416f1958

git log 0bbcb5b8e80b..5508416f1958 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 perezju@chromium.org [Telemetry] Add artifacts to intermediate results

Created with:
gclient setdep -r src/third_party/catapult@5508416f1958

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Bug: chromium:966835
Change-Id: I7cd7bfb8dbfb013eb91bc45cfb370a2cac29cebb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743811Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685145}

4d45cfb3

Add scrypt hashing function for username and password. · 084c9c7b

Vasilii Sukhanov authored Aug 08, 2019

Bug: 986298
Change-Id: I2831e5c0d1cb1f2d69a85f6b32057d9359706664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742173
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685144}

084c9c7b

[ozone/wayland] Stop using wl_display_roundtrip · c3469b5b

Maksim Sisov authored Aug 08, 2019

According to the Wayland documentation, wl_display_roundtrip is a
blocking call that can block if the event queue is empty. That is,
to be able to process buffer swap requests synchronously,
that call blocks until a frame callback comes or a wl_buffer
is attached. This results in blocking the CrBrowserMain thread.

This change alters the logic so that the buffer manager processes
one pending buffer at a time asynchronously avoiding blocking
the thread if synchronous processing is not possible due to
two conditions:
1) a frame callback is not received,
2) a wl_frame buffer is not created.

That is, on a frame no 1, the manager does not have a
frame callback installed and it may not process the buffer
synchronously if a wl_buffer is not created.
(note that wl_buffers can be created synchronously or asynchronously
depending on the protocol version of the zwp_linux_dmabuf[1]).
If such condition satisfies (there is no wl_buffer created), that
buffer is stored as a pending one and is processed on a
AttachWlBuffer call. Otherwise, the manager just processes
the buffer swap for the frame no 1 synchronously.

On frames no 2 and onwards, the manager may not process
buffer swaps synchronously if a frame callback is set, but not
received. That is, whenever the manager attaches
buffers to surfaces and commits them, it sets frame callbacks,
which Wayland compositor runs whenever it is time to send next
frame. If such condition satisfies, the manager stores the buffer
and processes it on next OnFrameCallback call. Otherwise, the swap
request processed synchronously.

[1] https://cs.chromium.org/chromium/src/ui/ozone/platform/wayland/host/wayland_zwp_linux_dmabuf.cc?g=0&l=67

Bug: 987821
Test: WaylandBufferManagerTest.TestCommitBufferConditions
Change-Id: I153b2071a453856a40e23a7f0a15f61dbc01d27f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726051Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#685143}

c3469b5b

Add some UMA stats to in_session_password_change_manager · 7929307d

A Olsen authored Aug 08, 2019

Bug: 930109
Change-Id: I142b1754a8fc3fa52d0d9c1994da513c01c6ff67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730162
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685142}

7929307d

Add ARIA role, state and properties to ElementInternals · 7311f5fc

Rakina Zata Amni authored Aug 08, 2019

Adds a way to set default ARIA role, state & properties for custom
elements through ElementInternals. These can be overridden with setting
the ARIA attributes on the element directly.

See https://github.com/whatwg/html/pull/4658 for spec PR.
Explainer: https://github.com/alice/aom/blob/gh-pages/explainer.md#per-instance-dynamic-semantics-via-the-elementinternals-object
Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/b-cGz9c67pM/0zvBzjhrAAAJ

Change-Id: I0caf6bc302445e48f4e0324513105eba3d6303a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709950
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685141}

7311f5fc

Roll src-internal 078bbedbb93b..619e49fa7df7 (2 commits) · 8109c669

chromium-internal-autoroll authored Aug 08, 2019

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/078bbedbb93b..619e49fa7df7

Created with:
gclient setdep -r src-internal@619e49fa7df7

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: Ia863298faa608cec00a7cb8c07868c33a677faee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743807Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685140}

8109c669

Update V8 to version 7.8.68. · b7d6e044

v8-ci-autoroll-builder authored Aug 08, 2019

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d795c6cc..a062e707

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie2c9f7a01d8bef81d463ea880e844a3eb6324e26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743577Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685139}

b7d6e044

Roll src/third_party/perfetto be9d120c47f7..6e0df67d958d (2 commits) · ae119cec

chromium-autoroll authored Aug 08, 2019

https://android.googlesource.com/platform/external/perfetto.git/+log/be9d120c47f7..6e0df67d958d

git log be9d120c47f7..6e0df67d958d --date=short --no-merges --format='%ad %ae %s'
2019-08-08 khokhlov@google.com Merge "Trace processor: Parse Chrome metadata"
2019-08-08 primiano@google.com Merge "Add log when producer and service flags mismatch"

Created with:
gclient setdep -r src/third_party/perfetto@6e0df67d958d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Iddbbef4db863172bd4768b582c0ab0fe507555ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743810Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685138}

ae119cec

BundledExchanges: defines and uses net::ERR_INVALID_BUNDLED_EXCHANGES · 8179a838

Takashi Toyoshima authored Aug 08, 2019

To represent an error occurred during BundledExchanges source parsing,
this patch introduces net::ERR_INVALID_BUNDLED_EXCHANGES error code,
and uses it when such errors occur.

Bug: 966753
Change-Id: Iea3c5c6a2cd3aa651c70765731477d19669fc3f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736349
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685137}

8179a838

Add credit card mediator unit test · a64e0229

redatawfik authored Aug 08, 2019

Bug: 984545
Change-Id: I96398bef9578b1652e63b077dec081a1b97b454c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741910Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Reda Tawfik <redatawfik@google.com>
Cr-Commit-Position: refs/heads/master@{#685136}

a64e0229

Remove checks from certificates handler · dd56e193

Michael Ershov authored Aug 08, 2019

This is follow up CL:1718364.
It was decided to remove these checks because
it's not very difficult for users to trigger them.

Scenario:
user: open certificate manager page;
admin: disallow editing certificates;
user: fetch policies without updating the page;
user: try to edit certificates.

Bug: 958455
Change-Id: I0a773ab83f612cca5200347a992686df55808937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735374Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Michael Ershov <miersh@google.com>
Cr-Commit-Position: refs/heads/master@{#685135}

dd56e193

Roll src/third_party/SPIRV-Tools/src 698b56a8f024..b029d3697ea3 (2 commits) · a8dc5219

chromium-autoroll authored Aug 08, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/698b56a8f024..b029d3697ea3

git log 698b56a8f024..b029d3697ea3 --date=short --no-merges --format='%ad %ae %s'
2019-08-07 stevenperron@google.com Handle RelaxedPrecision in SROA (#2788)
2019-08-07 zoddicus@users.noreply.github.com Add -fextra-semi to Clang builds (#2787)

Created with:
gclient setdep -r src/third_party/SPIRV-Tools/src@b029d3697ea3

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
TBR=radial-bots+chrome-roll@google.com,ynovikov@chromium.org

Bug: None
Change-Id: I0f80a963d9d766e61590dc75b9cdd547ebe23e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742402Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685134}

a8dc5219

Disable webtests in concurrent marking trybot · 62021a1a

Omer Katz authored Aug 08, 2019

Bug: 989278
Change-Id: I15fda92005fe9f77171ace913f161054b4a4fc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741668Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685133}

62021a1a

Roll src/third_party/angle 7424fe8b79c3..0fec5eabc671 (1 commits) · 895f65d9

chromium-autoroll authored Aug 08, 2019

https://chromium.googlesource.com/angle/angle.git/+log/7424fe8b79c3..0fec5eabc671

git log 7424fe8b79c3..0fec5eabc671 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 698b56a8f024..b029d3697ea3 (2 commits)

Created with:
gclient setdep -r src/third_party/angle@0fec5eabc671

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Bug: chromium:None
Change-Id: Id8b7c69c559e8e663ee2fb97716d7b48568eaed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742403Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685132}

895f65d9

BundledExchangesParser: Add support for critical and manifest section · 2f821af7

Kunihiko Sakamoto authored Aug 08, 2019

Before this patch, BundledExchangesParser only looked at the "index"
section when parsing the bundle's metadata.

This patch adds support for:

- "critical" section whose value is an array of string. If the bundle
  contains sections marked as critical but unknown to the parser, the
  parser will fail.
- "manifest" section whose content is a string representing the bundle's
  manifest URL. This is a required section; the parser will fail if the
  manifest section is absent.

Bug: 969596
Change-Id: I9fce8e795196215036b69815be955e124bd57be3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735569
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685131}

2f821af7

[Extensions] Add chrome.loginScreenStorage API · 61a11d2c

Zakhar Voit authored Aug 08, 2019

This CL introduces new extensions API that allows white-listed login
screen extensions to store persistent data accessible from login
screen and inject short-lived data into the user session (using
ChromeOS session manager daemon). See API proposal for more details.

Bug: 980171
Change-Id: I5b07311dbcba0e7be711457553cf85ded7443fd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611994
Commit-Queue: Zakhar Voit <voit@google.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685130}

61a11d2c

Roll Fuchsia SDK from 890574089166 to 890571594499 · e46dd10f

chromium-autoroll authored Aug 08, 2019

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Idced05c56a5a595703c9b14958888ba0ad276ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742404Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685129}

e46dd10f

Use new downcast helper for blink::HTMLFrameElement · 75391e2f

Abhijeet Kandalkar authored Aug 08, 2019

This CL has two goals,
1. Use To<HTMLFrameElement> and DynamicTo<HTMLFrameElement> as new
   downcast helper.
2. Use IsA<HTMLFrameElement>(element) in place of
   IsHTMLFrameElement(element)

Bug: 891908
Change-Id: Id895e0cf6c250307fca10a2bf4b40228b98ba889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741444
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685128}

75391e2f

[v8][layout-tests] remove gtest specification from {V8 Blink Win} · 08b5ec3f

Tamer Tas authored Aug 08, 2019

This CL removes the gtest_test specification to fix the crashes in
https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Win/10

R=machenbach@chromium.org

Bug: chromium:883629
No-Try: True
Change-Id: Ifa84c72601ddabda11cc186784eb25a47cfbbdd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741984
Auto-Submit: Tamer Tas <tmrts@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Tamer Tas <tmrts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685127}

08b5ec3f

[v8][layout-tests] define src-side builder for {V8-Blink Linux 64 Future} · 1a4977ac

Tamer Tas authored Aug 08, 2019

Layout tests future bot tests future JS features.

{blink_downstream} passes "--js-flags=--future" to enable JS features.

This CL creates src-side configurations for migrating the future bot to
{chromium_integration}.

We use the same mechanism used by the other bots linked here:
https://cs.chromium.org/chromium/src/testing/buildbot/test_suite_exceptions.pyl?l=1828&rcl=c172cf6fe19e46587c3be9a1009615a197a23b93

R=machenbach@chromium.org

Bug: chromium:883629
No-Try: True
Change-Id: Ie6e9dd68544fad8a0a6d082fd5e6b58c90656498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743726
Auto-Submit: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Tamer Tas <tmrts@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685126}

1a4977ac

Histograms: Added cros-oac@google as an owner · 0440bcb0

Roman Sorokin authored Aug 08, 2019

Also s/oac-team/cros-oac because the group was renamed.

Bug: none
Change-Id: Ib5602f6f1cdbcedec49569b13462d462db7c75c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738695Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685125}

0440bcb0

media/gpu/test: Add new video decoder 'DestroyBeforeInitialize' test. · 2c94f696

David Staessens authored Aug 08, 2019

This CL adds a test to the video_decode_accelerator_tests that verifies whether
it's safe to destroy a video decoder before calling Initialize().

TEST=ran new VD tests on eve

BUG=988929

Change-Id: I413bbf2fb16ed3fd06b959d71e14e7d834dd870a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737072
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685124}

2c94f696

Roll src-internal 142b1fc54cbc..078bbedbb93b (1 commits) · cbb75713

chromium-internal-autoroll authored Aug 08, 2019

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/142b1fc54cbc..078bbedbb93b

Created with:
gclient setdep -r src-internal@078bbedbb93b

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I8c98b7c43d7f11e6b0fb66e05c33d218024ac62f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743587Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685123}

cbb75713