- 04 Oct, 2017 40 commits
-
-
Kent Tamura authored
* make_qualified_names.py: Generates snake_case file names. * code_generator.py: Remove exceptions for HTMLNames.h and SVGNames.h. * MakeQualifedNames.*.tmpl: Renamed to snake_case. * scripts.gni: Follow the *.tmpl change. * other files: Use new names of FooNames.h. Bug: 770603 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I59e0512c5b2d6deffcd84eb9ea33fd47127acd70 Reviewed-on: https://chromium-review.googlesource.com/700236 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#506396}
-
Maks Orlovich authored
This is what it does behind scenes in Chrome anyway, but always using the scheduler in tests as well is helpful since it means a single TaskScheduler::FlushForTesting() call rather than needing both TaskScheduler and SequencedWorkerPool versions of FlushForTesting() as separate calls, which causes trouble when control jumps back and forth between the two. Bug: 766221 Change-Id: Iab6a49cad86f1fd5a31c66c50d25e2962c538d53 Reviewed-on: https://chromium-review.googlesource.com/697925Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#506395}
-
Vladislav Kuzkokov authored
There's currently no reason for this class to exist. Change-Id: Id8a981e37696ceb6c28687f4d894c4278d856997 Reviewed-on: https://chromium-review.googlesource.com/693015Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506394}
-
Justin Okamoto authored
This change allows for Android lint suppression configurations to be defined on a per-target basis (assuming said target is "Android lint capable") rather than having one global config. This will allow embedders to keep upstream's lint config for Chromium targets (w/o patching), while using a separate config for the embedding application. Bug: 737897 Change-Id: Ieccb95767e0ce541522d7a53edbe734c5bbfe6dc Reviewed-on: https://chromium-review.googlesource.com/698297Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#506393}
-
Theresa Wellington authored
Don't show the search provider when there is no half-height sheet state. This captures two scenarios: - Available screen height is less than 320dp - There are no normal tabs currently open BUG=759134 Change-Id: Ib36154b683679ad2084ac23fafe90e61f9b39fd1 Reviewed-on: https://chromium-review.googlesource.com/698349Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#506392}
-
Robert Phillips authored
This guard is required by the upcoming Skia CL https://skia-review.googlesource.com/c/skia/+/55100 (Use SK_DISABLE_DEFERRED_PROXIES to only disable deferred proxies for Chrome) Change-Id: Ib5972340b8db490af913d5d3bf0889fd364e90cc Reviewed-on: https://chromium-review.googlesource.com/700475Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#506391}
-
Fabio Tirelo authored
We may not be seeing as many reboots in the new flow because there is no browser window open when the cleaner finishes. If that's the case, we could add logic to reopen the Settings page when a window pops in the foreground. However, I'd rather make sure this problem exists before adding more logic to an already complex piece of code. Bug: Change-Id: I03deaadcda6e2a85001e360811c3fd53554d71a1 Reviewed-on: https://chromium-review.googlesource.com/692695 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#506390}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=samarth@chromium.org Bug: 666525 Change-Id: Id663ba6297c2513f71343452a1b2f56a1528c17d Reviewed-on: https://chromium-review.googlesource.com/689140Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506389}
-
Patrick Monette authored
This is a lock order violation that happens when the dll notification callback is unregistered while under the ModuleWatcher global lock and a dll notification arrives. Bug: 757398 Change-Id: I914b03409203394d7546f44d11dfd566f87a6cd4 Reviewed-on: https://chromium-review.googlesource.com/697825Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#506388}
-
Alexandr Ilin authored
This CL is a followup of http://crrev.com/c/695305. It adds relevant tests to catch any possible regressions. Bug: 770728 Change-Id: I8e77f1b6d0d8edc78965373da71b37ee764a18ae Reviewed-on: https://chromium-review.googlesource.com/695331Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506387}
-
Andrew Grieve authored
NOTRY=true # Doc change Change-Id: Ib1f0379d78b2c668fa8b9541f0427fb13eab177e Reviewed-on: https://chromium-review.googlesource.com/700478Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506386}
-
James Cook authored
Remove mukai@ from ui/message_center/OWNERS since he no longer works on Chromium. Bug: none Test: none Change-Id: I20c940861a7b6e120e7f7f235cdb0a33623d8b1a Reviewed-on: https://chromium-review.googlesource.com/698264Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#506385}
-
Becca Hughes authored
Official Android builds scrape the build logs looking for "unknown pragma" warnings and then remove any resources that don't have a corresponding warning. This means that the media controls resources were not getting included in Android builds causing a crash. BUG=771507,771513,771512,771397 Change-Id: Icde2be4a881b5e2e06e45a725f6983fe6b280967 Reviewed-on: https://chromium-review.googlesource.com/700495Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#506384}
-
Henrik Boström authored
Changes: https://webrtc.googlesource.com/src.git/+log/a9a2771..83ccca1 $ git log a9a2771..83ccca1 --date=short --no-merges --format=%ad %ae %s 2017-10-04 eladalon@webrtc.org Create and use RtcEventLogOutput for output 2017-10-04 alessiob@webrtc.org Allow horizontal scrolling in the APM-QA HTML reports. 2017-10-04 solenberg@webrtc.org Revert "Reland "Remove WEBRTC_TRACE."" 2017-10-04 solenberg@webrtc.org Reland "Remove WEBRTC_TRACE." 2017-10-03 deadbeef@webrtc.org Removing logging in unit test that was committed accidentally. 2017-10-03 deadbeef@webrtc.org Fixing invalid calls to FindMatchingCodec. 2017-10-03 steveanton@webrtc.org Add GetRemoteAudioSSLCertificate() to PeerConnection 2017-10-03 deadbeef@webrtc.org Revert "Run apprtcmobile_tests on real devices." 2017-10-03 deadbeef@webrtc.org Updating comment in Logging.java. 2017-10-03 buildbot@webrtc.org Roll chromium_revision 26bc519a..c5f8071c (506052:506124) 2017-10-03 bpyoung@google.com Enable uploading vertex array with non-zero stride in Android shader. 2017-10-03 buildbot@webrtc.org Roll chromium_revision efe42588..26bc519a (505994:506052) 2017-10-02 flim@webrtc.org Remove memcheck suppression for TestOpusDtx 2017-10-03 alessiob@webrtc.org APM-QA Test data generation: environmental noise looped. 2017-10-03 danilchap@webrtc.org Fix potentional race in AudioSendStream constructor 2017-10-03 nisse@webrtc.org New method RtpReceiver::GetLatestTimestamps. 2017-10-03 ehmaldonado@webrtc.org Disable win_baremetal. 2017-10-03 eladalon@webrtc.org Remove encoding code from RtcEventLogImpl and use RtcEventLogEncoder instead 2017-10-03 ehmaldonado@webrtc.org Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script." 2017-10-03 eladalon@webrtc.org Create RtcEventLogEncoderLegacy 2017-10-03 solenberg@webrtc.org Revert "Remove WEBRTC_TRACE." 2017-10-03 solenberg@webrtc.org Remove WEBRTC_TRACE. 2017-10-03 ehmaldonado@webrtc.org Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script." 2017-10-03 ehmaldonado@webrtc.org Revert "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script." 2017-10-03 ehmaldonado@webrtc.org Run apprtcmobile_tests on real devices. 2017-10-03 buildbot@webrtc.org Roll chromium_revision 624172f8..efe42588 (505968:505994) 2017-10-03 ehmaldonado@webrtc.org Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script. 2017-10-02 eladalon@webrtc.org Add the internals of RtcEvent's subclasses 2017-10-03 nisse@webrtc.org Revert "Make rtc_base/refcount.h self contained, not including refcountedobject.h." 2017-10-03 nisse@webrtc.org Make rtc_base/refcount.h self contained, not including refcountedobject.h. 2017-09-29 magjed@webrtc.org Move list of supported H264 codecs from InternalEncoderFactory to h264.h 2017-09-25 kthelgason@webrtc.org Remove deprecated mac screencapture code. TBR=hbos@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Bug: Change-Id: I14b7d0cfeaf8522702f163af9cad81b693334fd1 Reviewed-on: https://chromium-review.googlesource.com/700005Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506383}
-
Justin Donnelly authored
This matches the behavior on Android and avoids a DCHECK when calculator matches are produced. It would be better if both platforms used the calculator-specific icon (looks like an equal sign) but that's only available as a vector graphic. If we can get a png or start using vector icons on Android and iOS, we should switch. But for now this is an improvement. Bug: 754221 Change-Id: Ie589349e6507b7e0b21896df07b4354e4bc37714 Reviewed-on: https://chromium-review.googlesource.com/699315Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#506382}
-
Vladislav Kuzkokov authored
Considering that PdfMetafileSkia doesn't make any sanity checks here, creating it from bytes and then pulling those bytes back looks like an overly complicated no-op Change-Id: Ie564453318a606d7f71167d0596d44f2a69f589c Reviewed-on: https://chromium-review.googlesource.com/696202Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506381}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/689bd8a7..b16fa6d2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I1001ee08e2489938e08d4b3ee39f966dcb39e230 Reviewed-on: https://chromium-review.googlesource.com/700397Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506380}
-
stkhapugin@chromium.org authored
This allows instantiating OmniboxPopupViewIOS separately, as opposed to it being a part of OmniboxViewIOS. Bug: Change-Id: I8e26e3d73e4c85b89448c4812eccf3002705a702 Reviewed-on: https://chromium-review.googlesource.com/692015 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#506379}
-
David Bokan authored
I added ASSERTs to this test in r505630 but none of them tripped and the test is still flaky. I've replaced the ASSERTS with a new set. Bug: 769350 Change-Id: Ib4f3819de8e01e346fb1e882fe17b1811e0a30bb Reviewed-on: https://chromium-review.googlesource.com/698266Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506378}
-
Stephen Chenney authored
When a image document is re-parented inside an iframe a race condition exists between the creation of the ImageContentResource and the parsing of the document. ImageDocumentParser::Finish requests the CachedImageSize which accesses a null image pointer inside the image loader. Standard behavior for image resources is that they be cleared upon re-parenting, so enforce that for the ImageContentResource as well. R=hiroshige@chromium.org BUG=765917 Change-Id: I93cea9f3eba879abc66d8b8226c3d56a5e02af1b Reviewed-on: https://chromium-review.googlesource.com/679074Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#506377}
-
Bryan McQuade authored
This change migrates recording of URLs for navigation-based source ids from page_load_metrics to a more general dedicated WebContentsObserver. The WebContentsObserver can be easily reused in both unit tests and browser tests. Bug: 761685 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I3f093dc7e4d2d32c438752371eec5df2e0c58c51 Reviewed-on: https://chromium-review.googlesource.com/648285Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#506376}
-
Philip Jägenstedt authored
See https://github.com/w3c/web-platform-tests/pull/7544. TBR: mkwst@chromium.org Change-Id: I620980cf9f969045fdcc1eecaffbdec6ec607e07 Reviewed-on: https://chromium-review.googlesource.com/696084Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#506375}
-
Christian Dullweber authored
Reloading data when the site data page is visited was added in https://crrev.com/c/607874 but the change got lost in https://crrev.com/c/640152. This CL restores the code to reload cookies. Bug: 752133 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3e1ffa886d52657917ebc43050476c7308234fc6 Reviewed-on: https://chromium-review.googlesource.com/684299 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#506374}
-
Pawel Hajdan, Jr authored
TBR=brettw Bug: none Change-Id: I71fe3a6219a80a900eff82428b507e84b0e4c971 Reviewed-on: https://chromium-review.googlesource.com/700435Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Cr-Commit-Position: refs/heads/master@{#506373}
-
dhausknecht authored
The intent to implement was announced on https://groups.google.com/a/chromium.org/d/topic/blink-dev/mdkHs4jybG4/discussion Bug: 751996 Change-Id: I6938ba02fdefa795d1d8a9e35fd94428f61f54d0 Reviewed-on: https://chromium-review.googlesource.com/680218 Commit-Queue: Daniel Hausknecht <dhausknecht@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#506372}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1e946200. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2549 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Idd2b9ff74ca023fb354b0483945e9aaf5a524420 Reviewed-on: https://chromium-review.googlesource.com/700394 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506371}
-
Becca Hughes authored
Now that MediaControlPainter has been removed we don't need to directly package the images with Chrome (as they are included in the CSS file). This removes the images from being packaged with Chrome. BUG=770756 Change-Id: Ib9dc22c57efe0cef2bb13cd745eaecce7d955c78 Reviewed-on: https://chromium-review.googlesource.com/698084Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#506370}
-
Tatiana Gornak authored
BUG=739343 Change-Id: Id767a406ae5f1971d61f5efcf0149326cd0f4436 Reviewed-on: https://chromium-review.googlesource.com/692375Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#506369}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6758ab1..689bd8a7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ie31a02a69075952ee61af6593016f5eccd9fd6c3 Reviewed-on: https://chromium-review.googlesource.com/700415Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506368}
-
Daniel Bratell authored
"using namespace" in a global scope breaks jumbo builds (and are not allowed in the code style guide). This patch replaces them with explicit namespaces. Bug: 771153 Change-Id: Ic45f740d8081b9f4e531b30ac05f6578a404de11 Reviewed-on: https://chromium-review.googlesource.com/697371 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#506367}
-
John Mellor authored
Lots of code attempts to move url::Origin objects. Unfortunately, whilst Origins had an implicitly-declared copy constructor, they did not have an implicitly-declared move constructor since the user-declared destructor prevents that. Attempting to move Origin objects compiled fine however, since it was just falling through to the copy constructor. This code adds a default move constructor & move assignment operator to Origin and SchemeHostPort, so that they will be moved instead of copied when possible. Existing code should become faster :) (The patch also adds a default copy constructor & copy assignment operator, since otherwise adding the user-defined move constructor would cause the implicit ones to be deleted). Bug: none Change-Id: Ic250f3c8172c75a386294053719cc1ceb82bbdf5 Reviewed-on: https://chromium-review.googlesource.com/692022Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#506366}
-
Greg Kraynov authored
- touchstart_expected_soon - loading_tasks_seems_expensive - timer_tasks_seems_expensive Bug: 765660 Change-Id: I75cf6681410b14b1f378024bd0c568d261ecd3f7 Reviewed-on: https://chromium-review.googlesource.com/698325Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Grigoriy Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506365}
-
Hajime Hoshi authored
V8 tasks like GC are now posted to a loading task queue. This CL introduces V8 task queue at RendererSchedulerImpl and uses it for V8 tasks for better scheduling. Bug: n/a Change-Id: If65ad1b12e59de36a448dddc0da0777d2338b58a Reviewed-on: https://chromium-review.googlesource.com/697485Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#506364}
-
Jochen Eisinger authored
There's no point in protecting against multiple popups in that case.. BUG=762482 R=torne@chromium.org Change-Id: Ic8c953ff5235c5cb32b1db318c3828b86d722a95 Reviewed-on: https://chromium-review.googlesource.com/695543 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#506363}
-
Michael van Ouwerkerk authored
On large phones this works out as 3 lines for the first suggestion, 2 for the second, and 1 for the third. Bug: 761813 Change-Id: Iab852642887c0cff1db47b6f3c563dbcb6e37f91 Reviewed-on: https://chromium-review.googlesource.com/700002Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506362}
-
Daniel Bratell authored
"using namespace" in a global scope breaks jumbo builds (and are not allowed in the code style guide). This patch replaces them with explicit namespaces. Bug: 771153 Change-Id: Iea234b0e02636b198af20b0f2b6ad53e735ebf7b Reviewed-on: https://chromium-review.googlesource.com/697704 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#506361}
-
Rob Percival authored
See https://cs.chromium.org/chromium/src/components/certificate_transparency/single_tree_tracker.cc?l=79&rcl=a2d01bae3fbe6fd4c6433ef1163350d25945b298 Bug: 506227 Change-Id: I77938402209443b3d9386bcadc092e7f28e35df6 Reviewed-on: https://chromium-review.googlesource.com/681855Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#506360}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |SelectWordAroundPosition()| from |WebLocalFrame| class for improving code health. Bug: 657237 Change-Id: I0f49f98fc786ea85e286208dd4942ca6ab7b8882 Reviewed-on: https://chromium-review.googlesource.com/700354Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#506359}
-
Michael van Ouwerkerk authored
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=735556#c31 Bug: 735556 Change-Id: Ied40bede8056b1717bfb404dfca806208ff372e1 Reviewed-on: https://chromium-review.googlesource.com/700003Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506358}
-
Jochen Eisinger authored
The test flakily times out on Win7 (dbg). Attempt to figure out why. BUG=753691 R=mkwst@chromium.org Change-Id: I31440d7ccbde267f30b54584d65c5fa0834c4a31 Reviewed-on: https://chromium-review.googlesource.com/695161Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506357}
-