GitLab

https://chromium.googlesource.com/catapult.git/+log/abea78f985f4..7301d427d5df


git log abea78f985f4..7301d427d5df --date=short --no-merges --format='%ad %ae %s'
2019-06-07 perezju@chromium.org [Telemetry] Drop 'story' argument from results.[Add/Create]Artfifact


Created with:
  gclient setdep -r src/third_party/catapult@7301d427d5df

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:966835
TBR=oysteine@google.com

Change-Id: I53d36b9e23137174289e1d9e131cc1fef61657c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648648Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667143}

https://chromium.googlesource.com/angle/angle.git/+log/ea49f6f5d4e3..b407e1a0b5bf


git log ea49f6f5d4e3..b407e1a0b5bf --date=short --no-merges --format='%ad %ae %s'
2019-06-07 syoussefi@chromium.org Vulkan: implement ES3 blit


Created with:
  gclient setdep -r src/third_party/angle@b407e1a0b5bf

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Change-Id: I47ed430fa192e71fa59c39c8298b44a36e8feae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649717Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667142}

A new storage partition is generated every time the enrollment screen is
shown but the webview is bound to the storage partition set before the
first navigation. This generates errors when navigating the enrollment
screen more than once (using the 'Back' button).

This CL adopts the same solution used by the Gaia sing-in screen by
recreating the webview and assigning it the new partition if the screen
was already navigated.

Bug: 964945,956973
Change-Id: I8500631f81442b62105dfb3b00cc1532ab7af2ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647834Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Andreea-Elena Costinas <acostinas@google.com>
Cr-Commit-Position: refs/heads/master@{#667141}

Bug: 522168
Change-Id: I33c7fcf4b91198f50ecc253f315d0ce3da366bf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648437Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667140}

The browser can not delete a speculative main frame that has committed
since the renderer takes ownership of it. This is a race since the
renderer makes this decision, and the browser may try delete it before
hearing it has been committed. In this case the renderer ignores the
delete to avoid losing state.

However as part of cancelling speculative navigation during shutdown,
the browser will also replace the RenderFrameProxyHost which makes a
RenderFrameProxy and RemoteFrame as the main frame in the renderer.

This is a problem because it replaces Page's main_frame_ pointer to
the main LocalFrame that was committed and not deleted by the
browser's request. The LocalFrame becomes an orphan that lives
indefinitely, with the LocalFrame and associated RenderFrame and
WebViewFrameWidget holding raw pointers back to the WebViewImpl,
the RenderWidget, and the RenderViewImpl. When these are closed
and destroyed, if the process is not killed entirely, the frame
will crash if it tries to access these.

Since WebContentsImpl drops all RenderFrameProxyHosts before destroying
the FrameTreeNode, we can not go through RenderFrameHostManager's
CleanUpNavigation() or DiscardUnusedFrame() as this path will recreate
the already deleted RenderFrameProxyHost, leading to the leaked frame.

So instead we can simply delete the speculative RenderFrameHostImpl
with UnsetSpeculativeRenderFrameHost(). This skips past recreating the
RenderFrameProxyHost, setting the speculative RenderViewHost as being
swapped out, and notifying in IPC that the nav was cancelled, none of
which should matter to do at shutdown.

R=avi@chromium.org, dcheng@chromium.org

Bug: 964668, 838348, 915179
Change-Id: Icb7f2dfe6752ae745b0ea299fe4ca974b34516a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648463Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667139}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=pbond@chromium.org

Change-Id: If50583db78bf057eb73dd9ecedf6892ee3f9ef54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649679
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Polina Bondarenko <pbond@chromium.org>
Commit-Queue: Polina Bondarenko <pbond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667138}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=rouslan@chromium.org

Change-Id: I0d16e66a8b67117567d04884ebe7584fd7ea5926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649369
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#667137}

Change-Id: Ib715fb23b3fcb21997215e2c5d973f10e3cee92b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631589Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Nikita Zetilov <zetilovn@google.com>
Cr-Commit-Position: refs/heads/master@{#667136}

ModelTypeRegistry expects OnEncryptedTypesChanged() to be called before
initialization of PASSWORDS ModelTypeWorker. This CL satisfies the
expectation by notifying observers during bridge's Init().

Bug: 922900
Change-Id: I0fc50e40d8d0bccfa023c0cbe0c5ef409e96e6cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638519
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667135}

Bug: 910994
Change-Id: If87f745b55b3a044d1f92c8c61f6cb419d469798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638922Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667134}

Bug: 961846
Change-Id: I3cc0ebbe04f07c4b05c6d6d87e3b3110160e2d39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632870Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Rasha Nasri <rnasri@google.com>
Cr-Commit-Position: refs/heads/master@{#667133}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=mef@chromium.org

Change-Id: Icd3adfdfc99f8d1cc3a6b09022c829bd33706949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649734
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667132}

Replace old *_EXPORT macros in //ui/base/x by the new style COMPONENT_EXPORT.

Bug: 891175, 789065
Change-Id: I0d47b9d5b1ca5c2880ddf597daafaa5c416f81b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647007Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#667131}

This CL changes the Compact Translate Infobar implementation so that the
infobar can be created in the error state. The infobar presents a Snackbar
notification in this state.

This is needed when the Translate infobar is manually force-triggered in a
situation where translation cannot be done (English to English translation)

Bug: 971832
Change-Id: I9d2a58da42a783a23a8a0c958823bd27293fec77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648709
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667130}

This is a reland of 2f208730

Original change's description:
> Android: Align libchrome and libmonochrome GN target names
> 
> The GN target to build libchrome.so is historically called "libchrome",
> whereas libmonochrome.so's target is "monochrome".  The missing lib
> prefix on Monochrome necessitated special cases when referring to the
> library.
> 
> Further, when we start generating partitioned libraries, the
> subdirectory they get dumped into is based on the target name, and it'd
> be nice not to have to special-case that too, for the sake of release
> scripts.
> 
> Change-Id: I3d743ffdcab1fad47b7e9b4d15cfd31591428980
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646414
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666762}

Change-Id: Ieb1e82cc9f044b5c31c26cc5a40784cc0190c041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647965Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667129}

TBR=parastoog@google.com,msramek@chromium.org,noyau@chromium.org,sebsg@chromium.org

Bug: 969620
Change-Id: I37036ea4130d7d5491a3160cfccc2d5cab35a8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648168
Commit-Queue: Pauline Leitao <psivieroleitao@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667128}

As a first step, the corresponding shelf items are still created and
added to the model, but they are ignored at the view level, where the
buttons are created separately. The two corresponding item types are
marked as deprecated.

Bug: 971426
Change-Id: Ia6af9a982f29831d578d3e3b02976647d9681610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646972Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667127}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=jlebel@chromium.org

Change-Id: I3c46b26bbfd0a17c28f88b1853bb49378daf8eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648207
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667126}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=fmalita@chromium.org

Change-Id: I19a8495c4050395219665057dd6013ec0112b643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649327
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667125}

This reverts commit fee1e3c8.

Reason for revert: Suspected of causing memory leak in various tests (http://crbug.com/972005) e.g., crbgug.
* fast/forms/file/file-input-click.html
* fast/forms/file/file-input-key-enter.html
...


Original change's description:
> Use a Persistent FileChooserClient to avoid GC
> 
> Previous to this change, the FileChooserClient was only held by
> a WeakPersistent pointer, and as a result, the client could get
> garbage collected. This led to user-visible bugs, such as
> crbug.com/844119. This is now corrected.
> 
> Bug: 844119
> Change-Id: I7ab788e85dba4d6343a3abceafb092ef1cfe64f9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639046
> Commit-Queue: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Auto-Submit: Mason Freed <masonfreed@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666970}

TBR=tkent@chromium.org,masonfreed@chromium.org

Change-Id: Ief378adea1a4e19cf3fe0fe0a4b2517edeb8529f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650020Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667124}

https://skia.googlesource.com/skia.git/+log/6faf8d662af8..fe18de506097


git log 6faf8d662af8..fe18de506097 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 robertphillips@google.com Experimental: Add R_16 and RG_1616 to Ganesh (take 2)


Created with:
  gclient setdep -r src/third_party/skia@fe18de506097

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: Ib5e7f5d28bd582ce57b2f9f348f114a1466a05b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649716Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667123}

... by reporting a failure rather than DCHECK'ing. This seems to hit on
unit_tests on Mac a lot; those tests usually have the object managing the
temporary profile directory (usually TestingProfile) destroyed before they
shut down all the worker threads, so it may end up deleting the cache
directory in between when SimpleCache opens it and when it tries to grab
modification timestamp.


Bug: 937998
Change-Id: Id1d962cf8f8f96a6bb1f713c917db3f7eb0bbe3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645635Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667122}

This allows some OpenUiDelegate classes to be eliminated from ash
system tray code. AshTestBase now provides a shared SystemTrayClient
implementation for tests.

Long ago we had a similar class "TestSystemTrayDelegate" that did
something similar.

Bug: 970889
Test: ash_unittests
Change-Id: I0035dccfe343df4ef8504cb0113684539eae2ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649056Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667121}

https://android.googlesource.com/platform/external/perfetto.git/+log/7f47e1a27c39..c63be46c5020


git log 7f47e1a27c39..c63be46c5020 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 fmayer@google.com Merge "Revert "Revert "Add Mapping / Frame / Callstack to InternedData."""
2019-06-07 sidaths@google.com Process GPU frequency info from ftrace if available


Created with:
  gclient setdep -r src/third_party/perfetto@c63be46c5020

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I028ffff5e3aeb2f20c367a8da666d0bacfca433b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648649Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667120}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=kenrb@chromium.org

Change-Id: I121cbc069435b3dbbfbe0fc58d930333d07c1d55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649736
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667119}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/81513b8eb5f0..b793b75db948


Created with:
  gclient setdep -r src-internal@b793b75db948

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com

Change-Id: I7f2efc63170ff7b5b8bc4766af66e5e49e1e71ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648652Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667118}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=haraken@chromium.org

Change-Id: I01b6d2264953daa3d6ac9a7612d25147f6237c96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649370
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667117}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=sadrul@chromium.org

Change-Id: Ie9d8c8846d5f4f3a9d413ab08ee1cb1d814bb52b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648201
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667116}

It makes more sense for this code to live with the rest of the
formatting code and moving it reduces the size of a very large code
unit.

Bug: 971966
Change-Id: I816569428d9e21b5ccd84b687d1e604fd97956fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649166Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#667115}

If the experimental feature for Nigori USS is enabled, the new codepath
now uses a controller (ModelTypeController) to start and stop Nigori,
and to connect it to the ModelTypeWorker.

Because of lifetime issues with Nigori, and the special treatment for
the initial sync cycle during engine initialization (which predates the
instantiation of DataTypeManager), the interactions with the controller
are done manually, and on the sync thread. This is not ideal, but we
don't have better alternatives as of today, without intrusive changes
that would be barely feasible during the coexistence of both codepaths.

To avoid engine_impl's dependence on driver the registration of Nigori
datatype was moved back to SyncEngineBackend (partially revert
https://chromium-review.googlesource.com/c/chromium/src/+/1619813).

Bug: 922900
Change-Id: I22b20d3a0e2f396a0eddbef54cf2e429f02cc410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648178
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667114}

These metrics have taken on a renewed importance with the plans
to add video support.

Bug: 966641, 656015
Change-Id: I359387a35bdce6566d965e920072ac74f2d29be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648223Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667113}

The UIKit bug has been fixed in iOS 13, the workaround is no longer
needed.

Bug: 931173
Change-Id: Ie14df79e34a2b107a2e4733ced44509484062ce3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649534
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667112}

events that don't happen over the textfield (or the open menu).

Bug: 953185
Change-Id: I84af8df0ea97da1e3bb1daebc823697523811e0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638126
Commit-Queue: Edin Kadric <edinkadric@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667111}

Bug: 953678
Change-Id: Ice4d2d54793b2d1029ee9143db45443808a87bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646712
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667110}

Refactor to |base::OnceCallback| where possible.

Bug: 968109
Change-Id: I55a23349b7b4769d3f68d34624237a2f2255c1b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646015Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667109}

Bug: 970351
Change-Id: Iff672776690e8f7cdc3e38e69e6e1a658489f801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642814Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#667108}

ShaderTracking introduced a new namespace ui::gl which made
the symbol "gl" resolve differently inside the ui namespace. That
is why the style guide doesn't allow nested namespaces with the
same name as top level namespaces.

This caused problems in some jumbo builds where the compiler knew
more about available namespaces.

Bug: 969155
Change-Id: I6674c75c3ea06e78fcf7fbf063c688163e8044b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649501
Auto-Submit: Daniel Bratell <bratell@opera.com>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667107}

Because the cookie parser is permissive, we can get in a situation
where ToCookieLine() produces a string longer than the original
input. When this exceeds the maximum cookie line length, that longer
string cannot be parsed. This CL prevents the fuzzer from flagging
these kinds of errors.

Also changes the behavior of the fuzzer's mutator calling
code. According to ParsedCookie's header file, only SetName/SetValue
may be called on an invalid ParsedCookie (when IsValid returns false).

Bug: 971385
Change-Id: I16a412b5204f8d5f19496ab7f158d992960c5bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647389Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667106}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=eseckler@chromium.org

Change-Id: I1ed5e83463d74f354c44cf15bf9ea64199304d7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649507
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667105}

The RenderWidgetHostView for the predecessor is destroyed by the time
the ack is sent. We can safely ignore this ack, as all pending
touch events are already acked when the RWHV is destroyed
(see TouchEventAckQueue::UpdateQueueAfterTargetDestroyed).

Bug: 969714
Change-Id: I40d8a390b4f5b67115733850f8ad2ab7e6ecfa3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645159Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667104}