- 08 Jul, 2020 40 commits
-
-
Charlene Yan authored
The bug that makes it not possible to drag a tab to the right of a collapsed group header is due to TabStrip::GetLastVisibleTab() clamping the insertion index. TabStrip::ShouldTabBeVisible is used for determining if a tab is visible in the tabstrip due to space constraints. Moving the logic for collapsed tabs into TabStrip::SetTabVisibility(). This should also make is slightly nicer and show less headers in the case where the tabstrip is full of group headers and not visible tabs. Bug: 1099367 Change-Id: If31bf23b9d2fc069481f092e38310635b89d3165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277381 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#786498}
-
Daniel Murphy authored
The 'dummy' app installed to flush the sync system was installed in the wrong direction, so changes from profile 1 might not have made it to profile 0. This change fixes that. R=loyso@chromium.org Bug: 1099595 Change-Id: I28b8816e20ac2020d9329342a10936ba09309830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285296 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#786497}
-
Andrey Kosyakov authored
Originally broken by https://chromium-review.googlesource.com/c/chromium/src/+/2274584 Bug: 1094090 Change-Id: Icfd8b9be9acc7406ef63d88302986e9ac2d262cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288387 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#786496}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/430a7423039682e4bbc7b522e3b57b2c8dca5e3b..eda849d2e6e6a15a5a4dc728568ec12f21ebfb6d The following commits have Chromium bugs associated: eda849d2e Opaquify PKCS8_PRIV_KEY_INFO. 5d7c2f8b1 Implement i2d_PUBKEY and friends without crypto/asn1. 5fa22ed85 Avoid relying on SSL_get_session's behavior during the handshake. The following commits have update notes: eda849d2e Opaquify PKCS8_PRIV_KEY_INFO. d0637e901 Remove TRUST_TOKEN_experiment_v0. 25638f06e Remove x509->name. 5fa22ed85 Avoid relying on SSL_get_session's behavior during the handshake. Bug: 1010748, 1102458 Change-Id: I0e377889f94676efd90f292a0dcdf9b0c5b446d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288451 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#786495}
-
Maxime Charland authored
In parallel with the current TableViewEmptyView, the new TableViewIllustratedEmptyView will be able to display an image, a title and a subtitle on empty states. This new class will be accessible from a new helper function in ChromeTableViewController. (Googlers only links) Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: Ia54b55d9f2de749879bc0f811bd2629688dd2bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254519 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#786494}
-
Daniel Classon authored
Change-Id: Ifd63251a67ae9fe31e3d46f5e80a4dd54f7bd0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288203 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#786493}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/83fe1bc34d80..8a9919980f54 2020-07-08 cwallez@chromium.org Don't leak buffers if MapAtCreation fails. 2020-07-08 cwallez@chromium.org Fix MSVC compilation. 2020-07-08 tommek@google.com Adding Queue::WriteTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1103154 Tbr: cwallez@google.com Change-Id: I11ee7c9d876f7dc4d9e034602c8640628b8c3b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786492}
-
Vikas Soni authored
This is a reland of 5f7b87c0 with some additional changes and refactor. Original change's description: > Refactor SharedImageVideo backing. > > 1. Refactor SharedImageVideo backing to use SharedImageBackingAndroid > and SharedImageRepresentationSkiaVkAndroid. > > 2. Move GetAhardwareBuffer and VkImage creation from Representation's > BeginRead to ProduceSkia. > > Bug: 1091945 > Change-Id: Ic08616f37754c864d0059c38b0a64f1f296b1ae4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281478 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785336} Bug: 1091945 Change-Id: Ic46dbcfda2bc3c7a9435c1b5001b1c1722ed09a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282729Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786491}
-
Yu Han authored
In this CL, fixes all the remaining tests for ParentNode.replaceChildren by following the steps outlined in the spec[1]. Also connected RuntimeEnabledFeature to blink::feature so it's finch controllable. [1] https://dom.spec.whatwg.org/#dom-parentnode-replacechildren Bug: 1067384 Change-Id: I246b96d8907c222d15bc80376d83a0bc5ff90e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270678Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786490}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f8597f282852..5d5af4ebd056 2020-07-08 rmhasan@google.com telemetry: Add getter and setter for _binary_manager global variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:960833 Tbr: rmhasan@google.com Change-Id: I5436471462c52a2498f9321f3f994999310ed567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288651Reviewed-by:
-
Marijn Kruisselbrink authored
Following changes in https://github.com/WICG/native-file-system/pull/196 Bug: 1103022 Change-Id: I4ba11f12cf2e47ec326a09efa7b06fd300402945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285670 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#786488}
-
Lijin Shen authored
This reverts commit 5c5957c7. Reason for revert: testMergeOnMultiDisplay_OnDisplayChanged failing on test-n-phone https://ci.chromium.org/p/chrome/builders/ci/test-n-phone Original change's description: > Merge tabs of multi-instance when display is changed. > > On partner foldable phones, when the secondary display is off, there > is only one targetable displays and only #onDisplayChanged is called. > This CL tries to merge tabs #onDisplayChanged as well. > > Bug: 1088202 > Change-Id: Id21960b40bceb4b04fce7a2718c0e33bee0f4920 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272131 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Lijin Shen <lazzzis@google.com> > Cr-Commit-Position: refs/heads/master@{#786055} TBR=tedchoc@chromium.org,twellington@chromium.org,lazzzis@google.com Change-Id: I73c428b30eb6005f4e85171434dec16d54d4e419 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1088202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288809Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#786487}
-
Alex Moshchuk authored
This reverts commit cf27abd2. We thought that an outdated process model shortcut to avoid unnecessary OOPIFs was no longer needed now that we have default SiteInstances, but issue 1101214 showed that it is actually needed on Android Webview in cases where default SiteInstances aren't yet used, in particular with file: URLs. Hence, this CL brings the shortcut removed in https://crrev.com/c/1876979 back along with better documentation on why it's still needed. Bug: 1101214, 1103352, 1015882 Change-Id: I444700ca37670f47c9b7730ace1c7743ee408d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288382Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#786486}
-
Oleh Lamzin authored
Use constants close to type limits in unit tests. Bug: b:158658869 Change-Id: I364c55ebd14b7d9fccba78bd3cfcac3abd8ae960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278053 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#786485}
-
Qiaofei Ye authored
As mentioned in Bug 1030396, the containerName attribute was first added in https://codereview.chromium.org/2515993002/ and it was truncated to 100 chars. The spec does not mention this truncation anywhere, see https://w3c.github.io/longtasks/. In this PR, we removed undocumented containerName truncation, and changed member variables to use atomicString instead of String. Bug: 1030396 Change-Id: Ie1e7e6d7d1878ca16091a5f4db316d9c59368be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276680 Commit-Queue: Qiaofei Ye <qiaye@microsoft.com> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#786484}
-
Luis G Garcia authored
I2P: https://groups.google.com/a/chromium.org/d/msg/blink-dev/4kMGCyCUIao/5vjPk4tuAQAJ Change-Id: Ib30e5d2ec4d833d2cc44246bf95827f4e2083f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230280 Commit-Queue: Luis Garcia <luisggarcia@google.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#786483}
-
John Abd-El-Malek authored
They're timing out now. This brings them to the same runtime as Linux ASan LSan Tests. Bug: 1103330 Change-Id: I2e5e38ae4d3321b238c31af87026e26d95928abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288199 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#786482}
-
Ben Pastene authored
With crrev.com/c/2277078, the tool we're using to deploy chrome to the device/VM expects some additional runtime libs. These libs are encapsulated in the chromiumos_preflight group. So this adds them to any telemetry-based test's isolate input data. Bug: 1099963 Change-Id: Ie8bdad2b0aeb4f9b0848ec54869b4fcd4d7ec34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288491Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#786481}
-
Jeremy Roman authored
This is somewhat verbose, but allows us to avoid the unhandled rejection being visible to script without having to make this hack even worse. Instead of actually calling activate(), this mirrors the spec structure by simply calling to underlying logic, passing a resolver where it makes sense and not (in this case, passing a substitute object) where it doesn't. Bug: 1102081 Change-Id: I0eecf253928bfce39afcddccf54e9bc6f6c0d549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285340Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#786480}
-
Erik Staab authored
Change-Id: I9516cce3b5c5de8efd55ee10c511b4167c4616b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288102 Auto-Submit: Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#786479}
-
Oleh Lamzin authored
Do not compare field by field in tests to not forget testing new field in the future. Bug: b:158658869 Change-Id: I46225a1b3601bd0d7f0cf7026e246eeffb745a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274891 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/847ded3ada37..973c321add1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jam@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jam@google.com,mohsen@google.com Change-Id: Ia46afad1d5052954b59fff4b20c50160577f43a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288138Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786477}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c49c88ac82fb..e64cd3aeff71 2020-07-08 thakis@chromium.org mac: Add an arm64 slice to ninja-mac. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103315,chromium:762354 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I5b328dd2eb93cd1562224d76b20942ec49f057f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288589Reviewed-by:
-
Mirko Bonadei authored
This CL adds the parts of absl that are needed by both Nearby and //third_party/shell-encrpyption. Bug: 1046390 Change-Id: Idaf0b92b764565b8f08b25f2ca9e13a6c0f2ef99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260632Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#786475}
-
Ghazale Hosseinabadi authored
This CL reverts commit 20204dee. The revert in commit 20204d was done due to a failing test, i.e., ToolbarActionsBarUnitTest.ReuploadExtensionFailed. This CL also fixes ToolbarActionsBarUnitTest.ReuploadExtensionFailed. Bug: 1101189 Change-Id: I996b2fd17923162c89161ce154dcd1046c47b814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285334Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/master@{#786474}
-
Tibor Goldschwendt authored
Deprecates the histograms - Tab.NewTabDOMContentLoaded - Tab.NewTabScriptStart - Tab.NewTabOnload* (on desktop) and logging code. The histograms are no longer used for analysis. Fixed: 1089552, 1089553 Change-Id: Ieb129e80825c1004a854df48894f580776953247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284375Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#786473}
-
Sreeja Kamishetty authored
-virtual/webrtc-wpt-plan-b/external/wpt/webrtc/simulcast/h264.https.html -external/wpt/webrtc/protocol/video-codecs.https.html -virtual/webrtc-wpt-plan-b/external/wpt/webrtc/protocol/video-codecs.https.html -external/wpt/webrtc/simulcast/h264.https.html Also, rename third_party/blink/web_tests/FlagExpectations/back-forward-cache to third_party/blink/web_tests/FlagExpectations/enable-features=BackForwardCache to match the name in test_suite_exceptions.pyl Bug: 1103214 Change-Id: Ie6e65711c83c873d3ca5280c8a6d5b72e6daf796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287381Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#786472}
-
Guido Urdaneta authored
This class has been mojified and the ThreadSafeSender appears to be dead code. Bug: 1102895 Change-Id: I2fe859b842e085e595fd82e5f0a3a80e0a2f4961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285007Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#786471}
-
shrekshao authored
Suppress deqp/functional/gles3/fborender/recreate_color_03.html on Android FYI Release (Pixel 2) as RetryOnFailure Tbr: kbr@chromium.org No-Try: true Bug: 1103370 Change-Id: Idc004171e10c2b112e746a3c8092ede33436e405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288749Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#786470}
-
Kevin Schoedel authored
Focus did not work due to two distinct problems, both of which caused page-level focus to be absent, which in turn meant that blink-level focus was suppressed. - The aura::Window on which focus was attempted does not have an OnWindowFocused observer. This change focuses the Window that does. - Wayland app's aura::Windows are not visible. This change adds a check for an ancestor that is an exo window. Bug: b/156123509 Test: manual on device Change-Id: Ib4e8a5101bbc28d2b7a0448aff8142c8cffa2a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274201Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#786469}
-
Brian Geffon authored
To keep CLs small on userspace swap this CL only adds the configuration tunables which will be available to userspace swap. Additionally, it adds a helper to determine if the kernel supports the necessary features for userspace swap. BUG=chromium:1067833 Change-Id: Id674abede3d503218189cd3b4bef130c4297b5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288492 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786468}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/414418d55f49..babba97ae63a 2020-07-08 zepenghu@google.com Use test font manager for SVG fuzzer 2020-07-08 herb@google.com don't produce empty SubRuns 2020-07-08 jlavrova@google.com Placeholders coming from flutter can have Inf sizes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Iac39dc61175c418942267aadc39e22522f0d2f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288426Reviewed-by:
-
Oleh Lamzin authored
Use auto in tests when possible. Bug: b:158658869 Change-Id: Ib91a9ec07bfcac503b31811166361cb5e9033c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277992 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Jesse McKenna authored
This change moves the code to emit histogram "Windows.ChromeDllPrefetchResult" histogram into ChromeMain(). This fixes an issue where the histogram was created in chrome.exe and thus failed to be emitted by chrome.dll on non-components builds. Currently, the histogram is created before chrome.dll is entered, in chrome.exe. On non-component (release) builds, chrome.exe and chrome.dll each have separate copies of base, because base is statically linked ('baked in') into each portable executable file. Creating the histogram in chrome.exe's base means that chrome.dll's base, the one that actually emits the histograms to UMA, does not see the histogram. This change addresses this by passing the histogram value into ChromeMain() and emitting the histogram there. Bug: 1096609 Change-Id: I918144dff4fc0d5189d5882462ffadd88f27b9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280242 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#786465}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/49a334846e76..76cae97fc14c 2020-07-08 amaiorano@google.com Update llvm 10 Darwin config 2020-07-08 amaiorano@google.com Update llvm 10 Linux config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I01e0d277fbea13a8b294334fc11e8864666bc700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288139Reviewed-by:
-
Bettina authored
Instead of controlling it from Finch params, it will now be controlled in Client code. Also refactored the code to be in a central place to not duplicate it.Removed checks from compromised_credentials_* file as the saved password protection will be enabled by default. The signed-in non-sync and saved passwords will be ENABLED_BY_DEFAULT. This CL also does the clean up for both experiments. Bug: 1099908 Change-Id: I93dfb04ead935752658b24c7454786907e1f6141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269756 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#786463}
-
Oleh Lamzin authored
Fill disk infos in a separate logical block. It helps to avoid name collisions and looks simpler. Bug: b:158658869 Change-Id: I82a27cff9660e5540a3dfee90aae5f530c72a5dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277991 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Peter Kasting authored
These uses of std:: functions should use the base:: versions since they want an integral type. Bug: 1088346 Change-Id: I32c96ddd31b27676dd2d1fb0d1467e8b0263980e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275346 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#786461}
-
Daniel Murphy authored
This should never happen, but it seems to be occurring for some users (see bug). Until the root cause is found, do a manual check to make sure WebApp is not a nullptr. R=loyso@chromium.org Bug: 1101668 Change-Id: Ia6148a0335aaa4394d9e335763791280001a7dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284004 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Removed WMHelper::SetInstance and simplified the code a bit. Bug: None AX-Relnotes: n/a. Change-Id: I2c09d7aad7e8dce20d11cd3618da7c5d6f22a07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285345Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
-
