GitLab

Refactor only, no user-visible changes.

Following the naming conventions decided in
go/clank-preferences-refactor, this change replaces the "Preferences"
suffix in the Themes Settings fragment.

Also un-nest ThemeSetting inner class for clarity, and rename string
resource.

Bug: 1030446
Change-Id: I9813e0d8a3060d29dcb7e73ad2e3fe02c311b1cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958828
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723461}

This change removes the remaining use-cases for texture allocation using
skia and replaces them with shared images via CanvasResourceProvider. It
also removes all unused code as a result.

R=kbr@chromium.org

Bug: 962630
Change-Id: I5d1deff51a5b66f62dfbdf41348e4f343c7c42a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956250
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723460}

If we move these values into the mojo definition then we can
use it directly in blink and get rid of additional intermediate clases.
ie. WebLoadTimingInfo

Change-Id: I40f369597c4f305979767fb0a0d197282996a9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954298
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723459}

This is a re-land of:
https://chromium-review.googlesource.com/c/chromium/src/+/1868534

The original patch caused a regression and was reverted for
crbug.com/1028817. A test was added for the case at:
https://chromium-review.googlesource.com/c/chromium/src/+/1941451

The problem happened when |HandleOverflow| tried to break a
text item but it didn't fit. |NGLineBreaker| looks for
previous opportunities and rewind, but items it tried to
break were modified, which confused |NGLineBreaker|.

The old patch stopped rewinding there. The new approach is to
restore the original item when it failed to break so that it
can always see the original items.

:: The original description follows ::

This patch removes |NGLineInfo::LineEndFragment|, which was
introduced to support hyphens and ellipsis with the single
code. However, ellipsis was changed to use different code,
and |LineEndFragment| ended up with non-optimal way to handle
hyphens.

Although hyphens appear at most once in a line, storing this
to |NGLineInfo| makes harder to keep it in sync with the
hyphenated item. This patch changes it to a field in
|NGInlineItemResult|.

Bug: 1015297
Change-Id: I1dab0dacd8445ed563527bdc90d58b18470725f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943784Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723458}

Prior to this change, disabling (or marking readonly) an input
would cause input.validity.* to become always true, because
willValidate became false. The spec [1] isn't completely clear
but appears to say that input.validity.* should give the state
of validation, independent of whether the control will actually
be validated. Other browsers, including Firefox, behave this
way already.

This CL also adds testing of most validity.* accessors with
disabled=true, readonly=true, and both true. Most of these
tests fail without this CL in place, confirming the bug.

[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#the-constraint-validation-api

Fixes: 1030749
Change-Id: I3d3bea53c57a87cf49b99acf53e53772395bf6ed
Bug: 1030749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952027
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723457}

The possibility of scheduling a task at an exact time is being added to
the BackgroundTaskScheduler. Previous CLs have handled refactoring,
interface and delegation changes.

This CL adds the functionality that starts a task. A task will be
started at the decided time, the scheduling being handled by
AlarmManager. The start of the task and all the additional actions are
done through a receiver class. The start and the wait for the task are
done in a detached thread, while keeping the CPU on through a wake lock.

Bug: 970160
Change-Id: I5e981ebf34c80b6fff6cdba16e4fe2811720560f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778880
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723456}

Query amount of resource during swap buffers. It should be tracke by a Singleton
to prevent repeats. Reports it to both peak gpu memory monitor and task manager.
TODO: give it a CommandBufferId to separate it from SkiaOutputSurface?

Bug: 899905
Change-Id: Idc39e8d3cc01158580e5e8eca28e35bdb766acae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951137
Auto-Submit: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723455}

Bug: 1032592
Change-Id: If3e59edd7b2c90d95e0d323e5451a9821dc032ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953577
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723454}

The VizDisplayCompositor feature is now 100% launched for all Chrome
browser platforms. Remove the feature from chrome://flags and delete
some of the code to check the feature.

We still need to check the feature flag on Android since WebView
requires it be false. As a follow up the remaining places
IsVizDisplayCompositorEnabled() is still needed should be converted to
check IsUsingVizForWebView() and features::kVizDisplayCompositor can be
deleted entirely.

Bug: 732805, 936425
Change-Id: If6894f62195b7d5593ad890be4f95f2ea8025011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957014Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723453}

Was missed in a previous refactor.

Change-Id: I146abbb2cc490cf4ad94badaf9412930fe27a9c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958593
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723452}

An expectation at the end of this test is failing on iOS.  Removes that
expectation on iOS, similar to how it is already removed on Fuchsia.

BUG=1032568

Change-Id: I8a446c74ba18c9b580ca728900682a25c2fd2b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960525
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723451}

This makes noise in the console :)

Bug: None
Change-Id: I66957eaa0aa9e333a29dc1289de21db8c22a6b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959653Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723450}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/eec373d9e7a4..ebf36174fd09

git log eec373d9e7a4..ebf36174fd09 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 rharrison@google.com Rolling 5 dependencies (#933)

Created with:
  gclient setdep -r src/third_party/shaderc/src@ebf36174fd09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I380c8bc6f9f05b39f6a033fbfde13d19b6e20300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723449}

Bug: 1030785
Change-Id: Ib9604bfcfd919b19dd0032bb4ed19a2dfd7636f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959327Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723448}

Context: The Bottom-sheet based PaymentHandler UI is based on the
bottom-sheet, as its name suggested. For a ChromeActivity's
bottom-sheet, when users tap on the scrim, the default behavior is
dismissing the sheet. This behavior, however, would increase the avg
time for users to finish a transaction, because users may accidentally
tap to close the sheet and has to redo the transaction.

Old behavior: tapping the scrim of Payment Handler UI dismisses the
sheet.

Change: Since the sheet dismissal behavior is defined in the
onScrimClick method of the BottomSheet's default scrim-observer,
we override this method to bypass the dismissal.

New behavior: tapping the scrim of Payment Handler UI wouldn't dismiss
the sheet.

Bug: 1029815

Change-Id: If15ab2c7f293387fbc546c79006b2d2e811d6b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935431Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723447}

The legacy Windows printing with GDI/EMF has a different print path
from other desktop platforms, as it spools each page of a document
separately so that the results can go through an extra conversion step
from PDF to EMF before being sent to a device.

With XPS printing path no extra conversion step is required, enabling
Windows to use a similar interface as for other desktop platforms and
get the document metafile and simply spool the job.  This CL enables
that option for XPS to coexist with GDI depending upon the
|kUseXpsForPrinting| feature flag.

This CL uses a NOTIMPLEMENTED in PrintingContextWin::PrintDocument()
as a placeholder for where Skia calls will occur, which is to come in
later CL.

Bug: 1008222
Change-Id: I7d6b0a1ef737eaba358f99ed04e047d24a0e895e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935946Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723446}

This reverts commit ae835890.

Reason for revert: This is not a code duplicate as I initially thought. The override makes a call to MaxTextOffset() faster because it doesn't concatenate the strings returned by GetText().

Once this patch is reverted, I'll add a comment pointing out the optimization to make it explicit.

Original change's description:
> AXNodePosition::MaxTextOffset() is not needed anymore
> 
> https://crrev.com/c/1796047 by Nektarios updated
> AXNodePosition::MaxTextOffset(), making the override execute the exact
> same code as AXPosition::MaxTextOffset() already does by calling
> GetText(). The override is not necessary anymore.
> 
> The override was first introduced by Kevin Babbitt in
> https://crrev.com/c/1730094.
> 
> Bug: 1031271
> Change-Id: If9c7338544cc4d966dd7d82e465b04b03c06a5d9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954548
> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#722733}

TBR=nektar@chromium.org,kschmi@microsoft.com,benjamin.beaudry@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1031271
Change-Id: I939981e84827f43760eb462eaaa635500b87bf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959267Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723445}

between_child_spacing was added in an attempt to make FlexLayout
backwards-compatible with BoxLayout. The effort failed, and having this
method which adds behavior that doesn't work like anything else in
FlexLayout and which doubles existing functionality (and isn't actually
used anywhere) seems like a bad idea.

Change-Id: I424c51d3279717dbb504aa948d7acc9934c62447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956540
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723444}

Bug: 1028242
Change-Id: I6c0276a8e7b7930ae2e4af6e71117a9e323fec84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959785
Auto-Submit: Erik Staab <estaab@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723443}

Bug: 1021887
Change-Id: I09c1792a4e9d51c2336e0d00dad6350a41591409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959037Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723442}

Updates the expires_after attribute for 222 histograms that show
frequent access in the past 90 days.  These are the 80% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-06-07.

Change-Id: I038c7543b34c26d6b414b5dff87907f33f679bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958254
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723441}

Recording the MIME type of the main frame of a page will give us more
information about what the page contains. This will be useful to some
of the interventions like tab discarding who handle PDFs and regular
pages differently.

Bug: 1030399
Change-Id: I03cc93e913abb351f070a9cc68f808f601252656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955033
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723440}

base::JSONReader::Read() is a static method, so there is no need to
instantiate a base::JSONReader object. While making this change, also
stop using ReadDeprecated(), and make the code lint error free.

Change-Id: I4ba79d61af6c736e762cb926a04e28ef13fb63fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476413Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723439}

Bug: 1011098
Change-Id: Ic8e0d3d5028004d7c980bf1b8b7e7a61ad4a5bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956262Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723438}

Bug: 1032266
Change-Id: I6b0e0d3328444f24d0dbbd874ec8e951ef86ff20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959768Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723437}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3f57d6f9..a7b3b5fa

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ida9aabfd1c549ac1b7e3c20655a28503cfefd4f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960526Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723436}

During AXTree::Unserialize, if an AXID was reparented then ultimately
removed from the tree, AXTree would notify that the node was being
reparented rather than removed.

https://crrev.com/c/1907774 fixed the crash this behavior caused by
more accurately notifying OnNodeDeleted and changing when nodes are
un-mapped by BrowserAccessibilityManager.

This change fixes the incorrect events being fired that previously
would have caused a crash with the following stack :
- ui::AXNodeData::HasState
- ui::IsIgnored
- ui::AXNode::GetUnignoredParent
- content::BrowserAccessibility::InternalGetParent
- content::BrowserAccessibility::PlatformIsChildOfLeafIncludingIgnored
- content::BrowserAccessibility::CanFireEvents
- content::BrowserAccessibilityManager::OnAccessibilityEvents

This was caused by firing OnNodeWillBeReparented rather than
OnNodeWillBeDeleted. The node was not un-mapped, but the AXNode was
deleted in DestroyNodeAndSubtree, causing a UAF crash.

* Removed IsPotentiallyReparentedNode and the set it tracked because
  PendingStructureChanges better captures this state.
* Rewrote IsReparentedNode so it can detect if a node is expected to
  be reparented after all updates have been applied.

Bug: 1030531
Change-Id: I82d53f2e16b42b6e8084989e5995a95dace072d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949674
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#723435}

Fuchsia uses ICU rather than POSIX functions for Exploded time, but the
ICU time zone was not being set, so this test was always comparing UTC
time to UTC time.
The tests relies on localtime_r() to obtain the local time for
comparison, but POSIX local time functions always use UTC on Fuchsia so
the test must manually account for the time offset.

time_exploded_icu.cc::CreateCalendar() is removed.

Bug: 985946
Test: TimeTest.LocalTimeT fails if the |is_local| check in
Change-Id: I69701c37f5eea1eedd5020d46a2401818e73da16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952524Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723434}

This CL removes a conditional that defends against a message reordering
bug, but introduces a target confusion, and hence message loss, in the
DevTools front-end for certain navigations (the test
oopif-elements-navigate-out-extra-info.js
exposes the bug).

We expect these tests to flake and expose the reordering bug, so we can
fix that one next.

Bug: chromium:1030329
Fixed: 1030329
Change-Id: I0f14d6dcfe4047ff252fa1b4dd956f4258e4e45b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948898
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723433}

Readonly storage buffer is fully implemented in Dawn. We should
enable the support for related enum.

BUG=dawn:180

Change-Id: I13ba9b61757b8c1e7f612c93f34947c510663cbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957744Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#723432}

This CL changes the way we process incoming SyncEntities when decryption
is pending. After the change:
 - PopulateUpdateResponseData() early returns and does not populate
   anything if decryption is pending.
 - ProcessGetUpdatesResponse() then stores the original SyncEntity
   instead of the previous (partially) populated UpdateResponseData.
 - DecryptStoredEntities() gets much simpler because it can now reuse
   PopulateUpdateResponseData() and does not have to duplicate the
   decryption logic.

As a result this CL reconciles all bookmarks adaptations into a single
place in PopulateUpdateResponseData().

This CL does not introduce any behavioral change.

Bug: 1007199
Change-Id: I5ebbfcbaf5dd6bd677aba1697e7ee8d8cd08d75f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827427
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723431}

Send a localized string that includes the selection state to
the VoiceOver announcement API.
VoiceOver will speak the string and render on a Braille display.

Bug: 939526
Change-Id: I4aedd89bc4b7c99133afd9ca99eeddfe90f771c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953286Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723430}

This category is chosen because it was found to be relevant to investigation of
an ongoing bug.

Bug: 1017889
Change-Id: I674a72bdf07529df33535149e57529c4bf9e0a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959611Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723429}

https://android.googlesource.com/platform/external/perfetto.git/+log/49d99fe889d2..39a8168c4ee5

git log 49d99fe889d2..39a8168c4ee5 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 primiano@google.com Merge "Fix GitHub repo links in docs"
2019-12-10 khokhlov@google.com Merge "trace_processor: fix tests in Chrome on Android"
2019-12-10 fmayer@google.com Merge "Convert time of heap snapshots."
2019-12-10 lalitm@google.com Merge "trace_processor: allow comparisions between doubles and ints"
2019-12-10 hjd@google.com Merge "Replace lite-server with serveit clone"
2019-12-10 fmayer@google.com Merge "Make "Perfetto CI" banner clickable."
2019-12-10 primiano@google.com infra: fix regex for mirror bot and update docs
2019-12-10 primiano@google.com Merge "infra: update git mirror bot to point to new github url"
2019-12-10 lalitm@google.com Merge "trace_processor: fix null dereference in ref_type mapping"
2019-12-10 khokhlov@google.com Merge changes I93bf64ce,Ib30d867e,Iab2e2b59,I4b7109d2,I511b1782, ...
2019-12-09 lalitm@google.com trace_processor: migrate slice table to new database tables

Created with:
  gclient setdep -r src/third_party/perfetto@39a8168c4ee5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:135177627
Tbr: perfetto-bugs@google.com
Change-Id: Ia49733b26e3cc4afb649da2a3526069c96fe830b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960489Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723428}

This CL adds an overflow check to {buffered_amount_} in RTCDataChannel.

Here is some background about why I created this CL:
We (V8 team) prepare ArrayBuffers to be bigger than 4GB. Therefore we
changed the size field to size_t. Now we are changing all uses of
ByteLength to be able to deal with size_t, either by accepting a size_t,
or by throwing an exception if the size is too big.

The size of an ArrayBuffer is added to {buffered_amount_}, which is of
type {unsigned}. Therefore with a big enough ArrayBuffer an overflow
could potentially happen. I thought that if I already add an overflow
check for potentially too big ArrayBuffers, I could add the overflow
check everywhere.

R=guidou@chromium.org

Bug: chromium:1008840
Change-Id: I96385a52a357df1999c951c00307aea751e7a1fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953727Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723427}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Ibc206536ce3b72bda7e7e8ac4c99142a40659e2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959612Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723426}

Removes unused kNaClLoader (was PROCESS_TYPE_NACL_LOADER)
from Windows as these are in fact Ppapi (PPAPI) sandbox types.

Removes unused values from SandboxType enum and replaces default cases.

SandboxType is not used for iteration so these boundary values are removed
from the SandboxType enum.

The kInvalid SandboxType is retained as it is used as an error case in
a couple of places. It might be possible to remove this in the future.

This removes default cases from switch statements where it might make
sense to have a notification in future when new sandbox types are added.
In these cases the default case is replaced with all otherwise
unchecked cases, so retaining the existing behavior.

Change-Id: I76ffc8ae617f3f8fa9aa68236551ebcfa4cce32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938076Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723425}

AppInstance updates will be used to determine app usage time.

Bug: 1015658
Test: AppServiceWrapperTest
Change-Id: Idcb0232ecf80f02ac3fc3f1a3c2b7cb468db5152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958894
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723424}

Was iso-latin-1-unix according to Emacs and wasn't utf-8 according to
python. This commit changes the offending \x92 to a real '.

Change-Id: Ia40e0ef1332ab7dbb3ce50419404320ed6dcfc5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956278
Auto-Submit: Alex Gough <ajgo@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723423}

Some Android flavors have less fonts than
the numbers assumed (IoT cases). Change
this to test for 10.

Bug: b/143273186
Test: Local test run.
Change-Id: If4c23ee990f1de28aceb2bf768dc815f4693ef7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957207Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Brett Kilty <brettk@google.com>
Cr-Commit-Position: refs/heads/master@{#723422}