- 06 Jan, 2020 40 commits
-
-
Thomas Guilbert authored
It appears that a merge error in 555ef226... undid the roll in 252792a1ff65deadc4e627e59ce80b... This is a reland. https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/68b4dfdbd607..252792a1ff65 $ git log 68b4dfdbd..252792a1f --date=short --no-merges --format='%ad %ae %s' 2019-12-09 tguilbert Fix null pointer addition error 2019-12-06 tguilbert Fix null pointer arithmetic Created with: roll-dep src/third_party/ffmpeg TBR: tmathmeyer Bug: 1031252 Change-Id: I4b25092bbc7681578cd0bb6f447788f2936d5a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988726 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#728683}
-
Samuel Huang authored
Courgette's algorithm allow removal for underused labels. However, this was only used by ARM, whose support is recently removed. This CL is a follow-up to remove more dead code. * Remove AssemblyProgram::TrimLabels() * Remove LabelManager::RemoveUnderusedLabels() and usage in test. Bug: 1012592 Change-Id: Ia50ee2ec9f90e35ce123463e06edc9bfb5a868af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987863Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728682}
-
Vlad Tsyrklevich authored
Change-Id: I40ced1a170eeb5164c79f38d304f03b1319bab14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986369 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#728681}
-
Allen Webb authored
Bug: 874630 Change-Id: I248999003b3881dfc9bc941573b78fac84765fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987068 Auto-Submit: Allen Webb <allenwebb@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Allen Webb <allenwebb@google.com> Cr-Commit-Position: refs/heads/master@{#728680}
-
Rodney Ding authored
- add execution context to cssPropertyID() - Design doc https://docs.google.com/document/d/1Lc3U2WV38GZ3ShTAm3-p6fbZeGJGkxL-KZfWIQ-p8GU/edit?usp=sharing Bug: 775189 Change-Id: Iaf59eba6a12158398bd976fdb74a7800afd0228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965998 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#728679}
-
Stephen Martinis authored
This CL modifies the sorting and duplicate checks in the *.pyl files in //testing/buildbot. It adds more checks for subsections of the files; for example, each entry inside of test_suite_exceptions.pyl will now be checked, rather than just checking that the top level list of tests is sorted. A few duplicates have been removed; these won't cause any meaningful behavior change, since python ignores duplicates in dictionaries. Change-Id: I314338c904080b463ac6859011a538987a862530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986241 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728678}
-
rbpotter authored
The destinations iron-list in Print Preview has an initial height of 0, since it is sized based on its contents. This results in iron-list setting an optimal physical size of Infinity and rendering a list with length equal to the number of destinations that have been retrieved initially. This causes the dialog to be extremely slow in cases where there are many printers. Instead, set the height of the iron-list in JS before updating the list of printers it displays, and merge this logic with the logic to update the throbber (since it is performing similar compuations). Also removing unused listName property. Bug: 1038434 Change-Id: Id38ccc6252bb2bbbb2f99b67504328f17ccdff64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984717Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#728677}
-
Nina Satragno authored
Add support for the UV tokens to webauthn. When getting an assertion, if UV=true and the authenticator supports UV token, get a token and use it for subsequent operations. This allows silent credential discovery for credProtect=UVRequired credentials. Fixed: 1033225 Change-Id: I4537e76ef4803910d19d9bdc06bb920b4df6f525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975013 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#728676}
-
Peter Kasting authored
* Fixes some (but not all) "Could not delete temp dir" warnings by adding a new ThemeScoper object. This is the bulk of this change. * Fixes some tests that failed on sytems with dark mode on by default. * Cleans up some tests by removing unnecessary bits (e.g. UseDefaultTheme()/RunUntilIdle() calls on test start) and refactoring (e.g. adding a |theme_service_| convenience member alongside the existing |registry_|). Bug: none Change-Id: Ie5c3fcccda294a863c6a598a0513f076788b314d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986284 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#728675}
-
Taylor Bergquist authored
This also adjusts the internal View hierarchy for the tab counter; this will be important when the animation is changed to move the border and the text separately. Bug: 999557 Change-Id: I1f9f7d8544ca87e6ec463b29ce2370f1f88bedfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982722 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728674}
-
Mei Liang authored
This CL is the final CL that integrates all components in order to serve the CloseTabSuggestion to GTS. component that was previously landed and stripped out by Pro-guard. Binary-Size: Enables the feature by introducing a code path which used a Change-Id: If0fc9e2593fc2422494490b470a0c1b4464af65b Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959783 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728673}
-
Jack Lynch authored
This CL adds an axe accessibility test for the Sources panel Scope pane. Bug: 963183 Change-Id: Icb24c0ae8312d38fe26eaa78903472128a01e7cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668238Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728672}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3311ef65680e..f8ae5dc6d791 git log 3311ef65680e..f8ae5dc6d791 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 syoussefi@chromium.org GL: Enable EXT_gpu_shader5 2020-01-06 flibitijibibo@gmail.com Fix UWP build 2020-01-06 ericbinet@google.com Add missing steps in DevSetup 2020-01-06 flibitijibibo@gmail.com Fix GGP build 2020-01-06 lehoangq@gmail.com Metal: fix vertex attribute's conversion lost after changing buffer binding. Created with: gclient setdep -r src/third_party/angle@f8ae5dc6d791 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I08608142faf6ee51f0fdc49d0d9ce6fe74141bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728671}
-
Chris Mumford authored
CrossThreadBindRepeating::MakeCrossThreadFunction was calling base::Bind to create callback. Switching to base::BindRepeating. Also modified comment in worker_thread.cc to refer to WTF::Bind so as to not encourage the use of the banned base::Bind* methods in Blink. Bug: 1007835 Change-Id: Ib880897af9f78dc5684a7c7b4cd5be557ed5563d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988507Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728670}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed0cc5f6fd8e..a81450253f88 git log ed0cc5f6fd8e..a81450253f88 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 ehmaldonado@google.com depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock Created with: gclient setdep -r src/third_party/depot_tools@a81450253f88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I92eb147981445f3e0aa15fe5bc820d1365750e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988260Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728669}
-
Vasiliy Telezhnikov authored
After recent changes OffscreenCanvas now using SharedImage and so can work with Vulkan. This CL re-enables relevant tests. Fixed: 1002538 Change-Id: Icec465655bea0247f0919d95cb39ad62fe6e44e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988504 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#728668}
-
Ian Barkley-Yeung authored
On ChromeOS, pass --always_allow_feedback when running unattended (during integration tests). This avoids the need for most tests to try and set metrics consent. Requires https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1981037 to be rolled into Chromium before checkin. BUG=chromium:1037656 TEST=tast -verbose run --extrauseflags chrome_internal my_crbook ui.ChromeCrashNotLoggedInDirect Change-Id: I7ba481286c87856f2d5e8cebf224b9b1b6212824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981139 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#728667}
-
Matthew Mourgos authored
Without this change, when multiple external displays are connected and the primary display is turned off, sometimes the bounds of the login ui is incorrect, causing the login ui to be hidden. Bug: 1031571 Change-Id: Iae1447b0ceffe55d41ba79187d2c2fcf2b555b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984763Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728666}
-
Robert Ogden authored
This flag is no longer used on stable or later versions. TBR=ryansturm@chromium.org Change-Id: I1919d7015bf0caf8f72b31ce8c80f29f7a2048d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986063Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#728665}
-
Kurt Horimoto authored
This class was unnecessary, as the same functionality can be implemented much more easily by observing OverlayPresenter from BadgeMediator, which acts as the InfobarBadgeTabHelper's delegate. This implementation will be added in a follow-up CL. This CL replaces the browser agent's instantiation with an infobar- specific BrowserAgent creation helper function that will set up BrowserAgents to handle the model-layer updates from overlay UI interaction events. Bug: 1030357 Change-Id: I4fa3f0c3afa6d0f747f0a7d3b9f5ee14dd43d4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978623 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#728664}
-
Chris Mumford authored
WebGraphicsContext3DProvider::SetLostContextCallback already exlicitly uses base::RepeatingClosure so converting two overrides to do the same. Bug: 1007835 Change-Id: Id83a1067d9c555700b630deb75fe2b3d13c93d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988487Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#728663}
-
Joey Arhar authored
If a <button> element inside a <form> has a child element which is clicked, and the <button>'s onclick handler removes the child element from the DOM, the <button>'s default event handler which submits the form is never called. If this happens, and the <button>'s onclick handler also manually submits the form via form.submit(), then the form double-submit fix made in crrev.com/c/1850358 will prevent form.submit() from submitting the form because the form.submit() is blocked until the <button> gets the DOMActivate event, which never happens if the child element is removed from the DOM before it can emit the DOMActivate event to the parent <button>. This patch will submit the form in this case by listening to the click event instead of the DOMActivate event. If the click event is additionally preventDefault()ed, this patch will not cover that case. Once we switch back to async form submission in crbug.com/1013385 then all of the cases will be covered and this patch will be reverted. Bug: 1037740 Change-Id: I04cdff451b363b5fafa26d2c58ec0aa76ed95a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983547Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#728662}
-
Devlin Cronin authored
ExtensionIdSet is typedef'd to a std::set<ExtensionId>. Move the declaration from extension.h to extension_id.h, where the ExtensionId typedef is. Bug: 1038392 Tbr: vakh@chromium.org (micro change in extension_data_collection_unittest.cc) Change-Id: I98c4aa8285c67ac6c48cb372365f8b11700d1d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983192 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#728661}
-
Toby Huang authored
Child/Geller users currently cannot remove extensions with state BLOCKED or REQUIRE_APPROVAL because UserMayModifySettings() returns false. Make UserMayModifySettings() always return true so that child/ Geller users can remove installed extensions regardless of the state. Bug: 1033687,1032352 Change-Id: I4608c22099325578982e48b6da31840c124167d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969068 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728660}
-
Dan Beam authored
R=dpapad@chromium.org Bug: 1038846 Change-Id: I72d5b46a6132d0e033a1236af57153cf6a7b603b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987134Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#728659}
-
Peng Huang authored
The tearing is because the displayed_image_->EndPresent() is called in wrong place. It should be called when the displayed_image_ is being replaced by a new image. Bug: 1036566 Change-Id: Ic12c41d0191e9ad62638f931bce03c9d44a31c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988687Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728658}
-
Richard Knoll authored
Sharing.ClickToCallDialerPresent: Extended to M84 Sharing.ClickToCallHelpTextClicked: Obsolete Sharing.ClickToCallDialIntent: Replaced with ClickToCallDialerPresent Sharing.ClickToCallContextMenuPhoneNumberParsingDelay: Extended to M84 Bug: 1037598,1037286 Change-Id: Icbfee90db84403c43cdc2bbc6f73960a912939d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986802Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728657}
-
kylechar authored
This CL finishes removing code to handle submitting renderer CompositorFrames through content/browser/renderer_host/, primarily code left in RenderWidgetHostImpl. Also update RenderWidgetHostTest.FrameToken_* to not submit CompositorFrames. Bug: 812322, 766481 Change-Id: I9e6142a116da2cdf41ecb0d0b86cdaf5f479ce53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986784 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#728656}
-
Yusuf Sengul authored
Bug: 1039027 Change-Id: I3936986b390f414621df4d305b7ad8aa2f8bcbb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986057 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#728655}
-
Darwin Huang authored
As per Android documentation[1], Android clipboard formats should be referenced using MIME types. Update Chrome's Android clipboard formats to use MIME types, as opposed to shorter (but platform-specific) names. These formats are only really passed within Chrome clipboard code (through ClipboardFormatType, ClipboardAndroid, and ClipboardMap). This does also remove GetBookmarkType(), because as mentioned in ClipboardAndroid::WriteBookmark, this tends to actually write the URL spec. That said, ClipboardAndroid::ReadBookmark isn't implemented, so this has no real effect. This is primarily a refactoring change to simplify/consolidate code. No functional changes intended. [1]: https://developer.android.com/reference/android/content/ClipDescription.html#constants_2 Change-Id: If7008dd8ef5657f8bebf71d31f4f5cd246e753f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986243Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#728654}
-
Gabriel Marin authored
BUG=1036859,b:147113394 Change-Id: I10422d47e41057e1aca831cd7b65388f75d2fb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982185Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#728653}
-
danakj authored
Use OnceCallback where possible because the callback is only used once and RepeatingCallback and BindRepeating otherwise. Where a OnceCallback is conditionally consumed, pass it by pointer so that ownership is only moved when the callback will be run. R=alemate@chromium.org Bug: 1007659 Change-Id: I8174ce06a0937c2b9d54cfce45538c3b7a4f5bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967914 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#728652}
-
ckitagawa authored
Introduces a public API for compositing of paint previews. This should complete the API surface required for implementers of the base service to both capture and playback paint previews. I intend to follow this up with a change that moves the parts that should be depended upon externally to a separate target in a public/ directory within components/paint_preview/browser/ Bug: 1030269 Change-Id: I9275ffc6e00267e84a2eaf60b1c07d65f6f4b053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966073 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#728651}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2478e62054cf..ba37867fd234 git log 2478e62054cf..ba37867fd234 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 dberris@chromium.org Catapult: Use x86-64 exclusively for Presubmit Created with: gclient setdep -r src/third_party/catapult@ba37867fd234 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039167 Tbr: nuskos@google.com Change-Id: Ia1734ed97d9c02619225426f28b9f1e9e9b809be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988257 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728650}
-
Andrew Grieve authored
The version of apkanalyzer within android_sdk/tools/bin does not work with JDK11. This alpha package of cmdline-tools has a version that does. Bug: 1036426 Change-Id: I7a85300d243fc8ac2d2e79a9c5bd0b00c0956102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984667Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728649}
-
Tommy Steimel authored
This reverts commit 34d462f6. Reason for revert: compile failure on tree: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/8162 Original change's description: > Add end-to-end tests for demographic metrics in UMA and UKM > > Bug: 992573 > Change-Id: I5a27682828538c72fbe8fc71c78cbadc8fdef23e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872643 > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728621} TBR=rogerm@chromium.org,asvitkine@chromium.org,vincb@google.com Change-Id: Ib04abc8549e152033951e13d140da9bd529446fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 992573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988233Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#728648}
-
David Munro authored
Bug: None Test: Manual, check logs after failing to create a container Change-Id: I56d456878fe61156307c7060f844477efa8b330e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983693 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#728647}
-
Daniel Murphy authored
IndexedDB now generates a lot more data during it's readwrite transactions during API calls like IDBFactory.deleteDatabase. The system is designed to clean this up over time, but there are possible worst- case scenarios where the amount of data being written outstrips the amount of data being compacted/deleted. This change makes it so all IndexedDB leveldb databases are compacted when the backing store is closed. This happens after the normal 2 second grace period. This should: 1) Make IndexedDB's size smaller for all users. 2) Make IndexedDB's performance and usage more consistent 3) Eliminate the case where uncompacted data from deleting databases is hogging up the disk. R=jsbell@chromium.org, pwnall@chromium.org Bug: 1035025 Change-Id: I893743ce0ad5e2b66c1c0ceb5f636b8b424a05c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972910Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#728646}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/32eff228855c..804ad6f18ad8 git log 32eff228855c..804ad6f18ad8 --date=short --first-parent --format='%ad %ae %s' 2020-01-06 bookatz@google.com CtsPerfettoTestCases secondary_user Created with: gclient setdep -r src/third_party/perfetto@804ad6f18ad8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:141773058 Tbr: perfetto-bugs@google.com Change-Id: Ib6a39bea17d1a8df1c2816518c79507e60b2a7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728645}
-
Bettina authored
Previously, placeholders for the saved password protection warning are reordered based off of commonly spoofed domains. This means that the placeholders may not be in the same order as the |saved_password_matching_domains|. This is the unit test for cr/1983352. Bug: 1038132 Change-Id: I5a2d7ee57508c72097631414fc12b4aa0fcc612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986187 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728644}
-